.rubocop.yml 9.8 KB
Newer Older
R
Rémy Coutable 已提交
1 2 3
inherit_gem:
  gitlab-styles:
    - rubocop-default.yml
R
Robert Speicher 已提交
4

Z
Z.J. van de Weg 已提交
5
inherit_from: .rubocop_todo.yml
6 7 8
require:
  - ./rubocop/rubocop
  - rubocop-rspec
Z
Z.J. van de Weg 已提交
9

10
AllCops:
11
  TargetRubyVersion: 2.6
B
blackst0ne 已提交
12
  TargetRailsVersion: 5.0
13 14
  Exclude:
    - 'vendor/**/*'
M
Mike Greiling 已提交
15
    - 'node_modules/**/*'
S
Sean McGivern 已提交
16
    - 'db/fixtures/**/*'
17 18
    - 'db/schema.rb'
    - 'ee/db/geo/schema.rb'
19 20
    - 'tmp/**/*'
    - 'bin/**/*'
21
    - 'generator_templates/**/*'
22
    - 'builds/**/*'
23
    - 'plugins/**/*'
L
Lin Jen-Shin 已提交
24
  CacheRootDirectory: tmp
25

26 27 28 29 30 31 32 33 34 35 36
# This cop checks whether some constant value isn't a
# mutable literal (e.g. array or hash).
Style/MutableConstant:
  Enabled: true
  Exclude:
    - 'db/migrate/**/*'
    - 'db/post_migrate/**/*'
    - 'ee/db/migrate/**/*'
    - 'ee/db/post_migrate/**/*'
    - 'ee/db/geo/migrate/**/*'

37 38 39 40
# TODO: Move this to gitlab-styles
Style/SafeNavigation:
  Enabled: false

G
gfyoung 已提交
41 42 43 44 45 46 47 48 49 50 51 52
# Frozen String Literal
Style/FrozenStringLiteralComment:
  Enabled: true
  Exclude:
    - 'config.ru'
    - 'Dangerfile'
    - 'Gemfile'
    - 'Rakefile'
    - 'app/views/**/*'
    - 'config/**/*'
    - 'danger/**/*'
    - 'db/**/*'
R
Robert Speicher 已提交
53 54
    - 'ee/db/**/*'
    - 'ee/lib/tasks/**/*'
55
    - 'lib/tasks/**/*'
G
gfyoung 已提交
56 57 58 59
    - 'qa/**/*'
    - 'rubocop/**/*'
    - 'scripts/**/*'

60 61 62
RSpec/FilePath:
  Exclude:
    - 'qa/**/*'
63 64
    - 'spec/frontend/fixtures/*'
    - 'ee/spec/frontend/fixtures/*'
65 66
    - 'spec/requests/api/v3/*'

67 68 69
Naming/FileName:
  ExpectMatchingDefinition: true
  Exclude:
70 71
    - 'db/**/*'
    - 'ee/db/**/*'
72 73 74 75 76 77
    - 'spec/**/*'
    - 'features/**/*'
    - 'ee/spec/**/*'
    - 'qa/spec/**/*'
    - 'qa/qa/specs/**/*'
    - 'qa/bin/*'
78
    - 'ee/bin/*'
79
    - 'config/**/*'
80
    - 'ee/config/**/*'
81
    - 'lib/generators/**/*'
M
Mark Chao 已提交
82 83
    - 'locale/unfound_translations.rb'
    - 'ee/locale/unfound_translations.rb'
84
    - 'ee/lib/generators/**/*'
S
Sanad Liaquat 已提交
85 86
    - 'qa/qa/scenario/test/integration/ldap_no_tls.rb'
    - 'qa/qa/scenario/test/integration/ldap_tls.rb'
S
Sanad Liaquat 已提交
87

88 89 90 91 92
  IgnoreExecutableScripts: true
  AllowedAcronyms:
    - EE
    - JSON
    - LDAP
S
Sanad Liaquat 已提交
93
    - SAML
R
Robert Speicher 已提交
94
    - SSO
95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148
    - IO
    - HMAC
    - QA
    - ENV
    - STL
    - PDF
    - SVG
    - CTE
    - DN
    - RSA
    - CI
    - CD
    - OAuth
    # default ones:
    - CLI
    - DSL
    - ACL
    - API
    - ASCII
    - CPU
    - CSS
    - DNS
    - EOF
    - GUID
    - HTML
    - HTTP
    - HTTPS
    - ID
    - IP
    - JSON
    - LHS
    - QPS
    - RAM
    - RHS
    - RPC
    - SLA
    - SMTP
    - SQL
    - SSH
    - TCP
    - TLS
    - TTL
    - UDP
    - UI
    - UID
    - UUID
    - URI
    - URL
    - UTF8
    - VM
    - XML
    - XMPP
    - XSRF
    - XSS
149
    - GRPC
150

151 152 153 154 155 156 157
Rails/ApplicationRecord:
  Enabled: true
  Exclude:
    # Models in database migrations should not subclass from ApplicationRecord
    # as they need to be as decoupled from application code as possible
    - db/**/*.rb
    - lib/gitlab/background_migration/**/*.rb
158
    - ee/lib/ee/gitlab/background_migration/**/*.rb
159 160 161 162 163
    - lib/gitlab/database/**/*.rb
    - spec/**/*.rb
    - ee/db/**/*.rb
    - ee/spec/**/*.rb

164
# GitLab ###################################################################
165 166 167 168 169

Gitlab/ModuleWithInstanceVariables:
  Enable: true
  Exclude:
    # We ignore Rails helpers right now because it's hard to workaround it
L
Lin Jen-Shin 已提交
170
    - app/helpers/**/*_helper.rb
171
    - ee/app/helpers/**/*_helper.rb
172
    # We ignore Rails mailers right now because it's hard to workaround it
L
Lin Jen-Shin 已提交
173
    - app/mailers/emails/**/*.rb
174
    - ee/**/emails/**/*.rb
175 176 177
    # We ignore spec helpers because it usually doesn't matter
    - spec/support/**/*.rb
    - features/steps/**/*.rb
178

179 180 181 182 183
Gitlab/ConstGetInheritFalse:
  Enabled: true
  Exclude:
    - 'qa/bin/*'

184 185
Gitlab/HTTParty:
  Enabled: true
186 187 188
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'
189

190 191 192 193 194 195 196 197 198 199 200 201
GitlabSecurity/PublicSend:
  Enabled: true
  Exclude:
    - 'config/**/*'
    - 'db/**/*'
    - 'features/**/*'
    - 'lib/**/*.rake'
    - 'qa/**/*'
    - 'spec/**/*'
    - 'ee/db/**/*'
    - 'ee/lib/**/*.rake'
    - 'ee/spec/**/*'
202

203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224
Gitlab/DuplicateSpecLocation:
  Exclude:
    - ee/spec/helpers/auth_helper_spec.rb
    - ee/spec/lib/gitlab/gl_repository_spec.rb
    - ee/spec/models/namespace_spec.rb
    - ee/spec/models/note_spec.rb
    - ee/spec/serializers/environment_entity_spec.rb
    - ee/spec/services/issues/create_service_spec.rb
    - ee/spec/services/merge_requests/create_service_spec.rb
    - ee/spec/services/merge_requests/refresh_service_spec.rb
    - ee/spec/services/merge_requests/update_service_spec.rb
    - ee/spec/services/system_hooks_service_spec.rb
    - ee/spec/helpers/ee/auth_helper_spec.rb
    - ee/spec/models/ee/namespace_spec.rb
    - ee/spec/models/ee/note_spec.rb
    - ee/spec/serializers/ee/environment_entity_spec.rb
    - ee/spec/services/ee/issues/create_service_spec.rb
    - ee/spec/services/ee/merge_requests/create_service_spec.rb
    - ee/spec/services/ee/merge_requests/refresh_service_spec.rb
    - ee/spec/services/ee/merge_requests/update_service_spec.rb
    - ee/spec/services/ee/system_hooks_service_spec.rb

225 226 227 228 229
Cop/InjectEnterpriseEditionModule:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'
230 231 232

Style/ReturnNil:
  Enabled: true
N
Nick Thomas 已提交
233 234 235 236 237

# It isn't always safe to replace `=~` with `.match?`, especially when there are
# nil values on the left hand side
Performance/RegexpMatch:
  Enabled: false
238 239 240 241 242 243

ActiveRecordAssociationReload:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'
244

245 246 247 248 249 250
Naming/PredicateName:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'

251 252 253 254 255 256
RSpec/FactoriesInMigrationSpecs:
  Enabled: true
  Include:
    - 'spec/migrations/**/*.rb'
    - 'ee/spec/migrations/**/*.rb'
    - 'spec/lib/gitlab/background_migration/**/*.rb'
257 258
    - 'spec/lib/ee/gitlab/background_migration/**/*.rb'
    - 'ee/spec/lib/ee/gitlab/background_migration/**/*.rb'
259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293

Cop/IncludeSidekiqWorker:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'

Gitlab/Union:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'

Cop/SidekiqOptionsQueue:
  Enabled: true
  Exclude:
    - 'spec/**/*.rb'
    - 'ee/spec/**/*.rb'

Graphql/AuthorizeTypes:
  Enabled: true
  Exclude:
    - 'spec/**/*.rb'
    - 'ee/spec/**/*.rb'

RSpec/EnvAssignment:
  Enable: true
  Include:
    - 'spec/**/*.rb'
    - 'ee/spec/**/*.rb'
  Exclude:
    - 'spec/**/fast_spec_helper.rb'
    - 'ee/spec/**/fast_spec_helper.rb'
    - 'spec/**/spec_helper.rb'
    - 'ee/spec/**/spec_helper.rb'
294 295 296 297 298 299 300 301
RSpec/BeSuccessMatcher:
  Enabled: true
  Include:
    - 'spec/controllers/**/*'
    - 'ee/spec/controllers/**/*'
    - 'spec/support/shared_examples/controllers/**/*'
    - 'ee/spec/support/shared_examples/controllers/**/*'
    - 'spec/support/controllers/**/*'
302
    - 'ee/spec/support/controllers/**/*'
303

304 305 306 307 308
Scalability/FileUploads:
  Enabled: true
  Include:
    - 'lib/api/**/*.rb'
    - 'ee/lib/api/**/*.rb'
309 310 311 312 313 314

Graphql/Descriptions:
  Enabled: true
  Include:
    - 'app/graphql/**/*'
    - 'ee/app/graphql/**/*'
315 316 317

RSpec/AnyInstanceOf:
  Enabled: false
318 319 320 321 322 323

# Cops for upgrade to gitlab-styles 3.1.0
RSpec/ImplicitSubject:
  Enabled: false

RSpec/LeakyConstantDeclaration:
324 325 326 327
  Enabled: true
  Exclude:
    - 'spec/**/*.rb'
    - 'qa/spec/**/*.rb'
328 329 330 331 332 333 334
    - 'ee/spec/presenters/security/vulnerable_project_presenter_spec.rb'
    - 'ee/spec/serializers/vulnerable_project_entity_spec.rb'
    - 'ee/spec/services/clusters/applications/check_upgrade_progress_service_spec.rb'
    - 'ee/spec/services/dashboard/projects/list_service_spec.rb'
    - 'ee/spec/services/metrics/dashboard/clone_dashboard_service_spec.rb'
    - 'ee/spec/support/shared_contexts/epic_aggregate_constants.rb'
    - 'ee/spec/workers/elastic_namespace_rollout_worker_spec.rb'
335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365

RSpec/EmptyLineAfterHook:
  Enabled: false

RSpec/HooksBeforeExamples:
  Enabled: false

RSpec/EmptyLineAfterExample:
  Enabled: false

RSpec/Be:
  Enabled: false

RSpec/DescribedClass:
  Enabled: false

RSpec/SharedExamples:
  Enabled: false

RSpec/EmptyLineAfterExampleGroup:
  Enabled: false

RSpec/ReceiveNever:
  Enabled: false

RSpec/MissingExampleGroupArgument:
  Enabled: false

RSpec/UnspecifiedException:
  Enabled: false

366
RSpec/HaveGitlabHttpStatus:
367
  Enabled: true
368 369
  Exclude:
    - 'spec/support/matchers/have_gitlab_http_status.rb'
370
  Include:
371 372
    - 'spec/**/*'
    - 'ee/spec/**/*'
373

374 375 376 377
Style/MultilineWhenThen:
  Enabled: false

Style/FloatDivision:
378
  Enabled: false
379 380 381

Cop/BanCatchThrow:
  Enabled: true
382 383 384

Performance/ReadlinesEach:
  Enabled: true
385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419

# https://gitlab.com/gitlab-org/gitlab/-/issues/212541
RSpec/RepeatedExample:
  Exclude:
    - 'spec/features/issues/filtered_search/filter_issues_spec.rb'
    - 'spec/features/merge_request/user_posts_diff_notes_spec.rb'
    - 'spec/features/projects/files/template_type_dropdown_spec.rb'
    - 'spec/finders/environments_finder_spec.rb'
    - 'spec/frontend/fixtures/merge_requests.rb'
    - 'spec/graphql/gitlab_schema_spec.rb'
    - 'spec/helpers/users_helper_spec.rb'
    - 'spec/lib/banzai/filter/autolink_filter_spec.rb'
    - 'spec/lib/banzai/filter/issuable_state_filter_spec.rb'
    - 'spec/lib/gitlab/closing_issue_extractor_spec.rb'
    - 'spec/lib/gitlab/danger/changelog_spec.rb'
    - 'spec/lib/gitlab/git/blob_spec.rb'
    - 'spec/lib/gitlab/import_export/project/relation_factory_spec.rb'
    - 'spec/models/ability_spec.rb'
    - 'spec/models/ci/build_spec.rb'
    - 'spec/models/concerns/issuable_spec.rb'
    - 'spec/models/member_spec.rb'
    - 'spec/models/project_services/chat_message/pipeline_message_spec.rb'
    - 'spec/models/user_spec.rb'
    - 'spec/models/wiki_page_spec.rb'
    - 'spec/requests/api/merge_requests_spec.rb'
    - 'spec/routing/admin_routing_spec.rb'
    - 'spec/rubocop/cop/migration/update_large_table_spec.rb'
    - 'spec/services/notification_service_spec.rb'
    - 'spec/services/web_hook_service_spec.rb'
    - 'ee/spec/models/group_spec.rb'
    - 'ee/spec/models/user_spec.rb'
    - 'ee/spec/requests/api/merge_request_approvals_spec.rb'
    - 'ee/spec/services/boards/lists/update_service_spec.rb'
    - 'ee/spec/services/geo/repository_verification_primary_service_spec.rb'
    - 'ee/spec/workers/geo/file_download_dispatch_worker_spec.rb'