.rubocop.yml 4.1 KB
Newer Older
R
Rémy Coutable 已提交
1 2 3
inherit_gem:
  gitlab-styles:
    - rubocop-default.yml
R
Robert Speicher 已提交
4

Z
Z.J. van de Weg 已提交
5
inherit_from: .rubocop_todo.yml
6 7 8
require:
  - ./rubocop/rubocop
  - rubocop-rspec
Z
Z.J. van de Weg 已提交
9

10
AllCops:
N
Nick Thomas 已提交
11
  TargetRubyVersion: 2.5
B
blackst0ne 已提交
12
  TargetRailsVersion: 5.0
13 14
  Exclude:
    - 'vendor/**/*'
M
Mike Greiling 已提交
15
    - 'node_modules/**/*'
S
Sean McGivern 已提交
16
    - 'db/fixtures/**/*'
17 18
    - 'db/schema.rb'
    - 'ee/db/geo/schema.rb'
19 20
    - 'tmp/**/*'
    - 'bin/**/*'
21
    - 'generator_templates/**/*'
22
    - 'builds/**/*'
23
    - 'plugins/**/*'
L
Lin Jen-Shin 已提交
24
  CacheRootDirectory: tmp
25

26 27 28 29 30 31 32 33 34 35 36
# This cop checks whether some constant value isn't a
# mutable literal (e.g. array or hash).
Style/MutableConstant:
  Enabled: true
  Exclude:
    - 'db/migrate/**/*'
    - 'db/post_migrate/**/*'
    - 'ee/db/migrate/**/*'
    - 'ee/db/post_migrate/**/*'
    - 'ee/db/geo/migrate/**/*'

37 38 39 40
# TODO: Move this to gitlab-styles
Style/SafeNavigation:
  Enabled: false

G
gfyoung 已提交
41 42 43 44 45 46 47 48 49 50 51 52 53
# Frozen String Literal
Style/FrozenStringLiteralComment:
  Enabled: true
  Exclude:
    - 'config.ru'
    - 'Dangerfile'
    - 'Gemfile'
    - 'Rakefile'
    - 'app/views/**/*'
    - 'config/**/*'
    - 'danger/**/*'
    - 'db/**/*'
    - 'ee/**/*'
54
    - 'lib/tasks/**/*'
G
gfyoung 已提交
55 56 57 58 59
    - 'qa/**/*'
    - 'rubocop/**/*'
    - 'scripts/**/*'
    - 'spec/**/*'

60 61 62
RSpec/FilePath:
  Exclude:
    - 'qa/**/*'
63 64
    - 'spec/frontend/fixtures/*'
    - 'ee/spec/frontend/fixtures/*'
65 66
    - 'spec/requests/api/v3/*'

67 68 69
Naming/FileName:
  ExpectMatchingDefinition: true
  Exclude:
70 71
    - 'db/**/*'
    - 'ee/db/**/*'
72 73 74 75 76 77
    - 'spec/**/*'
    - 'features/**/*'
    - 'ee/spec/**/*'
    - 'qa/spec/**/*'
    - 'qa/qa/specs/**/*'
    - 'qa/bin/*'
78
    - 'ee/bin/*'
79
    - 'config/**/*'
80
    - 'ee/config/**/*'
81
    - 'lib/generators/**/*'
M
Mark Chao 已提交
82 83
    - 'locale/unfound_translations.rb'
    - 'ee/locale/unfound_translations.rb'
84
    - 'ee/lib/generators/**/*'
S
Sanad Liaquat 已提交
85 86
    - 'qa/qa/scenario/test/integration/ldap_no_tls.rb'
    - 'qa/qa/scenario/test/integration/ldap_tls.rb'
S
Sanad Liaquat 已提交
87

88 89 90 91 92
  IgnoreExecutableScripts: true
  AllowedAcronyms:
    - EE
    - JSON
    - LDAP
S
Sanad Liaquat 已提交
93
    - SAML
94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147
    - IO
    - HMAC
    - QA
    - ENV
    - STL
    - PDF
    - SVG
    - CTE
    - DN
    - RSA
    - CI
    - CD
    - OAuth
    # default ones:
    - CLI
    - DSL
    - ACL
    - API
    - ASCII
    - CPU
    - CSS
    - DNS
    - EOF
    - GUID
    - HTML
    - HTTP
    - HTTPS
    - ID
    - IP
    - JSON
    - LHS
    - QPS
    - RAM
    - RHS
    - RPC
    - SLA
    - SMTP
    - SQL
    - SSH
    - TCP
    - TLS
    - TTL
    - UDP
    - UI
    - UID
    - UUID
    - URI
    - URL
    - UTF8
    - VM
    - XML
    - XMPP
    - XSRF
    - XSS
148
    - GRPC
149

150 151 152 153 154 155 156 157 158 159 160 161 162 163
Rails/ApplicationRecord:
  Enabled: true
  Exclude:
    # Models in database migrations should not subclass from ApplicationRecord
    # as they need to be as decoupled from application code as possible
    - db/**/*.rb
    - lib/gitlab/background_migration/**/*.rb
    - lib/gitlab/database/**/*.rb
    - spec/**/*.rb
    - ee/db/**/*.rb
    - ee/lib/gitlab/background_migration/**/*.rb
    - ee/lib/ee/gitlab/background_migration/**/*.rb
    - ee/spec/**/*.rb

164
# GitLab ###################################################################
165 166 167 168 169

Gitlab/ModuleWithInstanceVariables:
  Enable: true
  Exclude:
    # We ignore Rails helpers right now because it's hard to workaround it
L
Lin Jen-Shin 已提交
170
    - app/helpers/**/*_helper.rb
171
    - ee/app/helpers/**/*_helper.rb
172
    # We ignore Rails mailers right now because it's hard to workaround it
L
Lin Jen-Shin 已提交
173
    - app/mailers/emails/**/*.rb
174
    - ee/**/emails/**/*.rb
175 176 177
    # We ignore spec helpers because it usually doesn't matter
    - spec/support/**/*.rb
    - features/steps/**/*.rb
178

179 180 181
Gitlab/HTTParty:
  Enabled: true

182 183 184 185 186 187 188 189 190 191 192 193
GitlabSecurity/PublicSend:
  Enabled: true
  Exclude:
    - 'config/**/*'
    - 'db/**/*'
    - 'features/**/*'
    - 'lib/**/*.rake'
    - 'qa/**/*'
    - 'spec/**/*'
    - 'ee/db/**/*'
    - 'ee/lib/**/*.rake'
    - 'ee/spec/**/*'
194 195 196 197 198 199

Cop/InjectEnterpriseEditionModule:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'
200 201 202

Style/ReturnNil:
  Enabled: true
N
Nick Thomas 已提交
203 204 205 206 207

# It isn't always safe to replace `=~` with `.match?`, especially when there are
# nil values on the left hand side
Performance/RegexpMatch:
  Enabled: false
208 209 210 211 212 213

ActiveRecordAssociationReload:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'