.rubocop.yml 5.7 KB
Newer Older
R
Rémy Coutable 已提交
1 2 3
inherit_gem:
  gitlab-styles:
    - rubocop-default.yml
R
Robert Speicher 已提交
4

Z
Z.J. van de Weg 已提交
5
inherit_from: .rubocop_todo.yml
6 7 8
require:
  - ./rubocop/rubocop
  - rubocop-rspec
Z
Z.J. van de Weg 已提交
9

10
AllCops:
11
  TargetRubyVersion: 2.6
B
blackst0ne 已提交
12
  TargetRailsVersion: 5.0
13 14
  Exclude:
    - 'vendor/**/*'
M
Mike Greiling 已提交
15
    - 'node_modules/**/*'
S
Sean McGivern 已提交
16
    - 'db/fixtures/**/*'
17 18
    - 'db/schema.rb'
    - 'ee/db/geo/schema.rb'
19 20
    - 'tmp/**/*'
    - 'bin/**/*'
21
    - 'generator_templates/**/*'
22
    - 'builds/**/*'
23
    - 'plugins/**/*'
L
Lin Jen-Shin 已提交
24
  CacheRootDirectory: tmp
25

26 27 28 29 30 31 32 33 34 35 36
# This cop checks whether some constant value isn't a
# mutable literal (e.g. array or hash).
Style/MutableConstant:
  Enabled: true
  Exclude:
    - 'db/migrate/**/*'
    - 'db/post_migrate/**/*'
    - 'ee/db/migrate/**/*'
    - 'ee/db/post_migrate/**/*'
    - 'ee/db/geo/migrate/**/*'

37 38 39 40
# TODO: Move this to gitlab-styles
Style/SafeNavigation:
  Enabled: false

G
gfyoung 已提交
41 42 43 44 45 46 47 48 49 50 51 52
# Frozen String Literal
Style/FrozenStringLiteralComment:
  Enabled: true
  Exclude:
    - 'config.ru'
    - 'Dangerfile'
    - 'Gemfile'
    - 'Rakefile'
    - 'app/views/**/*'
    - 'config/**/*'
    - 'danger/**/*'
    - 'db/**/*'
R
Robert Speicher 已提交
53 54
    - 'ee/db/**/*'
    - 'ee/lib/tasks/**/*'
55
    - 'lib/tasks/**/*'
G
gfyoung 已提交
56 57 58 59 60
    - 'qa/**/*'
    - 'rubocop/**/*'
    - 'scripts/**/*'
    - 'spec/**/*'

61 62 63
RSpec/FilePath:
  Exclude:
    - 'qa/**/*'
64 65
    - 'spec/frontend/fixtures/*'
    - 'ee/spec/frontend/fixtures/*'
66 67
    - 'spec/requests/api/v3/*'

68 69 70
Naming/FileName:
  ExpectMatchingDefinition: true
  Exclude:
71 72
    - 'db/**/*'
    - 'ee/db/**/*'
73 74 75 76 77 78
    - 'spec/**/*'
    - 'features/**/*'
    - 'ee/spec/**/*'
    - 'qa/spec/**/*'
    - 'qa/qa/specs/**/*'
    - 'qa/bin/*'
79
    - 'ee/bin/*'
80
    - 'config/**/*'
81
    - 'ee/config/**/*'
82
    - 'lib/generators/**/*'
M
Mark Chao 已提交
83 84
    - 'locale/unfound_translations.rb'
    - 'ee/locale/unfound_translations.rb'
85
    - 'ee/lib/generators/**/*'
S
Sanad Liaquat 已提交
86 87
    - 'qa/qa/scenario/test/integration/ldap_no_tls.rb'
    - 'qa/qa/scenario/test/integration/ldap_tls.rb'
S
Sanad Liaquat 已提交
88

89 90 91 92 93
  IgnoreExecutableScripts: true
  AllowedAcronyms:
    - EE
    - JSON
    - LDAP
S
Sanad Liaquat 已提交
94
    - SAML
R
Robert Speicher 已提交
95
    - SSO
96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149
    - IO
    - HMAC
    - QA
    - ENV
    - STL
    - PDF
    - SVG
    - CTE
    - DN
    - RSA
    - CI
    - CD
    - OAuth
    # default ones:
    - CLI
    - DSL
    - ACL
    - API
    - ASCII
    - CPU
    - CSS
    - DNS
    - EOF
    - GUID
    - HTML
    - HTTP
    - HTTPS
    - ID
    - IP
    - JSON
    - LHS
    - QPS
    - RAM
    - RHS
    - RPC
    - SLA
    - SMTP
    - SQL
    - SSH
    - TCP
    - TLS
    - TTL
    - UDP
    - UI
    - UID
    - UUID
    - URI
    - URL
    - UTF8
    - VM
    - XML
    - XMPP
    - XSRF
    - XSS
150
    - GRPC
151

152 153 154 155 156 157 158 159 160 161 162 163 164 165
Rails/ApplicationRecord:
  Enabled: true
  Exclude:
    # Models in database migrations should not subclass from ApplicationRecord
    # as they need to be as decoupled from application code as possible
    - db/**/*.rb
    - lib/gitlab/background_migration/**/*.rb
    - lib/gitlab/database/**/*.rb
    - spec/**/*.rb
    - ee/db/**/*.rb
    - ee/lib/gitlab/background_migration/**/*.rb
    - ee/lib/ee/gitlab/background_migration/**/*.rb
    - ee/spec/**/*.rb

166
# GitLab ###################################################################
167 168 169 170 171

Gitlab/ModuleWithInstanceVariables:
  Enable: true
  Exclude:
    # We ignore Rails helpers right now because it's hard to workaround it
L
Lin Jen-Shin 已提交
172
    - app/helpers/**/*_helper.rb
173
    - ee/app/helpers/**/*_helper.rb
174
    # We ignore Rails mailers right now because it's hard to workaround it
L
Lin Jen-Shin 已提交
175
    - app/mailers/emails/**/*.rb
176
    - ee/**/emails/**/*.rb
177 178 179
    # We ignore spec helpers because it usually doesn't matter
    - spec/support/**/*.rb
    - features/steps/**/*.rb
180

181 182
Gitlab/HTTParty:
  Enabled: true
183 184 185
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'
186

187 188 189 190 191 192 193 194 195 196 197 198
GitlabSecurity/PublicSend:
  Enabled: true
  Exclude:
    - 'config/**/*'
    - 'db/**/*'
    - 'features/**/*'
    - 'lib/**/*.rake'
    - 'qa/**/*'
    - 'spec/**/*'
    - 'ee/db/**/*'
    - 'ee/lib/**/*.rake'
    - 'ee/spec/**/*'
199 200 201 202 203 204

Cop/InjectEnterpriseEditionModule:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'
205 206 207

Style/ReturnNil:
  Enabled: true
N
Nick Thomas 已提交
208 209 210 211 212

# It isn't always safe to replace `=~` with `.match?`, especially when there are
# nil values on the left hand side
Performance/RegexpMatch:
  Enabled: false
213 214 215 216 217 218

ActiveRecordAssociationReload:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'
219

220 221 222 223 224 225
Naming/PredicateName:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'

226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273
RSpec/FactoriesInMigrationSpecs:
  Enabled: true
  Include:
    - 'spec/migrations/**/*.rb'
    - 'ee/spec/migrations/**/*.rb'
    - 'spec/lib/gitlab/background_migration/**/*.rb'
    - 'ee/spec/lib/gitlab/background_migration/**/*.rb'

Cop/IncludeActionViewContext:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'

Cop/IncludeSidekiqWorker:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'

Gitlab/Union:
  Enabled: true
  Exclude:
    - 'spec/**/*'
    - 'ee/spec/**/*'

Cop/SidekiqOptionsQueue:
  Enabled: true
  Exclude:
    - 'spec/**/*.rb'
    - 'ee/spec/**/*.rb'

Graphql/AuthorizeTypes:
  Enabled: true
  Exclude:
    - 'spec/**/*.rb'
    - 'ee/spec/**/*.rb'

RSpec/EnvAssignment:
  Enable: true
  Include:
    - 'spec/**/*.rb'
    - 'ee/spec/**/*.rb'
  Exclude:
    - 'spec/**/fast_spec_helper.rb'
    - 'ee/spec/**/fast_spec_helper.rb'
    - 'spec/**/spec_helper.rb'
    - 'ee/spec/**/spec_helper.rb'
274 275 276 277 278 279 280 281
RSpec/BeSuccessMatcher:
  Enabled: true
  Include:
    - 'spec/controllers/**/*'
    - 'ee/spec/controllers/**/*'
    - 'spec/support/shared_examples/controllers/**/*'
    - 'ee/spec/support/shared_examples/controllers/**/*'
    - 'spec/support/controllers/**/*'
282
    - 'ee/spec/support/controllers/**/*'
283

284 285 286 287 288
Scalability/FileUploads:
  Enabled: true
  Include:
    - 'lib/api/**/*.rb'
    - 'ee/lib/api/**/*.rb'
289 290 291 292 293 294

Graphql/Descriptions:
  Enabled: true
  Include:
    - 'app/graphql/**/*'
    - 'ee/app/graphql/**/*'