builder.rs 67.9 KB
Newer Older
1
use std::any::Any;
2
use std::cell::{Cell, RefCell};
3
use std::collections::BTreeSet;
S
Santiago Pastorino 已提交
4
use std::collections::HashMap;
5
use std::env;
6
use std::fmt::Debug;
7
use std::fs;
8
use std::hash::Hash;
9
use std::ops::Deref;
10 11
use std::path::{Path, PathBuf};
use std::process::Command;
S
Santiago Pastorino 已提交
12
use std::time::{Duration, Instant};
13

14 15
use build_helper::t;

L
ljedrz 已提交
16 17 18 19 20 21 22 23 24 25
use crate::cache::{Cache, Interned, INTERNER};
use crate::check;
use crate::compile;
use crate::dist;
use crate::doc;
use crate::flags::Subcommand;
use crate::install;
use crate::native;
use crate::test;
use crate::tool;
26
use crate::util::{self, add_lib_path, exe, libdir};
L
ljedrz 已提交
27 28 29
use crate::{Build, DocTests, Mode, GitRepo};

pub use crate::Compiler;
30

31
use petgraph::graph::NodeIndex;
S
Santiago Pastorino 已提交
32
use petgraph::Graph;
33

34 35 36 37 38
pub struct Builder<'a> {
    pub build: &'a Build,
    pub top_stage: u32,
    pub kind: Kind,
    cache: Cache,
39
    stack: RefCell<Vec<Box<dyn Any>>>,
40
    time_spent_on_dependencies: Cell<Duration>,
41
    pub paths: Vec<PathBuf>,
42 43 44
    graph_nodes: RefCell<HashMap<String, NodeIndex>>,
    graph: RefCell<Graph<String, bool>>,
    parent: Cell<Option<NodeIndex>>,
45 46 47 48 49 50 51 52 53 54
}

impl<'a> Deref for Builder<'a> {
    type Target = Build;

    fn deref(&self) -> &Self::Target {
        self.build
    }
}

55
pub trait Step: 'static + Clone + Debug + PartialEq + Eq + Hash {
56 57
    /// `PathBuf` when directories are created or to return a `Compiler` once
    /// it's been assembled.
58
    type Output: Clone;
59

60 61
    const DEFAULT: bool = false;

62
    /// Run this rule for all hosts without cross compiling.
63 64
    const ONLY_HOSTS: bool = false;

A
Alexander Regueiro 已提交
65
    /// Primary function to execute this rule. Can call `builder.ensure()`
66
    /// with other steps to run those.
T
Taiki Endo 已提交
67
    fn run(self, builder: &Builder<'_>) -> Self::Output;
68

69 70
    /// When bootstrap is passed a set of paths, this controls whether this rule
    /// will execute. However, it does not get called in a "default" context
A
Alexander Regueiro 已提交
71
    /// when we are not passed any paths; in that case, `make_run` is called
72
    /// directly.
T
Taiki Endo 已提交
73
    fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_>;
74

A
Alexander Regueiro 已提交
75
    /// Builds up a "root" rule, either as a default rule or from a path passed
76 77 78 79 80
    /// to us.
    ///
    /// When path is `None`, we are executing in a context where no paths were
    /// passed. When `./x.py build` is run, for example, this rule could get
    /// called if it is in the correct list below with a path of `None`.
T
Taiki Endo 已提交
81
    fn make_run(_run: RunConfig<'_>) {
82 83 84 85 86 87
        // It is reasonable to not have an implementation of make_run for rules
        // who do not want to get called from the root context. This means that
        // they are likely dependencies (e.g., sysroot creation) or similar, and
        // as such calling them from ./x.py isn't logical.
        unimplemented!()
    }
88 89
}

90 91 92 93
pub struct RunConfig<'a> {
    pub builder: &'a Builder<'a>,
    pub host: Interned<String>,
    pub target: Interned<String>,
94
    pub path: PathBuf,
95 96
}

97 98 99
struct StepDescription {
    default: bool,
    only_hosts: bool,
T
Taiki Endo 已提交
100 101
    should_run: fn(ShouldRun<'_>) -> ShouldRun<'_>,
    make_run: fn(RunConfig<'_>),
102 103 104 105
    name: &'static str,
}

#[derive(Debug, Clone, PartialOrd, Ord, PartialEq, Eq)]
106
pub enum PathSet {
S
Santiago Pastorino 已提交
107 108
    Set(BTreeSet<PathBuf>),
    Suite(PathBuf),
109 110 111
}

impl PathSet {
112
    fn empty() -> PathSet {
113
        PathSet::Set(BTreeSet::new())
114 115
    }

116 117 118
    fn one<P: Into<PathBuf>>(path: P) -> PathSet {
        let mut set = BTreeSet::new();
        set.insert(path.into());
119
        PathSet::Set(set)
120 121 122
    }

    fn has(&self, needle: &Path) -> bool {
123 124
        match self {
            PathSet::Set(set) => set.iter().any(|p| p.ends_with(needle)),
125
            PathSet::Suite(suite) => suite.ends_with(needle),
126
        }
127 128
    }

T
Taiki Endo 已提交
129
    fn path(&self, builder: &Builder<'_>) -> PathBuf {
130
        match self {
S
Santiago Pastorino 已提交
131 132 133 134 135 136
            PathSet::Set(set) => set
                .iter()
                .next()
                .unwrap_or(&builder.build.src)
                .to_path_buf(),
            PathSet::Suite(path) => PathBuf::from(path),
137
        }
138
    }
139 140 141 142 143 144 145 146 147
}

impl StepDescription {
    fn from<S: Step>() -> StepDescription {
        StepDescription {
            default: S::DEFAULT,
            only_hosts: S::ONLY_HOSTS,
            should_run: S::should_run,
            make_run: S::make_run,
148
            name: unsafe { ::std::intrinsics::type_name::<S>() },
149 150 151
        }
    }

T
Taiki Endo 已提交
152
    fn maybe_run(&self, builder: &Builder<'_>, pathset: &PathSet) {
153 154 155 156
        if builder.config.exclude.iter().any(|e| pathset.has(e)) {
            eprintln!("Skipping {:?} because it is excluded", pathset);
            return;
        } else if !builder.config.exclude.is_empty() {
S
Santiago Pastorino 已提交
157 158 159 160
            eprintln!(
                "{:?} not skipped for {:?} -- not in {:?}",
                pathset, self.name, builder.config.exclude
            );
161
        }
162
        let hosts = &builder.hosts;
163

M
Mark Simulacrum 已提交
164
        // Determine the targets participating in this rule.
165
        let targets = if self.only_hosts {
166
            if !builder.config.run_host_only {
167
                return; // don't run anything
168
            } else {
169
                &builder.hosts
170 171
            }
        } else {
172
            &builder.targets
173 174 175 176
        };

        for host in hosts {
            for target in targets {
177 178
                let run = RunConfig {
                    builder,
179
                    path: pathset.path(builder),
180 181 182 183
                    host: *host,
                    target: *target,
                };
                (self.make_run)(run);
184 185 186 187
            }
        }
    }

T
Taiki Endo 已提交
188
    fn run(v: &[StepDescription], builder: &Builder<'_>, paths: &[PathBuf]) {
S
Santiago Pastorino 已提交
189 190 191 192
        let should_runs = v
            .iter()
            .map(|desc| (desc.should_run)(ShouldRun::new(builder)))
            .collect::<Vec<_>>();
193 194 195

        // sanity checks on rules
        for (desc, should_run) in v.iter().zip(&should_runs) {
S
Santiago Pastorino 已提交
196 197 198 199 200
            assert!(
                !should_run.paths.is_empty(),
                "{:?} should have at least one pathset",
                desc.name
            );
201 202
        }

203
        if paths.is_empty() {
204 205
            for (desc, should_run) in v.iter().zip(should_runs) {
                if desc.default && should_run.is_really_default {
206 207 208
                    for pathset in &should_run.paths {
                        desc.maybe_run(builder, pathset);
                    }
209 210 211 212
                }
            }
        } else {
            for path in paths {
213 214 215 216 217 218
                // strip CurDir prefix if present
                let path = match path.strip_prefix(".") {
                    Ok(p) => p,
                    Err(_) => path,
                };

219
                let mut attempted_run = false;
220
                for (desc, should_run) in v.iter().zip(&should_runs) {
221 222 223 224
                    if let Some(suite) = should_run.is_suite_path(path) {
                        attempted_run = true;
                        desc.maybe_run(builder, suite);
                    } else if let Some(pathset) = should_run.pathset_for_path(path) {
225
                        attempted_run = true;
226
                        desc.maybe_run(builder, pathset);
227 228 229 230
                    }
                }

                if !attempted_run {
231
                    panic!("Error: no rules matched {}.", path.display());
232 233 234 235 236 237
                }
            }
        }
    }
}

238 239
#[derive(Clone)]
pub struct ShouldRun<'a> {
240
    pub builder: &'a Builder<'a>,
241
    // use a BTreeSet to maintain sort order
242
    paths: BTreeSet<PathSet>,
243 244

    // If this is a default rule, this is an additional constraint placed on
245
    // its run. Generally something like compiler docs being enabled.
246
    is_really_default: bool,
247 248 249
}

impl<'a> ShouldRun<'a> {
T
Taiki Endo 已提交
250
    fn new(builder: &'a Builder<'_>) -> ShouldRun<'a> {
251
        ShouldRun {
252
            builder,
253
            paths: BTreeSet::new(),
254
            is_really_default: true, // by default no additional conditions
255 256 257
        }
    }

258 259 260 261 262
    pub fn default_condition(mut self, cond: bool) -> Self {
        self.is_really_default = cond;
        self
    }

263 264 265 266 267 268 269 270
    // Unlike `krate` this will create just one pathset. As such, it probably shouldn't actually
    // ever be used, but as we transition to having all rules properly handle passing krate(...) by
    // actually doing something different for every crate passed.
    pub fn all_krates(mut self, name: &str) -> Self {
        let mut set = BTreeSet::new();
        for krate in self.builder.in_tree_crates(name) {
            set.insert(PathBuf::from(&krate.path));
        }
271
        self.paths.insert(PathSet::Set(set));
272 273 274
        self
    }

275
    pub fn krate(mut self, name: &str) -> Self {
276 277
        for krate in self.builder.in_tree_crates(name) {
            self.paths.insert(PathSet::one(&krate.path));
278 279 280 281
        }
        self
    }

282 283 284 285 286 287 288
    // single, non-aliased path
    pub fn path(self, path: &str) -> Self {
        self.paths(&[path])
    }

    // multiple aliases for the same job
    pub fn paths(mut self, paths: &[&str]) -> Self {
S
Santiago Pastorino 已提交
289 290
        self.paths
            .insert(PathSet::Set(paths.iter().map(PathBuf::from).collect()));
291 292 293 294
        self
    }

    pub fn is_suite_path(&self, path: &Path) -> Option<&PathSet> {
S
Santiago Pastorino 已提交
295 296 297
        self.paths.iter().find(|pathset| match pathset {
            PathSet::Suite(p) => path.starts_with(p),
            PathSet::Set(_) => false,
298 299 300 301 302
        })
    }

    pub fn suite_path(mut self, suite: &str) -> Self {
        self.paths.insert(PathSet::Suite(PathBuf::from(suite)));
303 304 305 306
        self
    }

    // allows being more explicit about why should_run in Step returns the value passed to it
307 308
    pub fn never(mut self) -> ShouldRun<'a> {
        self.paths.insert(PathSet::empty());
309 310 311
        self
    }

312 313
    fn pathset_for_path(&self, path: &Path) -> Option<&PathSet> {
        self.paths.iter().find(|pathset| pathset.has(path))
314 315 316
    }
}

317 318 319
#[derive(Copy, Clone, PartialEq, Eq, Debug)]
pub enum Kind {
    Build,
320
    Check,
321 322 323 324 325 326 327
    Test,
    Bench,
    Dist,
    Doc,
    Install,
}

328 329 330
impl<'a> Builder<'a> {
    fn get_step_descriptions(kind: Kind) -> Vec<StepDescription> {
        macro_rules! describe {
T
Taiki Endo 已提交
331
            ($($rule:ty),+ $(,)?) => {{
332 333
                vec![$(StepDescription::from::<$rule>()),+]
            }};
334
        }
335
        match kind {
S
Santiago Pastorino 已提交
336 337 338 339
            Kind::Build => describe!(
                compile::Std,
                compile::Test,
                compile::Rustc,
340
                compile::CodegenBackend,
S
Santiago Pastorino 已提交
341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378
                compile::StartupObjects,
                tool::BuildManifest,
                tool::Rustbook,
                tool::ErrorIndex,
                tool::UnstableBookGen,
                tool::Tidy,
                tool::Linkchecker,
                tool::CargoTest,
                tool::Compiletest,
                tool::RemoteTestServer,
                tool::RemoteTestClient,
                tool::RustInstaller,
                tool::Cargo,
                tool::Rls,
                tool::Rustdoc,
                tool::Clippy,
                native::Llvm,
                tool::Rustfmt,
                tool::Miri,
                native::Lld
            ),
            Kind::Check => describe!(
                check::Std,
                check::Test,
                check::Rustc,
                check::CodegenBackend,
                check::Rustdoc
            ),
            Kind::Test => describe!(
                test::Tidy,
                test::Ui,
                test::RunPass,
                test::CompileFail,
                test::RunFail,
                test::RunPassValgrind,
                test::MirOpt,
                test::Codegen,
                test::CodegenUnits,
379
                test::Assembly,
S
Santiago Pastorino 已提交
380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397
                test::Incremental,
                test::Debuginfo,
                test::UiFullDeps,
                test::RunPassFullDeps,
                test::Rustdoc,
                test::Pretty,
                test::RunPassPretty,
                test::RunFailPretty,
                test::RunPassValgrindPretty,
                test::Crate,
                test::CrateLibrustc,
                test::CrateRustdoc,
                test::Linkcheck,
                test::Cargotest,
                test::Cargo,
                test::Rls,
                test::ErrorIndex,
                test::Distcheck,
398
                test::RunMakeFullDeps,
S
Santiago Pastorino 已提交
399 400 401 402 403 404 405
                test::Nomicon,
                test::Reference,
                test::RustdocBook,
                test::RustByExample,
                test::TheBook,
                test::UnstableBook,
                test::RustcBook,
406
                test::EmbeddedBook,
E
Eric Huss 已提交
407
                test::EditionGuide,
S
Santiago Pastorino 已提交
408 409 410
                test::Rustfmt,
                test::Miri,
                test::Clippy,
411
                test::CompiletestTest,
G
Guillaume Gomez 已提交
412
                test::RustdocJSStd,
G
Guillaume Gomez 已提交
413
                test::RustdocJSNotStd,
S
Santiago Pastorino 已提交
414
                test::RustdocTheme,
J
John Kåre Alsaker 已提交
415
                test::RustdocUi,
416 417
                // Run bootstrap close to the end as it's unlikely to fail
                test::Bootstrap,
418
                // Run run-make last, since these won't pass without make on Windows
S
Santiago Pastorino 已提交
419 420
                test::RunMake,
            ),
421
            Kind::Bench => describe!(test::Crate, test::CrateLibrustc),
S
Santiago Pastorino 已提交
422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437
            Kind::Doc => describe!(
                doc::UnstableBook,
                doc::UnstableBookGen,
                doc::TheBook,
                doc::Standalone,
                doc::Std,
                doc::Test,
                doc::WhitelistedRustc,
                doc::Rustc,
                doc::Rustdoc,
                doc::ErrorIndex,
                doc::Nomicon,
                doc::Reference,
                doc::RustdocBook,
                doc::RustByExample,
                doc::RustcBook,
S
Steve Klabnik 已提交
438
                doc::CargoBook,
J
James Munns 已提交
439
                doc::EmbeddedBook,
S
Steve Klabnik 已提交
440
                doc::EditionGuide,
S
Santiago Pastorino 已提交
441 442 443 444 445 446 447 448 449 450 451 452 453 454
            ),
            Kind::Dist => describe!(
                dist::Docs,
                dist::RustcDocs,
                dist::Mingw,
                dist::Rustc,
                dist::DebuggerScripts,
                dist::Std,
                dist::Analysis,
                dist::Src,
                dist::PlainSourceTarball,
                dist::Cargo,
                dist::Rls,
                dist::Rustfmt,
455
                dist::Clippy,
456
                dist::Miri,
457
                dist::LlvmTools,
T
Tom Tromey 已提交
458
                dist::Lldb,
S
Santiago Pastorino 已提交
459 460 461 462 463 464 465 466 467
                dist::Extended,
                dist::HashSign
            ),
            Kind::Install => describe!(
                install::Docs,
                install::Std,
                install::Cargo,
                install::Rls,
                install::Rustfmt,
468
                install::Clippy,
469
                install::Miri,
S
Santiago Pastorino 已提交
470 471 472 473
                install::Analysis,
                install::Src,
                install::Rustc
            ),
474 475
        }
    }
476

477 478 479 480 481 482 483 484 485 486 487 488
    pub fn get_help(build: &Build, subcommand: &str) -> Option<String> {
        let kind = match subcommand {
            "build" => Kind::Build,
            "doc" => Kind::Doc,
            "test" => Kind::Test,
            "bench" => Kind::Bench,
            "dist" => Kind::Dist,
            "install" => Kind::Install,
            _ => return None,
        };

        let builder = Builder {
489
            build,
M
Mark Simulacrum 已提交
490
            top_stage: build.config.stage.unwrap_or(2),
491
            kind,
492 493
            cache: Cache::new(),
            stack: RefCell::new(Vec::new()),
494
            time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
495
            paths: vec![],
496 497 498
            graph_nodes: RefCell::new(HashMap::new()),
            graph: RefCell::new(Graph::new()),
            parent: Cell::new(None),
499 500 501 502
        };

        let builder = &builder;
        let mut should_run = ShouldRun::new(builder);
503 504
        for desc in Builder::get_step_descriptions(builder.kind) {
            should_run = (desc.should_run)(should_run);
505 506
        }
        let mut help = String::from("Available paths:\n");
507
        for pathset in should_run.paths {
S
Santiago Pastorino 已提交
508 509 510 511 512 513
            if let PathSet::Set(set) = pathset {
                set.iter().for_each(|path| {
                    help.push_str(
                        format!("    ./x.py {} {}\n", subcommand, path.display()).as_str(),
                    )
                })
514
            }
515 516 517 518
        }
        Some(help)
    }

T
Taiki Endo 已提交
519
    pub fn new(build: &Build) -> Builder<'_> {
M
Mark Simulacrum 已提交
520
        let (kind, paths) = match build.config.cmd {
521
            Subcommand::Build { ref paths } => (Kind::Build, &paths[..]),
522
            Subcommand::Check { ref paths } => (Kind::Check, &paths[..]),
523 524 525 526 527
            Subcommand::Doc { ref paths } => (Kind::Doc, &paths[..]),
            Subcommand::Test { ref paths, .. } => (Kind::Test, &paths[..]),
            Subcommand::Bench { ref paths, .. } => (Kind::Bench, &paths[..]),
            Subcommand::Dist { ref paths } => (Kind::Dist, &paths[..]),
            Subcommand::Install { ref paths } => (Kind::Install, &paths[..]),
O
Oliver Schneider 已提交
528
            Subcommand::Clean { .. } => panic!(),
529 530 531
        };

        let builder = Builder {
532
            build,
M
Mark Simulacrum 已提交
533
            top_stage: build.config.stage.unwrap_or(2),
534
            kind,
535 536
            cache: Cache::new(),
            stack: RefCell::new(Vec::new()),
537
            time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
538
            paths: paths.to_owned(),
539 540 541
            graph_nodes: RefCell::new(HashMap::new()),
            graph: RefCell::new(Graph::new()),
            parent: Cell::new(None),
542 543
        };

544
        if kind == Kind::Dist {
S
Santiago Pastorino 已提交
545 546 547
            assert!(
                !builder.config.test_miri,
                "Do not distribute with miri enabled.\n\
548
                The distributed libraries would include all MIR (increasing binary size).
S
Santiago Pastorino 已提交
549 550
                The distributed MIR would include validation statements."
            );
551 552
        }

553 554 555
        builder
    }

556
    pub fn execute_cli(&self) -> Graph<String, bool> {
M
Mark Simulacrum 已提交
557
        self.run_step_descriptions(&Builder::get_step_descriptions(self.kind), &self.paths);
558
        self.graph.borrow().clone()
559 560 561 562
    }

    pub fn default_doc(&self, paths: Option<&[PathBuf]>) {
        let paths = paths.unwrap_or(&[]);
M
Mark Simulacrum 已提交
563 564 565 566 567
        self.run_step_descriptions(&Builder::get_step_descriptions(Kind::Doc), paths);
    }

    fn run_step_descriptions(&self, v: &[StepDescription], paths: &[PathBuf]) {
        StepDescription::run(v, self, paths);
568 569
    }

B
Bastien Orivel 已提交
570
    /// Obtain a compiler at a given stage and for a given host. Explicitly does
571 572 573
    /// not take `Compiler` since all `Compiler` instances are meant to be
    /// obtained through this function, since it ensures that they are valid
    /// (i.e., built and assembled).
574
    pub fn compiler(&self, stage: u32, host: Interned<String>) -> Compiler {
S
Santiago Pastorino 已提交
575 576 577
        self.ensure(compile::Assemble {
            target_compiler: Compiler { stage, host },
        })
578 579
    }

580
    pub fn sysroot(&self, compiler: Compiler) -> Interned<PathBuf> {
581 582 583 584 585
        self.ensure(compile::Sysroot { compiler })
    }

    /// Returns the libdir where the standard library and other artifacts are
    /// found for a compiler's sysroot.
586
    pub fn sysroot_libdir(
S
Santiago Pastorino 已提交
587 588 589
        &self,
        compiler: Compiler,
        target: Interned<String>,
590 591 592 593 594
    ) -> Interned<PathBuf> {
        #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
        struct Libdir {
            compiler: Compiler,
            target: Interned<String>,
595
        }
596 597
        impl Step for Libdir {
            type Output = Interned<PathBuf>;
598

T
Taiki Endo 已提交
599
            fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
600
                run.never()
601 602
            }

T
Taiki Endo 已提交
603
            fn run(self, builder: &Builder<'_>) -> Interned<PathBuf> {
604
                let compiler = self.compiler;
605 606 607
                let config = &builder.build.config;
                let lib = if compiler.stage >= 1 && config.libdir_relative().is_some() {
                    builder.build.config.libdir_relative().unwrap()
608
                } else {
609
                    Path::new("lib")
610
                };
S
Santiago Pastorino 已提交
611 612 613 614 615 616
                let sysroot = builder
                    .sysroot(self.compiler)
                    .join(lib)
                    .join("rustlib")
                    .join(self.target)
                    .join("lib");
617 618
                let _ = fs::remove_dir_all(&sysroot);
                t!(fs::create_dir_all(&sysroot));
619
                INTERNER.intern_path(sysroot)
620 621 622 623 624
            }
        }
        self.ensure(Libdir { compiler, target })
    }

625 626
    pub fn sysroot_codegen_backends(&self, compiler: Compiler) -> PathBuf {
        self.sysroot_libdir(compiler, compiler.host)
627
            .with_file_name(self.config.rust_codegen_backends_dir.clone())
628 629
    }

630 631 632 633 634 635 636
    /// Returns the compiler's libdir where it stores the dynamic libraries that
    /// it itself links against.
    ///
    /// For example this returns `<sysroot>/lib` on Unix and `<sysroot>/bin` on
    /// Windows.
    pub fn rustc_libdir(&self, compiler: Compiler) -> PathBuf {
        if compiler.is_snapshot(self) {
637
            self.rustc_snapshot_libdir()
638
        } else {
O
O01eg 已提交
639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660
            match self.config.libdir_relative() {
                Some(relative_libdir) if compiler.stage >= 1
                    => self.sysroot(compiler).join(relative_libdir),
                _ => self.sysroot(compiler).join(libdir(&compiler.host))
            }
        }
    }

    /// Returns the compiler's relative libdir where it stores the dynamic libraries that
    /// it itself links against.
    ///
    /// For example this returns `lib` on Unix and `bin` on
    /// Windows.
    pub fn libdir_relative(&self, compiler: Compiler) -> &Path {
        if compiler.is_snapshot(self) {
            libdir(&self.config.build).as_ref()
        } else {
            match self.config.libdir_relative() {
                Some(relative_libdir) if compiler.stage >= 1
                    => relative_libdir,
                _ => libdir(&compiler.host).as_ref()
            }
661 662 663 664 665 666 667 668 669 670
        }
    }

    /// Adds the compiler's directory of dynamic libraries to `cmd`'s dynamic
    /// library lookup path.
    pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Command) {
        // Windows doesn't need dylib path munging because the dlls for the
        // compiler live next to the compiler and the system will find them
        // automatically.
        if cfg!(windows) {
S
Santiago Pastorino 已提交
671
            return;
672 673 674 675 676
        }

        add_lib_path(vec![self.rustc_libdir(compiler)], cmd);
    }

A
Alexander Regueiro 已提交
677
    /// Gets a path to the compiler specified.
678 679 680 681
    pub fn rustc(&self, compiler: Compiler) -> PathBuf {
        if compiler.is_snapshot(self) {
            self.initial_rustc.clone()
        } else {
S
Santiago Pastorino 已提交
682 683 684
            self.sysroot(compiler)
                .join("bin")
                .join(exe("rustc", &compiler.host))
685 686 687
        }
    }

A
Alexander Regueiro 已提交
688
    /// Gets the paths to all of the compiler's codegen backends.
689 690 691 692 693 694 695 696
    fn codegen_backends(&self, compiler: Compiler) -> impl Iterator<Item = PathBuf> {
        fs::read_dir(self.sysroot_codegen_backends(compiler))
            .into_iter()
            .flatten()
            .filter_map(Result::ok)
            .map(|entry| entry.path())
    }

M
Mark Rousskov 已提交
697 698
    pub fn rustdoc(&self, compiler: Compiler) -> PathBuf {
        self.ensure(tool::Rustdoc { compiler })
M
Mark Simulacrum 已提交
699 700
    }

M
Mark Rousskov 已提交
701
    pub fn rustdoc_cmd(&self, compiler: Compiler) -> Command {
M
Mark Simulacrum 已提交
702
        let mut cmd = Command::new(&self.out.join("bootstrap/debug/rustdoc"));
O
Oliver Schneider 已提交
703
        cmd.env("RUSTC_STAGE", compiler.stage.to_string())
S
Santiago Pastorino 已提交
704
            .env("RUSTC_SYSROOT", self.sysroot(compiler))
M
Mark Rousskov 已提交
705 706 707
            // Note that this is *not* the sysroot_libdir because rustdoc must be linked
            // equivalently to rustc.
            .env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler))
S
Santiago Pastorino 已提交
708
            .env("CFG_RELEASE_CHANNEL", &self.config.channel)
M
Mark Rousskov 已提交
709
            .env("RUSTDOC_REAL", self.rustdoc(compiler))
S
Santiago Pastorino 已提交
710 711
            .env("RUSTDOC_CRATE_VERSION", self.rust_version())
            .env("RUSTC_BOOTSTRAP", "1");
712 713 714 715 716

        // Remove make-related flags that can cause jobserver problems.
        cmd.env_remove("MAKEFLAGS");
        cmd.env_remove("MFLAGS");

M
Mark Rousskov 已提交
717
        if let Some(linker) = self.linker(compiler.host) {
O
Oliver Schneider 已提交
718 719
            cmd.env("RUSTC_TARGET_LINKER", linker);
        }
M
Mark Simulacrum 已提交
720
        cmd
721 722
    }

723 724 725 726 727 728 729
    /// Prepares an invocation of `cargo` to be run.
    ///
    /// This will create a `Command` that represents a pending execution of
    /// Cargo. This cargo will be configured to use `compiler` as the actual
    /// rustc compiler, its output will be scoped by `mode`'s output directory,
    /// it will pass the `--target` flag for the specified `target`, and will be
    /// executing the Cargo command `cmd`.
S
Santiago Pastorino 已提交
730 731 732 733 734 735 736
    pub fn cargo(
        &self,
        compiler: Compiler,
        mode: Mode,
        target: Interned<String>,
        cmd: &str,
    ) -> Command {
M
Mark Simulacrum 已提交
737 738
        let mut cargo = Command::new(&self.initial_cargo);
        let out_dir = self.stage_out(compiler, mode);
739

740
        // command specific path, we call clear_if_dirty with this
741 742 743 744
        let mut my_out = match cmd {
            "build" => self.cargo_out(compiler, mode, target),

            // This is the intended out directory for crate documentation.
745
            "doc" | "rustdoc" =>  self.crate_doc_out(target),
746 747 748 749 750 751 752

            _ => self.stage_out(compiler, mode),
        };

        // This is for the original compiler, but if we're forced to use stage 1, then
        // std/test/rustc stamps won't exist in stage 2, so we need to get those from stage 1, since
        // we copy the libs forward.
753
        let cmp = if self.force_use_stage1(compiler, target) {
754 755 756 757 758 759
            self.compiler(1, compiler.host)
        } else {
            compiler
        };

        let libstd_stamp = match cmd {
760 761
            "check" => check::libstd_stamp(self, cmp, target),
            _ => compile::libstd_stamp(self, cmp, target),
762 763 764
        };

        let libtest_stamp = match cmd {
765 766
            "check" => check::libtest_stamp(self, cmp, target),
            _ => compile::libstd_stamp(self, cmp, target),
767 768 769
        };

        let librustc_stamp = match cmd {
770 771
            "check" => check::librustc_stamp(self, cmp, target),
            _ => compile::librustc_stamp(self, cmp, target),
772 773
        };

774
        if cmd == "doc" || cmd == "rustdoc" {
775
            if mode == Mode::Rustc || mode == Mode::ToolRustc || mode == Mode::Codegen {
776 777 778
                // This is the intended out directory for compiler documentation.
                my_out = self.compiler_doc_out(target);
            }
M
Mark Rousskov 已提交
779
            let rustdoc = self.rustdoc(compiler);
780
            self.clear_if_dirty(&my_out, &rustdoc);
781
        } else if cmd != "test" {
782 783 784
            match mode {
                Mode::Std => {
                    self.clear_if_dirty(&my_out, &self.rustc(compiler));
785 786 787
                    for backend in self.codegen_backends(compiler) {
                        self.clear_if_dirty(&my_out, &backend);
                    }
788
                },
789 790 791
                Mode::Test => {
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                },
792
                Mode::Rustc => {
793
                    self.clear_if_dirty(&my_out, &self.rustc(compiler));
794 795 796
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                    self.clear_if_dirty(&my_out, &libtest_stamp);
                },
C
Collins Abitekaniza 已提交
797
                Mode::Codegen => {
798
                    self.clear_if_dirty(&my_out, &librustc_stamp);
C
Collins Abitekaniza 已提交
799 800 801 802 803 804 805 806 807
                },
                Mode::ToolBootstrap => { },
                Mode::ToolStd => {
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                },
                Mode::ToolTest => {
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                    self.clear_if_dirty(&my_out, &libtest_stamp);
                },
808 809 810 811
                Mode::ToolRustc => {
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                    self.clear_if_dirty(&my_out, &libtest_stamp);
                    self.clear_if_dirty(&my_out, &librustc_stamp);
812
                },
813 814 815
            }
        }

S
Santiago Pastorino 已提交
816 817
        cargo
            .env("CARGO_TARGET_DIR", out_dir)
818 819
            .arg(cmd);

820 821 822 823 824 825 826
        // See comment in librustc_llvm/build.rs for why this is necessary, largely llvm-config
        // needs to not accidentally link to libLLVM in stage0/lib.
        cargo.env("REAL_LIBRARY_PATH_VAR", &util::dylib_path_var());
        if let Some(e) = env::var_os(util::dylib_path_var()) {
            cargo.env("REAL_LIBRARY_PATH", e);
        }

827 828 829 830 831 832
        if cmd != "install" {
            cargo.arg("--target")
                 .arg(target);
        } else {
            assert_eq!(target, compiler.host);
        }
833

V
varkor 已提交
834
        // Set a flag for `check` so that certain build scripts can do less work
835
        // (e.g., not building/requiring LLVM).
V
varkor 已提交
836 837 838 839
        if cmd == "check" {
            cargo.env("RUST_CHECK", "1");
        }

J
John Kåre Alsaker 已提交
840 841 842 843 844 845 846 847 848 849 850
        match mode {
            Mode::Std | Mode::Test | Mode::ToolBootstrap | Mode::ToolStd | Mode::ToolTest=> {},
            Mode::Rustc | Mode::Codegen | Mode::ToolRustc => {
                // Build proc macros both for the host and the target
                if target != compiler.host && cmd != "check" {
                    cargo.arg("-Zdual-proc-macros");
                    cargo.env("RUST_DUAL_PROC_MACROS", "1");
                }
            },
        }

851 852 853 854
        cargo.arg("-j").arg(self.jobs().to_string());
        // Remove make-related flags to ensure Cargo can correctly set things up
        cargo.env_remove("MAKEFLAGS");
        cargo.env_remove("MFLAGS");
855

856 857
        // FIXME: Temporary fix for https://github.com/rust-lang/cargo/issues/3005
        // Force cargo to output binaries with disambiguating hashes in the name
858 859
        let mut metadata = if compiler.stage == 0 {
            // Treat stage0 like a special channel, whether it's a normal prior-
860 861
            // release rustc or a local rebuild with the same version, so we
            // never mix these libraries by accident.
862
            "bootstrap".to_string()
863
        } else {
864
            self.config.channel.to_string()
865
        };
866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881
        // We want to make sure that none of the dependencies between
        // std/test/rustc unify with one another. This is done for weird linkage
        // reasons but the gist of the problem is that if librustc, libtest, and
        // libstd all depend on libc from crates.io (which they actually do) we
        // want to make sure they all get distinct versions. Things get really
        // weird if we try to unify all these dependencies right now, namely
        // around how many times the library is linked in dynamic libraries and
        // such. If rustc were a static executable or if we didn't ship dylibs
        // this wouldn't be a problem, but we do, so it is. This is in general
        // just here to make sure things build right. If you can remove this and
        // things still build right, please do!
        match mode {
            Mode::Std => metadata.push_str("std"),
            Mode::Test => metadata.push_str("test"),
            _ => {},
        }
882
        cargo.env("__CARGO_DEFAULT_LIB_METADATA", &metadata);
883 884

        let stage;
M
Mark Simulacrum 已提交
885
        if compiler.stage == 0 && self.local_rebuild {
886 887 888 889 890 891
            // Assume the local-rebuild rustc already has stage1 features.
            stage = 1;
        } else {
            stage = compiler.stage;
        }

892 893 894
        let mut extra_args = env::var(&format!("RUSTFLAGS_STAGE_{}", stage)).unwrap_or_default();
        if stage != 0 {
            let s = env::var("RUSTFLAGS_STAGE_NOT_0").unwrap_or_default();
895 896 897
            if !extra_args.is_empty() {
                extra_args.push_str(" ");
            }
898 899 900 901
            extra_args.push_str(&s);
        }

        if !extra_args.is_empty() {
S
Santiago Pastorino 已提交
902 903 904 905 906 907 908 909
            cargo.env(
                "RUSTFLAGS",
                format!(
                    "{} {}",
                    env::var("RUSTFLAGS").unwrap_or_default(),
                    extra_args
                ),
            );
910 911
        }

K
kennytm 已提交
912
        let want_rustdoc = self.doc_tests != DocTests::No;
K
kennytm 已提交
913

914 915 916 917 918 919
        // We synthetically interpret a stage0 compiler used to build tools as a
        // "raw" compiler in that it's the exact snapshot we download. Normally
        // the stage0 build means it uses libraries build by the stage0
        // compiler, but for tools we just use the precompiled libraries that
        // we've downloaded
        let use_snapshot = mode == Mode::ToolBootstrap;
920
        assert!(!use_snapshot || stage == 0 || self.local_rebuild);
921 922 923 924 925 926 927

        let maybe_sysroot = self.sysroot(compiler);
        let sysroot = if use_snapshot {
            self.rustc_snapshot_sysroot()
        } else {
            &maybe_sysroot
        };
M
Mark Rousskov 已提交
928
        let libdir = self.rustc_libdir(compiler);
929

930 931
        // Customize the compiler we're running. Specify the compiler to cargo
        // as our shim and then pass it some various options used to configure
M
Mark Simulacrum 已提交
932
        // how the actual compiler itself is called.
933 934 935
        //
        // These variables are primarily all read by
        // src/bootstrap/bin/{rustc.rs,rustdoc.rs}
S
Santiago Pastorino 已提交
936 937 938 939 940 941 942 943 944
        cargo
            .env("RUSTBUILD_NATIVE_DIR", self.native_dir(target))
            .env("RUSTC", self.out.join("bootstrap/debug/rustc"))
            .env("RUSTC_REAL", self.rustc(compiler))
            .env("RUSTC_STAGE", stage.to_string())
            .env(
                "RUSTC_DEBUG_ASSERTIONS",
                self.config.rust_debug_assertions.to_string(),
            )
945 946
            .env("RUSTC_SYSROOT", &sysroot)
            .env("RUSTC_LIBDIR", &libdir)
S
Santiago Pastorino 已提交
947 948 949 950
            .env("RUSTC_RPATH", self.config.rust_rpath.to_string())
            .env("RUSTDOC", self.out.join("bootstrap/debug/rustdoc"))
            .env(
                "RUSTDOC_REAL",
951
                if cmd == "doc" || cmd == "rustdoc" || (cmd == "test" && want_rustdoc) {
M
Mark Rousskov 已提交
952
                    self.rustdoc(compiler)
S
Santiago Pastorino 已提交
953 954 955 956 957 958
                } else {
                    PathBuf::from("/path/to/nowhere/rustdoc/not/required")
                },
            )
            .env("TEST_MIRI", self.config.test_miri.to_string())
            .env("RUSTC_ERROR_METADATA_DST", self.extended_error_dir());
959

960
        if let Some(host_linker) = self.linker(compiler.host) {
O
Oliver Schneider 已提交
961 962
            cargo.env("RUSTC_HOST_LINKER", host_linker);
        }
963
        if let Some(target_linker) = self.linker(target) {
O
Oliver Schneider 已提交
964 965
            cargo.env("RUSTC_TARGET_LINKER", target_linker);
        }
P
penpalperson 已提交
966 967 968
        if let Some(ref error_format) = self.config.rustc_error_format {
            cargo.env("RUSTC_ERROR_FORMAT", error_format);
        }
969
        if cmd != "build" && cmd != "check" && cmd != "rustc" && want_rustdoc {
M
Mark Rousskov 已提交
970
            cargo.env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler));
971
        }
972

973 974 975 976 977 978 979 980 981
        let debuginfo_level = match mode {
            Mode::Rustc | Mode::Codegen => self.config.rust_debuginfo_level_rustc,
            Mode::Std | Mode::Test => self.config.rust_debuginfo_level_std,
            Mode::ToolBootstrap | Mode::ToolStd |
            Mode::ToolTest | Mode::ToolRustc => self.config.rust_debuginfo_level_tools,
        };
        cargo.env("RUSTC_DEBUGINFO_LEVEL", debuginfo_level.to_string());

        if !mode.is_tool() {
O
Oliver Schneider 已提交
982
            cargo.env("RUSTC_FORCE_UNSTABLE", "1");
983 984

            // Currently the compiler depends on crates from crates.io, and
985
            // then other crates can depend on the compiler (e.g., proc-macro
M
Mark Simulacrum 已提交
986
            // crates). Let's say, for example that rustc itself depends on the
987 988
            // bitflags crate. If an external crate then depends on the
            // bitflags crate as well, we need to make sure they don't
B
Bastien Orivel 已提交
989
            // conflict, even if they pick the same version of bitflags. We'll
990
            // want to make sure that e.g., a plugin and rustc each get their
991 992 993 994 995 996 997 998 999 1000 1001 1002
            // own copy of bitflags.

            // Cargo ensures that this works in general through the -C metadata
            // flag. This flag will frob the symbols in the binary to make sure
            // they're different, even though the source code is the exact
            // same. To solve this problem for the compiler we extend Cargo's
            // already-passed -C metadata flag with our own. Our rustc.rs
            // wrapper around the actual rustc will detect -C metadata being
            // passed and frob it with this extra string we're passing in.
            cargo.env("RUSTC_METADATA_SUFFIX", "rustc");
        }

1003 1004 1005 1006
        if let Some(x) = self.crt_static(target) {
            cargo.env("RUSTC_CRT_STATIC", x.to_string());
        }

1007 1008 1009 1010
        if let Some(x) = self.crt_static(compiler.host) {
            cargo.env("RUSTC_HOST_CRT_STATIC", x.to_string());
        }

1011 1012 1013 1014
        if let Some(map) = self.build.debuginfo_map(GitRepo::Rustc) {
            cargo.env("RUSTC_DEBUGINFO_MAP", map);
        }

1015 1016
        // Enable usage of unstable features
        cargo.env("RUSTC_BOOTSTRAP", "1");
M
Mark Simulacrum 已提交
1017
        self.add_rust_test_threads(&mut cargo);
1018 1019 1020

        // Almost all of the crates that we compile as part of the bootstrap may
        // have a build script, including the standard library. To compile a
M
Mark Simulacrum 已提交
1021
        // build script, however, it itself needs a standard library! This
1022
        // introduces a bit of a pickle when we're compiling the standard
M
Mark Simulacrum 已提交
1023
        // library itself.
1024 1025
        //
        // To work around this we actually end up using the snapshot compiler
M
Mark Simulacrum 已提交
1026
        // (stage0) for compiling build scripts of the standard library itself.
1027 1028 1029 1030 1031
        // The stage0 compiler is guaranteed to have a libstd available for use.
        //
        // For other crates, however, we know that we've already got a standard
        // library up and running, so we can use the normal compiler to compile
        // build scripts in that situation.
B
bjorn3 已提交
1032
        if mode == Mode::Std {
S
Santiago Pastorino 已提交
1033 1034 1035
            cargo
                .env("RUSTC_SNAPSHOT", &self.initial_rustc)
                .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_snapshot_libdir());
1036
        } else {
S
Santiago Pastorino 已提交
1037 1038 1039
            cargo
                .env("RUSTC_SNAPSHOT", self.rustc(compiler))
                .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_libdir(compiler));
1040 1041
        }

1042
        if self.config.incremental {
1043
            cargo.env("CARGO_INCREMENTAL", "1");
1044 1045 1046
        } else {
            // Don't rely on any default setting for incr. comp. in Cargo
            cargo.env("CARGO_INCREMENTAL", "0");
1047 1048
        }

M
Mark Simulacrum 已提交
1049
        if let Some(ref on_fail) = self.config.on_fail {
1050 1051 1052
            cargo.env("RUSTC_ON_FAIL", on_fail);
        }

1053 1054 1055 1056
        if self.config.print_step_timings {
            cargo.env("RUSTC_PRINT_STEP_TIMINGS", "1");
        }

J
John Kåre Alsaker 已提交
1057 1058 1059 1060
        if self.config.backtrace_on_ice {
            cargo.env("RUSTC_BACKTRACE_ON_ICE", "1");
        }

L
ljedrz 已提交
1061
        cargo.env("RUSTC_VERBOSE", self.verbosity.to_string());
1062

V
varkor 已提交
1063
        if self.config.deny_warnings {
1064 1065 1066
            cargo.env("RUSTC_DENY_WARNINGS", "1");
        }

O
Oliver Schneider 已提交
1067 1068 1069 1070 1071
        // Throughout the build Cargo can execute a number of build scripts
        // compiling C/C++ code and we need to pass compilers, archivers, flags, etc
        // obtained previously to those build scripts.
        // Build scripts use either the `cc` crate or `configure/make` so we pass
        // the options through environment variables that are fetched and understood by both.
1072 1073
        //
        // FIXME: the guard against msvc shouldn't need to be here
1074 1075 1076 1077 1078
        if target.contains("msvc") {
            if let Some(ref cl) = self.config.llvm_clang_cl {
                cargo.env("CC", cl).env("CXX", cl);
            }
        } else {
1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095
            let ccache = self.config.ccache.as_ref();
            let ccacheify = |s: &Path| {
                let ccache = match ccache {
                    Some(ref s) => s,
                    None => return s.display().to_string(),
                };
                // FIXME: the cc-rs crate only recognizes the literal strings
                // `ccache` and `sccache` when doing caching compilations, so we
                // mirror that here. It should probably be fixed upstream to
                // accept a new env var or otherwise work with custom ccache
                // vars.
                match &ccache[..] {
                    "ccache" | "sccache" => format!("{} {}", ccache, s.display()),
                    _ => s.display().to_string(),
                }
            };
            let cc = ccacheify(&self.cc(target));
1096
            cargo.env(format!("CC_{}", target), &cc);
O
Oliver Schneider 已提交
1097

1098
            let cflags = self.cflags(target, GitRepo::Rustc).join(" ");
S
Santiago Pastorino 已提交
1099
            cargo
1100
                .env(format!("CFLAGS_{}", target), cflags.clone());
O
Oliver Schneider 已提交
1101 1102 1103

            if let Some(ar) = self.ar(target) {
                let ranlib = format!("{} s", ar.display());
S
Santiago Pastorino 已提交
1104 1105
                cargo
                    .env(format!("AR_{}", target), ar)
1106
                    .env(format!("RANLIB_{}", target), ranlib);
O
Oliver Schneider 已提交
1107
            }
1108

M
Mark Simulacrum 已提交
1109
            if let Ok(cxx) = self.cxx(target) {
1110
                let cxx = ccacheify(&cxx);
S
Santiago Pastorino 已提交
1111 1112
                cargo
                    .env(format!("CXX_{}", target), &cxx)
1113
                    .env(format!("CXXFLAGS_{}", target), cflags);
1114 1115 1116
            }
        }

1117
        if (cmd == "build" || cmd == "rustc")
C
Collins Abitekaniza 已提交
1118
            && mode == Mode::Std
S
Santiago Pastorino 已提交
1119 1120
            && self.config.extended
            && compiler.is_final_stage(self)
1121
        {
1122 1123 1124
            cargo.env("RUSTC_SAVE_ANALYSIS", "api".to_string());
        }

O
Oliver Schneider 已提交
1125
        // For `cargo doc` invocations, make rustdoc print the Rust version into the docs
1126
        cargo.env("RUSTDOC_CRATE_VERSION", self.rust_version());
O
Oliver Schneider 已提交
1127

1128 1129 1130 1131 1132
        // Environment variables *required* throughout the build
        //
        // FIXME: should update code to not require this env var
        cargo.env("CFG_COMPILER_HOST_TRIPLE", target);

1133
        // Set this for all builds to make sure doc builds also get it.
1134
        cargo.env("CFG_RELEASE_CHANNEL", &self.config.channel);
1135

1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153
        // This one's a bit tricky. As of the time of this writing the compiler
        // links to the `winapi` crate on crates.io. This crate provides raw
        // bindings to Windows system functions, sort of like libc does for
        // Unix. This crate also, however, provides "import libraries" for the
        // MinGW targets. There's an import library per dll in the windows
        // distribution which is what's linked to. These custom import libraries
        // are used because the winapi crate can reference Windows functions not
        // present in the MinGW import libraries.
        //
        // For example MinGW may ship libdbghelp.a, but it may not have
        // references to all the functions in the dbghelp dll. Instead the
        // custom import library for dbghelp in the winapi crates has all this
        // information.
        //
        // Unfortunately for us though the import libraries are linked by
        // default via `-ldylib=winapi_foo`. That is, they're linked with the
        // `dylib` type with a `winapi_` prefix (so the winapi ones don't
        // conflict with the system MinGW ones). This consequently means that
I
Irina Popa 已提交
1154
        // the binaries we ship of things like rustc_codegen_llvm (aka the rustc_codegen_llvm
1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166
        // DLL) when linked against *again*, for example with procedural macros
        // or plugins, will trigger the propagation logic of `-ldylib`, passing
        // `-lwinapi_foo` to the linker again. This isn't actually available in
        // our distribution, however, so the link fails.
        //
        // To solve this problem we tell winapi to not use its bundled import
        // libraries. This means that it will link to the system MinGW import
        // libraries by default, and the `-ldylib=foo` directives will still get
        // passed to the final linker, but they'll look like `-lfoo` which can
        // be resolved because MinGW has the import library. The downside is we
        // don't get newer functions from Windows, but we don't use any of them
        // anyway.
C
Collins Abitekaniza 已提交
1167
        if !mode.is_tool() {
A
Alex Crichton 已提交
1168 1169
            cargo.env("WINAPI_NO_BUNDLED_LIBRARIES", "1");
        }
1170

C
comex 已提交
1171
        for _ in 1..self.verbosity {
1172 1173
            cargo.arg("-v");
        }
1174

1175 1176 1177 1178 1179 1180 1181 1182 1183
        match (mode, self.config.rust_codegen_units_std, self.config.rust_codegen_units) {
            (Mode::Std, Some(n), _) |
            (Mode::Test, Some(n), _) |
            (_, _, Some(n)) => {
                cargo.env("RUSTC_CODEGEN_UNITS", n.to_string());
            }
            _ => {
                // Don't set anything
            }
1184 1185
        }

O
Oliver Schneider 已提交
1186
        if self.config.rust_optimize {
1187 1188
            // FIXME: cargo bench/install do not accept `--release`
            if cmd != "bench" && cmd != "install" {
O
Oliver Schneider 已提交
1189 1190
                cargo.arg("--release");
            }
1191
        }
1192

M
Mark Simulacrum 已提交
1193
        if self.config.locked_deps {
1194 1195
            cargo.arg("--locked");
        }
M
Mark Simulacrum 已提交
1196
        if self.config.vendor || self.is_sudo {
1197 1198 1199
            cargo.arg("--frozen");
        }

M
Mark Simulacrum 已提交
1200
        self.ci_env.force_coloring_in_ci(&mut cargo);
1201 1202 1203 1204

        cargo
    }

V
varkor 已提交
1205
    /// Ensure that a given step is built, returning its output. This will
1206 1207
    /// cache the step, so it is safe (and good!) to call this as often as
    /// needed to ensure that all dependencies are built.
1208
    pub fn ensure<S: Step>(&'a self, step: S) -> S::Output {
1209 1210
        {
            let mut stack = self.stack.borrow_mut();
1211 1212
            for stack_step in stack.iter() {
                // should skip
S
Santiago Pastorino 已提交
1213 1214 1215 1216
                if stack_step
                    .downcast_ref::<S>()
                    .map_or(true, |stack_step| *stack_step != step)
                {
1217
                    continue;
1218
                }
1219
                let mut out = String::new();
1220
                out += &format!("\n\nCycle in build detected when adding {:?}\n", step);
1221 1222 1223 1224 1225
                for el in stack.iter().rev() {
                    out += &format!("\t{:?}\n", el);
                }
                panic!(out);
            }
1226
            if let Some(out) = self.cache.get(&step) {
1227
                self.verbose(&format!("{}c {:?}", "  ".repeat(stack.len()), step));
1228

1229 1230 1231
                {
                    let mut graph = self.graph.borrow_mut();
                    let parent = self.parent.get();
S
Santiago Pastorino 已提交
1232 1233 1234
                    let us = *self
                        .graph_nodes
                        .borrow_mut()
1235 1236 1237 1238 1239 1240 1241
                        .entry(format!("{:?}", step))
                        .or_insert_with(|| graph.add_node(format!("{:?}", step)));
                    if let Some(parent) = parent {
                        graph.add_edge(parent, us, false);
                    }
                }

1242 1243
                return out;
            }
1244
            self.verbose(&format!("{}> {:?}", "  ".repeat(stack.len()), step));
1245
            stack.push(Box::new(step.clone()));
1246
        }
1247

1248 1249 1250 1251 1252
        let prev_parent = self.parent.get();

        {
            let mut graph = self.graph.borrow_mut();
            let parent = self.parent.get();
S
Santiago Pastorino 已提交
1253 1254 1255
            let us = *self
                .graph_nodes
                .borrow_mut()
1256 1257 1258 1259 1260 1261 1262 1263
                .entry(format!("{:?}", step))
                .or_insert_with(|| graph.add_node(format!("{:?}", step)));
            self.parent.set(Some(us));
            if let Some(parent) = parent {
                graph.add_edge(parent, us, true);
            }
        }

1264 1265 1266 1267 1268 1269 1270 1271 1272 1273
        let (out, dur) = {
            let start = Instant::now();
            let zero = Duration::new(0, 0);
            let parent = self.time_spent_on_dependencies.replace(zero);
            let out = step.clone().run(self);
            let dur = start.elapsed();
            let deps = self.time_spent_on_dependencies.replace(parent + dur);
            (out, dur - deps)
        };

1274 1275
        self.parent.set(prev_parent);

1276
        if self.config.print_step_timings && dur > Duration::from_millis(100) {
S
Santiago Pastorino 已提交
1277 1278 1279 1280 1281 1282
            println!(
                "[TIMING] {:?} -- {}.{:03}",
                step,
                dur.as_secs(),
                dur.subsec_nanos() / 1_000_000
            );
1283 1284
        }

1285 1286
        {
            let mut stack = self.stack.borrow_mut();
1287 1288
            let cur_step = stack.pop().expect("step stack empty");
            assert_eq!(cur_step.downcast_ref(), Some(&step));
1289
        }
S
Santiago Pastorino 已提交
1290 1291 1292 1293 1294
        self.verbose(&format!(
            "{}< {:?}",
            "  ".repeat(self.stack.borrow().len()),
            step
        ));
1295 1296
        self.cache.put(step, out.clone());
        out
1297 1298
    }
}
M
Mark Simulacrum 已提交
1299 1300 1301

#[cfg(test)]
mod __test {
S
Santiago Pastorino 已提交
1302
    use super::*;
L
ljedrz 已提交
1303
    use crate::config::Config;
1304
    use std::thread;
M
Mark Simulacrum 已提交
1305

1306 1307
    use pretty_assertions::assert_eq;

M
Mark Simulacrum 已提交
1308 1309
    fn configure(host: &[&str], target: &[&str]) -> Config {
        let mut config = Config::default_opts();
M
Mark Simulacrum 已提交
1310 1311
        // don't save toolstates
        config.save_toolstates = None;
M
Mark Simulacrum 已提交
1312
        config.run_host_only = true;
1313 1314
        config.dry_run = true;
        // try to avoid spurious failures in dist where we create/delete each others file
S
Santiago Pastorino 已提交
1315 1316 1317 1318 1319 1320
        let dir = config.out.join("tmp-rustbuild-tests").join(
            &thread::current()
                .name()
                .unwrap_or("unknown")
                .replace(":", "-"),
        );
1321 1322
        t!(fs::create_dir_all(&dir));
        config.out = dir;
M
Mark Simulacrum 已提交
1323
        config.build = INTERNER.intern_str("A");
S
Santiago Pastorino 已提交
1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334
        config.hosts = vec![config.build]
            .clone()
            .into_iter()
            .chain(host.iter().map(|s| INTERNER.intern_str(s)))
            .collect::<Vec<_>>();
        config.targets = config
            .hosts
            .clone()
            .into_iter()
            .chain(target.iter().map(|s| INTERNER.intern_str(s)))
            .collect::<Vec<_>>();
M
Mark Simulacrum 已提交
1335 1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347 1348 1349
        config
    }

    fn first<A, B>(v: Vec<(A, B)>) -> Vec<A> {
        v.into_iter().map(|(a, _)| a).collect::<Vec<_>>()
    }

    #[test]
    fn dist_baseline() {
        let build = Build::new(configure(&[], &[]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");

S
Santiago Pastorino 已提交
1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[dist::Docs { stage: 2, host: a },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[dist::Rustc {
                compiler: Compiler { host: a, stage: 2 }
            },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[dist::Std {
M
Mark Simulacrum 已提交
1367 1368
                compiler: Compiler { host: a, stage: 2 },
                target: a,
S
Santiago Pastorino 已提交
1369 1370
            },]
        );
M
Mark Simulacrum 已提交
1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_targets() {
        let build = Build::new(configure(&[], &["B"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");

S
Santiago Pastorino 已提交
1383 1384 1385 1386 1387 1388 1389 1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a }, dist::Mingw { host: b },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[dist::Rustc {
                compiler: Compiler { host: a, stage: 2 }
            },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
M
Mark Simulacrum 已提交
1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_hosts() {
        let build = Build::new(configure(&["B"], &[]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");

S
Santiago Pastorino 已提交
1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a }, dist::Mingw { host: b },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[
                dist::Rustc {
                    compiler: Compiler { host: a, stage: 2 }
                },
                dist::Rustc {
                    compiler: Compiler { host: b, stage: 2 }
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
M
Mark Simulacrum 已提交
1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_targets_and_hosts() {
        let build = Build::new(configure(&["B"], &["C"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

S
Santiago Pastorino 已提交
1473 1474 1475 1476 1477 1478 1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
                dist::Docs { stage: 2, host: c },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[
                dist::Mingw { host: a },
                dist::Mingw { host: b },
                dist::Mingw { host: c },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[
                dist::Rustc {
                    compiler: Compiler { host: a, stage: 2 }
                },
                dist::Rustc {
                    compiler: Compiler { host: b, stage: 2 }
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_target_flag() {
        let mut config = configure(&["B"], &["C"]);
        config.run_host_only = false; // as-if --target=C was passed
        let build = Build::new(config);
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

S
Santiago Pastorino 已提交
1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
                dist::Docs { stage: 2, host: c },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[
                dist::Mingw { host: a },
                dist::Mingw { host: b },
                dist::Mingw { host: c },
            ]
        );
M
Mark Simulacrum 已提交
1548
        assert_eq!(first(builder.cache.all::<dist::Rustc>()), &[]);
S
Santiago Pastorino 已提交
1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[]);
    }

    #[test]
    fn dist_with_same_targets_and_hosts() {
        let build = Build::new(configure(&["B"], &["B"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");

S
Santiago Pastorino 已提交
1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a }, dist::Mingw { host: b },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[
                dist::Rustc {
                    compiler: Compiler { host: a, stage: 2 }
                },
                dist::Rustc {
                    compiler: Compiler { host: b, stage: 2 }
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
M
Mark Simulacrum 已提交
1613
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
S
Santiago Pastorino 已提交
1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680
        assert_eq!(
            first(builder.cache.all::<compile::Std>()),
            &[
                compile::Std {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<compile::Test>()),
            &[
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<compile::Assemble>()),
            &[
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 0 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 1 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 2 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: b, stage: 2 },
                },
            ]
        );
M
Mark Simulacrum 已提交
1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694
    }

    #[test]
    fn build_default() {
        let build = Build::new(configure(&["B"], &["C"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Build), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

        assert!(!builder.cache.all::<compile::Std>().is_empty());
        assert!(!builder.cache.all::<compile::Assemble>().is_empty());
S
Santiago Pastorino 已提交
1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777
        assert_eq!(
            first(builder.cache.all::<compile::Rustc>()),
            &[
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: b, stage: 2 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: b, stage: 2 },
                    target: b,
                },
            ]
        );

        assert_eq!(
            first(builder.cache.all::<compile::Test>()),
            &[
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792
    }

    #[test]
    fn build_with_target_flag() {
        let mut config = configure(&["B"], &["C"]);
        config.run_host_only = false;
        let build = Build::new(config);
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Build), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

        assert!(!builder.cache.all::<compile::Std>().is_empty());
S
Santiago Pastorino 已提交
1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844 1845 1846 1847 1848 1849 1850 1851 1852 1853 1854 1855 1856 1857 1858 1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871 1872 1873 1874 1875 1876 1877 1878 1879
        assert_eq!(
            first(builder.cache.all::<compile::Assemble>()),
            &[
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 0 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 1 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: b, stage: 1 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 2 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: b, stage: 2 },
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<compile::Rustc>()),
            &[
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
            ]
        );

        assert_eq!(
            first(builder.cache.all::<compile::Test>()),
            &[
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1880
    }
K
kennytm 已提交
1881 1882 1883 1884 1885 1886 1887 1888 1889 1890

    #[test]
    fn test_with_no_doc_stage0() {
        let mut config = configure(&[], &[]);
        config.stage = Some(0);
        config.cmd = Subcommand::Test {
            paths: vec!["src/libstd".into()],
            test_args: vec![],
            rustc_args: vec![],
            fail_fast: true,
K
kennytm 已提交
1891
            doc_tests: DocTests::No,
O
Oliver Schneider 已提交
1892
            bless: false,
S
Santiago Pastorino 已提交
1893
            compare_mode: None,
P
Philipp Hansch 已提交
1894
            rustfix_coverage: false,
K
kennytm 已提交
1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907
        };

        let build = Build::new(config);
        let mut builder = Builder::new(&build);

        let host = INTERNER.intern_str("A");

        builder.run_step_descriptions(
            &[StepDescription::from::<test::Crate>()],
            &["src/libstd".into()],
        );

        // Ensure we don't build any compiler artifacts.
1908
        assert!(!builder.cache.contains::<compile::Rustc>());
S
Santiago Pastorino 已提交
1909 1910 1911
        assert_eq!(
            first(builder.cache.all::<test::Crate>()),
            &[test::Crate {
K
kennytm 已提交
1912 1913
                compiler: Compiler { host, stage: 0 },
                target: host,
C
Collins Abitekaniza 已提交
1914
                mode: Mode::Std,
K
kennytm 已提交
1915 1916
                test_kind: test::TestKind::Test,
                krate: INTERNER.intern_str("std"),
S
Santiago Pastorino 已提交
1917 1918
            },]
        );
K
kennytm 已提交
1919
    }
1920 1921 1922 1923 1924 1925 1926 1927 1928 1929 1930 1931 1932 1933 1934 1935

    #[test]
    fn test_exclude() {
        let mut config = configure(&[], &[]);
        config.exclude = vec![
            "src/test/run-pass".into(),
            "src/tools/tidy".into(),
        ];
        config.cmd = Subcommand::Test {
            paths: Vec::new(),
            test_args: Vec::new(),
            rustc_args: Vec::new(),
            fail_fast: true,
            doc_tests: DocTests::No,
            bless: false,
            compare_mode: None,
P
Philipp Hansch 已提交
1936
            rustfix_coverage: false,
1937 1938 1939 1940 1941 1942 1943 1944 1945 1946 1947 1948 1949 1950
        };

        let build = Build::new(config);
        let builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Test), &[]);

        // Ensure we have really excluded run-pass & tidy
        assert!(!builder.cache.contains::<test::RunPass>());
        assert!(!builder.cache.contains::<test::Tidy>());

        // Ensure other tests are not affected.
        assert!(builder.cache.contains::<test::RunPassFullDeps>());
        assert!(builder.cache.contains::<test::RustdocUi>());
    }
M
Mark Simulacrum 已提交
1951
}