builder.rs 23.3 KB
Newer Older
1 2 3 4 5 6 7 8 9 10
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

11 12
use std::fmt::Debug;
use std::hash::Hash;
13 14 15 16
use std::cell::RefCell;
use std::path::{Path, PathBuf};
use std::process::Command;
use std::fs;
17
use std::ops::Deref;
18
use std::any::Any;
19
use std::collections::BTreeSet;
20 21 22 23 24 25

use compile;
use install;
use dist;
use util::{exe, libdir, add_lib_path};
use {Build, Mode};
26
use cache::{INTERNER, Interned, Cache};
27 28 29
use check;
use flags::Subcommand;
use doc;
M
Mark Simulacrum 已提交
30
use tool;
A
Alex Crichton 已提交
31
use native;
32

33 34
pub use Compiler;

35 36 37 38 39
pub struct Builder<'a> {
    pub build: &'a Build,
    pub top_stage: u32,
    pub kind: Kind,
    cache: Cache,
40
    stack: RefCell<Vec<Box<Any>>>,
41 42 43 44 45 46 47 48 49 50
}

impl<'a> Deref for Builder<'a> {
    type Target = Build;

    fn deref(&self) -> &Self::Target {
        self.build
    }
}

51
pub trait Step: 'static + Clone + Debug + PartialEq + Eq + Hash {
52 53
    /// `PathBuf` when directories are created or to return a `Compiler` once
    /// it's been assembled.
54
    type Output: Clone;
55

56 57
    const DEFAULT: bool = false;

58
    /// Run this rule for all hosts without cross compiling.
59 60 61 62 63 64 65 66
    const ONLY_HOSTS: bool = false;

    /// Run this rule for all targets, but only with the native host.
    const ONLY_BUILD_TARGETS: bool = false;

    /// Only run this step with the build triple as host and target.
    const ONLY_BUILD: bool = false;

67 68
    /// Primary function to execute this rule. Can call `builder.ensure(...)`
    /// with other steps to run those.
69
    fn run(self, builder: &Builder) -> Self::Output;
70

71 72 73 74
    /// When bootstrap is passed a set of paths, this controls whether this rule
    /// will execute. However, it does not get called in a "default" context
    /// when we are not passed any paths; in that case, make_run is called
    /// directly.
75
    fn should_run(run: ShouldRun) -> ShouldRun;
76

77 78 79 80 81 82
    /// Build up a "root" rule, either as a default rule or from a path passed
    /// to us.
    ///
    /// When path is `None`, we are executing in a context where no paths were
    /// passed. When `./x.py build` is run, for example, this rule could get
    /// called if it is in the correct list below with a path of `None`.
83
    fn make_run(_run: RunConfig) {
84 85 86 87 88 89
        // It is reasonable to not have an implementation of make_run for rules
        // who do not want to get called from the root context. This means that
        // they are likely dependencies (e.g., sysroot creation) or similar, and
        // as such calling them from ./x.py isn't logical.
        unimplemented!()
    }
90 91
}

92 93 94 95 96 97 98
pub struct RunConfig<'a> {
    pub builder: &'a Builder<'a>,
    pub host: Interned<String>,
    pub target: Interned<String>,
    pub path: Option<&'a Path>,
}

99 100 101 102 103 104
struct StepDescription {
    default: bool,
    only_hosts: bool,
    only_build_targets: bool,
    only_build: bool,
    should_run: fn(ShouldRun) -> ShouldRun,
105
    make_run: fn(RunConfig),
106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122
}

impl StepDescription {
    fn from<S: Step>() -> StepDescription {
        StepDescription {
            default: S::DEFAULT,
            only_hosts: S::ONLY_HOSTS,
            only_build_targets: S::ONLY_BUILD_TARGETS,
            only_build: S::ONLY_BUILD,
            should_run: S::should_run,
            make_run: S::make_run,
        }
    }

    fn maybe_run(&self, builder: &Builder, path: Option<&Path>) {
        let build = builder.build;
        let hosts = if self.only_build_targets || self.only_build {
M
Mark Simulacrum 已提交
123
            build.build_triple()
124 125 126 127
        } else {
            &build.hosts
        };

M
Mark Simulacrum 已提交
128
        // Determine the targets participating in this rule.
129
        let targets = if self.only_hosts {
130
            if build.config.run_host_only {
131 132
                &[]
            } else if self.only_build {
M
Mark Simulacrum 已提交
133
                build.build_triple()
134
            } else {
M
Mark Simulacrum 已提交
135
                &build.hosts
136 137 138 139 140 141 142
            }
        } else {
            &build.targets
        };

        for host in hosts {
            for target in targets {
143 144 145 146 147 148 149
                let run = RunConfig {
                    builder,
                    path,
                    host: *host,
                    target: *target,
                };
                (self.make_run)(run);
150 151 152 153 154
            }
        }
    }

    fn run(v: &[StepDescription], builder: &Builder, paths: &[PathBuf]) {
155 156 157
        let should_runs = v.iter().map(|desc| {
            (desc.should_run)(ShouldRun::new(builder))
        }).collect::<Vec<_>>();
158
        if paths.is_empty() {
159 160
            for (desc, should_run) in v.iter().zip(should_runs) {
                if desc.default && should_run.is_really_default {
161 162 163 164 165 166
                    desc.maybe_run(builder, None);
                }
            }
        } else {
            for path in paths {
                let mut attempted_run = false;
167 168
                for (desc, should_run) in v.iter().zip(&should_runs) {
                    if should_run.run(path) {
169 170 171 172 173 174 175 176 177 178 179 180 181
                        attempted_run = true;
                        desc.maybe_run(builder, Some(path));
                    }
                }

                if !attempted_run {
                    eprintln!("Warning: no rules matched {}.", path.display());
                }
            }
        }
    }
}

182 183
#[derive(Clone)]
pub struct ShouldRun<'a> {
184
    pub builder: &'a Builder<'a>,
185 186
    // use a BTreeSet to maintain sort order
    paths: BTreeSet<PathBuf>,
187 188 189 190

    // If this is a default rule, this is an additional constraint placed on
    // it's run. Generally something like compiler docs being enabled.
    is_really_default: bool,
191 192 193 194 195 196 197
}

impl<'a> ShouldRun<'a> {
    fn new(builder: &'a Builder) -> ShouldRun<'a> {
        ShouldRun {
            builder: builder,
            paths: BTreeSet::new(),
198
            is_really_default: true, // by default no additional conditions
199 200 201
        }
    }

202 203 204 205 206
    pub fn default_condition(mut self, cond: bool) -> Self {
        self.is_really_default = cond;
        self
    }

207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228
    pub fn krate(mut self, name: &str) -> Self {
        for (_, krate_path) in self.builder.crates(name) {
            self.paths.insert(PathBuf::from(krate_path));
        }
        self
    }

    pub fn path(mut self, path: &str) -> Self {
        self.paths.insert(PathBuf::from(path));
        self
    }

    // allows being more explicit about why should_run in Step returns the value passed to it
    pub fn never(self) -> ShouldRun<'a> {
        self
    }

    fn run(&self, path: &Path) -> bool {
        self.paths.iter().any(|p| path.ends_with(p))
    }
}

229 230 231 232 233 234 235 236 237 238
#[derive(Copy, Clone, PartialEq, Eq, Debug)]
pub enum Kind {
    Build,
    Test,
    Bench,
    Dist,
    Doc,
    Install,
}

239 240 241 242 243 244
impl<'a> Builder<'a> {
    fn get_step_descriptions(kind: Kind) -> Vec<StepDescription> {
        macro_rules! describe {
            ($($rule:ty),+ $(,)*) => {{
                vec![$(StepDescription::from::<$rule>()),+]
            }};
245
        }
246 247 248 249 250
        match kind {
            Kind::Build => describe!(compile::Std, compile::Test, compile::Rustc,
                compile::StartupObjects, tool::BuildManifest, tool::Rustbook, tool::ErrorIndex,
                tool::UnstableBookGen, tool::Tidy, tool::Linkchecker, tool::CargoTest,
                tool::Compiletest, tool::RemoteTestServer, tool::RemoteTestClient,
A
Alex Crichton 已提交
251 252
                tool::RustInstaller, tool::Cargo, tool::Rls, tool::Rustdoc,
                native::Llvm),
253 254
            Kind::Test => describe!(check::Tidy, check::Bootstrap, check::DefaultCompiletest,
                check::HostCompiletest, check::Crate, check::CrateLibrustc, check::Linkcheck,
M
Mark Simulacrum 已提交
255 256
                check::Cargotest, check::Cargo, check::Rls, check::Docs, check::ErrorIndex,
                check::Distcheck),
257 258 259
            Kind::Bench => describe!(check::Crate, check::CrateLibrustc),
            Kind::Doc => describe!(doc::UnstableBook, doc::UnstableBookGen, doc::TheBook,
                doc::Standalone, doc::Std, doc::Test, doc::Rustc, doc::ErrorIndex, doc::Nomicon,
S
steveklabnik 已提交
260
                doc::Reference, doc::Rustdoc),
261 262 263 264 265 266 267
            Kind::Dist => describe!(dist::Docs, dist::Mingw, dist::Rustc, dist::DebuggerScripts,
                dist::Std, dist::Analysis, dist::Src, dist::PlainSourceTarball, dist::Cargo,
                dist::Rls, dist::Extended, dist::HashSign),
            Kind::Install => describe!(install::Docs, install::Std, install::Cargo, install::Rls,
                install::Analysis, install::Src, install::Rustc),
        }
    }
268

269 270 271 272 273 274 275 276 277 278 279 280 281
    pub fn get_help(build: &Build, subcommand: &str) -> Option<String> {
        let kind = match subcommand {
            "build" => Kind::Build,
            "doc" => Kind::Doc,
            "test" => Kind::Test,
            "bench" => Kind::Bench,
            "dist" => Kind::Dist,
            "install" => Kind::Install,
            _ => return None,
        };

        let builder = Builder {
            build: build,
M
Mark Simulacrum 已提交
282
            top_stage: build.config.stage.unwrap_or(2),
283 284 285 286 287 288 289
            kind: kind,
            cache: Cache::new(),
            stack: RefCell::new(Vec::new()),
        };

        let builder = &builder;
        let mut should_run = ShouldRun::new(builder);
290 291
        for desc in Builder::get_step_descriptions(builder.kind) {
            should_run = (desc.should_run)(should_run);
292 293 294 295 296 297 298 299
        }
        let mut help = String::from("Available paths:\n");
        for path in should_run.paths {
            help.push_str(format!("    ./x.py {} {}\n", subcommand, path.display()).as_str());
        }
        Some(help)
    }

300
    pub fn run(build: &Build) {
M
Mark Simulacrum 已提交
301
        let (kind, paths) = match build.config.cmd {
302 303 304 305 306 307 308 309 310 311 312
            Subcommand::Build { ref paths } => (Kind::Build, &paths[..]),
            Subcommand::Doc { ref paths } => (Kind::Doc, &paths[..]),
            Subcommand::Test { ref paths, .. } => (Kind::Test, &paths[..]),
            Subcommand::Bench { ref paths, .. } => (Kind::Bench, &paths[..]),
            Subcommand::Dist { ref paths } => (Kind::Dist, &paths[..]),
            Subcommand::Install { ref paths } => (Kind::Install, &paths[..]),
            Subcommand::Clean => panic!(),
        };

        let builder = Builder {
            build: build,
M
Mark Simulacrum 已提交
313
            top_stage: build.config.stage.unwrap_or(2),
314 315 316 317 318
            kind: kind,
            cache: Cache::new(),
            stack: RefCell::new(Vec::new()),
        };

319
        StepDescription::run(&Builder::get_step_descriptions(builder.kind), &builder, paths);
320 321 322 323
    }

    pub fn default_doc(&self, paths: Option<&[PathBuf]>) {
        let paths = paths.unwrap_or(&[]);
324
        StepDescription::run(&Builder::get_step_descriptions(Kind::Doc), self, paths);
325 326
    }

B
Bastien Orivel 已提交
327
    /// Obtain a compiler at a given stage and for a given host. Explicitly does
328 329 330
    /// not take `Compiler` since all `Compiler` instances are meant to be
    /// obtained through this function, since it ensures that they are valid
    /// (i.e., built and assembled).
331
    pub fn compiler(&self, stage: u32, host: Interned<String>) -> Compiler {
332 333 334
        self.ensure(compile::Assemble { target_compiler: Compiler { stage, host } })
    }

335
    pub fn sysroot(&self, compiler: Compiler) -> Interned<PathBuf> {
336 337 338 339 340
        self.ensure(compile::Sysroot { compiler })
    }

    /// Returns the libdir where the standard library and other artifacts are
    /// found for a compiler's sysroot.
341 342 343 344 345 346 347
    pub fn sysroot_libdir(
        &self, compiler: Compiler, target: Interned<String>
    ) -> Interned<PathBuf> {
        #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
        struct Libdir {
            compiler: Compiler,
            target: Interned<String>,
348
        }
349 350
        impl Step for Libdir {
            type Output = Interned<PathBuf>;
351

352 353
            fn should_run(run: ShouldRun) -> ShouldRun {
                run.never()
354 355
            }

356
            fn run(self, builder: &Builder) -> Interned<PathBuf> {
357
                let compiler = self.compiler;
358
                let lib = if compiler.stage >= 2 && builder.build.config.libdir_relative.is_some() {
359
                    builder.build.config.libdir_relative.clone().unwrap()
360 361 362 363 364
                } else {
                    PathBuf::from("lib")
                };
                let sysroot = builder.sysroot(self.compiler).join(lib)
                    .join("rustlib").join(self.target).join("lib");
365 366
                let _ = fs::remove_dir_all(&sysroot);
                t!(fs::create_dir_all(&sysroot));
367
                INTERNER.intern_path(sysroot)
368 369 370 371 372 373 374 375 376 377 378 379 380 381
            }
        }
        self.ensure(Libdir { compiler, target })
    }

    /// Returns the compiler's libdir where it stores the dynamic libraries that
    /// it itself links against.
    ///
    /// For example this returns `<sysroot>/lib` on Unix and `<sysroot>/bin` on
    /// Windows.
    pub fn rustc_libdir(&self, compiler: Compiler) -> PathBuf {
        if compiler.is_snapshot(self) {
            self.build.rustc_snapshot_libdir()
        } else {
382
            self.sysroot(compiler).join(libdir(&compiler.host))
383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398
        }
    }

    /// Adds the compiler's directory of dynamic libraries to `cmd`'s dynamic
    /// library lookup path.
    pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Command) {
        // Windows doesn't need dylib path munging because the dlls for the
        // compiler live next to the compiler and the system will find them
        // automatically.
        if cfg!(windows) {
            return
        }

        add_lib_path(vec![self.rustc_libdir(compiler)], cmd);
    }

399 400 401 402 403
    /// Get a path to the compiler specified.
    pub fn rustc(&self, compiler: Compiler) -> PathBuf {
        if compiler.is_snapshot(self) {
            self.initial_rustc.clone()
        } else {
404
            self.sysroot(compiler).join("bin").join(exe("rustc", &compiler.host))
405 406 407
        }
    }

408 409
    pub fn rustdoc(&self, host: Interned<String>) -> PathBuf {
        self.ensure(tool::Rustdoc { host })
M
Mark Simulacrum 已提交
410 411
    }

412
    pub fn rustdoc_cmd(&self, host: Interned<String>) -> Command {
M
Mark Simulacrum 已提交
413
        let mut cmd = Command::new(&self.out.join("bootstrap/debug/rustdoc"));
414
        let compiler = self.compiler(self.top_stage, host);
M
Mark Simulacrum 已提交
415 416
        cmd
            .env("RUSTC_STAGE", compiler.stage.to_string())
417 418
            .env("RUSTC_SYSROOT", self.sysroot(compiler))
            .env("RUSTC_LIBDIR", self.sysroot_libdir(compiler, self.build.build))
419
            .env("CFG_RELEASE_CHANNEL", &self.build.config.channel)
420
            .env("RUSTDOC_REAL", self.rustdoc(host));
M
Mark Simulacrum 已提交
421
        cmd
422 423
    }

424 425 426 427 428 429 430
    /// Prepares an invocation of `cargo` to be run.
    ///
    /// This will create a `Command` that represents a pending execution of
    /// Cargo. This cargo will be configured to use `compiler` as the actual
    /// rustc compiler, its output will be scoped by `mode`'s output directory,
    /// it will pass the `--target` flag for the specified `target`, and will be
    /// executing the Cargo command `cmd`.
431
    pub fn cargo(&self,
M
Mark Simulacrum 已提交
432 433
             compiler: Compiler,
             mode: Mode,
434
             target: Interned<String>,
M
Mark Simulacrum 已提交
435 436 437
             cmd: &str) -> Command {
        let mut cargo = Command::new(&self.initial_cargo);
        let out_dir = self.stage_out(compiler, mode);
438 439
        cargo.env("CARGO_TARGET_DIR", out_dir)
             .arg(cmd)
M
Mark Simulacrum 已提交
440
             .arg("-j").arg(self.jobs().to_string())
441 442 443 444
             .arg("--target").arg(target);

        // FIXME: Temporary fix for https://github.com/rust-lang/cargo/issues/3005
        // Force cargo to output binaries with disambiguating hashes in the name
M
Mark Simulacrum 已提交
445
        cargo.env("__CARGO_DEFAULT_LIB_METADATA", &self.config.channel);
446 447

        let stage;
M
Mark Simulacrum 已提交
448
        if compiler.stage == 0 && self.local_rebuild {
449 450 451 452 453 454 455 456
            // Assume the local-rebuild rustc already has stage1 features.
            stage = 1;
        } else {
            stage = compiler.stage;
        }

        // Customize the compiler we're running. Specify the compiler to cargo
        // as our shim and then pass it some various options used to configure
M
Mark Simulacrum 已提交
457
        // how the actual compiler itself is called.
458 459 460
        //
        // These variables are primarily all read by
        // src/bootstrap/bin/{rustc.rs,rustdoc.rs}
M
Mark Simulacrum 已提交
461 462
        cargo.env("RUSTBUILD_NATIVE_DIR", self.native_dir(target))
             .env("RUSTC", self.out.join("bootstrap/debug/rustc"))
463
             .env("RUSTC_REAL", self.rustc(compiler))
464 465
             .env("RUSTC_STAGE", stage.to_string())
             .env("RUSTC_CODEGEN_UNITS",
M
Mark Simulacrum 已提交
466
                  self.config.rust_codegen_units.to_string())
467
             .env("RUSTC_DEBUG_ASSERTIONS",
M
Mark Simulacrum 已提交
468
                  self.config.rust_debug_assertions.to_string())
469 470
             .env("RUSTC_SYSROOT", self.sysroot(compiler))
             .env("RUSTC_LIBDIR", self.rustc_libdir(compiler))
M
Mark Simulacrum 已提交
471 472
             .env("RUSTC_RPATH", self.config.rust_rpath.to_string())
             .env("RUSTDOC", self.out.join("bootstrap/debug/rustdoc"))
M
Mark Simulacrum 已提交
473
             .env("RUSTDOC_REAL", if cmd == "doc" || cmd == "test" {
474
                 self.rustdoc(compiler.host)
M
Mark Simulacrum 已提交
475 476 477
             } else {
                 PathBuf::from("/path/to/nowhere/rustdoc/not/required")
             })
M
Mark Simulacrum 已提交
478
             .env("RUSTC_FLAGS", self.rustc_flags(target).join(" "));
479 480 481 482

        if mode != Mode::Tool {
            // Tools don't get debuginfo right now, e.g. cargo and rls don't
            // get compiled with debuginfo.
M
Mark Simulacrum 已提交
483 484
            cargo.env("RUSTC_DEBUGINFO", self.config.rust_debuginfo.to_string())
                 .env("RUSTC_DEBUGINFO_LINES", self.config.rust_debuginfo_lines.to_string())
485 486 487 488
                 .env("RUSTC_FORCE_UNSTABLE", "1");

            // Currently the compiler depends on crates from crates.io, and
            // then other crates can depend on the compiler (e.g. proc-macro
M
Mark Simulacrum 已提交
489
            // crates). Let's say, for example that rustc itself depends on the
490 491
            // bitflags crate. If an external crate then depends on the
            // bitflags crate as well, we need to make sure they don't
B
Bastien Orivel 已提交
492
            // conflict, even if they pick the same version of bitflags. We'll
493 494 495 496 497 498 499 500 501 502 503 504 505 506 507
            // want to make sure that e.g. a plugin and rustc each get their
            // own copy of bitflags.

            // Cargo ensures that this works in general through the -C metadata
            // flag. This flag will frob the symbols in the binary to make sure
            // they're different, even though the source code is the exact
            // same. To solve this problem for the compiler we extend Cargo's
            // already-passed -C metadata flag with our own. Our rustc.rs
            // wrapper around the actual rustc will detect -C metadata being
            // passed and frob it with this extra string we're passing in.
            cargo.env("RUSTC_METADATA_SUFFIX", "rustc");
        }

        // Enable usage of unstable features
        cargo.env("RUSTC_BOOTSTRAP", "1");
M
Mark Simulacrum 已提交
508
        self.add_rust_test_threads(&mut cargo);
509 510 511

        // Almost all of the crates that we compile as part of the bootstrap may
        // have a build script, including the standard library. To compile a
M
Mark Simulacrum 已提交
512
        // build script, however, it itself needs a standard library! This
513
        // introduces a bit of a pickle when we're compiling the standard
M
Mark Simulacrum 已提交
514
        // library itself.
515 516
        //
        // To work around this we actually end up using the snapshot compiler
M
Mark Simulacrum 已提交
517
        // (stage0) for compiling build scripts of the standard library itself.
518 519 520 521 522 523
        // The stage0 compiler is guaranteed to have a libstd available for use.
        //
        // For other crates, however, we know that we've already got a standard
        // library up and running, so we can use the normal compiler to compile
        // build scripts in that situation.
        if mode == Mode::Libstd {
M
Mark Simulacrum 已提交
524 525
            cargo.env("RUSTC_SNAPSHOT", &self.initial_rustc)
                 .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_snapshot_libdir());
526
        } else {
527
            cargo.env("RUSTC_SNAPSHOT", self.rustc(compiler))
528 529 530 531 532 533
                 .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_libdir(compiler));
        }

        // Ignore incremental modes except for stage0, since we're
        // not guaranteeing correctness across builds if the compiler
        // is changing under your feet.`
M
Mark Simulacrum 已提交
534
        if self.config.incremental && compiler.stage == 0 {
M
Mark Simulacrum 已提交
535
            let incr_dir = self.incremental_dir(compiler);
536 537 538
            cargo.env("RUSTC_INCREMENTAL", incr_dir);
        }

M
Mark Simulacrum 已提交
539
        if let Some(ref on_fail) = self.config.on_fail {
540 541 542
            cargo.env("RUSTC_ON_FAIL", on_fail);
        }

M
Mark Simulacrum 已提交
543
        cargo.env("RUSTC_VERBOSE", format!("{}", self.verbosity));
544 545 546 547 548 549

        // Specify some various options for build scripts used throughout
        // the build.
        //
        // FIXME: the guard against msvc shouldn't need to be here
        if !target.contains("msvc") {
M
Mark Simulacrum 已提交
550 551 552
            cargo.env(format!("CC_{}", target), self.cc(target))
                 .env(format!("AR_{}", target), self.ar(target).unwrap()) // only msvc is None
                 .env(format!("CFLAGS_{}", target), self.cflags(target).join(" "));
553

M
Mark Simulacrum 已提交
554
            if let Ok(cxx) = self.cxx(target) {
555 556 557 558
                 cargo.env(format!("CXX_{}", target), cxx);
            }
        }

M
Mark Simulacrum 已提交
559
        if mode == Mode::Libstd && self.config.extended && compiler.is_final_stage(self) {
560 561 562 563 564 565 566 567
            cargo.env("RUSTC_SAVE_ANALYSIS", "api".to_string());
        }

        // Environment variables *required* throughout the build
        //
        // FIXME: should update code to not require this env var
        cargo.env("CFG_COMPILER_HOST_TRIPLE", target);

568 569 570
        // Set this for all builds to make sure doc builds also get it.
        cargo.env("CFG_RELEASE_CHANNEL", &self.build.config.channel);

M
Mark Simulacrum 已提交
571
        if self.is_verbose() {
572 573 574
            cargo.arg("-v");
        }
        // FIXME: cargo bench does not accept `--release`
M
Mark Simulacrum 已提交
575
        if self.config.rust_optimize && cmd != "bench" {
576 577
            cargo.arg("--release");
        }
M
Mark Simulacrum 已提交
578
        if self.config.locked_deps {
579 580
            cargo.arg("--locked");
        }
M
Mark Simulacrum 已提交
581
        if self.config.vendor || self.is_sudo {
582 583 584
            cargo.arg("--frozen");
        }

M
Mark Simulacrum 已提交
585
        self.ci_env.force_coloring_in_ci(&mut cargo);
586 587 588 589

        cargo
    }

590 591 592
    /// Ensure that a given step is built, returning it's output. This will
    /// cache the step, so it is safe (and good!) to call this as often as
    /// needed to ensure that all dependencies are built.
593
    pub fn ensure<S: Step>(&'a self, step: S) -> S::Output {
594 595
        {
            let mut stack = self.stack.borrow_mut();
596 597 598 599
            for stack_step in stack.iter() {
                // should skip
                if stack_step.downcast_ref::<S>().map_or(true, |stack_step| *stack_step != step) {
                    continue;
600
                }
601
                let mut out = String::new();
602
                out += &format!("\n\nCycle in build detected when adding {:?}\n", step);
603 604 605 606 607
                for el in stack.iter().rev() {
                    out += &format!("\t{:?}\n", el);
                }
                panic!(out);
            }
608 609
            if let Some(out) = self.cache.get(&step) {
                self.build.verbose(&format!("{}c {:?}", "  ".repeat(stack.len()), step));
610 611 612

                return out;
            }
613
            self.build.verbose(&format!("{}> {:?}", "  ".repeat(stack.len()), step));
614
            stack.push(Box::new(step.clone()));
615
        }
616
        let out = step.clone().run(self);
617 618
        {
            let mut stack = self.stack.borrow_mut();
619 620
            let cur_step = stack.pop().expect("step stack empty");
            assert_eq!(cur_step.downcast_ref(), Some(&step));
621
        }
622 623 624
        self.build.verbose(&format!("{}< {:?}", "  ".repeat(self.stack.borrow().len()), step));
        self.cache.put(step, out.clone());
        out
625 626
    }
}