builder.rs 63.7 KB
Newer Older
1 2 3 4 5 6 7 8 9 10
// Copyright 2017 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

11
use std::any::Any;
12
use std::cell::{Cell, RefCell};
13
use std::collections::BTreeSet;
S
Santiago Pastorino 已提交
14
use std::collections::HashMap;
15
use std::env;
16
use std::fmt::Debug;
17
use std::fs;
18
use std::hash::Hash;
19
use std::ops::Deref;
20 21
use std::path::{Path, PathBuf};
use std::process::Command;
S
Santiago Pastorino 已提交
22
use std::time::{Duration, Instant};
23

S
Santiago Pastorino 已提交
24 25
use cache::{Cache, Interned, INTERNER};
use check;
26 27 28
use compile;
use dist;
use doc;
S
Santiago Pastorino 已提交
29 30
use flags::Subcommand;
use install;
A
Alex Crichton 已提交
31
use native;
S
Santiago Pastorino 已提交
32 33 34 35
use test;
use tool;
use util::{add_lib_path, exe, libdir};
use {Build, DocTests, Mode};
36

37 38
pub use Compiler;

39
use petgraph::graph::NodeIndex;
S
Santiago Pastorino 已提交
40
use petgraph::Graph;
41

42 43 44 45 46
pub struct Builder<'a> {
    pub build: &'a Build,
    pub top_stage: u32,
    pub kind: Kind,
    cache: Cache,
47
    stack: RefCell<Vec<Box<dyn Any>>>,
48
    time_spent_on_dependencies: Cell<Duration>,
49
    pub paths: Vec<PathBuf>,
50 51 52
    graph_nodes: RefCell<HashMap<String, NodeIndex>>,
    graph: RefCell<Graph<String, bool>>,
    parent: Cell<Option<NodeIndex>>,
53 54 55 56 57 58 59 60 61 62
}

impl<'a> Deref for Builder<'a> {
    type Target = Build;

    fn deref(&self) -> &Self::Target {
        self.build
    }
}

63
pub trait Step: 'static + Clone + Debug + PartialEq + Eq + Hash {
64 65
    /// `PathBuf` when directories are created or to return a `Compiler` once
    /// it's been assembled.
66
    type Output: Clone;
67

68 69
    const DEFAULT: bool = false;

70
    /// Run this rule for all hosts without cross compiling.
71 72
    const ONLY_HOSTS: bool = false;

73 74
    /// Primary function to execute this rule. Can call `builder.ensure(...)`
    /// with other steps to run those.
75
    fn run(self, builder: &Builder) -> Self::Output;
76

77 78 79 80
    /// When bootstrap is passed a set of paths, this controls whether this rule
    /// will execute. However, it does not get called in a "default" context
    /// when we are not passed any paths; in that case, make_run is called
    /// directly.
81
    fn should_run(run: ShouldRun) -> ShouldRun;
82

83 84 85 86 87 88
    /// Build up a "root" rule, either as a default rule or from a path passed
    /// to us.
    ///
    /// When path is `None`, we are executing in a context where no paths were
    /// passed. When `./x.py build` is run, for example, this rule could get
    /// called if it is in the correct list below with a path of `None`.
89
    fn make_run(_run: RunConfig) {
90 91 92 93 94 95
        // It is reasonable to not have an implementation of make_run for rules
        // who do not want to get called from the root context. This means that
        // they are likely dependencies (e.g., sysroot creation) or similar, and
        // as such calling them from ./x.py isn't logical.
        unimplemented!()
    }
96 97
}

98 99 100 101
pub struct RunConfig<'a> {
    pub builder: &'a Builder<'a>,
    pub host: Interned<String>,
    pub target: Interned<String>,
102
    pub path: PathBuf,
103 104
}

105 106 107 108
struct StepDescription {
    default: bool,
    only_hosts: bool,
    should_run: fn(ShouldRun) -> ShouldRun,
109
    make_run: fn(RunConfig),
110 111 112 113
    name: &'static str,
}

#[derive(Debug, Clone, PartialOrd, Ord, PartialEq, Eq)]
114
pub enum PathSet {
S
Santiago Pastorino 已提交
115 116
    Set(BTreeSet<PathBuf>),
    Suite(PathBuf),
117 118 119
}

impl PathSet {
120
    fn empty() -> PathSet {
121
        PathSet::Set(BTreeSet::new())
122 123
    }

124 125 126
    fn one<P: Into<PathBuf>>(path: P) -> PathSet {
        let mut set = BTreeSet::new();
        set.insert(path.into());
127
        PathSet::Set(set)
128 129 130
    }

    fn has(&self, needle: &Path) -> bool {
131 132
        match self {
            PathSet::Set(set) => set.iter().any(|p| p.ends_with(needle)),
S
Santiago Pastorino 已提交
133
            PathSet::Suite(_) => false,
134
        }
135 136
    }

137
    fn path(&self, builder: &Builder) -> PathBuf {
138
        match self {
S
Santiago Pastorino 已提交
139 140 141 142 143 144
            PathSet::Set(set) => set
                .iter()
                .next()
                .unwrap_or(&builder.build.src)
                .to_path_buf(),
            PathSet::Suite(path) => PathBuf::from(path),
145
        }
146
    }
147 148 149 150 151 152 153 154 155
}

impl StepDescription {
    fn from<S: Step>() -> StepDescription {
        StepDescription {
            default: S::DEFAULT,
            only_hosts: S::ONLY_HOSTS,
            should_run: S::should_run,
            make_run: S::make_run,
156
            name: unsafe { ::std::intrinsics::type_name::<S>() },
157 158 159
        }
    }

160 161 162 163 164
    fn maybe_run(&self, builder: &Builder, pathset: &PathSet) {
        if builder.config.exclude.iter().any(|e| pathset.has(e)) {
            eprintln!("Skipping {:?} because it is excluded", pathset);
            return;
        } else if !builder.config.exclude.is_empty() {
S
Santiago Pastorino 已提交
165 166 167 168
            eprintln!(
                "{:?} not skipped for {:?} -- not in {:?}",
                pathset, self.name, builder.config.exclude
            );
169
        }
170
        let hosts = &builder.hosts;
171

M
Mark Simulacrum 已提交
172
        // Determine the targets participating in this rule.
173
        let targets = if self.only_hosts {
174
            if !builder.config.run_host_only {
175
                return; // don't run anything
176
            } else {
177
                &builder.hosts
178 179
            }
        } else {
180
            &builder.targets
181 182 183 184
        };

        for host in hosts {
            for target in targets {
185 186
                let run = RunConfig {
                    builder,
187
                    path: pathset.path(builder),
188 189 190 191
                    host: *host,
                    target: *target,
                };
                (self.make_run)(run);
192 193 194 195 196
            }
        }
    }

    fn run(v: &[StepDescription], builder: &Builder, paths: &[PathBuf]) {
S
Santiago Pastorino 已提交
197 198 199 200
        let should_runs = v
            .iter()
            .map(|desc| (desc.should_run)(ShouldRun::new(builder)))
            .collect::<Vec<_>>();
201 202 203

        // sanity checks on rules
        for (desc, should_run) in v.iter().zip(&should_runs) {
S
Santiago Pastorino 已提交
204 205 206 207 208
            assert!(
                !should_run.paths.is_empty(),
                "{:?} should have at least one pathset",
                desc.name
            );
209 210
        }

211
        if paths.is_empty() {
212 213
            for (desc, should_run) in v.iter().zip(should_runs) {
                if desc.default && should_run.is_really_default {
214 215 216
                    for pathset in &should_run.paths {
                        desc.maybe_run(builder, pathset);
                    }
217 218 219 220
                }
            }
        } else {
            for path in paths {
221 222 223 224 225 226
                // strip CurDir prefix if present
                let path = match path.strip_prefix(".") {
                    Ok(p) => p,
                    Err(_) => path,
                };

227
                let mut attempted_run = false;
228
                for (desc, should_run) in v.iter().zip(&should_runs) {
229 230 231 232
                    if let Some(suite) = should_run.is_suite_path(path) {
                        attempted_run = true;
                        desc.maybe_run(builder, suite);
                    } else if let Some(pathset) = should_run.pathset_for_path(path) {
233
                        attempted_run = true;
234
                        desc.maybe_run(builder, pathset);
235 236 237 238
                    }
                }

                if !attempted_run {
239
                    panic!("Error: no rules matched {}.", path.display());
240 241 242 243 244 245
                }
            }
        }
    }
}

246 247
#[derive(Clone)]
pub struct ShouldRun<'a> {
248
    pub builder: &'a Builder<'a>,
249
    // use a BTreeSet to maintain sort order
250
    paths: BTreeSet<PathSet>,
251 252

    // If this is a default rule, this is an additional constraint placed on
253
    // its run. Generally something like compiler docs being enabled.
254
    is_really_default: bool,
255 256 257 258 259
}

impl<'a> ShouldRun<'a> {
    fn new(builder: &'a Builder) -> ShouldRun<'a> {
        ShouldRun {
260
            builder,
261
            paths: BTreeSet::new(),
262
            is_really_default: true, // by default no additional conditions
263 264 265
        }
    }

266 267 268 269 270
    pub fn default_condition(mut self, cond: bool) -> Self {
        self.is_really_default = cond;
        self
    }

271 272 273 274 275 276 277 278
    // Unlike `krate` this will create just one pathset. As such, it probably shouldn't actually
    // ever be used, but as we transition to having all rules properly handle passing krate(...) by
    // actually doing something different for every crate passed.
    pub fn all_krates(mut self, name: &str) -> Self {
        let mut set = BTreeSet::new();
        for krate in self.builder.in_tree_crates(name) {
            set.insert(PathBuf::from(&krate.path));
        }
279
        self.paths.insert(PathSet::Set(set));
280 281 282
        self
    }

283
    pub fn krate(mut self, name: &str) -> Self {
284 285
        for krate in self.builder.in_tree_crates(name) {
            self.paths.insert(PathSet::one(&krate.path));
286 287 288 289
        }
        self
    }

290 291 292 293 294 295 296
    // single, non-aliased path
    pub fn path(self, path: &str) -> Self {
        self.paths(&[path])
    }

    // multiple aliases for the same job
    pub fn paths(mut self, paths: &[&str]) -> Self {
S
Santiago Pastorino 已提交
297 298
        self.paths
            .insert(PathSet::Set(paths.iter().map(PathBuf::from).collect()));
299 300 301 302
        self
    }

    pub fn is_suite_path(&self, path: &Path) -> Option<&PathSet> {
S
Santiago Pastorino 已提交
303 304 305
        self.paths.iter().find(|pathset| match pathset {
            PathSet::Suite(p) => path.starts_with(p),
            PathSet::Set(_) => false,
306 307 308 309 310
        })
    }

    pub fn suite_path(mut self, suite: &str) -> Self {
        self.paths.insert(PathSet::Suite(PathBuf::from(suite)));
311 312 313 314
        self
    }

    // allows being more explicit about why should_run in Step returns the value passed to it
315 316
    pub fn never(mut self) -> ShouldRun<'a> {
        self.paths.insert(PathSet::empty());
317 318 319
        self
    }

320 321
    fn pathset_for_path(&self, path: &Path) -> Option<&PathSet> {
        self.paths.iter().find(|pathset| pathset.has(path))
322 323 324
    }
}

325 326 327
#[derive(Copy, Clone, PartialEq, Eq, Debug)]
pub enum Kind {
    Build,
328
    Check,
329 330 331 332 333 334 335
    Test,
    Bench,
    Dist,
    Doc,
    Install,
}

336 337 338 339 340 341
impl<'a> Builder<'a> {
    fn get_step_descriptions(kind: Kind) -> Vec<StepDescription> {
        macro_rules! describe {
            ($($rule:ty),+ $(,)*) => {{
                vec![$(StepDescription::from::<$rule>()),+]
            }};
342
        }
343
        match kind {
S
Santiago Pastorino 已提交
344 345 346 347
            Kind::Build => describe!(
                compile::Std,
                compile::Test,
                compile::Rustc,
348
                compile::CodegenBackend,
S
Santiago Pastorino 已提交
349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410
                compile::StartupObjects,
                tool::BuildManifest,
                tool::Rustbook,
                tool::ErrorIndex,
                tool::UnstableBookGen,
                tool::Tidy,
                tool::Linkchecker,
                tool::CargoTest,
                tool::Compiletest,
                tool::RemoteTestServer,
                tool::RemoteTestClient,
                tool::RustInstaller,
                tool::Cargo,
                tool::Rls,
                tool::Rustdoc,
                tool::Clippy,
                native::Llvm,
                tool::Rustfmt,
                tool::Miri,
                native::Lld
            ),
            Kind::Check => describe!(
                check::Std,
                check::Test,
                check::Rustc,
                check::CodegenBackend,
                check::Rustdoc
            ),
            Kind::Test => describe!(
                test::Tidy,
                test::Ui,
                test::RunPass,
                test::CompileFail,
                test::ParseFail,
                test::RunFail,
                test::RunPassValgrind,
                test::MirOpt,
                test::Codegen,
                test::CodegenUnits,
                test::Incremental,
                test::Debuginfo,
                test::UiFullDeps,
                test::RunPassFullDeps,
                test::RunFailFullDeps,
                test::CompileFailFullDeps,
                test::IncrementalFullDeps,
                test::Rustdoc,
                test::Pretty,
                test::RunPassPretty,
                test::RunFailPretty,
                test::RunPassValgrindPretty,
                test::RunPassFullDepsPretty,
                test::RunFailFullDepsPretty,
                test::Crate,
                test::CrateLibrustc,
                test::CrateRustdoc,
                test::Linkcheck,
                test::Cargotest,
                test::Cargo,
                test::Rls,
                test::ErrorIndex,
                test::Distcheck,
411
                test::RunMakeFullDeps,
S
Santiago Pastorino 已提交
412 413 414 415 416 417 418 419 420 421 422 423
                test::Nomicon,
                test::Reference,
                test::RustdocBook,
                test::RustByExample,
                test::TheBook,
                test::UnstableBook,
                test::RustcBook,
                test::Rustfmt,
                test::Miri,
                test::Clippy,
                test::RustdocJS,
                test::RustdocTheme,
424 425
                // Run bootstrap close to the end as it's unlikely to fail
                test::Bootstrap,
426
                // Run run-make last, since these won't pass without make on Windows
S
Santiago Pastorino 已提交
427 428 429
                test::RunMake,
                test::RustdocUi
            ),
430
            Kind::Bench => describe!(test::Crate, test::CrateLibrustc),
S
Santiago Pastorino 已提交
431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461
            Kind::Doc => describe!(
                doc::UnstableBook,
                doc::UnstableBookGen,
                doc::TheBook,
                doc::Standalone,
                doc::Std,
                doc::Test,
                doc::WhitelistedRustc,
                doc::Rustc,
                doc::Rustdoc,
                doc::ErrorIndex,
                doc::Nomicon,
                doc::Reference,
                doc::RustdocBook,
                doc::RustByExample,
                doc::RustcBook,
                doc::CargoBook
            ),
            Kind::Dist => describe!(
                dist::Docs,
                dist::RustcDocs,
                dist::Mingw,
                dist::Rustc,
                dist::DebuggerScripts,
                dist::Std,
                dist::Analysis,
                dist::Src,
                dist::PlainSourceTarball,
                dist::Cargo,
                dist::Rls,
                dist::Rustfmt,
462
                dist::Clippy,
463
                dist::LlvmTools,
T
Tom Tromey 已提交
464
                dist::Lldb,
S
Santiago Pastorino 已提交
465 466 467 468 469 470 471 472 473
                dist::Extended,
                dist::HashSign
            ),
            Kind::Install => describe!(
                install::Docs,
                install::Std,
                install::Cargo,
                install::Rls,
                install::Rustfmt,
474
                install::Clippy,
S
Santiago Pastorino 已提交
475 476 477 478
                install::Analysis,
                install::Src,
                install::Rustc
            ),
479 480
        }
    }
481

482 483 484 485 486 487 488 489 490 491 492 493
    pub fn get_help(build: &Build, subcommand: &str) -> Option<String> {
        let kind = match subcommand {
            "build" => Kind::Build,
            "doc" => Kind::Doc,
            "test" => Kind::Test,
            "bench" => Kind::Bench,
            "dist" => Kind::Dist,
            "install" => Kind::Install,
            _ => return None,
        };

        let builder = Builder {
494
            build,
M
Mark Simulacrum 已提交
495
            top_stage: build.config.stage.unwrap_or(2),
496
            kind,
497 498
            cache: Cache::new(),
            stack: RefCell::new(Vec::new()),
499
            time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
500
            paths: vec![],
501 502 503
            graph_nodes: RefCell::new(HashMap::new()),
            graph: RefCell::new(Graph::new()),
            parent: Cell::new(None),
504 505 506 507
        };

        let builder = &builder;
        let mut should_run = ShouldRun::new(builder);
508 509
        for desc in Builder::get_step_descriptions(builder.kind) {
            should_run = (desc.should_run)(should_run);
510 511
        }
        let mut help = String::from("Available paths:\n");
512
        for pathset in should_run.paths {
S
Santiago Pastorino 已提交
513 514 515 516 517 518
            if let PathSet::Set(set) = pathset {
                set.iter().for_each(|path| {
                    help.push_str(
                        format!("    ./x.py {} {}\n", subcommand, path.display()).as_str(),
                    )
                })
519
            }
520 521 522 523
        }
        Some(help)
    }

524
    pub fn new(build: &Build) -> Builder {
M
Mark Simulacrum 已提交
525
        let (kind, paths) = match build.config.cmd {
526
            Subcommand::Build { ref paths } => (Kind::Build, &paths[..]),
527
            Subcommand::Check { ref paths } => (Kind::Check, &paths[..]),
528 529 530 531 532
            Subcommand::Doc { ref paths } => (Kind::Doc, &paths[..]),
            Subcommand::Test { ref paths, .. } => (Kind::Test, &paths[..]),
            Subcommand::Bench { ref paths, .. } => (Kind::Bench, &paths[..]),
            Subcommand::Dist { ref paths } => (Kind::Dist, &paths[..]),
            Subcommand::Install { ref paths } => (Kind::Install, &paths[..]),
O
Oliver Schneider 已提交
533
            Subcommand::Clean { .. } => panic!(),
534 535 536
        };

        let builder = Builder {
537
            build,
M
Mark Simulacrum 已提交
538
            top_stage: build.config.stage.unwrap_or(2),
539
            kind,
540 541
            cache: Cache::new(),
            stack: RefCell::new(Vec::new()),
542
            time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
543
            paths: paths.to_owned(),
544 545 546
            graph_nodes: RefCell::new(HashMap::new()),
            graph: RefCell::new(Graph::new()),
            parent: Cell::new(None),
547 548
        };

549
        if kind == Kind::Dist {
S
Santiago Pastorino 已提交
550 551 552
            assert!(
                !builder.config.test_miri,
                "Do not distribute with miri enabled.\n\
553
                The distributed libraries would include all MIR (increasing binary size).
S
Santiago Pastorino 已提交
554 555
                The distributed MIR would include validation statements."
            );
556 557
        }

558 559 560
        builder
    }

561
    pub fn execute_cli(&self) -> Graph<String, bool> {
M
Mark Simulacrum 已提交
562
        self.run_step_descriptions(&Builder::get_step_descriptions(self.kind), &self.paths);
563
        self.graph.borrow().clone()
564 565 566 567
    }

    pub fn default_doc(&self, paths: Option<&[PathBuf]>) {
        let paths = paths.unwrap_or(&[]);
M
Mark Simulacrum 已提交
568 569 570 571 572
        self.run_step_descriptions(&Builder::get_step_descriptions(Kind::Doc), paths);
    }

    fn run_step_descriptions(&self, v: &[StepDescription], paths: &[PathBuf]) {
        StepDescription::run(v, self, paths);
573 574
    }

B
Bastien Orivel 已提交
575
    /// Obtain a compiler at a given stage and for a given host. Explicitly does
576 577 578
    /// not take `Compiler` since all `Compiler` instances are meant to be
    /// obtained through this function, since it ensures that they are valid
    /// (i.e., built and assembled).
579
    pub fn compiler(&self, stage: u32, host: Interned<String>) -> Compiler {
S
Santiago Pastorino 已提交
580 581 582
        self.ensure(compile::Assemble {
            target_compiler: Compiler { stage, host },
        })
583 584
    }

585
    pub fn sysroot(&self, compiler: Compiler) -> Interned<PathBuf> {
586 587 588 589 590
        self.ensure(compile::Sysroot { compiler })
    }

    /// Returns the libdir where the standard library and other artifacts are
    /// found for a compiler's sysroot.
591
    pub fn sysroot_libdir(
S
Santiago Pastorino 已提交
592 593 594
        &self,
        compiler: Compiler,
        target: Interned<String>,
595 596 597 598 599
    ) -> Interned<PathBuf> {
        #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
        struct Libdir {
            compiler: Compiler,
            target: Interned<String>,
600
        }
601 602
        impl Step for Libdir {
            type Output = Interned<PathBuf>;
603

604 605
            fn should_run(run: ShouldRun) -> ShouldRun {
                run.never()
606 607
            }

608
            fn run(self, builder: &Builder) -> Interned<PathBuf> {
609
                let compiler = self.compiler;
610 611 612
                let config = &builder.build.config;
                let lib = if compiler.stage >= 1 && config.libdir_relative().is_some() {
                    builder.build.config.libdir_relative().unwrap()
613
                } else {
614
                    Path::new("lib")
615
                };
S
Santiago Pastorino 已提交
616 617 618 619 620 621
                let sysroot = builder
                    .sysroot(self.compiler)
                    .join(lib)
                    .join("rustlib")
                    .join(self.target)
                    .join("lib");
622 623
                let _ = fs::remove_dir_all(&sysroot);
                t!(fs::create_dir_all(&sysroot));
624
                INTERNER.intern_path(sysroot)
625 626 627 628 629
            }
        }
        self.ensure(Libdir { compiler, target })
    }

630 631
    pub fn sysroot_codegen_backends(&self, compiler: Compiler) -> PathBuf {
        self.sysroot_libdir(compiler, compiler.host)
632
            .with_file_name(self.config.rust_codegen_backends_dir.clone())
633 634
    }

635 636 637 638 639 640 641
    /// Returns the compiler's libdir where it stores the dynamic libraries that
    /// it itself links against.
    ///
    /// For example this returns `<sysroot>/lib` on Unix and `<sysroot>/bin` on
    /// Windows.
    pub fn rustc_libdir(&self, compiler: Compiler) -> PathBuf {
        if compiler.is_snapshot(self) {
642
            self.rustc_snapshot_libdir()
643
        } else {
644
            self.sysroot(compiler).join(libdir(&compiler.host))
645 646 647 648 649 650 651 652 653 654
        }
    }

    /// Adds the compiler's directory of dynamic libraries to `cmd`'s dynamic
    /// library lookup path.
    pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Command) {
        // Windows doesn't need dylib path munging because the dlls for the
        // compiler live next to the compiler and the system will find them
        // automatically.
        if cfg!(windows) {
S
Santiago Pastorino 已提交
655
            return;
656 657 658 659 660
        }

        add_lib_path(vec![self.rustc_libdir(compiler)], cmd);
    }

661 662 663 664 665
    /// Get a path to the compiler specified.
    pub fn rustc(&self, compiler: Compiler) -> PathBuf {
        if compiler.is_snapshot(self) {
            self.initial_rustc.clone()
        } else {
S
Santiago Pastorino 已提交
666 667 668
            self.sysroot(compiler)
                .join("bin")
                .join(exe("rustc", &compiler.host))
669 670 671
        }
    }

672 673
    pub fn rustdoc(&self, host: Interned<String>) -> PathBuf {
        self.ensure(tool::Rustdoc { host })
M
Mark Simulacrum 已提交
674 675
    }

676
    pub fn rustdoc_cmd(&self, host: Interned<String>) -> Command {
M
Mark Simulacrum 已提交
677
        let mut cmd = Command::new(&self.out.join("bootstrap/debug/rustdoc"));
678
        let compiler = self.compiler(self.top_stage, host);
O
Oliver Schneider 已提交
679
        cmd.env("RUSTC_STAGE", compiler.stage.to_string())
S
Santiago Pastorino 已提交
680 681 682 683 684 685 686 687 688
            .env("RUSTC_SYSROOT", self.sysroot(compiler))
            .env(
                "RUSTDOC_LIBDIR",
                self.sysroot_libdir(compiler, self.config.build),
            )
            .env("CFG_RELEASE_CHANNEL", &self.config.channel)
            .env("RUSTDOC_REAL", self.rustdoc(host))
            .env("RUSTDOC_CRATE_VERSION", self.rust_version())
            .env("RUSTC_BOOTSTRAP", "1");
689
        if let Some(linker) = self.linker(host) {
O
Oliver Schneider 已提交
690 691
            cmd.env("RUSTC_TARGET_LINKER", linker);
        }
M
Mark Simulacrum 已提交
692
        cmd
693 694
    }

695 696 697 698 699 700 701
    /// Prepares an invocation of `cargo` to be run.
    ///
    /// This will create a `Command` that represents a pending execution of
    /// Cargo. This cargo will be configured to use `compiler` as the actual
    /// rustc compiler, its output will be scoped by `mode`'s output directory,
    /// it will pass the `--target` flag for the specified `target`, and will be
    /// executing the Cargo command `cmd`.
S
Santiago Pastorino 已提交
702 703 704 705 706 707 708
    pub fn cargo(
        &self,
        compiler: Compiler,
        mode: Mode,
        target: Interned<String>,
        cmd: &str,
    ) -> Command {
M
Mark Simulacrum 已提交
709 710
        let mut cargo = Command::new(&self.initial_cargo);
        let out_dir = self.stage_out(compiler, mode);
711 712 713 714 715 716 717 718 719 720 721 722 723

        let mut my_out = match cmd {
            "build" => self.cargo_out(compiler, mode, target),

            // This is the intended out directory for crate documentation.
            "doc" =>  self.crate_doc_out(target),

            _ => self.stage_out(compiler, mode),
        };

        // This is for the original compiler, but if we're forced to use stage 1, then
        // std/test/rustc stamps won't exist in stage 2, so we need to get those from stage 1, since
        // we copy the libs forward.
724
        let cmp = if self.force_use_stage1(compiler, target) {
725 726 727 728 729 730
            self.compiler(1, compiler.host)
        } else {
            compiler
        };

        let libstd_stamp = match cmd {
731 732
            "check" => check::libstd_stamp(self, cmp, target),
            _ => compile::libstd_stamp(self, cmp, target),
733 734 735
        };

        let libtest_stamp = match cmd {
736 737
            "check" => check::libtest_stamp(self, cmp, target),
            _ => compile::libstd_stamp(self, cmp, target),
738 739 740
        };

        let librustc_stamp = match cmd {
741 742
            "check" => check::librustc_stamp(self, cmp, target),
            _ => compile::librustc_stamp(self, cmp, target),
743 744 745
        };

        if cmd == "doc" {
746
            if mode == Mode::Rustc || mode == Mode::ToolRustc || mode == Mode::Codegen {
747 748 749 750 751 752 753 754 755 756 757
                // This is the intended out directory for compiler documentation.
                my_out = self.compiler_doc_out(target);
            }
            let rustdoc = self.rustdoc(compiler.host);
            self.clear_if_dirty(&my_out, &rustdoc);
        } else {
            match mode {
                Mode::Std => {
                    self.clear_if_dirty(&my_out, &self.rustc(compiler));
                },
                Mode::Rustc => {
758
                    self.clear_if_dirty(&my_out, &self.rustc(compiler));
759 760 761 762 763 764 765 766 767 768 769 770 771 772 773
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                    self.clear_if_dirty(&my_out, &libtest_stamp);
                },
                Mode::Test => {
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                },
                Mode::ToolRustc => {
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                    self.clear_if_dirty(&my_out, &libtest_stamp);
                    self.clear_if_dirty(&my_out, &librustc_stamp);
                }
                _ => { }
            }
        }

S
Santiago Pastorino 已提交
774 775
        cargo
            .env("CARGO_TARGET_DIR", out_dir)
776 777 778 779 780 781 782 783
            .arg(cmd);

        if cmd != "install" {
            cargo.arg("--target")
                 .arg(target);
        } else {
            assert_eq!(target, compiler.host);
        }
784

V
varkor 已提交
785 786 787 788 789 790
        // Set a flag for `check` so that certain build scripts can do less work
        // (e.g. not building/requiring LLVM).
        if cmd == "check" {
            cargo.env("RUST_CHECK", "1");
        }

791 792 793 794
        cargo.arg("-j").arg(self.jobs().to_string());
        // Remove make-related flags to ensure Cargo can correctly set things up
        cargo.env_remove("MAKEFLAGS");
        cargo.env_remove("MFLAGS");
795

796 797
        // FIXME: Temporary fix for https://github.com/rust-lang/cargo/issues/3005
        // Force cargo to output binaries with disambiguating hashes in the name
798 799 800 801 802 803 804 805 806
        let metadata = if compiler.stage == 0 {
            // Treat stage0 like special channel, whether it's a normal prior-
            // release rustc or a local rebuild with the same version, so we
            // never mix these libraries by accident.
            "bootstrap"
        } else {
            &self.config.channel
        };
        cargo.env("__CARGO_DEFAULT_LIB_METADATA", &metadata);
807 808

        let stage;
M
Mark Simulacrum 已提交
809
        if compiler.stage == 0 && self.local_rebuild {
810 811 812 813 814 815
            // Assume the local-rebuild rustc already has stage1 features.
            stage = 1;
        } else {
            stage = compiler.stage;
        }

816 817 818
        let mut extra_args = env::var(&format!("RUSTFLAGS_STAGE_{}", stage)).unwrap_or_default();
        if stage != 0 {
            let s = env::var("RUSTFLAGS_STAGE_NOT_0").unwrap_or_default();
819 820 821
            if !extra_args.is_empty() {
                extra_args.push_str(" ");
            }
822 823 824 825
            extra_args.push_str(&s);
        }

        if !extra_args.is_empty() {
S
Santiago Pastorino 已提交
826 827 828 829 830 831 832 833
            cargo.env(
                "RUSTFLAGS",
                format!(
                    "{} {}",
                    env::var("RUSTFLAGS").unwrap_or_default(),
                    extra_args
                ),
            );
834 835
        }

K
kennytm 已提交
836
        let want_rustdoc = self.doc_tests != DocTests::No;
K
kennytm 已提交
837

838 839 840 841 842 843
        // We synthetically interpret a stage0 compiler used to build tools as a
        // "raw" compiler in that it's the exact snapshot we download. Normally
        // the stage0 build means it uses libraries build by the stage0
        // compiler, but for tools we just use the precompiled libraries that
        // we've downloaded
        let use_snapshot = mode == Mode::ToolBootstrap;
844
        assert!(!use_snapshot || stage == 0 || self.local_rebuild);
845 846 847 848 849 850 851 852 853

        let maybe_sysroot = self.sysroot(compiler);
        let sysroot = if use_snapshot {
            self.rustc_snapshot_sysroot()
        } else {
            &maybe_sysroot
        };
        let libdir = sysroot.join(libdir(&compiler.host));

854 855
        // Customize the compiler we're running. Specify the compiler to cargo
        // as our shim and then pass it some various options used to configure
M
Mark Simulacrum 已提交
856
        // how the actual compiler itself is called.
857 858 859
        //
        // These variables are primarily all read by
        // src/bootstrap/bin/{rustc.rs,rustdoc.rs}
S
Santiago Pastorino 已提交
860 861 862 863 864 865 866 867 868
        cargo
            .env("RUSTBUILD_NATIVE_DIR", self.native_dir(target))
            .env("RUSTC", self.out.join("bootstrap/debug/rustc"))
            .env("RUSTC_REAL", self.rustc(compiler))
            .env("RUSTC_STAGE", stage.to_string())
            .env(
                "RUSTC_DEBUG_ASSERTIONS",
                self.config.rust_debug_assertions.to_string(),
            )
869 870
            .env("RUSTC_SYSROOT", &sysroot)
            .env("RUSTC_LIBDIR", &libdir)
S
Santiago Pastorino 已提交
871 872 873 874 875 876 877 878 879 880 881 882
            .env("RUSTC_RPATH", self.config.rust_rpath.to_string())
            .env("RUSTDOC", self.out.join("bootstrap/debug/rustdoc"))
            .env(
                "RUSTDOC_REAL",
                if cmd == "doc" || (cmd == "test" && want_rustdoc) {
                    self.rustdoc(compiler.host)
                } else {
                    PathBuf::from("/path/to/nowhere/rustdoc/not/required")
                },
            )
            .env("TEST_MIRI", self.config.test_miri.to_string())
            .env("RUSTC_ERROR_METADATA_DST", self.extended_error_dir());
883

884
        if let Some(host_linker) = self.linker(compiler.host) {
O
Oliver Schneider 已提交
885 886
            cargo.env("RUSTC_HOST_LINKER", host_linker);
        }
887
        if let Some(target_linker) = self.linker(target) {
O
Oliver Schneider 已提交
888 889
            cargo.env("RUSTC_TARGET_LINKER", target_linker);
        }
P
penpalperson 已提交
890 891 892
        if let Some(ref error_format) = self.config.rustc_error_format {
            cargo.env("RUSTC_ERROR_FORMAT", error_format);
        }
893
        if cmd != "build" && cmd != "check" && cmd != "rustc" && want_rustdoc {
894
            cargo.env("RUSTDOC_LIBDIR", self.sysroot_libdir(compiler, self.config.build));
895
        }
896

C
Collins Abitekaniza 已提交
897
        if mode.is_tool() {
898
            // Tools like cargo and rls don't get debuginfo by default right now, but this can be
899
            // enabled in the config.  Adding debuginfo makes them several times larger.
900 901
            if self.config.rust_debuginfo_tools {
                cargo.env("RUSTC_DEBUGINFO", self.config.rust_debuginfo.to_string());
S
Santiago Pastorino 已提交
902 903 904 905
                cargo.env(
                    "RUSTC_DEBUGINFO_LINES",
                    self.config.rust_debuginfo_lines.to_string(),
                );
906 907
            }
        } else {
908
            cargo.env("RUSTC_DEBUGINFO", self.config.rust_debuginfo.to_string());
S
Santiago Pastorino 已提交
909 910 911 912
            cargo.env(
                "RUSTC_DEBUGINFO_LINES",
                self.config.rust_debuginfo_lines.to_string(),
            );
O
Oliver Schneider 已提交
913
            cargo.env("RUSTC_FORCE_UNSTABLE", "1");
914 915 916

            // Currently the compiler depends on crates from crates.io, and
            // then other crates can depend on the compiler (e.g. proc-macro
M
Mark Simulacrum 已提交
917
            // crates). Let's say, for example that rustc itself depends on the
918 919
            // bitflags crate. If an external crate then depends on the
            // bitflags crate as well, we need to make sure they don't
B
Bastien Orivel 已提交
920
            // conflict, even if they pick the same version of bitflags. We'll
921 922 923 924 925 926 927 928 929 930 931 932 933
            // want to make sure that e.g. a plugin and rustc each get their
            // own copy of bitflags.

            // Cargo ensures that this works in general through the -C metadata
            // flag. This flag will frob the symbols in the binary to make sure
            // they're different, even though the source code is the exact
            // same. To solve this problem for the compiler we extend Cargo's
            // already-passed -C metadata flag with our own. Our rustc.rs
            // wrapper around the actual rustc will detect -C metadata being
            // passed and frob it with this extra string we're passing in.
            cargo.env("RUSTC_METADATA_SUFFIX", "rustc");
        }

934 935 936 937
        if let Some(x) = self.crt_static(target) {
            cargo.env("RUSTC_CRT_STATIC", x.to_string());
        }

938 939 940 941
        if let Some(x) = self.crt_static(compiler.host) {
            cargo.env("RUSTC_HOST_CRT_STATIC", x.to_string());
        }

942 943
        // Enable usage of unstable features
        cargo.env("RUSTC_BOOTSTRAP", "1");
M
Mark Simulacrum 已提交
944
        self.add_rust_test_threads(&mut cargo);
945 946 947

        // Almost all of the crates that we compile as part of the bootstrap may
        // have a build script, including the standard library. To compile a
M
Mark Simulacrum 已提交
948
        // build script, however, it itself needs a standard library! This
949
        // introduces a bit of a pickle when we're compiling the standard
M
Mark Simulacrum 已提交
950
        // library itself.
951 952
        //
        // To work around this we actually end up using the snapshot compiler
M
Mark Simulacrum 已提交
953
        // (stage0) for compiling build scripts of the standard library itself.
954 955 956 957 958
        // The stage0 compiler is guaranteed to have a libstd available for use.
        //
        // For other crates, however, we know that we've already got a standard
        // library up and running, so we can use the normal compiler to compile
        // build scripts in that situation.
959 960
        //
        // If LLVM support is disabled we need to use the snapshot compiler to compile
961
        // build scripts, as the new compiler doesn't support executables.
C
Collins Abitekaniza 已提交
962
        if mode == Mode::Std || !self.config.llvm_enabled {
S
Santiago Pastorino 已提交
963 964 965
            cargo
                .env("RUSTC_SNAPSHOT", &self.initial_rustc)
                .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_snapshot_libdir());
966
        } else {
S
Santiago Pastorino 已提交
967 968 969
            cargo
                .env("RUSTC_SNAPSHOT", self.rustc(compiler))
                .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_libdir(compiler));
970 971
        }

972
        if self.config.incremental {
973
            cargo.env("CARGO_INCREMENTAL", "1");
974 975
        }

M
Mark Simulacrum 已提交
976
        if let Some(ref on_fail) = self.config.on_fail {
977 978 979
            cargo.env("RUSTC_ON_FAIL", on_fail);
        }

980 981 982 983
        if self.config.print_step_timings {
            cargo.env("RUSTC_PRINT_STEP_TIMINGS", "1");
        }

J
John Kåre Alsaker 已提交
984 985 986 987
        if self.config.backtrace_on_ice {
            cargo.env("RUSTC_BACKTRACE_ON_ICE", "1");
        }

988 989 990 991
        if self.config.rust_verify_llvm_ir {
            cargo.env("RUSTC_VERIFY_LLVM_IR", "1");
        }

L
ljedrz 已提交
992
        cargo.env("RUSTC_VERBOSE", self.verbosity.to_string());
993

994
        // in std, we want to avoid denying warnings for stage 0 as that makes cfg's painful.
C
Collins Abitekaniza 已提交
995
        if self.config.deny_warnings && !(mode == Mode::Std && stage == 0) {
996 997 998
            cargo.env("RUSTC_DENY_WARNINGS", "1");
        }

O
Oliver Schneider 已提交
999 1000 1001 1002 1003
        // Throughout the build Cargo can execute a number of build scripts
        // compiling C/C++ code and we need to pass compilers, archivers, flags, etc
        // obtained previously to those build scripts.
        // Build scripts use either the `cc` crate or `configure/make` so we pass
        // the options through environment variables that are fetched and understood by both.
1004 1005
        //
        // FIXME: the guard against msvc shouldn't need to be here
1006 1007 1008 1009 1010
        if target.contains("msvc") {
            if let Some(ref cl) = self.config.llvm_clang_cl {
                cargo.env("CC", cl).env("CXX", cl);
            }
        } else {
1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027
            let ccache = self.config.ccache.as_ref();
            let ccacheify = |s: &Path| {
                let ccache = match ccache {
                    Some(ref s) => s,
                    None => return s.display().to_string(),
                };
                // FIXME: the cc-rs crate only recognizes the literal strings
                // `ccache` and `sccache` when doing caching compilations, so we
                // mirror that here. It should probably be fixed upstream to
                // accept a new env var or otherwise work with custom ccache
                // vars.
                match &ccache[..] {
                    "ccache" | "sccache" => format!("{} {}", ccache, s.display()),
                    _ => s.display().to_string(),
                }
            };
            let cc = ccacheify(&self.cc(target));
S
Santiago Pastorino 已提交
1028
            cargo.env(format!("CC_{}", target), &cc).env("CC", &cc);
O
Oliver Schneider 已提交
1029 1030

            let cflags = self.cflags(target).join(" ");
S
Santiago Pastorino 已提交
1031 1032 1033
            cargo
                .env(format!("CFLAGS_{}", target), cflags.clone())
                .env("CFLAGS", cflags.clone());
O
Oliver Schneider 已提交
1034 1035 1036

            if let Some(ar) = self.ar(target) {
                let ranlib = format!("{} s", ar.display());
S
Santiago Pastorino 已提交
1037 1038 1039 1040 1041
                cargo
                    .env(format!("AR_{}", target), ar)
                    .env("AR", ar)
                    .env(format!("RANLIB_{}", target), ranlib.clone())
                    .env("RANLIB", ranlib);
O
Oliver Schneider 已提交
1042
            }
1043

M
Mark Simulacrum 已提交
1044
            if let Ok(cxx) = self.cxx(target) {
1045
                let cxx = ccacheify(&cxx);
S
Santiago Pastorino 已提交
1046 1047 1048 1049 1050
                cargo
                    .env(format!("CXX_{}", target), &cxx)
                    .env("CXX", &cxx)
                    .env(format!("CXXFLAGS_{}", target), cflags.clone())
                    .env("CXXFLAGS", cflags);
1051 1052 1053
            }
        }

1054
        if (cmd == "build" || cmd == "rustc")
C
Collins Abitekaniza 已提交
1055
            && mode == Mode::Std
S
Santiago Pastorino 已提交
1056 1057
            && self.config.extended
            && compiler.is_final_stage(self)
1058
        {
1059 1060 1061
            cargo.env("RUSTC_SAVE_ANALYSIS", "api".to_string());
        }

O
Oliver Schneider 已提交
1062
        // For `cargo doc` invocations, make rustdoc print the Rust version into the docs
1063
        cargo.env("RUSTDOC_CRATE_VERSION", self.rust_version());
O
Oliver Schneider 已提交
1064

1065 1066 1067 1068 1069
        // Environment variables *required* throughout the build
        //
        // FIXME: should update code to not require this env var
        cargo.env("CFG_COMPILER_HOST_TRIPLE", target);

1070
        // Set this for all builds to make sure doc builds also get it.
1071
        cargo.env("CFG_RELEASE_CHANNEL", &self.config.channel);
1072

1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090
        // This one's a bit tricky. As of the time of this writing the compiler
        // links to the `winapi` crate on crates.io. This crate provides raw
        // bindings to Windows system functions, sort of like libc does for
        // Unix. This crate also, however, provides "import libraries" for the
        // MinGW targets. There's an import library per dll in the windows
        // distribution which is what's linked to. These custom import libraries
        // are used because the winapi crate can reference Windows functions not
        // present in the MinGW import libraries.
        //
        // For example MinGW may ship libdbghelp.a, but it may not have
        // references to all the functions in the dbghelp dll. Instead the
        // custom import library for dbghelp in the winapi crates has all this
        // information.
        //
        // Unfortunately for us though the import libraries are linked by
        // default via `-ldylib=winapi_foo`. That is, they're linked with the
        // `dylib` type with a `winapi_` prefix (so the winapi ones don't
        // conflict with the system MinGW ones). This consequently means that
I
Irina Popa 已提交
1091
        // the binaries we ship of things like rustc_codegen_llvm (aka the rustc_codegen_llvm
1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103
        // DLL) when linked against *again*, for example with procedural macros
        // or plugins, will trigger the propagation logic of `-ldylib`, passing
        // `-lwinapi_foo` to the linker again. This isn't actually available in
        // our distribution, however, so the link fails.
        //
        // To solve this problem we tell winapi to not use its bundled import
        // libraries. This means that it will link to the system MinGW import
        // libraries by default, and the `-ldylib=foo` directives will still get
        // passed to the final linker, but they'll look like `-lfoo` which can
        // be resolved because MinGW has the import library. The downside is we
        // don't get newer functions from Windows, but we don't use any of them
        // anyway.
C
Collins Abitekaniza 已提交
1104
        if !mode.is_tool() {
A
Alex Crichton 已提交
1105 1106
            cargo.env("WINAPI_NO_BUNDLED_LIBRARIES", "1");
        }
1107

C
comex 已提交
1108
        for _ in 1..self.verbosity {
1109 1110
            cargo.arg("-v");
        }
1111 1112 1113 1114 1115 1116 1117

        // This must be kept before the thinlto check, as we set codegen units
        // to 1 forcibly there.
        if let Some(n) = self.config.rust_codegen_units {
            cargo.env("RUSTC_CODEGEN_UNITS", n.to_string());
        }

O
Oliver Schneider 已提交
1118
        if self.config.rust_optimize {
1119 1120
            // FIXME: cargo bench/install do not accept `--release`
            if cmd != "bench" && cmd != "install" {
O
Oliver Schneider 已提交
1121 1122
                cargo.arg("--release");
            }
1123
        }
1124

M
Mark Simulacrum 已提交
1125
        if self.config.locked_deps {
1126 1127
            cargo.arg("--locked");
        }
M
Mark Simulacrum 已提交
1128
        if self.config.vendor || self.is_sudo {
1129 1130 1131
            cargo.arg("--frozen");
        }

M
Mark Simulacrum 已提交
1132
        self.ci_env.force_coloring_in_ci(&mut cargo);
1133 1134 1135 1136

        cargo
    }

V
varkor 已提交
1137
    /// Ensure that a given step is built, returning its output. This will
1138 1139
    /// cache the step, so it is safe (and good!) to call this as often as
    /// needed to ensure that all dependencies are built.
1140
    pub fn ensure<S: Step>(&'a self, step: S) -> S::Output {
1141 1142
        {
            let mut stack = self.stack.borrow_mut();
1143 1144
            for stack_step in stack.iter() {
                // should skip
S
Santiago Pastorino 已提交
1145 1146 1147 1148
                if stack_step
                    .downcast_ref::<S>()
                    .map_or(true, |stack_step| *stack_step != step)
                {
1149
                    continue;
1150
                }
1151
                let mut out = String::new();
1152
                out += &format!("\n\nCycle in build detected when adding {:?}\n", step);
1153 1154 1155 1156 1157
                for el in stack.iter().rev() {
                    out += &format!("\t{:?}\n", el);
                }
                panic!(out);
            }
1158
            if let Some(out) = self.cache.get(&step) {
1159
                self.verbose(&format!("{}c {:?}", "  ".repeat(stack.len()), step));
1160

1161 1162 1163
                {
                    let mut graph = self.graph.borrow_mut();
                    let parent = self.parent.get();
S
Santiago Pastorino 已提交
1164 1165 1166
                    let us = *self
                        .graph_nodes
                        .borrow_mut()
1167 1168 1169 1170 1171 1172 1173
                        .entry(format!("{:?}", step))
                        .or_insert_with(|| graph.add_node(format!("{:?}", step)));
                    if let Some(parent) = parent {
                        graph.add_edge(parent, us, false);
                    }
                }

1174 1175
                return out;
            }
1176
            self.verbose(&format!("{}> {:?}", "  ".repeat(stack.len()), step));
1177
            stack.push(Box::new(step.clone()));
1178
        }
1179

1180 1181 1182 1183 1184
        let prev_parent = self.parent.get();

        {
            let mut graph = self.graph.borrow_mut();
            let parent = self.parent.get();
S
Santiago Pastorino 已提交
1185 1186 1187
            let us = *self
                .graph_nodes
                .borrow_mut()
1188 1189 1190 1191 1192 1193 1194 1195
                .entry(format!("{:?}", step))
                .or_insert_with(|| graph.add_node(format!("{:?}", step)));
            self.parent.set(Some(us));
            if let Some(parent) = parent {
                graph.add_edge(parent, us, true);
            }
        }

1196 1197 1198 1199 1200 1201 1202 1203 1204 1205
        let (out, dur) = {
            let start = Instant::now();
            let zero = Duration::new(0, 0);
            let parent = self.time_spent_on_dependencies.replace(zero);
            let out = step.clone().run(self);
            let dur = start.elapsed();
            let deps = self.time_spent_on_dependencies.replace(parent + dur);
            (out, dur - deps)
        };

1206 1207
        self.parent.set(prev_parent);

1208
        if self.config.print_step_timings && dur > Duration::from_millis(100) {
S
Santiago Pastorino 已提交
1209 1210 1211 1212 1213 1214
            println!(
                "[TIMING] {:?} -- {}.{:03}",
                step,
                dur.as_secs(),
                dur.subsec_nanos() / 1_000_000
            );
1215 1216
        }

1217 1218
        {
            let mut stack = self.stack.borrow_mut();
1219 1220
            let cur_step = stack.pop().expect("step stack empty");
            assert_eq!(cur_step.downcast_ref(), Some(&step));
1221
        }
S
Santiago Pastorino 已提交
1222 1223 1224 1225 1226
        self.verbose(&format!(
            "{}< {:?}",
            "  ".repeat(self.stack.borrow().len()),
            step
        ));
1227 1228
        self.cache.put(step, out.clone());
        out
1229 1230
    }
}
M
Mark Simulacrum 已提交
1231 1232 1233

#[cfg(test)]
mod __test {
S
Santiago Pastorino 已提交
1234
    use super::*;
M
Mark Simulacrum 已提交
1235
    use config::Config;
1236
    use std::thread;
M
Mark Simulacrum 已提交
1237 1238 1239

    fn configure(host: &[&str], target: &[&str]) -> Config {
        let mut config = Config::default_opts();
M
Mark Simulacrum 已提交
1240 1241
        // don't save toolstates
        config.save_toolstates = None;
M
Mark Simulacrum 已提交
1242
        config.run_host_only = true;
1243 1244
        config.dry_run = true;
        // try to avoid spurious failures in dist where we create/delete each others file
S
Santiago Pastorino 已提交
1245 1246 1247 1248 1249 1250
        let dir = config.out.join("tmp-rustbuild-tests").join(
            &thread::current()
                .name()
                .unwrap_or("unknown")
                .replace(":", "-"),
        );
1251 1252
        t!(fs::create_dir_all(&dir));
        config.out = dir;
M
Mark Simulacrum 已提交
1253
        config.build = INTERNER.intern_str("A");
S
Santiago Pastorino 已提交
1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264
        config.hosts = vec![config.build]
            .clone()
            .into_iter()
            .chain(host.iter().map(|s| INTERNER.intern_str(s)))
            .collect::<Vec<_>>();
        config.targets = config
            .hosts
            .clone()
            .into_iter()
            .chain(target.iter().map(|s| INTERNER.intern_str(s)))
            .collect::<Vec<_>>();
M
Mark Simulacrum 已提交
1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279
        config
    }

    fn first<A, B>(v: Vec<(A, B)>) -> Vec<A> {
        v.into_iter().map(|(a, _)| a).collect::<Vec<_>>()
    }

    #[test]
    fn dist_baseline() {
        let build = Build::new(configure(&[], &[]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");

S
Santiago Pastorino 已提交
1280 1281 1282 1283 1284 1285 1286 1287 1288 1289 1290 1291 1292 1293 1294 1295 1296
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[dist::Docs { stage: 2, host: a },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[dist::Rustc {
                compiler: Compiler { host: a, stage: 2 }
            },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[dist::Std {
M
Mark Simulacrum 已提交
1297 1298
                compiler: Compiler { host: a, stage: 2 },
                target: a,
S
Santiago Pastorino 已提交
1299 1300
            },]
        );
M
Mark Simulacrum 已提交
1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_targets() {
        let build = Build::new(configure(&[], &["B"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");

S
Santiago Pastorino 已提交
1313 1314 1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331 1332 1333 1334 1335 1336 1337 1338 1339 1340 1341 1342
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a }, dist::Mingw { host: b },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[dist::Rustc {
                compiler: Compiler { host: a, stage: 2 }
            },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
M
Mark Simulacrum 已提交
1343 1344 1345 1346 1347 1348 1349 1350 1351 1352 1353 1354
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_hosts() {
        let build = Build::new(configure(&["B"], &[]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");

S
Santiago Pastorino 已提交
1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377 1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a }, dist::Mingw { host: b },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[
                dist::Rustc {
                    compiler: Compiler { host: a, stage: 2 }
                },
                dist::Rustc {
                    compiler: Compiler { host: b, stage: 2 }
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
M
Mark Simulacrum 已提交
1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_targets_and_hosts() {
        let build = Build::new(configure(&["B"], &["C"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

S
Santiago Pastorino 已提交
1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
                dist::Docs { stage: 2, host: c },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[
                dist::Mingw { host: a },
                dist::Mingw { host: b },
                dist::Mingw { host: c },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[
                dist::Rustc {
                    compiler: Compiler { host: a, stage: 2 }
                },
                dist::Rustc {
                    compiler: Compiler { host: b, stage: 2 }
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_target_flag() {
        let mut config = configure(&["B"], &["C"]);
        config.run_host_only = false; // as-if --target=C was passed
        let build = Build::new(config);
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

S
Santiago Pastorino 已提交
1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
                dist::Docs { stage: 2, host: c },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[
                dist::Mingw { host: a },
                dist::Mingw { host: b },
                dist::Mingw { host: c },
            ]
        );
M
Mark Simulacrum 已提交
1478
        assert_eq!(first(builder.cache.all::<dist::Rustc>()), &[]);
S
Santiago Pastorino 已提交
1479 1480 1481 1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[]);
    }

    #[test]
    fn dist_with_same_targets_and_hosts() {
        let build = Build::new(configure(&["B"], &["B"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");

S
Santiago Pastorino 已提交
1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a }, dist::Mingw { host: b },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[
                dist::Rustc {
                    compiler: Compiler { host: a, stage: 2 }
                },
                dist::Rustc {
                    compiler: Compiler { host: b, stage: 2 }
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
M
Mark Simulacrum 已提交
1543
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
S
Santiago Pastorino 已提交
1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577 1578 1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610
        assert_eq!(
            first(builder.cache.all::<compile::Std>()),
            &[
                compile::Std {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<compile::Test>()),
            &[
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<compile::Assemble>()),
            &[
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 0 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 1 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 2 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: b, stage: 2 },
                },
            ]
        );
M
Mark Simulacrum 已提交
1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624
    }

    #[test]
    fn build_default() {
        let build = Build::new(configure(&["B"], &["C"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Build), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

        assert!(!builder.cache.all::<compile::Std>().is_empty());
        assert!(!builder.cache.all::<compile::Assemble>().is_empty());
S
Santiago Pastorino 已提交
1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645 1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659 1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707
        assert_eq!(
            first(builder.cache.all::<compile::Rustc>()),
            &[
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: b, stage: 2 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: b, stage: 2 },
                    target: b,
                },
            ]
        );

        assert_eq!(
            first(builder.cache.all::<compile::Test>()),
            &[
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722
    }

    #[test]
    fn build_with_target_flag() {
        let mut config = configure(&["B"], &["C"]);
        config.run_host_only = false;
        let build = Build::new(config);
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Build), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

        assert!(!builder.cache.all::<compile::Std>().is_empty());
S
Santiago Pastorino 已提交
1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742 1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757 1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809
        assert_eq!(
            first(builder.cache.all::<compile::Assemble>()),
            &[
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 0 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 1 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: b, stage: 1 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 2 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: b, stage: 2 },
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<compile::Rustc>()),
            &[
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
            ]
        );

        assert_eq!(
            first(builder.cache.all::<compile::Test>()),
            &[
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1810
    }
K
kennytm 已提交
1811 1812 1813 1814 1815 1816 1817 1818 1819 1820

    #[test]
    fn test_with_no_doc_stage0() {
        let mut config = configure(&[], &[]);
        config.stage = Some(0);
        config.cmd = Subcommand::Test {
            paths: vec!["src/libstd".into()],
            test_args: vec![],
            rustc_args: vec![],
            fail_fast: true,
K
kennytm 已提交
1821
            doc_tests: DocTests::No,
O
Oliver Schneider 已提交
1822
            bless: false,
S
Santiago Pastorino 已提交
1823
            compare_mode: None,
K
kennytm 已提交
1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837
        };

        let build = Build::new(config);
        let mut builder = Builder::new(&build);

        let host = INTERNER.intern_str("A");

        builder.run_step_descriptions(
            &[StepDescription::from::<test::Crate>()],
            &["src/libstd".into()],
        );

        // Ensure we don't build any compiler artifacts.
        assert!(builder.cache.all::<compile::Rustc>().is_empty());
S
Santiago Pastorino 已提交
1838 1839 1840
        assert_eq!(
            first(builder.cache.all::<test::Crate>()),
            &[test::Crate {
K
kennytm 已提交
1841 1842
                compiler: Compiler { host, stage: 0 },
                target: host,
C
Collins Abitekaniza 已提交
1843
                mode: Mode::Std,
K
kennytm 已提交
1844 1845
                test_kind: test::TestKind::Test,
                krate: INTERNER.intern_str("std"),
S
Santiago Pastorino 已提交
1846 1847
            },]
        );
K
kennytm 已提交
1848
    }
M
Mark Simulacrum 已提交
1849
}