builder.rs 66.2 KB
Newer Older
1
use std::any::Any;
2
use std::cell::{Cell, RefCell};
3
use std::collections::BTreeSet;
S
Santiago Pastorino 已提交
4
use std::collections::HashMap;
5
use std::env;
6
use std::fmt::Debug;
7
use std::fs;
8
use std::hash::Hash;
9
use std::ops::Deref;
10 11
use std::path::{Path, PathBuf};
use std::process::Command;
S
Santiago Pastorino 已提交
12
use std::time::{Duration, Instant};
13

L
ljedrz 已提交
14 15 16 17 18 19 20 21 22 23
use crate::cache::{Cache, Interned, INTERNER};
use crate::check;
use crate::compile;
use crate::dist;
use crate::doc;
use crate::flags::Subcommand;
use crate::install;
use crate::native;
use crate::test;
use crate::tool;
24
use crate::util::{self, add_lib_path, exe, libdir};
L
ljedrz 已提交
25 26 27
use crate::{Build, DocTests, Mode, GitRepo};

pub use crate::Compiler;
28

29
use petgraph::graph::NodeIndex;
S
Santiago Pastorino 已提交
30
use petgraph::Graph;
31

32 33 34 35 36
pub struct Builder<'a> {
    pub build: &'a Build,
    pub top_stage: u32,
    pub kind: Kind,
    cache: Cache,
37
    stack: RefCell<Vec<Box<dyn Any>>>,
38
    time_spent_on_dependencies: Cell<Duration>,
39
    pub paths: Vec<PathBuf>,
40 41 42
    graph_nodes: RefCell<HashMap<String, NodeIndex>>,
    graph: RefCell<Graph<String, bool>>,
    parent: Cell<Option<NodeIndex>>,
43 44 45 46 47 48 49 50 51 52
}

impl<'a> Deref for Builder<'a> {
    type Target = Build;

    fn deref(&self) -> &Self::Target {
        self.build
    }
}

53
pub trait Step: 'static + Clone + Debug + PartialEq + Eq + Hash {
54 55
    /// `PathBuf` when directories are created or to return a `Compiler` once
    /// it's been assembled.
56
    type Output: Clone;
57

58 59
    const DEFAULT: bool = false;

60
    /// Run this rule for all hosts without cross compiling.
61 62
    const ONLY_HOSTS: bool = false;

A
Alexander Regueiro 已提交
63
    /// Primary function to execute this rule. Can call `builder.ensure()`
64
    /// with other steps to run those.
T
Taiki Endo 已提交
65
    fn run(self, builder: &Builder<'_>) -> Self::Output;
66

67 68
    /// When bootstrap is passed a set of paths, this controls whether this rule
    /// will execute. However, it does not get called in a "default" context
A
Alexander Regueiro 已提交
69
    /// when we are not passed any paths; in that case, `make_run` is called
70
    /// directly.
T
Taiki Endo 已提交
71
    fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_>;
72

A
Alexander Regueiro 已提交
73
    /// Builds up a "root" rule, either as a default rule or from a path passed
74 75 76 77 78
    /// to us.
    ///
    /// When path is `None`, we are executing in a context where no paths were
    /// passed. When `./x.py build` is run, for example, this rule could get
    /// called if it is in the correct list below with a path of `None`.
T
Taiki Endo 已提交
79
    fn make_run(_run: RunConfig<'_>) {
80 81 82 83 84 85
        // It is reasonable to not have an implementation of make_run for rules
        // who do not want to get called from the root context. This means that
        // they are likely dependencies (e.g., sysroot creation) or similar, and
        // as such calling them from ./x.py isn't logical.
        unimplemented!()
    }
86 87
}

88 89 90 91
pub struct RunConfig<'a> {
    pub builder: &'a Builder<'a>,
    pub host: Interned<String>,
    pub target: Interned<String>,
92
    pub path: PathBuf,
93 94
}

95 96 97
struct StepDescription {
    default: bool,
    only_hosts: bool,
T
Taiki Endo 已提交
98 99
    should_run: fn(ShouldRun<'_>) -> ShouldRun<'_>,
    make_run: fn(RunConfig<'_>),
100 101 102 103
    name: &'static str,
}

#[derive(Debug, Clone, PartialOrd, Ord, PartialEq, Eq)]
104
pub enum PathSet {
S
Santiago Pastorino 已提交
105 106
    Set(BTreeSet<PathBuf>),
    Suite(PathBuf),
107 108 109
}

impl PathSet {
110
    fn empty() -> PathSet {
111
        PathSet::Set(BTreeSet::new())
112 113
    }

114 115 116
    fn one<P: Into<PathBuf>>(path: P) -> PathSet {
        let mut set = BTreeSet::new();
        set.insert(path.into());
117
        PathSet::Set(set)
118 119 120
    }

    fn has(&self, needle: &Path) -> bool {
121 122
        match self {
            PathSet::Set(set) => set.iter().any(|p| p.ends_with(needle)),
123
            PathSet::Suite(suite) => suite.ends_with(needle),
124
        }
125 126
    }

T
Taiki Endo 已提交
127
    fn path(&self, builder: &Builder<'_>) -> PathBuf {
128
        match self {
S
Santiago Pastorino 已提交
129 130 131 132 133 134
            PathSet::Set(set) => set
                .iter()
                .next()
                .unwrap_or(&builder.build.src)
                .to_path_buf(),
            PathSet::Suite(path) => PathBuf::from(path),
135
        }
136
    }
137 138 139 140 141 142 143 144 145
}

impl StepDescription {
    fn from<S: Step>() -> StepDescription {
        StepDescription {
            default: S::DEFAULT,
            only_hosts: S::ONLY_HOSTS,
            should_run: S::should_run,
            make_run: S::make_run,
146
            name: unsafe { ::std::intrinsics::type_name::<S>() },
147 148 149
        }
    }

T
Taiki Endo 已提交
150
    fn maybe_run(&self, builder: &Builder<'_>, pathset: &PathSet) {
151 152 153 154
        if builder.config.exclude.iter().any(|e| pathset.has(e)) {
            eprintln!("Skipping {:?} because it is excluded", pathset);
            return;
        } else if !builder.config.exclude.is_empty() {
S
Santiago Pastorino 已提交
155 156 157 158
            eprintln!(
                "{:?} not skipped for {:?} -- not in {:?}",
                pathset, self.name, builder.config.exclude
            );
159
        }
160
        let hosts = &builder.hosts;
161

M
Mark Simulacrum 已提交
162
        // Determine the targets participating in this rule.
163
        let targets = if self.only_hosts {
164
            if !builder.config.run_host_only {
165
                return; // don't run anything
166
            } else {
167
                &builder.hosts
168 169
            }
        } else {
170
            &builder.targets
171 172 173 174
        };

        for host in hosts {
            for target in targets {
175 176
                let run = RunConfig {
                    builder,
177
                    path: pathset.path(builder),
178 179 180 181
                    host: *host,
                    target: *target,
                };
                (self.make_run)(run);
182 183 184 185
            }
        }
    }

T
Taiki Endo 已提交
186
    fn run(v: &[StepDescription], builder: &Builder<'_>, paths: &[PathBuf]) {
S
Santiago Pastorino 已提交
187 188 189 190
        let should_runs = v
            .iter()
            .map(|desc| (desc.should_run)(ShouldRun::new(builder)))
            .collect::<Vec<_>>();
191 192 193

        // sanity checks on rules
        for (desc, should_run) in v.iter().zip(&should_runs) {
S
Santiago Pastorino 已提交
194 195 196 197 198
            assert!(
                !should_run.paths.is_empty(),
                "{:?} should have at least one pathset",
                desc.name
            );
199 200
        }

201
        if paths.is_empty() {
202 203
            for (desc, should_run) in v.iter().zip(should_runs) {
                if desc.default && should_run.is_really_default {
204 205 206
                    for pathset in &should_run.paths {
                        desc.maybe_run(builder, pathset);
                    }
207 208 209 210
                }
            }
        } else {
            for path in paths {
211 212 213 214 215 216
                // strip CurDir prefix if present
                let path = match path.strip_prefix(".") {
                    Ok(p) => p,
                    Err(_) => path,
                };

217
                let mut attempted_run = false;
218
                for (desc, should_run) in v.iter().zip(&should_runs) {
219 220 221 222
                    if let Some(suite) = should_run.is_suite_path(path) {
                        attempted_run = true;
                        desc.maybe_run(builder, suite);
                    } else if let Some(pathset) = should_run.pathset_for_path(path) {
223
                        attempted_run = true;
224
                        desc.maybe_run(builder, pathset);
225 226 227 228
                    }
                }

                if !attempted_run {
229
                    panic!("Error: no rules matched {}.", path.display());
230 231 232 233 234 235
                }
            }
        }
    }
}

236 237
#[derive(Clone)]
pub struct ShouldRun<'a> {
238
    pub builder: &'a Builder<'a>,
239
    // use a BTreeSet to maintain sort order
240
    paths: BTreeSet<PathSet>,
241 242

    // If this is a default rule, this is an additional constraint placed on
243
    // its run. Generally something like compiler docs being enabled.
244
    is_really_default: bool,
245 246 247
}

impl<'a> ShouldRun<'a> {
T
Taiki Endo 已提交
248
    fn new(builder: &'a Builder<'_>) -> ShouldRun<'a> {
249
        ShouldRun {
250
            builder,
251
            paths: BTreeSet::new(),
252
            is_really_default: true, // by default no additional conditions
253 254 255
        }
    }

256 257 258 259 260
    pub fn default_condition(mut self, cond: bool) -> Self {
        self.is_really_default = cond;
        self
    }

261 262 263 264 265 266 267 268
    // Unlike `krate` this will create just one pathset. As such, it probably shouldn't actually
    // ever be used, but as we transition to having all rules properly handle passing krate(...) by
    // actually doing something different for every crate passed.
    pub fn all_krates(mut self, name: &str) -> Self {
        let mut set = BTreeSet::new();
        for krate in self.builder.in_tree_crates(name) {
            set.insert(PathBuf::from(&krate.path));
        }
269
        self.paths.insert(PathSet::Set(set));
270 271 272
        self
    }

273
    pub fn krate(mut self, name: &str) -> Self {
274 275
        for krate in self.builder.in_tree_crates(name) {
            self.paths.insert(PathSet::one(&krate.path));
276 277 278 279
        }
        self
    }

280 281 282 283 284 285 286
    // single, non-aliased path
    pub fn path(self, path: &str) -> Self {
        self.paths(&[path])
    }

    // multiple aliases for the same job
    pub fn paths(mut self, paths: &[&str]) -> Self {
S
Santiago Pastorino 已提交
287 288
        self.paths
            .insert(PathSet::Set(paths.iter().map(PathBuf::from).collect()));
289 290 291 292
        self
    }

    pub fn is_suite_path(&self, path: &Path) -> Option<&PathSet> {
S
Santiago Pastorino 已提交
293 294 295
        self.paths.iter().find(|pathset| match pathset {
            PathSet::Suite(p) => path.starts_with(p),
            PathSet::Set(_) => false,
296 297 298 299 300
        })
    }

    pub fn suite_path(mut self, suite: &str) -> Self {
        self.paths.insert(PathSet::Suite(PathBuf::from(suite)));
301 302 303 304
        self
    }

    // allows being more explicit about why should_run in Step returns the value passed to it
305 306
    pub fn never(mut self) -> ShouldRun<'a> {
        self.paths.insert(PathSet::empty());
307 308 309
        self
    }

310 311
    fn pathset_for_path(&self, path: &Path) -> Option<&PathSet> {
        self.paths.iter().find(|pathset| pathset.has(path))
312 313 314
    }
}

315 316 317
#[derive(Copy, Clone, PartialEq, Eq, Debug)]
pub enum Kind {
    Build,
318
    Check,
319 320 321 322 323 324 325
    Test,
    Bench,
    Dist,
    Doc,
    Install,
}

326 327 328
impl<'a> Builder<'a> {
    fn get_step_descriptions(kind: Kind) -> Vec<StepDescription> {
        macro_rules! describe {
T
Taiki Endo 已提交
329
            ($($rule:ty),+ $(,)?) => {{
330 331
                vec![$(StepDescription::from::<$rule>()),+]
            }};
332
        }
333
        match kind {
S
Santiago Pastorino 已提交
334 335 336 337
            Kind::Build => describe!(
                compile::Std,
                compile::Test,
                compile::Rustc,
338
                compile::CodegenBackend,
S
Santiago Pastorino 已提交
339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394
                compile::StartupObjects,
                tool::BuildManifest,
                tool::Rustbook,
                tool::ErrorIndex,
                tool::UnstableBookGen,
                tool::Tidy,
                tool::Linkchecker,
                tool::CargoTest,
                tool::Compiletest,
                tool::RemoteTestServer,
                tool::RemoteTestClient,
                tool::RustInstaller,
                tool::Cargo,
                tool::Rls,
                tool::Rustdoc,
                tool::Clippy,
                native::Llvm,
                tool::Rustfmt,
                tool::Miri,
                native::Lld
            ),
            Kind::Check => describe!(
                check::Std,
                check::Test,
                check::Rustc,
                check::CodegenBackend,
                check::Rustdoc
            ),
            Kind::Test => describe!(
                test::Tidy,
                test::Ui,
                test::RunPass,
                test::CompileFail,
                test::RunFail,
                test::RunPassValgrind,
                test::MirOpt,
                test::Codegen,
                test::CodegenUnits,
                test::Incremental,
                test::Debuginfo,
                test::UiFullDeps,
                test::RunPassFullDeps,
                test::Rustdoc,
                test::Pretty,
                test::RunPassPretty,
                test::RunFailPretty,
                test::RunPassValgrindPretty,
                test::Crate,
                test::CrateLibrustc,
                test::CrateRustdoc,
                test::Linkcheck,
                test::Cargotest,
                test::Cargo,
                test::Rls,
                test::ErrorIndex,
                test::Distcheck,
395
                test::RunMakeFullDeps,
S
Santiago Pastorino 已提交
396 397 398 399 400 401 402
                test::Nomicon,
                test::Reference,
                test::RustdocBook,
                test::RustByExample,
                test::TheBook,
                test::UnstableBook,
                test::RustcBook,
403
                test::EmbeddedBook,
S
Santiago Pastorino 已提交
404 405 406
                test::Rustfmt,
                test::Miri,
                test::Clippy,
407
                test::CompiletestTest,
G
Guillaume Gomez 已提交
408
                test::RustdocJSStd,
G
Guillaume Gomez 已提交
409
                test::RustdocJSNotStd,
S
Santiago Pastorino 已提交
410
                test::RustdocTheme,
411 412
                // Run bootstrap close to the end as it's unlikely to fail
                test::Bootstrap,
413
                // Run run-make last, since these won't pass without make on Windows
S
Santiago Pastorino 已提交
414 415 416
                test::RunMake,
                test::RustdocUi
            ),
417
            Kind::Bench => describe!(test::Crate, test::CrateLibrustc),
S
Santiago Pastorino 已提交
418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433
            Kind::Doc => describe!(
                doc::UnstableBook,
                doc::UnstableBookGen,
                doc::TheBook,
                doc::Standalone,
                doc::Std,
                doc::Test,
                doc::WhitelistedRustc,
                doc::Rustc,
                doc::Rustdoc,
                doc::ErrorIndex,
                doc::Nomicon,
                doc::Reference,
                doc::RustdocBook,
                doc::RustByExample,
                doc::RustcBook,
S
Steve Klabnik 已提交
434
                doc::CargoBook,
J
James Munns 已提交
435
                doc::EmbeddedBook,
S
Steve Klabnik 已提交
436
                doc::EditionGuide,
S
Santiago Pastorino 已提交
437 438 439 440 441 442 443 444 445 446 447 448 449 450
            ),
            Kind::Dist => describe!(
                dist::Docs,
                dist::RustcDocs,
                dist::Mingw,
                dist::Rustc,
                dist::DebuggerScripts,
                dist::Std,
                dist::Analysis,
                dist::Src,
                dist::PlainSourceTarball,
                dist::Cargo,
                dist::Rls,
                dist::Rustfmt,
451
                dist::Clippy,
452
                dist::Miri,
453
                dist::LlvmTools,
T
Tom Tromey 已提交
454
                dist::Lldb,
S
Santiago Pastorino 已提交
455 456 457 458 459 460 461 462 463
                dist::Extended,
                dist::HashSign
            ),
            Kind::Install => describe!(
                install::Docs,
                install::Std,
                install::Cargo,
                install::Rls,
                install::Rustfmt,
464
                install::Clippy,
465
                install::Miri,
S
Santiago Pastorino 已提交
466 467 468 469
                install::Analysis,
                install::Src,
                install::Rustc
            ),
470 471
        }
    }
472

473 474 475 476 477 478 479 480 481 482 483 484
    pub fn get_help(build: &Build, subcommand: &str) -> Option<String> {
        let kind = match subcommand {
            "build" => Kind::Build,
            "doc" => Kind::Doc,
            "test" => Kind::Test,
            "bench" => Kind::Bench,
            "dist" => Kind::Dist,
            "install" => Kind::Install,
            _ => return None,
        };

        let builder = Builder {
485
            build,
M
Mark Simulacrum 已提交
486
            top_stage: build.config.stage.unwrap_or(2),
487
            kind,
488 489
            cache: Cache::new(),
            stack: RefCell::new(Vec::new()),
490
            time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
491
            paths: vec![],
492 493 494
            graph_nodes: RefCell::new(HashMap::new()),
            graph: RefCell::new(Graph::new()),
            parent: Cell::new(None),
495 496 497 498
        };

        let builder = &builder;
        let mut should_run = ShouldRun::new(builder);
499 500
        for desc in Builder::get_step_descriptions(builder.kind) {
            should_run = (desc.should_run)(should_run);
501 502
        }
        let mut help = String::from("Available paths:\n");
503
        for pathset in should_run.paths {
S
Santiago Pastorino 已提交
504 505 506 507 508 509
            if let PathSet::Set(set) = pathset {
                set.iter().for_each(|path| {
                    help.push_str(
                        format!("    ./x.py {} {}\n", subcommand, path.display()).as_str(),
                    )
                })
510
            }
511 512 513 514
        }
        Some(help)
    }

T
Taiki Endo 已提交
515
    pub fn new(build: &Build) -> Builder<'_> {
M
Mark Simulacrum 已提交
516
        let (kind, paths) = match build.config.cmd {
517
            Subcommand::Build { ref paths } => (Kind::Build, &paths[..]),
518
            Subcommand::Check { ref paths } => (Kind::Check, &paths[..]),
519 520 521 522 523
            Subcommand::Doc { ref paths } => (Kind::Doc, &paths[..]),
            Subcommand::Test { ref paths, .. } => (Kind::Test, &paths[..]),
            Subcommand::Bench { ref paths, .. } => (Kind::Bench, &paths[..]),
            Subcommand::Dist { ref paths } => (Kind::Dist, &paths[..]),
            Subcommand::Install { ref paths } => (Kind::Install, &paths[..]),
O
Oliver Schneider 已提交
524
            Subcommand::Clean { .. } => panic!(),
525 526 527
        };

        let builder = Builder {
528
            build,
M
Mark Simulacrum 已提交
529
            top_stage: build.config.stage.unwrap_or(2),
530
            kind,
531 532
            cache: Cache::new(),
            stack: RefCell::new(Vec::new()),
533
            time_spent_on_dependencies: Cell::new(Duration::new(0, 0)),
534
            paths: paths.to_owned(),
535 536 537
            graph_nodes: RefCell::new(HashMap::new()),
            graph: RefCell::new(Graph::new()),
            parent: Cell::new(None),
538 539
        };

540
        if kind == Kind::Dist {
S
Santiago Pastorino 已提交
541 542 543
            assert!(
                !builder.config.test_miri,
                "Do not distribute with miri enabled.\n\
544
                The distributed libraries would include all MIR (increasing binary size).
S
Santiago Pastorino 已提交
545 546
                The distributed MIR would include validation statements."
            );
547 548
        }

549 550 551
        builder
    }

552
    pub fn execute_cli(&self) -> Graph<String, bool> {
M
Mark Simulacrum 已提交
553
        self.run_step_descriptions(&Builder::get_step_descriptions(self.kind), &self.paths);
554
        self.graph.borrow().clone()
555 556 557 558
    }

    pub fn default_doc(&self, paths: Option<&[PathBuf]>) {
        let paths = paths.unwrap_or(&[]);
M
Mark Simulacrum 已提交
559 560 561 562 563
        self.run_step_descriptions(&Builder::get_step_descriptions(Kind::Doc), paths);
    }

    fn run_step_descriptions(&self, v: &[StepDescription], paths: &[PathBuf]) {
        StepDescription::run(v, self, paths);
564 565
    }

B
Bastien Orivel 已提交
566
    /// Obtain a compiler at a given stage and for a given host. Explicitly does
567 568 569
    /// not take `Compiler` since all `Compiler` instances are meant to be
    /// obtained through this function, since it ensures that they are valid
    /// (i.e., built and assembled).
570
    pub fn compiler(&self, stage: u32, host: Interned<String>) -> Compiler {
S
Santiago Pastorino 已提交
571 572 573
        self.ensure(compile::Assemble {
            target_compiler: Compiler { stage, host },
        })
574 575
    }

576
    pub fn sysroot(&self, compiler: Compiler) -> Interned<PathBuf> {
577 578 579 580 581
        self.ensure(compile::Sysroot { compiler })
    }

    /// Returns the libdir where the standard library and other artifacts are
    /// found for a compiler's sysroot.
582
    pub fn sysroot_libdir(
S
Santiago Pastorino 已提交
583 584 585
        &self,
        compiler: Compiler,
        target: Interned<String>,
586 587 588 589 590
    ) -> Interned<PathBuf> {
        #[derive(Debug, Copy, Clone, Hash, PartialEq, Eq)]
        struct Libdir {
            compiler: Compiler,
            target: Interned<String>,
591
        }
592 593
        impl Step for Libdir {
            type Output = Interned<PathBuf>;
594

T
Taiki Endo 已提交
595
            fn should_run(run: ShouldRun<'_>) -> ShouldRun<'_> {
596
                run.never()
597 598
            }

T
Taiki Endo 已提交
599
            fn run(self, builder: &Builder<'_>) -> Interned<PathBuf> {
600
                let compiler = self.compiler;
601 602 603
                let config = &builder.build.config;
                let lib = if compiler.stage >= 1 && config.libdir_relative().is_some() {
                    builder.build.config.libdir_relative().unwrap()
604
                } else {
605
                    Path::new("lib")
606
                };
S
Santiago Pastorino 已提交
607 608 609 610 611 612
                let sysroot = builder
                    .sysroot(self.compiler)
                    .join(lib)
                    .join("rustlib")
                    .join(self.target)
                    .join("lib");
613 614
                let _ = fs::remove_dir_all(&sysroot);
                t!(fs::create_dir_all(&sysroot));
615
                INTERNER.intern_path(sysroot)
616 617 618 619 620
            }
        }
        self.ensure(Libdir { compiler, target })
    }

621 622
    pub fn sysroot_codegen_backends(&self, compiler: Compiler) -> PathBuf {
        self.sysroot_libdir(compiler, compiler.host)
623
            .with_file_name(self.config.rust_codegen_backends_dir.clone())
624 625
    }

626 627 628 629 630 631 632
    /// Returns the compiler's libdir where it stores the dynamic libraries that
    /// it itself links against.
    ///
    /// For example this returns `<sysroot>/lib` on Unix and `<sysroot>/bin` on
    /// Windows.
    pub fn rustc_libdir(&self, compiler: Compiler) -> PathBuf {
        if compiler.is_snapshot(self) {
633
            self.rustc_snapshot_libdir()
634
        } else {
635
            self.sysroot(compiler).join(libdir(&compiler.host))
636 637 638 639 640 641 642 643 644 645
        }
    }

    /// Adds the compiler's directory of dynamic libraries to `cmd`'s dynamic
    /// library lookup path.
    pub fn add_rustc_lib_path(&self, compiler: Compiler, cmd: &mut Command) {
        // Windows doesn't need dylib path munging because the dlls for the
        // compiler live next to the compiler and the system will find them
        // automatically.
        if cfg!(windows) {
S
Santiago Pastorino 已提交
646
            return;
647 648 649 650 651
        }

        add_lib_path(vec![self.rustc_libdir(compiler)], cmd);
    }

A
Alexander Regueiro 已提交
652
    /// Gets a path to the compiler specified.
653 654 655 656
    pub fn rustc(&self, compiler: Compiler) -> PathBuf {
        if compiler.is_snapshot(self) {
            self.initial_rustc.clone()
        } else {
S
Santiago Pastorino 已提交
657 658 659
            self.sysroot(compiler)
                .join("bin")
                .join(exe("rustc", &compiler.host))
660 661 662
        }
    }

A
Alexander Regueiro 已提交
663
    /// Gets the paths to all of the compiler's codegen backends.
664 665 666 667 668 669 670 671
    fn codegen_backends(&self, compiler: Compiler) -> impl Iterator<Item = PathBuf> {
        fs::read_dir(self.sysroot_codegen_backends(compiler))
            .into_iter()
            .flatten()
            .filter_map(Result::ok)
            .map(|entry| entry.path())
    }

672 673
    pub fn rustdoc(&self, host: Interned<String>) -> PathBuf {
        self.ensure(tool::Rustdoc { host })
M
Mark Simulacrum 已提交
674 675
    }

676
    pub fn rustdoc_cmd(&self, host: Interned<String>) -> Command {
M
Mark Simulacrum 已提交
677
        let mut cmd = Command::new(&self.out.join("bootstrap/debug/rustdoc"));
678
        let compiler = self.compiler(self.top_stage, host);
O
Oliver Schneider 已提交
679
        cmd.env("RUSTC_STAGE", compiler.stage.to_string())
S
Santiago Pastorino 已提交
680
            .env("RUSTC_SYSROOT", self.sysroot(compiler))
M
Mark Rousskov 已提交
681 682 683
            // Note that this is *not* the sysroot_libdir because rustdoc must be linked
            // equivalently to rustc.
            .env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler))
S
Santiago Pastorino 已提交
684 685 686 687
            .env("CFG_RELEASE_CHANNEL", &self.config.channel)
            .env("RUSTDOC_REAL", self.rustdoc(host))
            .env("RUSTDOC_CRATE_VERSION", self.rust_version())
            .env("RUSTC_BOOTSTRAP", "1");
688 689 690 691 692

        // Remove make-related flags that can cause jobserver problems.
        cmd.env_remove("MAKEFLAGS");
        cmd.env_remove("MFLAGS");

693
        if let Some(linker) = self.linker(host) {
O
Oliver Schneider 已提交
694 695
            cmd.env("RUSTC_TARGET_LINKER", linker);
        }
M
Mark Simulacrum 已提交
696
        cmd
697 698
    }

699 700 701 702 703 704 705
    /// Prepares an invocation of `cargo` to be run.
    ///
    /// This will create a `Command` that represents a pending execution of
    /// Cargo. This cargo will be configured to use `compiler` as the actual
    /// rustc compiler, its output will be scoped by `mode`'s output directory,
    /// it will pass the `--target` flag for the specified `target`, and will be
    /// executing the Cargo command `cmd`.
S
Santiago Pastorino 已提交
706 707 708 709 710 711 712
    pub fn cargo(
        &self,
        compiler: Compiler,
        mode: Mode,
        target: Interned<String>,
        cmd: &str,
    ) -> Command {
M
Mark Simulacrum 已提交
713 714
        let mut cargo = Command::new(&self.initial_cargo);
        let out_dir = self.stage_out(compiler, mode);
715

716
        // command specific path, we call clear_if_dirty with this
717 718 719 720
        let mut my_out = match cmd {
            "build" => self.cargo_out(compiler, mode, target),

            // This is the intended out directory for crate documentation.
721
            "doc" | "rustdoc" =>  self.crate_doc_out(target),
722 723 724 725 726 727 728

            _ => self.stage_out(compiler, mode),
        };

        // This is for the original compiler, but if we're forced to use stage 1, then
        // std/test/rustc stamps won't exist in stage 2, so we need to get those from stage 1, since
        // we copy the libs forward.
729
        let cmp = if self.force_use_stage1(compiler, target) {
730 731 732 733 734 735
            self.compiler(1, compiler.host)
        } else {
            compiler
        };

        let libstd_stamp = match cmd {
736 737
            "check" => check::libstd_stamp(self, cmp, target),
            _ => compile::libstd_stamp(self, cmp, target),
738 739 740
        };

        let libtest_stamp = match cmd {
741 742
            "check" => check::libtest_stamp(self, cmp, target),
            _ => compile::libstd_stamp(self, cmp, target),
743 744 745
        };

        let librustc_stamp = match cmd {
746 747
            "check" => check::librustc_stamp(self, cmp, target),
            _ => compile::librustc_stamp(self, cmp, target),
748 749
        };

750
        if cmd == "doc" || cmd == "rustdoc" {
751
            if mode == Mode::Rustc || mode == Mode::ToolRustc || mode == Mode::Codegen {
752 753 754 755 756
                // This is the intended out directory for compiler documentation.
                my_out = self.compiler_doc_out(target);
            }
            let rustdoc = self.rustdoc(compiler.host);
            self.clear_if_dirty(&my_out, &rustdoc);
757
        } else if cmd != "test" {
758 759 760
            match mode {
                Mode::Std => {
                    self.clear_if_dirty(&my_out, &self.rustc(compiler));
761 762 763
                    for backend in self.codegen_backends(compiler) {
                        self.clear_if_dirty(&my_out, &backend);
                    }
764
                },
765 766 767
                Mode::Test => {
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                },
768
                Mode::Rustc => {
769
                    self.clear_if_dirty(&my_out, &self.rustc(compiler));
770 771 772
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                    self.clear_if_dirty(&my_out, &libtest_stamp);
                },
C
Collins Abitekaniza 已提交
773
                Mode::Codegen => {
774
                    self.clear_if_dirty(&my_out, &librustc_stamp);
C
Collins Abitekaniza 已提交
775 776 777 778 779 780 781 782 783
                },
                Mode::ToolBootstrap => { },
                Mode::ToolStd => {
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                },
                Mode::ToolTest => {
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                    self.clear_if_dirty(&my_out, &libtest_stamp);
                },
784 785 786 787
                Mode::ToolRustc => {
                    self.clear_if_dirty(&my_out, &libstd_stamp);
                    self.clear_if_dirty(&my_out, &libtest_stamp);
                    self.clear_if_dirty(&my_out, &librustc_stamp);
788
                },
789 790 791
            }
        }

S
Santiago Pastorino 已提交
792 793
        cargo
            .env("CARGO_TARGET_DIR", out_dir)
794 795
            .arg(cmd);

796 797 798 799 800 801 802
        // See comment in librustc_llvm/build.rs for why this is necessary, largely llvm-config
        // needs to not accidentally link to libLLVM in stage0/lib.
        cargo.env("REAL_LIBRARY_PATH_VAR", &util::dylib_path_var());
        if let Some(e) = env::var_os(util::dylib_path_var()) {
            cargo.env("REAL_LIBRARY_PATH", e);
        }

803 804 805 806 807 808
        if cmd != "install" {
            cargo.arg("--target")
                 .arg(target);
        } else {
            assert_eq!(target, compiler.host);
        }
809

V
varkor 已提交
810
        // Set a flag for `check` so that certain build scripts can do less work
811
        // (e.g., not building/requiring LLVM).
V
varkor 已提交
812 813 814 815
        if cmd == "check" {
            cargo.env("RUST_CHECK", "1");
        }

J
John Kåre Alsaker 已提交
816 817 818 819 820 821 822 823 824 825 826
        match mode {
            Mode::Std | Mode::Test | Mode::ToolBootstrap | Mode::ToolStd | Mode::ToolTest=> {},
            Mode::Rustc | Mode::Codegen | Mode::ToolRustc => {
                // Build proc macros both for the host and the target
                if target != compiler.host && cmd != "check" {
                    cargo.arg("-Zdual-proc-macros");
                    cargo.env("RUST_DUAL_PROC_MACROS", "1");
                }
            },
        }

827 828 829 830
        cargo.arg("-j").arg(self.jobs().to_string());
        // Remove make-related flags to ensure Cargo can correctly set things up
        cargo.env_remove("MAKEFLAGS");
        cargo.env_remove("MFLAGS");
831

832 833
        // FIXME: Temporary fix for https://github.com/rust-lang/cargo/issues/3005
        // Force cargo to output binaries with disambiguating hashes in the name
834 835 836 837 838 839 840 841 842
        let metadata = if compiler.stage == 0 {
            // Treat stage0 like special channel, whether it's a normal prior-
            // release rustc or a local rebuild with the same version, so we
            // never mix these libraries by accident.
            "bootstrap"
        } else {
            &self.config.channel
        };
        cargo.env("__CARGO_DEFAULT_LIB_METADATA", &metadata);
843 844

        let stage;
M
Mark Simulacrum 已提交
845
        if compiler.stage == 0 && self.local_rebuild {
846 847 848 849 850 851
            // Assume the local-rebuild rustc already has stage1 features.
            stage = 1;
        } else {
            stage = compiler.stage;
        }

852 853 854
        let mut extra_args = env::var(&format!("RUSTFLAGS_STAGE_{}", stage)).unwrap_or_default();
        if stage != 0 {
            let s = env::var("RUSTFLAGS_STAGE_NOT_0").unwrap_or_default();
855 856 857
            if !extra_args.is_empty() {
                extra_args.push_str(" ");
            }
858 859 860 861
            extra_args.push_str(&s);
        }

        if !extra_args.is_empty() {
S
Santiago Pastorino 已提交
862 863 864 865 866 867 868 869
            cargo.env(
                "RUSTFLAGS",
                format!(
                    "{} {}",
                    env::var("RUSTFLAGS").unwrap_or_default(),
                    extra_args
                ),
            );
870 871
        }

K
kennytm 已提交
872
        let want_rustdoc = self.doc_tests != DocTests::No;
K
kennytm 已提交
873

874 875 876 877 878 879
        // We synthetically interpret a stage0 compiler used to build tools as a
        // "raw" compiler in that it's the exact snapshot we download. Normally
        // the stage0 build means it uses libraries build by the stage0
        // compiler, but for tools we just use the precompiled libraries that
        // we've downloaded
        let use_snapshot = mode == Mode::ToolBootstrap;
880
        assert!(!use_snapshot || stage == 0 || self.local_rebuild);
881 882 883 884 885 886 887

        let maybe_sysroot = self.sysroot(compiler);
        let sysroot = if use_snapshot {
            self.rustc_snapshot_sysroot()
        } else {
            &maybe_sysroot
        };
M
Mark Rousskov 已提交
888
        let libdir = self.rustc_libdir(compiler);
889

890 891
        // Customize the compiler we're running. Specify the compiler to cargo
        // as our shim and then pass it some various options used to configure
M
Mark Simulacrum 已提交
892
        // how the actual compiler itself is called.
893 894 895
        //
        // These variables are primarily all read by
        // src/bootstrap/bin/{rustc.rs,rustdoc.rs}
S
Santiago Pastorino 已提交
896 897 898 899 900 901 902 903 904
        cargo
            .env("RUSTBUILD_NATIVE_DIR", self.native_dir(target))
            .env("RUSTC", self.out.join("bootstrap/debug/rustc"))
            .env("RUSTC_REAL", self.rustc(compiler))
            .env("RUSTC_STAGE", stage.to_string())
            .env(
                "RUSTC_DEBUG_ASSERTIONS",
                self.config.rust_debug_assertions.to_string(),
            )
905 906
            .env("RUSTC_SYSROOT", &sysroot)
            .env("RUSTC_LIBDIR", &libdir)
S
Santiago Pastorino 已提交
907 908 909 910
            .env("RUSTC_RPATH", self.config.rust_rpath.to_string())
            .env("RUSTDOC", self.out.join("bootstrap/debug/rustdoc"))
            .env(
                "RUSTDOC_REAL",
911
                if cmd == "doc" || cmd == "rustdoc" || (cmd == "test" && want_rustdoc) {
S
Santiago Pastorino 已提交
912 913 914 915 916 917 918
                    self.rustdoc(compiler.host)
                } else {
                    PathBuf::from("/path/to/nowhere/rustdoc/not/required")
                },
            )
            .env("TEST_MIRI", self.config.test_miri.to_string())
            .env("RUSTC_ERROR_METADATA_DST", self.extended_error_dir());
919

920
        if let Some(host_linker) = self.linker(compiler.host) {
O
Oliver Schneider 已提交
921 922
            cargo.env("RUSTC_HOST_LINKER", host_linker);
        }
923
        if let Some(target_linker) = self.linker(target) {
O
Oliver Schneider 已提交
924 925
            cargo.env("RUSTC_TARGET_LINKER", target_linker);
        }
P
penpalperson 已提交
926 927 928
        if let Some(ref error_format) = self.config.rustc_error_format {
            cargo.env("RUSTC_ERROR_FORMAT", error_format);
        }
929
        if cmd != "build" && cmd != "check" && cmd != "rustc" && want_rustdoc {
M
Mark Rousskov 已提交
930
            cargo.env("RUSTDOC_LIBDIR", self.rustc_libdir(compiler));
931
        }
932

C
Collins Abitekaniza 已提交
933
        if mode.is_tool() {
934
            // Tools like cargo and rls don't get debuginfo by default right now, but this can be
935
            // enabled in the config.  Adding debuginfo makes them several times larger.
936 937
            if self.config.rust_debuginfo_tools {
                cargo.env("RUSTC_DEBUGINFO", self.config.rust_debuginfo.to_string());
S
Santiago Pastorino 已提交
938 939 940 941
                cargo.env(
                    "RUSTC_DEBUGINFO_LINES",
                    self.config.rust_debuginfo_lines.to_string(),
                );
942 943
            }
        } else {
944
            cargo.env("RUSTC_DEBUGINFO", self.config.rust_debuginfo.to_string());
S
Santiago Pastorino 已提交
945 946 947 948
            cargo.env(
                "RUSTC_DEBUGINFO_LINES",
                self.config.rust_debuginfo_lines.to_string(),
            );
O
Oliver Schneider 已提交
949
            cargo.env("RUSTC_FORCE_UNSTABLE", "1");
950 951

            // Currently the compiler depends on crates from crates.io, and
952
            // then other crates can depend on the compiler (e.g., proc-macro
M
Mark Simulacrum 已提交
953
            // crates). Let's say, for example that rustc itself depends on the
954 955
            // bitflags crate. If an external crate then depends on the
            // bitflags crate as well, we need to make sure they don't
B
Bastien Orivel 已提交
956
            // conflict, even if they pick the same version of bitflags. We'll
957
            // want to make sure that e.g., a plugin and rustc each get their
958 959 960 961 962 963 964 965 966 967 968 969
            // own copy of bitflags.

            // Cargo ensures that this works in general through the -C metadata
            // flag. This flag will frob the symbols in the binary to make sure
            // they're different, even though the source code is the exact
            // same. To solve this problem for the compiler we extend Cargo's
            // already-passed -C metadata flag with our own. Our rustc.rs
            // wrapper around the actual rustc will detect -C metadata being
            // passed and frob it with this extra string we're passing in.
            cargo.env("RUSTC_METADATA_SUFFIX", "rustc");
        }

970 971 972 973
        if let Some(x) = self.crt_static(target) {
            cargo.env("RUSTC_CRT_STATIC", x.to_string());
        }

974 975 976 977
        if let Some(x) = self.crt_static(compiler.host) {
            cargo.env("RUSTC_HOST_CRT_STATIC", x.to_string());
        }

978 979 980 981
        if let Some(map) = self.build.debuginfo_map(GitRepo::Rustc) {
            cargo.env("RUSTC_DEBUGINFO_MAP", map);
        }

982 983
        // Enable usage of unstable features
        cargo.env("RUSTC_BOOTSTRAP", "1");
M
Mark Simulacrum 已提交
984
        self.add_rust_test_threads(&mut cargo);
985 986 987

        // Almost all of the crates that we compile as part of the bootstrap may
        // have a build script, including the standard library. To compile a
M
Mark Simulacrum 已提交
988
        // build script, however, it itself needs a standard library! This
989
        // introduces a bit of a pickle when we're compiling the standard
M
Mark Simulacrum 已提交
990
        // library itself.
991 992
        //
        // To work around this we actually end up using the snapshot compiler
M
Mark Simulacrum 已提交
993
        // (stage0) for compiling build scripts of the standard library itself.
994 995 996 997 998
        // The stage0 compiler is guaranteed to have a libstd available for use.
        //
        // For other crates, however, we know that we've already got a standard
        // library up and running, so we can use the normal compiler to compile
        // build scripts in that situation.
B
bjorn3 已提交
999
        if mode == Mode::Std {
S
Santiago Pastorino 已提交
1000 1001 1002
            cargo
                .env("RUSTC_SNAPSHOT", &self.initial_rustc)
                .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_snapshot_libdir());
1003
        } else {
S
Santiago Pastorino 已提交
1004 1005 1006
            cargo
                .env("RUSTC_SNAPSHOT", self.rustc(compiler))
                .env("RUSTC_SNAPSHOT_LIBDIR", self.rustc_libdir(compiler));
1007 1008
        }

1009
        if self.config.incremental {
1010
            cargo.env("CARGO_INCREMENTAL", "1");
1011 1012 1013
        } else {
            // Don't rely on any default setting for incr. comp. in Cargo
            cargo.env("CARGO_INCREMENTAL", "0");
1014 1015
        }

M
Mark Simulacrum 已提交
1016
        if let Some(ref on_fail) = self.config.on_fail {
1017 1018 1019
            cargo.env("RUSTC_ON_FAIL", on_fail);
        }

1020 1021 1022 1023
        if self.config.print_step_timings {
            cargo.env("RUSTC_PRINT_STEP_TIMINGS", "1");
        }

J
John Kåre Alsaker 已提交
1024 1025 1026 1027
        if self.config.backtrace_on_ice {
            cargo.env("RUSTC_BACKTRACE_ON_ICE", "1");
        }

L
ljedrz 已提交
1028
        cargo.env("RUSTC_VERBOSE", self.verbosity.to_string());
1029

V
varkor 已提交
1030
        if self.config.deny_warnings {
1031 1032 1033
            cargo.env("RUSTC_DENY_WARNINGS", "1");
        }

O
Oliver Schneider 已提交
1034 1035 1036 1037 1038
        // Throughout the build Cargo can execute a number of build scripts
        // compiling C/C++ code and we need to pass compilers, archivers, flags, etc
        // obtained previously to those build scripts.
        // Build scripts use either the `cc` crate or `configure/make` so we pass
        // the options through environment variables that are fetched and understood by both.
1039 1040
        //
        // FIXME: the guard against msvc shouldn't need to be here
1041 1042 1043 1044 1045
        if target.contains("msvc") {
            if let Some(ref cl) = self.config.llvm_clang_cl {
                cargo.env("CC", cl).env("CXX", cl);
            }
        } else {
1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062
            let ccache = self.config.ccache.as_ref();
            let ccacheify = |s: &Path| {
                let ccache = match ccache {
                    Some(ref s) => s,
                    None => return s.display().to_string(),
                };
                // FIXME: the cc-rs crate only recognizes the literal strings
                // `ccache` and `sccache` when doing caching compilations, so we
                // mirror that here. It should probably be fixed upstream to
                // accept a new env var or otherwise work with custom ccache
                // vars.
                match &ccache[..] {
                    "ccache" | "sccache" => format!("{} {}", ccache, s.display()),
                    _ => s.display().to_string(),
                }
            };
            let cc = ccacheify(&self.cc(target));
1063
            cargo.env(format!("CC_{}", target), &cc);
O
Oliver Schneider 已提交
1064

1065
            let cflags = self.cflags(target, GitRepo::Rustc).join(" ");
S
Santiago Pastorino 已提交
1066
            cargo
1067
                .env(format!("CFLAGS_{}", target), cflags.clone());
O
Oliver Schneider 已提交
1068 1069 1070

            if let Some(ar) = self.ar(target) {
                let ranlib = format!("{} s", ar.display());
S
Santiago Pastorino 已提交
1071 1072
                cargo
                    .env(format!("AR_{}", target), ar)
1073
                    .env(format!("RANLIB_{}", target), ranlib);
O
Oliver Schneider 已提交
1074
            }
1075

M
Mark Simulacrum 已提交
1076
            if let Ok(cxx) = self.cxx(target) {
1077
                let cxx = ccacheify(&cxx);
S
Santiago Pastorino 已提交
1078 1079
                cargo
                    .env(format!("CXX_{}", target), &cxx)
1080
                    .env(format!("CXXFLAGS_{}", target), cflags);
1081 1082 1083
            }
        }

1084
        if (cmd == "build" || cmd == "rustc")
C
Collins Abitekaniza 已提交
1085
            && mode == Mode::Std
S
Santiago Pastorino 已提交
1086 1087
            && self.config.extended
            && compiler.is_final_stage(self)
1088
        {
1089 1090 1091
            cargo.env("RUSTC_SAVE_ANALYSIS", "api".to_string());
        }

O
Oliver Schneider 已提交
1092
        // For `cargo doc` invocations, make rustdoc print the Rust version into the docs
1093
        cargo.env("RUSTDOC_CRATE_VERSION", self.rust_version());
O
Oliver Schneider 已提交
1094

1095 1096 1097 1098 1099
        // Environment variables *required* throughout the build
        //
        // FIXME: should update code to not require this env var
        cargo.env("CFG_COMPILER_HOST_TRIPLE", target);

1100
        // Set this for all builds to make sure doc builds also get it.
1101
        cargo.env("CFG_RELEASE_CHANNEL", &self.config.channel);
1102

1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120
        // This one's a bit tricky. As of the time of this writing the compiler
        // links to the `winapi` crate on crates.io. This crate provides raw
        // bindings to Windows system functions, sort of like libc does for
        // Unix. This crate also, however, provides "import libraries" for the
        // MinGW targets. There's an import library per dll in the windows
        // distribution which is what's linked to. These custom import libraries
        // are used because the winapi crate can reference Windows functions not
        // present in the MinGW import libraries.
        //
        // For example MinGW may ship libdbghelp.a, but it may not have
        // references to all the functions in the dbghelp dll. Instead the
        // custom import library for dbghelp in the winapi crates has all this
        // information.
        //
        // Unfortunately for us though the import libraries are linked by
        // default via `-ldylib=winapi_foo`. That is, they're linked with the
        // `dylib` type with a `winapi_` prefix (so the winapi ones don't
        // conflict with the system MinGW ones). This consequently means that
I
Irina Popa 已提交
1121
        // the binaries we ship of things like rustc_codegen_llvm (aka the rustc_codegen_llvm
1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133
        // DLL) when linked against *again*, for example with procedural macros
        // or plugins, will trigger the propagation logic of `-ldylib`, passing
        // `-lwinapi_foo` to the linker again. This isn't actually available in
        // our distribution, however, so the link fails.
        //
        // To solve this problem we tell winapi to not use its bundled import
        // libraries. This means that it will link to the system MinGW import
        // libraries by default, and the `-ldylib=foo` directives will still get
        // passed to the final linker, but they'll look like `-lfoo` which can
        // be resolved because MinGW has the import library. The downside is we
        // don't get newer functions from Windows, but we don't use any of them
        // anyway.
C
Collins Abitekaniza 已提交
1134
        if !mode.is_tool() {
A
Alex Crichton 已提交
1135 1136
            cargo.env("WINAPI_NO_BUNDLED_LIBRARIES", "1");
        }
1137

C
comex 已提交
1138
        for _ in 1..self.verbosity {
1139 1140
            cargo.arg("-v");
        }
1141

1142 1143 1144 1145 1146 1147 1148 1149 1150
        match (mode, self.config.rust_codegen_units_std, self.config.rust_codegen_units) {
            (Mode::Std, Some(n), _) |
            (Mode::Test, Some(n), _) |
            (_, _, Some(n)) => {
                cargo.env("RUSTC_CODEGEN_UNITS", n.to_string());
            }
            _ => {
                // Don't set anything
            }
1151 1152
        }

O
Oliver Schneider 已提交
1153
        if self.config.rust_optimize {
1154 1155
            // FIXME: cargo bench/install do not accept `--release`
            if cmd != "bench" && cmd != "install" {
O
Oliver Schneider 已提交
1156 1157
                cargo.arg("--release");
            }
1158
        }
1159

M
Mark Simulacrum 已提交
1160
        if self.config.locked_deps {
1161 1162
            cargo.arg("--locked");
        }
M
Mark Simulacrum 已提交
1163
        if self.config.vendor || self.is_sudo {
1164 1165 1166
            cargo.arg("--frozen");
        }

M
Mark Simulacrum 已提交
1167
        self.ci_env.force_coloring_in_ci(&mut cargo);
1168 1169 1170 1171

        cargo
    }

V
varkor 已提交
1172
    /// Ensure that a given step is built, returning its output. This will
1173 1174
    /// cache the step, so it is safe (and good!) to call this as often as
    /// needed to ensure that all dependencies are built.
1175
    pub fn ensure<S: Step>(&'a self, step: S) -> S::Output {
1176 1177
        {
            let mut stack = self.stack.borrow_mut();
1178 1179
            for stack_step in stack.iter() {
                // should skip
S
Santiago Pastorino 已提交
1180 1181 1182 1183
                if stack_step
                    .downcast_ref::<S>()
                    .map_or(true, |stack_step| *stack_step != step)
                {
1184
                    continue;
1185
                }
1186
                let mut out = String::new();
1187
                out += &format!("\n\nCycle in build detected when adding {:?}\n", step);
1188 1189 1190 1191 1192
                for el in stack.iter().rev() {
                    out += &format!("\t{:?}\n", el);
                }
                panic!(out);
            }
1193
            if let Some(out) = self.cache.get(&step) {
1194
                self.verbose(&format!("{}c {:?}", "  ".repeat(stack.len()), step));
1195

1196 1197 1198
                {
                    let mut graph = self.graph.borrow_mut();
                    let parent = self.parent.get();
S
Santiago Pastorino 已提交
1199 1200 1201
                    let us = *self
                        .graph_nodes
                        .borrow_mut()
1202 1203 1204 1205 1206 1207 1208
                        .entry(format!("{:?}", step))
                        .or_insert_with(|| graph.add_node(format!("{:?}", step)));
                    if let Some(parent) = parent {
                        graph.add_edge(parent, us, false);
                    }
                }

1209 1210
                return out;
            }
1211
            self.verbose(&format!("{}> {:?}", "  ".repeat(stack.len()), step));
1212
            stack.push(Box::new(step.clone()));
1213
        }
1214

1215 1216 1217 1218 1219
        let prev_parent = self.parent.get();

        {
            let mut graph = self.graph.borrow_mut();
            let parent = self.parent.get();
S
Santiago Pastorino 已提交
1220 1221 1222
            let us = *self
                .graph_nodes
                .borrow_mut()
1223 1224 1225 1226 1227 1228 1229 1230
                .entry(format!("{:?}", step))
                .or_insert_with(|| graph.add_node(format!("{:?}", step)));
            self.parent.set(Some(us));
            if let Some(parent) = parent {
                graph.add_edge(parent, us, true);
            }
        }

1231 1232 1233 1234 1235 1236 1237 1238 1239 1240
        let (out, dur) = {
            let start = Instant::now();
            let zero = Duration::new(0, 0);
            let parent = self.time_spent_on_dependencies.replace(zero);
            let out = step.clone().run(self);
            let dur = start.elapsed();
            let deps = self.time_spent_on_dependencies.replace(parent + dur);
            (out, dur - deps)
        };

1241 1242
        self.parent.set(prev_parent);

1243
        if self.config.print_step_timings && dur > Duration::from_millis(100) {
S
Santiago Pastorino 已提交
1244 1245 1246 1247 1248 1249
            println!(
                "[TIMING] {:?} -- {}.{:03}",
                step,
                dur.as_secs(),
                dur.subsec_nanos() / 1_000_000
            );
1250 1251
        }

1252 1253
        {
            let mut stack = self.stack.borrow_mut();
1254 1255
            let cur_step = stack.pop().expect("step stack empty");
            assert_eq!(cur_step.downcast_ref(), Some(&step));
1256
        }
S
Santiago Pastorino 已提交
1257 1258 1259 1260 1261
        self.verbose(&format!(
            "{}< {:?}",
            "  ".repeat(self.stack.borrow().len()),
            step
        ));
1262 1263
        self.cache.put(step, out.clone());
        out
1264 1265
    }
}
M
Mark Simulacrum 已提交
1266 1267 1268

#[cfg(test)]
mod __test {
S
Santiago Pastorino 已提交
1269
    use super::*;
L
ljedrz 已提交
1270
    use crate::config::Config;
1271
    use std::thread;
M
Mark Simulacrum 已提交
1272 1273 1274

    fn configure(host: &[&str], target: &[&str]) -> Config {
        let mut config = Config::default_opts();
M
Mark Simulacrum 已提交
1275 1276
        // don't save toolstates
        config.save_toolstates = None;
M
Mark Simulacrum 已提交
1277
        config.run_host_only = true;
1278 1279
        config.dry_run = true;
        // try to avoid spurious failures in dist where we create/delete each others file
S
Santiago Pastorino 已提交
1280 1281 1282 1283 1284 1285
        let dir = config.out.join("tmp-rustbuild-tests").join(
            &thread::current()
                .name()
                .unwrap_or("unknown")
                .replace(":", "-"),
        );
1286 1287
        t!(fs::create_dir_all(&dir));
        config.out = dir;
M
Mark Simulacrum 已提交
1288
        config.build = INTERNER.intern_str("A");
S
Santiago Pastorino 已提交
1289 1290 1291 1292 1293 1294 1295 1296 1297 1298 1299
        config.hosts = vec![config.build]
            .clone()
            .into_iter()
            .chain(host.iter().map(|s| INTERNER.intern_str(s)))
            .collect::<Vec<_>>();
        config.targets = config
            .hosts
            .clone()
            .into_iter()
            .chain(target.iter().map(|s| INTERNER.intern_str(s)))
            .collect::<Vec<_>>();
M
Mark Simulacrum 已提交
1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314
        config
    }

    fn first<A, B>(v: Vec<(A, B)>) -> Vec<A> {
        v.into_iter().map(|(a, _)| a).collect::<Vec<_>>()
    }

    #[test]
    fn dist_baseline() {
        let build = Build::new(configure(&[], &[]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");

S
Santiago Pastorino 已提交
1315 1316 1317 1318 1319 1320 1321 1322 1323 1324 1325 1326 1327 1328 1329 1330 1331
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[dist::Docs { stage: 2, host: a },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[dist::Rustc {
                compiler: Compiler { host: a, stage: 2 }
            },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[dist::Std {
M
Mark Simulacrum 已提交
1332 1333
                compiler: Compiler { host: a, stage: 2 },
                target: a,
S
Santiago Pastorino 已提交
1334 1335
            },]
        );
M
Mark Simulacrum 已提交
1336 1337 1338 1339 1340 1341 1342 1343 1344 1345 1346 1347
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_targets() {
        let build = Build::new(configure(&[], &["B"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");

S
Santiago Pastorino 已提交
1348 1349 1350 1351 1352 1353 1354 1355 1356 1357 1358 1359 1360 1361 1362 1363 1364 1365 1366 1367 1368 1369 1370 1371 1372 1373 1374 1375 1376 1377
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a }, dist::Mingw { host: b },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[dist::Rustc {
                compiler: Compiler { host: a, stage: 2 }
            },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
M
Mark Simulacrum 已提交
1378 1379 1380 1381 1382 1383 1384 1385 1386 1387 1388 1389
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_hosts() {
        let build = Build::new(configure(&["B"], &[]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");

S
Santiago Pastorino 已提交
1390 1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a }, dist::Mingw { host: b },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[
                dist::Rustc {
                    compiler: Compiler { host: a, stage: 2 }
                },
                dist::Rustc {
                    compiler: Compiler { host: b, stage: 2 }
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
M
Mark Simulacrum 已提交
1425 1426 1427 1428 1429 1430 1431 1432 1433 1434 1435 1436 1437
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_targets_and_hosts() {
        let build = Build::new(configure(&["B"], &["C"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

S
Santiago Pastorino 已提交
1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453 1454 1455 1456 1457 1458 1459 1460 1461 1462 1463 1464 1465 1466 1467 1468 1469 1470 1471 1472 1473 1474 1475 1476 1477 1478 1479 1480 1481
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
                dist::Docs { stage: 2, host: c },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[
                dist::Mingw { host: a },
                dist::Mingw { host: b },
                dist::Mingw { host: c },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[
                dist::Rustc {
                    compiler: Compiler { host: a, stage: 2 }
                },
                dist::Rustc {
                    compiler: Compiler { host: b, stage: 2 }
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1482 1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
    }

    #[test]
    fn dist_with_target_flag() {
        let mut config = configure(&["B"], &["C"]);
        config.run_host_only = false; // as-if --target=C was passed
        let build = Build::new(config);
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

S
Santiago Pastorino 已提交
1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
                dist::Docs { stage: 2, host: c },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[
                dist::Mingw { host: a },
                dist::Mingw { host: b },
                dist::Mingw { host: c },
            ]
        );
M
Mark Simulacrum 已提交
1513
        assert_eq!(first(builder.cache.all::<dist::Rustc>()), &[]);
S
Santiago Pastorino 已提交
1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[]);
    }

    #[test]
    fn dist_with_same_targets_and_hosts() {
        let build = Build::new(configure(&["B"], &["B"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Dist), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");

S
Santiago Pastorino 已提交
1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557 1558 1559 1560 1561 1562 1563 1564 1565 1566 1567 1568 1569 1570 1571 1572 1573 1574 1575 1576 1577
        assert_eq!(
            first(builder.cache.all::<dist::Docs>()),
            &[
                dist::Docs { stage: 2, host: a },
                dist::Docs { stage: 2, host: b },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Mingw>()),
            &[dist::Mingw { host: a }, dist::Mingw { host: b },]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Rustc>()),
            &[
                dist::Rustc {
                    compiler: Compiler { host: a, stage: 2 }
                },
                dist::Rustc {
                    compiler: Compiler { host: b, stage: 2 }
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<dist::Std>()),
            &[
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                dist::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
M
Mark Simulacrum 已提交
1578
        assert_eq!(first(builder.cache.all::<dist::Src>()), &[dist::Src]);
S
Santiago Pastorino 已提交
1579 1580 1581 1582 1583 1584 1585 1586 1587 1588 1589 1590 1591 1592 1593 1594 1595 1596 1597 1598 1599 1600 1601 1602 1603 1604 1605 1606 1607 1608 1609 1610 1611 1612 1613 1614 1615 1616 1617 1618 1619 1620 1621 1622 1623 1624 1625 1626 1627 1628 1629 1630 1631 1632 1633 1634 1635 1636 1637 1638 1639 1640 1641 1642 1643 1644 1645
        assert_eq!(
            first(builder.cache.all::<compile::Std>()),
            &[
                compile::Std {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Std {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<compile::Test>()),
            &[
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<compile::Assemble>()),
            &[
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 0 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 1 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 2 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: b, stage: 2 },
                },
            ]
        );
M
Mark Simulacrum 已提交
1646 1647 1648 1649 1650 1651 1652 1653 1654 1655 1656 1657 1658 1659
    }

    #[test]
    fn build_default() {
        let build = Build::new(configure(&["B"], &["C"]));
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Build), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

        assert!(!builder.cache.all::<compile::Std>().is_empty());
        assert!(!builder.cache.all::<compile::Assemble>().is_empty());
S
Santiago Pastorino 已提交
1660 1661 1662 1663 1664 1665 1666 1667 1668 1669 1670 1671 1672 1673 1674 1675 1676 1677 1678 1679 1680 1681 1682 1683 1684 1685 1686 1687 1688 1689 1690 1691 1692 1693 1694 1695 1696 1697 1698 1699 1700 1701 1702 1703 1704 1705 1706 1707 1708 1709 1710 1711 1712 1713 1714 1715 1716 1717 1718 1719 1720 1721 1722 1723 1724 1725 1726 1727 1728 1729 1730 1731 1732 1733 1734 1735 1736 1737 1738 1739 1740 1741 1742
        assert_eq!(
            first(builder.cache.all::<compile::Rustc>()),
            &[
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: b, stage: 2 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: b, stage: 2 },
                    target: b,
                },
            ]
        );

        assert_eq!(
            first(builder.cache.all::<compile::Test>()),
            &[
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1743 1744 1745 1746 1747 1748 1749 1750 1751 1752 1753 1754 1755 1756 1757
    }

    #[test]
    fn build_with_target_flag() {
        let mut config = configure(&["B"], &["C"]);
        config.run_host_only = false;
        let build = Build::new(config);
        let mut builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Build), &[]);

        let a = INTERNER.intern_str("A");
        let b = INTERNER.intern_str("B");
        let c = INTERNER.intern_str("C");

        assert!(!builder.cache.all::<compile::Std>().is_empty());
S
Santiago Pastorino 已提交
1758 1759 1760 1761 1762 1763 1764 1765 1766 1767 1768 1769 1770 1771 1772 1773 1774 1775 1776 1777 1778 1779 1780 1781 1782 1783 1784 1785 1786 1787 1788 1789 1790 1791 1792 1793 1794 1795 1796 1797 1798 1799 1800 1801 1802 1803 1804 1805 1806 1807 1808 1809 1810 1811 1812 1813 1814 1815 1816 1817 1818 1819 1820 1821 1822 1823 1824 1825 1826 1827 1828 1829 1830 1831 1832 1833 1834 1835 1836 1837 1838 1839 1840 1841 1842 1843 1844
        assert_eq!(
            first(builder.cache.all::<compile::Assemble>()),
            &[
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 0 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 1 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: b, stage: 1 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: a, stage: 2 },
                },
                compile::Assemble {
                    target_compiler: Compiler { host: b, stage: 2 },
                },
            ]
        );
        assert_eq!(
            first(builder.cache.all::<compile::Rustc>()),
            &[
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Rustc {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
            ]
        );

        assert_eq!(
            first(builder.cache.all::<compile::Test>()),
            &[
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: a,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 0 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 1 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: b,
                },
                compile::Test {
                    compiler: Compiler { host: a, stage: 2 },
                    target: c,
                },
                compile::Test {
                    compiler: Compiler { host: b, stage: 2 },
                    target: c,
                },
            ]
        );
M
Mark Simulacrum 已提交
1845
    }
K
kennytm 已提交
1846 1847 1848 1849 1850 1851 1852 1853 1854 1855

    #[test]
    fn test_with_no_doc_stage0() {
        let mut config = configure(&[], &[]);
        config.stage = Some(0);
        config.cmd = Subcommand::Test {
            paths: vec!["src/libstd".into()],
            test_args: vec![],
            rustc_args: vec![],
            fail_fast: true,
K
kennytm 已提交
1856
            doc_tests: DocTests::No,
O
Oliver Schneider 已提交
1857
            bless: false,
S
Santiago Pastorino 已提交
1858
            compare_mode: None,
K
kennytm 已提交
1859 1860 1861 1862 1863 1864 1865 1866 1867 1868 1869 1870 1871
        };

        let build = Build::new(config);
        let mut builder = Builder::new(&build);

        let host = INTERNER.intern_str("A");

        builder.run_step_descriptions(
            &[StepDescription::from::<test::Crate>()],
            &["src/libstd".into()],
        );

        // Ensure we don't build any compiler artifacts.
1872
        assert!(!builder.cache.contains::<compile::Rustc>());
S
Santiago Pastorino 已提交
1873 1874 1875
        assert_eq!(
            first(builder.cache.all::<test::Crate>()),
            &[test::Crate {
K
kennytm 已提交
1876 1877
                compiler: Compiler { host, stage: 0 },
                target: host,
C
Collins Abitekaniza 已提交
1878
                mode: Mode::Std,
K
kennytm 已提交
1879 1880
                test_kind: test::TestKind::Test,
                krate: INTERNER.intern_str("std"),
S
Santiago Pastorino 已提交
1881 1882
            },]
        );
K
kennytm 已提交
1883
    }
1884 1885 1886 1887 1888 1889 1890 1891 1892 1893 1894 1895 1896 1897 1898 1899 1900 1901 1902 1903 1904 1905 1906 1907 1908 1909 1910 1911 1912 1913

    #[test]
    fn test_exclude() {
        let mut config = configure(&[], &[]);
        config.exclude = vec![
            "src/test/run-pass".into(),
            "src/tools/tidy".into(),
        ];
        config.cmd = Subcommand::Test {
            paths: Vec::new(),
            test_args: Vec::new(),
            rustc_args: Vec::new(),
            fail_fast: true,
            doc_tests: DocTests::No,
            bless: false,
            compare_mode: None,
        };

        let build = Build::new(config);
        let builder = Builder::new(&build);
        builder.run_step_descriptions(&Builder::get_step_descriptions(Kind::Test), &[]);

        // Ensure we have really excluded run-pass & tidy
        assert!(!builder.cache.contains::<test::RunPass>());
        assert!(!builder.cache.contains::<test::Tidy>());

        // Ensure other tests are not affected.
        assert!(builder.cache.contains::<test::RunPassFullDeps>());
        assert!(builder.cache.contains::<test::RustdocUi>());
    }
M
Mark Simulacrum 已提交
1914
}