* Bloody mutable fields (#10116)

* Fix 9150 --- #i nuget on desktop witout net48 ref assemblies fails. (#10114)

* signing (#10108)
Co-authored-by: NKevin Ransom (msft) <codecutter@hotmail.com>

* Remove parseILGlobals

* Fixed build

* Starting porting DIM consumption work

* Fixing lang support

* Compiles

* Fixing up lang feature support

* Starting to port tests

* Some tests pass

* More tests passing

* Remove flags

* Added infra to test IVT

* Trying to fix more tests

* Remove dead code

* One more test remaining

* Fix test

* Fix ordering in FCS

* Minor comment change

* Update LanguageFeatures.fs

* Get rid of minor format

* Feedback changes in MethodOverrides.fs

* Removed RequiredSlotFlags

* Fixing build

* Added more static interface method tests. Fixing tests.

* Removed IsDefaultInterfaceMethod

* Almost refactored overrides

* A bit better querying for most specific impls

* Final feedback changes

* More optimizations

* Minor formatting

* Added a failing test

* Going to import overrides declaring type

* Accounting for method shadowing

* Fixing tests

* cross-platform wrapper around memory-backed memorymappedfile creation

* reenable FCS tests on non-windows platforms

* publish test results on non-windows platforms

* ensure correct .net sdk versions are installed regardless of VM image preloads

* simple workaround for missing mscorlib versions to TFMs

* publish per-framework xml results and report them in AZDO

* rework mono fixes to use ByteArrayMemory directly

* move runningOnMono call to bytes.fs and patch up callsites

* revert to build-only on mono-containing platforms

another MR will be required to fix the underlying logic before those can be changed to run tests again

* trigger ci

* First step to get rid of ilglobals

* Added ILScopeRef.PrimaryAssembly

* almost

* Fixed

* Fixing build

* Revert ilwrite changes from last commit

* some cleanup

* Trying to fix build

* Trying to fix build

* Adjusting a few cases that use QualifiedName

* Refactor a bit on normalize

* Some cleanup

* Put ctok in local function

* Minor touch up for ILScopeRef matching

* Do not need this function anymore

* Remove ILGlobals dep on getNameOfScopeRef

* Added possiblePrimaryAssemblyRefs

* Fixed build

* Hopefully this fixes the build

* Added EqualsIgnoringVersion to ILAssemblyRef

* Added RemapAssemblyRef

* Use EqualsIgnoringVersion on primaryAssemblyRef check in remap

* Cleanup

* nit style feedback changes

* Removed RemapAssemblyRef. Added stamp that ignores version.

* Fixed build

* Minor format change

* minor name refactoring

* minimizing diff

* Remove IsModuleRef/IsAssemblyRef/ModuleRef/AssemblyRef properties on ILScopeRef

* Use m_typ_Object for scope

* Fixed LOH byte array allocations in the IDE. Unified memory handling for IL and FSharp metadata.

* minor cleanup

* minor cleanup

* rename EmitBytes to EmitByteMemory

* Fixed ByteArrayMemory

* fixing build

* Fixing build again

* Better ReadInt32/ReadUInt16

* ILResourceLocation.Local should use a ReadOnlyByteMemory

* Able to have a ReadOnlyStream

* Using OutOfRangeException according to feedback

* Making ILVersionInfo a struct

* Fixing tests

* Making ILVersionInfo a struct

* Fixing tests

* Microsoft.FSharp.Comiler --> FSharp.Compiler

* Microsoft.FSharp.Build --> FSharp.Build

* fix small mistakes

* fix build

* fix flakey test (?)

* Remove some asses from the codebase

* Remove more asses

* Add decoded ILAttribute representation

* Remove ILAttribute.Data

* Add docs

* We only need to check for mangledGenericTypeNameSym once

* ShortCut name checking

* Reduce number of LastIndexOf calls

* Reduce number of LastIndexOf calls

* Reduce number of LastIndexOf calls

* Incorporate feedback

* Use PrettyNaming.DemangleGenericTypeName instead of ungenericizeTypeName

* Remove couple of double checks

* Update illib.fs

* Update README.md

* Update README.md

* Update README.md

* [RFCs FS-1051, FS-1052, FS-1053] support for span, readonly refs, byref-like structs (#4888)

* initial support for span, readonly refs, byref-like structs

* fix proto build

* make proto work with previous FSharp.Core

* make proto work with previous FSharp.Core

* update baselines

* integrate code cleanup

* integrate code cleanup

* integrate code cleanup

* integrate code cleanup

* fix build

* fix build

* implicit deref of byref returns

* add tests for Memory, ReadOnlySpan and ReadOnlyMemory

* fix tests

* simplify diff

* simplify diff

* remove duplicate error messages

* fix build

* test updates

* fix build

* fix build

* update baselines

* fix uses of NativePtr.toByRef

* switch to inference using byref pointer capabilities

* fix proto build

* update baselines, byref extension methods

* fix test errors

* emit in,out,modreq attributes correctly

* update tests

* fix build

* fix build

* fix tests

* fix tests

* get it right silly boy

* fix test

* minor cleanup

* add more tests

* clarify overloading behaviour + test case

* fix build break

* fix build of tests

* update tests

* add more tests

* byref fixes

* updates for subsumption calls, error message, assign-to-return-byref

* test updates, implicit deref on byref return for normal functions

* update baseline

* improve debug formatting, better error message on implicit deref, improve error messages

* add more tests for recursive functions

* update baselines

* fix baselines

* updates for new test cases

* updates for new test cases

* test updates and byref-to-byreflike

* deal with 'M() <- expr'

* restrict addresses of immutable top-level things

* fix IsByRefLike on struct

* update tests

* fix test

* fix test

* improve check for no-return-of-struct-field-addresses

* fix test case

* Provide fast generic comparer for bool values (#5076)

* provide fast generic comparer for bool values

* formatting

* no completion on name of value and function declaration (#5083)

* LOC CHECKIN | Microsoft/visualfsharp master | 20180604 | Termchange (#5082)

* fix merge

* initial support for span, readonly refs, byref-like structs

* fix proto build

* make proto work with previous FSharp.Core

* make proto work with previous FSharp.Core

* update baselines

* integrate code cleanup

* integrate code cleanup

* integrate code cleanup

* integrate code cleanup

* fix build

* fix build

* implicit deref of byref returns

* add tests for Memory, ReadOnlySpan and ReadOnlyMemory

* fix tests

* simplify diff

* simplify diff

* remove duplicate error messages

* fix build

* test updates

* fix build

* fix build

* update baselines

* fix uses of NativePtr.toByRef

* switch to inference using byref pointer capabilities

* fix proto build

* update baselines, byref extension methods

* fix test errors

* emit in,out,modreq attributes correctly

* update tests

* fix build

* fix build

* fix tests

* fix tests

* get it right silly boy

* fix test

* minor cleanup

* add more tests

* clarify overloading behaviour + test case

* fix build break

* fix build of tests

* update tests

* add more tests

* byref fixes

* updates for subsumption calls, error message, assign-to-return-byref

* test updates, implicit deref on byref return for normal functions

* update baseline

* improve debug formatting, better error message on implicit deref, improve error messages

* add more tests for recursive functions

* update baselines

* fix baselines

* updates for new test cases

* updates for new test cases

* test updates and byref-to-byreflike

* deal with 'M() <- expr'

* restrict addresses of immutable top-level things

* fix IsByRefLike on struct

* update tests

* fix test

* fix test

* improve check for no-return-of-struct-field-addresses

* fix test case

* Add DeclaringEntity

* extend tests to cover namespaces

* extend tests to cover namespaces

* build on Mono 5.10

* bump FCS version

* various comments and debugging improvements

* code review

* Read/store ILCustomAttrs, ILSecurityDecls, ILTypeDef sensibly (#4597)

* hide representation of ILPreTypeDef

* fix build

* remove unnecessary use of lists with repeated tail-appends

* add comment

* fix test

* weak ByteFile

* cleanup, only use in VS

* cleanup flags

* some comments

* some comments

* use Roslyn memory manager for metadata in VS

* report statistics only with --times, clarify flags2

* minor updates

* us in VS

* fix build

* fix build

* fix build

* add SFH to FileSystem

* fix build

* fix build

* fix build

* fix build

* add some comments

* reduce ILEventDef ILPropertyDef and ILFieldDef memory

* Update IlxGen.fs

* reduce ILMethodDef memory

* reduce ILTypeDef memory

* clean redundant functions

* make tuples support Item* with warning

* add deactivated tests for struct tuple

* proper return types for Rest, prototype ctors

* fix SRTP

* fix tests

* fix tests

* add more protection

* improve code for decompiling types

* fix unit tests

* don't rebuild

* make infos systematic to reduce use of tcrefOfAppTy

* update test cases

* fix build

* update test cases

* bump FCS version consistently

* use consistent names

* code review

* rename src/fsharp/vs --> src/fsharp/service

* move unit tests to tests"

* remove some namespace opens

* remove COMPILER_PUBLIC_API

* remove COMPILER_PUBLIC_API

* Use NO_EXTENSIONTYPING for better compiler debugging in normal case

* Update Fsc.fsproj

* Fix attribute references

* For attributes with type arguments only add reference to Nominal types

* Implement `MethodImplOptions.AggressiveInlining` flag - fixes #1637

* More inlining

* remove change to TAST

* fix build

* add test

* Don't convert attributes to array and then to list

* Don't convert attributes to array and then to list