* Bloody mutable fields (#10116)

* Fix 9150 --- #i nuget on desktop witout net48 ref assemblies fails. (#10114)

* signing (#10108)
Co-authored-by: NKevin Ransom (msft) <codecutter@hotmail.com>

* poundi

* baselines

* Don't color disposables differently be default but retain customization

* Update resource strings for settings

* Update surface area tests

* oopsie

* Emitting IsReadOnlyAttribute on return arguments of type inref<_>

* Emitting modreq(InAttribute) on property type and emitting IsReadOnlyAttribute on property

* Correctly getting return type. Added more tests.

* fix 8908 - no method splitting for anonymous record comparison functions

* fix 8908 - no method splitting for anonymous record comparison functions

* tentative fix for 7618

* further part of fix

* testing for various constraints

* testing for various constraints

* consider appropriately annotated type variables to have default constructors and default values

* simplify code

* add extra test case

* add back missing file
Co-authored-by: NPhillip Carter <pcarter@fastmail.com>

* fix 9903

* fix 9903

* fix typo

* Cleanup regarding operator checking in tools

* oops

* Handle invalid anonymous record type declaration

* Update FSComp.txt

* Update lang version for interpolated strings

* error messages

* Nuget package + release notes

* feedback

* fix for https://github.com/dotnet/fsharp/issues/7734

* add test

Eliminate tuple allocations in seekReadCustomAttributeRow via a custom reader for attribute rows (#9218)

* seekReadCustomAttributeRow as a struct 3-tuple

* Read custom attributes via a specialized reader

* Remove CompactFramework-supporting implementations

* Remove unneeded TryDeref and simplify OR logic

* Revert "Remove unneeded TryDeref and simplify OR logic"

This reverts commit 9fb63c26d0f32a47556900f62ac87d8dcb810903.

* remove CompactFramework reference and simplify or logic take 2

* ws cleanup
Co-authored-by: NCharles Roddie <charles.roddie@mathspire.com>

Optimize 'string', remove boxing where possible, prevent FS0670, simplify generic code (RFC-1089) (#9549)

* Merge from Re-enable-tests-for-operators

* Add tests that cover the changes for fixing FS0670

* Un-inline `string` to allow used in generic overrides and types

* Fix 3x C# default impl tests by removing dep. on FSharp.Core.dll

* Implement new 'string' ideas from RFC-1089

* Some housekeeping, adding IFormattable to the list

* Further optimizations for unsigned ints and (u)nativeint

* Adding back 'inline' but not SRTP

* Ignore NCrunch temp files and local user files

* Fix string of enum-of-char

* Fix tests in ExprTests.fs

* Distinguish between FSharp.Core 4.5, 4.6 and 4.7 in tests in ExprTests.fs

* cleanup old formatting code

* cleanup old formatting code

* cleanup old formatting code

* cleanup old formatting code

* cleanup old formatting code

* cleanup old formatting code

* cleanup old formatting code

* cleanup old formatting code

* cleanup old formatting code

* Update sformat.fs

* Fixed generic union type instantiation on open type

* Fixed record type instantiation. Added tests for pattern matching on union and records.

* Consolidating fix

* remove comment

* Renamed field and updated comment

* Minor updates

* Reduce copying and allocations in lexing

* Simplify and improve perf of eval

* Dont create temporary array in discardInput since blit handles overlapping memory

* Fix review comments and update a new method
* rename methods
* remove "new"

* Embed source generated by the build in portable pdbs

* fix tests

* Shipping packages alone are sufficient to test

* pars.fsy: capture empty interpolated string fills and report error

reduce empty interp fill error range, update tests

update error msg 3382

* StringInterp: update test error code

* Remove limitations on custom operation overloads

- Check 1:1 by operation/method names instead of count
- Remove arg count check

(cherry picked from commit 854f080c1fb486e53892894c95cc9351bb04be96)

* Updated baselines

(cherry picked from commit 527eb54fc47802ed742c5fd5aa69a9b6a3d22f25)

* New error messages

(cherry picked from commit cdc765d231fa4b3f39681d0d43cdfeba033009b7)

* Add failing tests based on RFC

* Expand test cases for overloaded CE members

* open Extensions to fix tests

* Fix error with opening missing Extensions module

* Fix unit tests

* Give unique values for each check in CE overload tests

* Add regression scenarios to ensure current functionality does not break for computation expression overloads [FS-1056]

* Rename g to group per code review [FS-1056]

* Hide overloads for custom operations behind feature flag [FS-1056]

* Add feature flag to GetFeatureString

* Add featureOverloadsForCustomOperations to FSComps

* Update FSComp.txt [FS-1056]

* Update baselines [FS-1056]

* Revert "New error messages"

This reverts commit 3ee5a492ecd886793c88236217e5a21f4f1e7b65.
Co-authored-by: NDiego Esmerio <menhowca@gmail.com>
Co-authored-by: NDiego Esmerio <diego.esmerio@fitsolucoes.biz>

* Ensure compiler service builds a package

* Update FSharp.Compiler.Service.fsproj

* do it

* merge

* no pack

* Use package switch

* xlf + csharp_analysis

* feedback

* xlf

* fix build.sh

* Update to fsharp5

* Update preview error messages

* Update error messages

* fix

Fix showing pars.fs, lex.fs output in solution view, fix auto-generating FsLex/FsYacc output on change, add fsl and fsy to solution view (#9918)

* Fix showing pars.fs, lex.fs, pppars.fs and pplex.fs in sln

* Also fix showing ilpars.fs and illex.fs

* Fix automatic run of fslex/fsyacc when file is dirty

* Same for AbsIL lex/yacc output, fix order in sln expl

* Allow using nested types in unqualified scenarios

* Renaming OpenStaticClasses to OpenTypeDeclaration

* Added 'open type' declaration

* Added more tests

* Fixing build

* Added tooling support

* More updates

* Some refactor

* open static prototype

* open static prototype

* Fixes on merge

* Fixing build

* Fixing some tests

* Trying to figure out nested

* Added eUnqualifiedTyconTypeArgs

* Properly opening generic types with nested generic types

* Update test baseline

* Include range on target

* Fixing build

* Fixing build

* Fixing build

* Error if not an appty

* Slightly better error

* Getting tests to pass

* Trying to fix tests

* Get current tests to pass

* Partial working unused opens

* Almost there

* Some fixed

* Reverting back to original service analysis

* Fixed test

* Fixed test

* Fixed build

* Fixing tests

* Fixing tests

* Fixing more tests

* Removing broken tests

* Added more tests. Checking for byrefs

* More tests

* More tests

* Update tests

* Rename

* Better names

* Added test case for inherited members

* Added more tests with CSharp style extension members

* Minor format

* Minor updates

* Fixing nested types

* Fixed nested types possibly

* Trying to fix it

* Some cleanup

* More cleanup

* Partial

* Partially working

* Fixed nested types

* Fixing tests

* Removed NumStaticArgs

* Rename AddEntties/OpenEntities to AddModuleOrNamespaceRefs/OpenModuleOrNamespaceRefs

* minor cleanup

* Minor rename

* Another rename

* Update src/fsharp/symbols/Symbols.fs
Co-authored-by: NPhillip Carter <pcarter@fastmail.com>

* Trying to add type provider test

* Remove type provider test for now

* Starting to convert tests

* More tests converted

* More tests converted

* more tests converted

* Added type provider tests

* Added complex generic types with nested generic types

* Added units of measure tests and named types

* Added more tests

* Added two more tests

* Added one more test

* Added enum test case

* Added enum tests and support

* Adding union case support

* Removing unions support

* Fixing build

* Disallowing operators to come into scope

* Minor refactoring

* Access to record labels and union cases

* Fixing opening generic types

* Do not need to return enclosing type instantiations from a dot

* Added generic union and record tests

* Combining intrinsic and extension method groups. Ignoring generic record/union tests.

* Update FSComp.txt.ja.xlf

* Fixing build

* Update OpenTypeDeclarationTests.fs
Co-authored-by: NDon Syme <dsyme@microsoft.com>
Co-authored-by: NPhillip Carter <pcarter@fastmail.com>