- 09 1月, 2019 27 次提交
-
-
由 Matt Bierner 提交于
Fixes #18131
-
由 Matt Bierner 提交于
-
由 Matt Bierner 提交于
-
由 Matt Bierner 提交于
-
由 Matt Bierner 提交于
-
由 Matt Bierner 提交于
-
由 Matt Bierner 提交于
-
由 Matt Bierner 提交于
-
由 Matt Bierner 提交于
* Switch to use more state machine like state management in progressService **Problem** In progress service, the `ProgressState` object is quite difficult to understand. Only a subset of fields are active at a given time so the state is really more like a state machine. When enabling strict null checks, the existing pattern is also a pain because it is not clear which subset of fields go to gether and will not be undefined **Fix** I've been experimenting with writing states much explicitly. This has two main points: - Encapsulating all state in a single state object (which the progress service already does) - Encoding each valid state very explicitly in a state machine like manner For progress service, the encoding breaks the `ProgressState` object up into five different states that the progress service transitions between. * Use const enum and namespace * Don't allow passing `infinite=false` to progressService This state is currently unused and make no sense. Update the signature to prevent ever trying to go into this state
-
由 Matt Bierner 提交于
This state is currently unused and make no sense. Update the signature to prevent ever trying to go into this state
-
由 Matt Bierner 提交于
-
由 Matt Bierner 提交于
-
由 Matt Bierner 提交于
-
由 Matt Bierner 提交于
This reverts commit 7b375fcb. Reapplies 4a38520d with a fix for #66202 Fixes #66202
-
由 Sandeep Somavarapu 提交于
-
由 Matt Bierner 提交于
**Problem** In progress service, the `ProgressState` object is quite difficult to understand. Only a subset of fields are active at a given time so the state is really more like a state machine. When enabling strict null checks, the existing pattern is also a pain because it is not clear which subset of fields go to gether and will not be undefined **Fix** I've been experimenting with writing states much explicitly. This has two main points: - Encapsulating all state in a single state object (which the progress service already does) - Encoding each valid state very explicitly in a state machine like manner For progress service, the encoding breaks the `ProgressState` object up into five different states that the progress service transitions between.
-
由 Daniel Imms 提交于
Exclude/include commandsToSkipShell instead of butchering user settings file
-
由 Daniel Imms 提交于
-
由 Daniel Imms 提交于
-
由 Daniel Imms 提交于
Just hardcode the command names, it's a soft dep anyway
-
由 Miguel Solorio 提交于
Update Octicons
-
由 Daniel Imms 提交于
-
由 Daniel Imms 提交于
-
由 Daniel Imms 提交于
-
由 Martin Aeschlimann 提交于
-
由 Benjamin Pasero 提交于
-
由 Sandeep Somavarapu 提交于
move rendering marker hover to hover widget
-
- 08 1月, 2019 13 次提交
-
-
由 Sandeep Somavarapu 提交于
-
由 Sandeep Somavarapu 提交于
-
由 Sandeep Somavarapu 提交于
-
由 Alex Dima 提交于
-
由 Johannes Rieken 提交于
-
由 Johannes Rieken 提交于
-
由 Benjamin Pasero 提交于
-
由 Benjamin Pasero 提交于
-
由 Benjamin Pasero 提交于
-
由 vemoo 提交于
* do not generate error when parsing `NamedMultiLineCheckedProblemPattern` * use simplify `MultiLineCheckedProblemPattern.is`
-
由 Benjamin Pasero 提交于
-
由 Benjamin Pasero 提交于
-
由 Joao Moreno 提交于
This reverts commit 4a38520d.
-