提交 f4ab083c 编写于 作者: B Benjamin Pasero

update todos

上级 ca370bdb
...@@ -233,7 +233,7 @@ export class CodeWindow extends Disposable implements ICodeWindow { ...@@ -233,7 +233,7 @@ export class CodeWindow extends Disposable implements ICodeWindow {
this._win.setSheetOffset(22); // offset dialogs by the height of the custom title bar if we have any this._win.setSheetOffset(22); // offset dialogs by the height of the custom title bar if we have any
} }
// TODO@Ben (Electron 4 regression): when running on multiple displays where the target display // TODO@bpasero (Electron 4 regression): when running on multiple displays where the target display
// to open the window has a larger resolution than the primary display, the window will not size // to open the window has a larger resolution than the primary display, the window will not size
// correctly unless we set the bounds again (https://github.com/microsoft/vscode/issues/74872) // correctly unless we set the bounds again (https://github.com/microsoft/vscode/issues/74872)
// //
...@@ -568,7 +568,7 @@ export class CodeWindow extends Disposable implements ICodeWindow { ...@@ -568,7 +568,7 @@ export class CodeWindow extends Disposable implements ICodeWindow {
// Unresponsive // Unresponsive
if (error === WindowError.UNRESPONSIVE) { if (error === WindowError.UNRESPONSIVE) {
if (this.isExtensionDevelopmentHost || this.isExtensionTestHost || (this._win && this._win.webContents && this._win.webContents.isDevToolsOpened())) { if (this.isExtensionDevelopmentHost || this.isExtensionTestHost || (this._win && this._win.webContents && this._win.webContents.isDevToolsOpened())) {
// TODO@Ben Workaround for https://github.com/microsoft/vscode/issues/56994 // TODO@bpasero Workaround for https://github.com/microsoft/vscode/issues/56994
// In certain cases the window can report unresponsiveness because a breakpoint was hit // In certain cases the window can report unresponsiveness because a breakpoint was hit
// and the process is stopped executing. The most typical cases are: // and the process is stopped executing. The most typical cases are:
// - devtools are opened and debugging happens // - devtools are opened and debugging happens
......
...@@ -278,7 +278,7 @@ export interface IFileSystemProvider { ...@@ -278,7 +278,7 @@ export interface IFileSystemProvider {
readonly capabilities: FileSystemProviderCapabilities; readonly capabilities: FileSystemProviderCapabilities;
readonly onDidChangeCapabilities: Event<void>; readonly onDidChangeCapabilities: Event<void>;
readonly onDidErrorOccur?: Event<string>; // TODO@ben remove once file watchers are solid readonly onDidErrorOccur?: Event<string>; // TODO@bpasero remove once file watchers are solid
readonly onDidChangeFile: Event<readonly IFileChange[]>; readonly onDidChangeFile: Event<readonly IFileChange[]>;
watch(resource: URI, opts: IWatchOptions): IDisposable; watch(resource: URI, opts: IWatchOptions): IDisposable;
......
...@@ -522,7 +522,7 @@ export class DiskFileSystemProvider extends Disposable implements ...@@ -522,7 +522,7 @@ export class DiskFileSystemProvider extends Disposable implements
return this.watchRecursive(resource, opts.excludes); return this.watchRecursive(resource, opts.excludes);
} }
return this.watchNonRecursive(resource); // TODO@ben ideally the same watcher can be used in both cases return this.watchNonRecursive(resource); // TODO@bpasero ideally the same watcher can be used in both cases
} }
private watchRecursive(resource: URI, excludes: string[]): IDisposable { private watchRecursive(resource: URI, excludes: string[]): IDisposable {
......
...@@ -55,10 +55,15 @@ export class GotoSymbolQuickAccessProvider extends AbstractGotoSymbolQuickAccess ...@@ -55,10 +55,15 @@ export class GotoSymbolQuickAccessProvider extends AbstractGotoSymbolQuickAccess
} }
protected get activeTextEditorControl() { protected get activeTextEditorControl() {
// TODO@bpasero this distinction should go away by adopting `IOutlineService`
// for all editors (either text based ones or not). Currently text based
// editors are not yet using the new outline service infrastructure but the
// "classical" document symbols approach.
if (isCompositeEditor(this.editorService.activeEditorPane?.getControl())) { if (isCompositeEditor(this.editorService.activeEditorPane?.getControl())) {
// TODO@bpasero adopt IOutlineService for "normal" document symbols.
return undefined; return undefined;
} }
return this.editorService.activeTextEditorControl; return this.editorService.activeTextEditorControl;
} }
......
...@@ -128,7 +128,7 @@ export abstract class AbstractFileOutputChannelModel extends Disposable implemen ...@@ -128,7 +128,7 @@ export abstract class AbstractFileOutputChannelModel extends Disposable implemen
} }
} }
// TODO@ben see if new watchers can cope with spdlog and avoid polling then // TODO@bpasero see if new watchers can cope with spdlog and avoid polling then
class OutputFileListener extends Disposable { class OutputFileListener extends Disposable {
private readonly _onDidContentChange = new Emitter<number | undefined>(); private readonly _onDidContentChange = new Emitter<number | undefined>();
......
...@@ -148,7 +148,7 @@ class DesktopMain extends Disposable { ...@@ -148,7 +148,7 @@ class DesktopMain extends Disposable {
private onWindowResize(e: Event, retry: boolean, workbench: Workbench): void { private onWindowResize(e: Event, retry: boolean, workbench: Workbench): void {
if (e.target === window) { if (e.target === window) {
if (window.document && window.document.body && window.document.body.clientWidth === 0) { if (window.document && window.document.body && window.document.body.clientWidth === 0) {
// TODO@Ben this is an electron issue on macOS when simple fullscreen is enabled // TODO@bpasero this is an electron issue on macOS when simple fullscreen is enabled
// where for some reason the window clientWidth is reported as 0 when switching // where for some reason the window clientWidth is reported as 0 when switching
// between simple fullscreen and normal screen. In that case we schedule the layout // between simple fullscreen and normal screen. In that case we schedule the layout
// call at the next animation frame once, in the hope that the dimensions are // call at the next animation frame once, in the hope that the dimensions are
......
...@@ -120,7 +120,7 @@ class DesktopMain extends Disposable { ...@@ -120,7 +120,7 @@ class DesktopMain extends Disposable {
private onWindowResize(e: Event, retry: boolean, workbench: Workbench): void { private onWindowResize(e: Event, retry: boolean, workbench: Workbench): void {
if (e.target === window) { if (e.target === window) {
if (window.document && window.document.body && window.document.body.clientWidth === 0) { if (window.document && window.document.body && window.document.body.clientWidth === 0) {
// TODO@Ben this is an electron issue on macOS when simple fullscreen is enabled // TODO@bpasero this is an electron issue on macOS when simple fullscreen is enabled
// where for some reason the window clientWidth is reported as 0 when switching // where for some reason the window clientWidth is reported as 0 when switching
// between simple fullscreen and normal screen. In that case we schedule the layout // between simple fullscreen and normal screen. In that case we schedule the layout
// call at the next animation frame once, in the hope that the dimensions are // call at the next animation frame once, in the hope that the dimensions are
......
...@@ -83,7 +83,7 @@ export class TimerService extends AbstractTimerService { ...@@ -83,7 +83,7 @@ export class TimerService extends AbstractTimerService {
//#region cached data logic //#region cached data logic
export function didUseCachedData(): boolean { export function didUseCachedData(): boolean {
// TODO@Ben TODO@Jo need a different way to figure out if cached data was used // TODO@bpasero TODO@jrieken need a different way to figure out if cached data was used
if (context.sandbox) { if (context.sandbox) {
return true; return true;
} }
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册