Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
xxadev
vscode
提交
f4ab083c
V
vscode
项目概览
xxadev
/
vscode
与 Fork 源项目一致
从无法访问的项目Fork
通知
2
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
V
vscode
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
f4ab083c
编写于
1月 04, 2021
作者:
B
Benjamin Pasero
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
update todos
上级
ca370bdb
变更
8
隐藏空白更改
内联
并排
Showing
8 changed file
with
14 addition
and
9 deletion
+14
-9
src/vs/code/electron-main/window.ts
src/vs/code/electron-main/window.ts
+2
-2
src/vs/platform/files/common/files.ts
src/vs/platform/files/common/files.ts
+1
-1
src/vs/platform/files/node/diskFileSystemProvider.ts
src/vs/platform/files/node/diskFileSystemProvider.ts
+1
-1
src/vs/workbench/contrib/codeEditor/browser/quickaccess/gotoSymbolQuickAccess.ts
...b/codeEditor/browser/quickaccess/gotoSymbolQuickAccess.ts
+6
-1
src/vs/workbench/contrib/output/common/outputChannelModel.ts
src/vs/workbench/contrib/output/common/outputChannelModel.ts
+1
-1
src/vs/workbench/electron-browser/desktop.main.ts
src/vs/workbench/electron-browser/desktop.main.ts
+1
-1
src/vs/workbench/electron-sandbox/desktop.main.ts
src/vs/workbench/electron-sandbox/desktop.main.ts
+1
-1
src/vs/workbench/services/timer/electron-sandbox/timerService.ts
...workbench/services/timer/electron-sandbox/timerService.ts
+1
-1
未找到文件。
src/vs/code/electron-main/window.ts
浏览文件 @
f4ab083c
...
...
@@ -233,7 +233,7 @@ export class CodeWindow extends Disposable implements ICodeWindow {
this
.
_win
.
setSheetOffset
(
22
);
// offset dialogs by the height of the custom title bar if we have any
}
// TODO@
Ben
(Electron 4 regression): when running on multiple displays where the target display
// TODO@
bpasero
(Electron 4 regression): when running on multiple displays where the target display
// to open the window has a larger resolution than the primary display, the window will not size
// correctly unless we set the bounds again (https://github.com/microsoft/vscode/issues/74872)
//
...
...
@@ -568,7 +568,7 @@ export class CodeWindow extends Disposable implements ICodeWindow {
// Unresponsive
if
(
error
===
WindowError
.
UNRESPONSIVE
)
{
if
(
this
.
isExtensionDevelopmentHost
||
this
.
isExtensionTestHost
||
(
this
.
_win
&&
this
.
_win
.
webContents
&&
this
.
_win
.
webContents
.
isDevToolsOpened
()))
{
// TODO@
Ben
Workaround for https://github.com/microsoft/vscode/issues/56994
// TODO@
bpasero
Workaround for https://github.com/microsoft/vscode/issues/56994
// In certain cases the window can report unresponsiveness because a breakpoint was hit
// and the process is stopped executing. The most typical cases are:
// - devtools are opened and debugging happens
...
...
src/vs/platform/files/common/files.ts
浏览文件 @
f4ab083c
...
...
@@ -278,7 +278,7 @@ export interface IFileSystemProvider {
readonly
capabilities
:
FileSystemProviderCapabilities
;
readonly
onDidChangeCapabilities
:
Event
<
void
>
;
readonly
onDidErrorOccur
?:
Event
<
string
>
;
// TODO@b
en
remove once file watchers are solid
readonly
onDidErrorOccur
?:
Event
<
string
>
;
// TODO@b
pasero
remove once file watchers are solid
readonly
onDidChangeFile
:
Event
<
readonly
IFileChange
[]
>
;
watch
(
resource
:
URI
,
opts
:
IWatchOptions
):
IDisposable
;
...
...
src/vs/platform/files/node/diskFileSystemProvider.ts
浏览文件 @
f4ab083c
...
...
@@ -522,7 +522,7 @@ export class DiskFileSystemProvider extends Disposable implements
return
this
.
watchRecursive
(
resource
,
opts
.
excludes
);
}
return
this
.
watchNonRecursive
(
resource
);
// TODO@b
en
ideally the same watcher can be used in both cases
return
this
.
watchNonRecursive
(
resource
);
// TODO@b
pasero
ideally the same watcher can be used in both cases
}
private
watchRecursive
(
resource
:
URI
,
excludes
:
string
[]):
IDisposable
{
...
...
src/vs/workbench/contrib/codeEditor/browser/quickaccess/gotoSymbolQuickAccess.ts
浏览文件 @
f4ab083c
...
...
@@ -55,10 +55,15 @@ export class GotoSymbolQuickAccessProvider extends AbstractGotoSymbolQuickAccess
}
protected
get
activeTextEditorControl
()
{
// TODO@bpasero this distinction should go away by adopting `IOutlineService`
// for all editors (either text based ones or not). Currently text based
// editors are not yet using the new outline service infrastructure but the
// "classical" document symbols approach.
if
(
isCompositeEditor
(
this
.
editorService
.
activeEditorPane
?.
getControl
()))
{
// TODO@bpasero adopt IOutlineService for "normal" document symbols.
return
undefined
;
}
return
this
.
editorService
.
activeTextEditorControl
;
}
...
...
src/vs/workbench/contrib/output/common/outputChannelModel.ts
浏览文件 @
f4ab083c
...
...
@@ -128,7 +128,7 @@ export abstract class AbstractFileOutputChannelModel extends Disposable implemen
}
}
// TODO@b
en
see if new watchers can cope with spdlog and avoid polling then
// TODO@b
pasero
see if new watchers can cope with spdlog and avoid polling then
class
OutputFileListener
extends
Disposable
{
private
readonly
_onDidContentChange
=
new
Emitter
<
number
|
undefined
>
();
...
...
src/vs/workbench/electron-browser/desktop.main.ts
浏览文件 @
f4ab083c
...
...
@@ -148,7 +148,7 @@ class DesktopMain extends Disposable {
private
onWindowResize
(
e
:
Event
,
retry
:
boolean
,
workbench
:
Workbench
):
void
{
if
(
e
.
target
===
window
)
{
if
(
window
.
document
&&
window
.
document
.
body
&&
window
.
document
.
body
.
clientWidth
===
0
)
{
// TODO@
Ben
this is an electron issue on macOS when simple fullscreen is enabled
// TODO@
bpasero
this is an electron issue on macOS when simple fullscreen is enabled
// where for some reason the window clientWidth is reported as 0 when switching
// between simple fullscreen and normal screen. In that case we schedule the layout
// call at the next animation frame once, in the hope that the dimensions are
...
...
src/vs/workbench/electron-sandbox/desktop.main.ts
浏览文件 @
f4ab083c
...
...
@@ -120,7 +120,7 @@ class DesktopMain extends Disposable {
private
onWindowResize
(
e
:
Event
,
retry
:
boolean
,
workbench
:
Workbench
):
void
{
if
(
e
.
target
===
window
)
{
if
(
window
.
document
&&
window
.
document
.
body
&&
window
.
document
.
body
.
clientWidth
===
0
)
{
// TODO@
Ben
this is an electron issue on macOS when simple fullscreen is enabled
// TODO@
bpasero
this is an electron issue on macOS when simple fullscreen is enabled
// where for some reason the window clientWidth is reported as 0 when switching
// between simple fullscreen and normal screen. In that case we schedule the layout
// call at the next animation frame once, in the hope that the dimensions are
...
...
src/vs/workbench/services/timer/electron-sandbox/timerService.ts
浏览文件 @
f4ab083c
...
...
@@ -83,7 +83,7 @@ export class TimerService extends AbstractTimerService {
//#region cached data logic
export
function
didUseCachedData
():
boolean
{
// TODO@
Ben TODO@Jo
need a different way to figure out if cached data was used
// TODO@
bpasero TODO@jrieken
need a different way to figure out if cached data was used
if
(
context
.
sandbox
)
{
return
true
;
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录