提交 dbea32ff 编写于 作者: S Sandeep Somavarapu

StatusWidget: Take extension as argument instead of options

上级 ee36050e
......@@ -220,7 +220,7 @@ export class ExtensionEditor extends BaseEditor {
this.name.textContent = extension.displayName;
this.identifier.textContent = `${extension.publisher}.${extension.name}`;
this.transientDisposables.push(this.instantiationService.createInstance(StatusWidget, this.status, { extension }));
this.transientDisposables.push(this.instantiationService.createInstance(StatusWidget, this.status, extension));
this.publisher.textContent = extension.publisherDisplayName;
this.description.textContent = extension.description;
......
......@@ -69,7 +69,7 @@ export class Renderer implements IPagedRenderer<IExtension, ITemplateData> {
const versionWidget = this.instantiationService.createInstance(Label, version, e => e.version);
const installCountWidget = this.instantiationService.createInstance(InstallWidget, installCount, { small: true });
const ratingsWidget = this.instantiationService.createInstance(RatingsWidget, ratings, { small: true });
const statusWidget = this.instantiationService.createInstance(StatusWidget, status);
const statusWidget = this.instantiationService.createInstance(StatusWidget, status, null);
const builtinStatusAction = this.instantiationService.createInstance(BuiltinStatusLabelAction);
const installAction = this.instantiationService.createInstance(CombinedInstallAction);
......
......@@ -44,16 +44,14 @@ export class Label implements IDisposable {
export class StatusWidget implements IDisposable {
private listener: IDisposable;
private _extension: IExtension;
get extension(): IExtension { return this._extension; }
set extension(extension: IExtension) { this._extension = extension; this.render(); }
constructor(
private container: HTMLElement,
private options: IOptions = {},
private _extension: IExtension,
@IExtensionsWorkbenchService extensionsWorkbenchService: IExtensionsWorkbenchService
) {
this._extension = options.extension;
this.render();
this.listener = extensionsWorkbenchService.onChange(this.render, this);
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册