From dbea32ff1af048f36cd7119c9364bc80a0683c83 Mon Sep 17 00:00:00 2001 From: Sandeep Somavarapu Date: Thu, 13 Oct 2016 14:58:20 +0200 Subject: [PATCH] StatusWidget: Take extension as argument instead of options --- .../parts/extensions/electron-browser/extensionEditor.ts | 2 +- .../parts/extensions/electron-browser/extensionsList.ts | 2 +- .../parts/extensions/electron-browser/extensionsWidgets.ts | 4 +--- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts index 86039fd0970..7c67b38c5a3 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts @@ -220,7 +220,7 @@ export class ExtensionEditor extends BaseEditor { this.name.textContent = extension.displayName; this.identifier.textContent = `${extension.publisher}.${extension.name}`; - this.transientDisposables.push(this.instantiationService.createInstance(StatusWidget, this.status, { extension })); + this.transientDisposables.push(this.instantiationService.createInstance(StatusWidget, this.status, extension)); this.publisher.textContent = extension.publisherDisplayName; this.description.textContent = extension.description; diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts index 49290d6fd2b..61adf89f648 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionsList.ts @@ -69,7 +69,7 @@ export class Renderer implements IPagedRenderer { const versionWidget = this.instantiationService.createInstance(Label, version, e => e.version); const installCountWidget = this.instantiationService.createInstance(InstallWidget, installCount, { small: true }); const ratingsWidget = this.instantiationService.createInstance(RatingsWidget, ratings, { small: true }); - const statusWidget = this.instantiationService.createInstance(StatusWidget, status); + const statusWidget = this.instantiationService.createInstance(StatusWidget, status, null); const builtinStatusAction = this.instantiationService.createInstance(BuiltinStatusLabelAction); const installAction = this.instantiationService.createInstance(CombinedInstallAction); diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionsWidgets.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionsWidgets.ts index eca42aa8cf5..bcb8c9221e8 100644 --- a/src/vs/workbench/parts/extensions/electron-browser/extensionsWidgets.ts +++ b/src/vs/workbench/parts/extensions/electron-browser/extensionsWidgets.ts @@ -44,16 +44,14 @@ export class Label implements IDisposable { export class StatusWidget implements IDisposable { private listener: IDisposable; - private _extension: IExtension; get extension(): IExtension { return this._extension; } set extension(extension: IExtension) { this._extension = extension; this.render(); } constructor( private container: HTMLElement, - private options: IOptions = {}, + private _extension: IExtension, @IExtensionsWorkbenchService extensionsWorkbenchService: IExtensionsWorkbenchService ) { - this._extension = options.extension; this.render(); this.listener = extensionsWorkbenchService.onChange(this.render, this); } -- GitLab