提交 b936b570 编写于 作者: R Ramya Achutha Rao

Understanding user interaction in the activity bar

上级 5e945443
......@@ -22,6 +22,7 @@ import { StandardMouseEvent } from 'vs/base/browser/mouseEvent';
import { KeyCode } from 'vs/base/common/keyCodes';
import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
import { ActivityAction, ActivityActionItem, ICompositeBarColors } from 'vs/workbench/browser/parts/compositebar/compositeBarActions';
import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
export class ViewletActivityAction extends ActivityAction {
......@@ -32,7 +33,8 @@ export class ViewletActivityAction extends ActivityAction {
constructor(
activity: IActivity,
@IViewletService private viewletService: IViewletService,
@IPartService private partService: IPartService
@IPartService private partService: IPartService,
@ITelemetryService private telemetryService: ITelemetryService
) {
super(activity);
}
......@@ -54,11 +56,23 @@ export class ViewletActivityAction extends ActivityAction {
// Hide sidebar if selected viewlet already visible
if (sideBarVisible && activeViewlet && activeViewlet.getId() === this.activity.id) {
this.logAction('hide');
return this.partService.setSideBarHidden(true);
}
this.logAction('show');
return this.viewletService.openViewlet(this.activity.id, true).then(() => this.activate());
}
private logAction(action: string) {
/* __GDPR__
"activityBarAction" : {
"viewletId": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"action": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
}
*/
this.telemetryService.publicLog('activityBarAction', { viewletId: this.activity.id, action });
}
}
export class ToggleViewletAction extends Action {
......
......@@ -412,7 +412,7 @@ export class ExtensionEditor extends BaseEditor {
if (this.editorLoadComplete) {
/* __GDPR__
"extensionEditor:navbarChange" : {
"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
"navItem": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
"${include}": [
"${GalleryExtensionTelemetryData}"
]
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册