From b936b570bdf314fee71252a729b65fec2389ff52 Mon Sep 17 00:00:00 2001
From: Ramya Achutha Rao <ramyar@microsoft.com>
Date: Sat, 28 Apr 2018 23:47:38 -0700
Subject: [PATCH] Understanding user interaction in the activity bar

---
 .../parts/activitybar/activitybarActions.ts      | 16 +++++++++++++++-
 .../electron-browser/extensionEditor.ts          |  2 +-
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/src/vs/workbench/browser/parts/activitybar/activitybarActions.ts b/src/vs/workbench/browser/parts/activitybar/activitybarActions.ts
index 96ec92771ac..366b81fe440 100644
--- a/src/vs/workbench/browser/parts/activitybar/activitybarActions.ts
+++ b/src/vs/workbench/browser/parts/activitybar/activitybarActions.ts
@@ -22,6 +22,7 @@ import { StandardMouseEvent } from 'vs/base/browser/mouseEvent';
 import { KeyCode } from 'vs/base/common/keyCodes';
 import { StandardKeyboardEvent } from 'vs/base/browser/keyboardEvent';
 import { ActivityAction, ActivityActionItem, ICompositeBarColors } from 'vs/workbench/browser/parts/compositebar/compositeBarActions';
+import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
 
 export class ViewletActivityAction extends ActivityAction {
 
@@ -32,7 +33,8 @@ export class ViewletActivityAction extends ActivityAction {
 	constructor(
 		activity: IActivity,
 		@IViewletService private viewletService: IViewletService,
-		@IPartService private partService: IPartService
+		@IPartService private partService: IPartService,
+		@ITelemetryService private telemetryService: ITelemetryService
 	) {
 		super(activity);
 	}
@@ -54,11 +56,23 @@ export class ViewletActivityAction extends ActivityAction {
 
 		// Hide sidebar if selected viewlet already visible
 		if (sideBarVisible && activeViewlet && activeViewlet.getId() === this.activity.id) {
+			this.logAction('hide');
 			return this.partService.setSideBarHidden(true);
 		}
 
+		this.logAction('show');
 		return this.viewletService.openViewlet(this.activity.id, true).then(() => this.activate());
 	}
+
+	private logAction(action: string) {
+		/* __GDPR__
+			"activityBarAction" : {
+				"viewletId": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
+				"action": { "classification": "SystemMetaData", "purpose": "FeatureInsight" }
+			}
+		*/
+		this.telemetryService.publicLog('activityBarAction', { viewletId: this.activity.id, action });
+	}
 }
 
 export class ToggleViewletAction extends Action {
diff --git a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts
index bf2fb8027a6..bdcf15d35d8 100644
--- a/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts
+++ b/src/vs/workbench/parts/extensions/electron-browser/extensionEditor.ts
@@ -412,7 +412,7 @@ export class ExtensionEditor extends BaseEditor {
 		if (this.editorLoadComplete) {
 			/* __GDPR__
 				"extensionEditor:navbarChange" : {
-					"recommendationReason": { "classification": "SystemMetaData", "purpose": "FeatureInsight", "isMeasurement": true },
+					"navItem": { "classification": "SystemMetaData", "purpose": "FeatureInsight" },
 					"${include}": [
 						"${GalleryExtensionTelemetryData}"
 					]
-- 
GitLab