We used to use Map<String,Object> as a data store for Descriptor, but this requires a lot of boiler plate code to move values in/out from this Map, making the code uglier.
I modified this to just use XStream like the rest of the Hudson, so that the information can be persisted by simply storing them in fields.
Existing Descriptors are enhanced so that they can convert formats from pre-1.62 XML format.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1126 71c3de6d-444a-0410-be80-ed276b4c234a

Fixed a bug where empty list of recipients of build notification messages causes NPE in Mailer component.

Submitted by:  Vladimir Sizikov
Reviewed by:   Kohsuke

CVS: ----------------------------------------------------------------------
CVS: Issue number:
CVS:   If this change addresses one or more issues,
CVS:   then enter the issue number(s) here.
CVS: Obtained from:
CVS:   If this change has been taken from another system,
CVS:   then name the system in this line, otherwise delete it.
CVS: Submitted by:
CVS:   If this code has been contributed to the project by someone else; i.e.,
CVS:   they sent us a patch or a set of diffs, then include their name/email
CVS:   address here. If this is your work then delete this line.
CVS: Reviewed by:
CVS:   If we are doing pre-commit code reviews and someone else has
CVS:   reviewed your changes, include their name(s) here.
CVS:   If you have not had it reviewed then delete this line.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1124 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1122 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1121 71c3de6d-444a-0410-be80-ed276b4c234a

Modern version of Hudson uses a job result submission via HTTP, so this shouldn't really be an issue at all.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1120 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1115 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1113 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1112 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1109 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1104 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1103 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1102 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1100 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1075 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1074 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1073 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1072 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1071 71c3de6d-444a-0410-be80-ed276b4c234a

If you just return, it will cause an empty page to be rendered, leaving the user clue-less.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1068 71c3de6d-444a-0410-be80-ed276b4c234a

Contrubuted by:  Vladimir Sizikov
Reviewed by:   Kohsuke

So, a new button, similar to "Keep this log" was added: "Delete this build".

The new button only enabled if the build is not marked with "keep this
log forever" - there is no need to delete a build if the user explicitly
stated that this build must be preserved.

When user click on the "Delete" button, he is redirected to
confirmation page, similar to what is currently available for "Delete
Project".

We once again double-check that it's OK to delete the build, and there
are no other projects that depend on this build and wish it to stay.

If we see that the build should not be deleted, a warning shown to
user.

If it's OK to delete the build and user clicks "Yes" button, we delete
it.


git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1067 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1066 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1065 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1063 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1060 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1059 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1058 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1056 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1054 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1051 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1050 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1049 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1048 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1047 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1046 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1045 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1044 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1043 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1042 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1041 71c3de6d-444a-0410-be80-ed276b4c234a

git-svn-id: https://hudson.dev.java.net/svn/hudson/trunk/hudson/main@1040 71c3de6d-444a-0410-be80-ed276b4c234a