提交 329a0201 编写于 作者: K Kohsuke Kawaguchi

fail more gracefully if the header is not provided.

上级 9a13990b
......@@ -27,16 +27,20 @@ import hudson.Functions;
import hudson.model.ModelObject;
import hudson.model.Run;
import org.kohsuke.stapler.Header;
import org.kohsuke.stapler.HttpResponses;
import org.kohsuke.stapler.Stapler;
import org.kohsuke.stapler.StaplerRequest;
import org.kohsuke.stapler.StaplerResponse;
import javax.servlet.ServletException;
import javax.servlet.http.HttpServletResponse;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import static javax.servlet.http.HttpServletResponse.SC_BAD_REQUEST;
/**
* Displays the history of records (normally {@link Run}s) on the side panel.
*
......@@ -151,7 +155,7 @@ public class HistoryWidget<O extends ModelObject,T> extends Widget {
public void doAjax( StaplerRequest req, StaplerResponse rsp,
@Header("n") String n ) throws IOException, ServletException {
// FIXME n can be null if the client behave incorrectly. We should fail gracefully (404?) instead of NPEing
if (n==null) throw HttpResponses.error(SC_BAD_REQUEST,new Exception("Missing the 'n' HTTP header"));
rsp.setContentType("text/html;charset=UTF-8");
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册