From 329a0201885d8882f53b0aa6a6e10b92a90f3c10 Mon Sep 17 00:00:00 2001 From: Kohsuke Kawaguchi Date: Fri, 4 Feb 2011 20:34:09 -0800 Subject: [PATCH] fail more gracefully if the header is not provided. --- core/src/main/java/hudson/widgets/HistoryWidget.java | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/core/src/main/java/hudson/widgets/HistoryWidget.java b/core/src/main/java/hudson/widgets/HistoryWidget.java index 24882058b8..c22ccbabf3 100644 --- a/core/src/main/java/hudson/widgets/HistoryWidget.java +++ b/core/src/main/java/hudson/widgets/HistoryWidget.java @@ -27,16 +27,20 @@ import hudson.Functions; import hudson.model.ModelObject; import hudson.model.Run; import org.kohsuke.stapler.Header; +import org.kohsuke.stapler.HttpResponses; import org.kohsuke.stapler.Stapler; import org.kohsuke.stapler.StaplerRequest; import org.kohsuke.stapler.StaplerResponse; import javax.servlet.ServletException; +import javax.servlet.http.HttpServletResponse; import java.io.IOException; import java.util.ArrayList; import java.util.Iterator; import java.util.List; +import static javax.servlet.http.HttpServletResponse.SC_BAD_REQUEST; + /** * Displays the history of records (normally {@link Run}s) on the side panel. * @@ -151,7 +155,7 @@ public class HistoryWidget extends Widget { public void doAjax( StaplerRequest req, StaplerResponse rsp, @Header("n") String n ) throws IOException, ServletException { - // FIXME n can be null if the client behave incorrectly. We should fail gracefully (404?) instead of NPEing + if (n==null) throw HttpResponses.error(SC_BAD_REQUEST,new Exception("Missing the 'n' HTTP header")); rsp.setContentType("text/html;charset=UTF-8"); -- GitLab