downloader_test.go 58.7 KB
Newer Older
F
Felix Lange 已提交
1
// Copyright 2015 The go-ethereum Authors
2
// This file is part of the go-ethereum library.
F
Felix Lange 已提交
3
//
4
// The go-ethereum library is free software: you can redistribute it and/or modify
F
Felix Lange 已提交
5 6 7 8
// it under the terms of the GNU Lesser General Public License as published by
// the Free Software Foundation, either version 3 of the License, or
// (at your option) any later version.
//
9
// The go-ethereum library is distributed in the hope that it will be useful,
F
Felix Lange 已提交
10
// but WITHOUT ANY WARRANTY; without even the implied warranty of
11
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
F
Felix Lange 已提交
12 13 14
// GNU Lesser General Public License for more details.
//
// You should have received a copy of the GNU Lesser General Public License
15
// along with the go-ethereum library. If not, see <http://www.gnu.org/licenses/>.
F
Felix Lange 已提交
16

17 18 19
package downloader

import (
20
	"errors"
21
	"fmt"
22
	"math/big"
23
	"strings"
24
	"sync"
25
	"sync/atomic"
26 27 28
	"testing"
	"time"

29
	ethereum "github.com/ethereum/go-ethereum"
30 31
	"github.com/ethereum/go-ethereum/common"
	"github.com/ethereum/go-ethereum/core/types"
32
	"github.com/ethereum/go-ethereum/ethdb"
O
obscuren 已提交
33
	"github.com/ethereum/go-ethereum/event"
34
	"github.com/ethereum/go-ethereum/trie"
35 36
)

37
// Reduce some of the parameters to make the tester faster.
38
func init() {
39
	MaxForkAncestry = uint64(10000)
40 41
	blockCacheItems = 1024
	fsHeaderContCheck = 500 * time.Millisecond
42 43 44 45 46 47 48 49 50
}

// downloadTester is a test simulator for mocking out local block chain.
type downloadTester struct {
	downloader *Downloader

	genesis *types.Block   // Genesis blocks used by the tester and peers
	stateDb ethdb.Database // Database used by the tester for syncing from peers
	peerDb  ethdb.Database // Database of the peers containing all data
51
	peers   map[string]*downloadTesterPeer
52 53 54 55 56 57 58 59 60 61 62 63 64

	ownHashes   []common.Hash                  // Hash chain belonging to the tester
	ownHeaders  map[common.Hash]*types.Header  // Headers belonging to the tester
	ownBlocks   map[common.Hash]*types.Block   // Blocks belonging to the tester
	ownReceipts map[common.Hash]types.Receipts // Receipts belonging to the tester
	ownChainTd  map[common.Hash]*big.Int       // Total difficulties of the blocks in the local chain

	lock sync.RWMutex
}

// newTester creates a new downloader test mocker.
func newTester() *downloadTester {
	tester := &downloadTester{
65 66 67 68 69 70 71 72
		genesis:     testGenesis,
		peerDb:      testDB,
		peers:       make(map[string]*downloadTesterPeer),
		ownHashes:   []common.Hash{testGenesis.Hash()},
		ownHeaders:  map[common.Hash]*types.Header{testGenesis.Hash(): testGenesis.Header()},
		ownBlocks:   map[common.Hash]*types.Block{testGenesis.Hash(): testGenesis},
		ownReceipts: map[common.Hash]types.Receipts{testGenesis.Hash(): nil},
		ownChainTd:  map[common.Hash]*big.Int{testGenesis.Hash(): testGenesis.Difficulty()},
73
	}
74
	tester.stateDb = ethdb.NewMemDatabase()
75
	tester.stateDb.Put(testGenesis.Root().Bytes(), []byte{0x00})
76
	tester.downloader = New(FullSync, tester.stateDb, new(event.TypeMux), tester, nil, tester.dropPeer)
77
	return tester
78 79
}

80 81 82 83 84 85
// terminate aborts any operations on the embedded downloader and releases all
// held resources.
func (dl *downloadTester) terminate() {
	dl.downloader.Terminate()
}

86
// sync starts synchronizing with a remote peer, blocking until it completes.
87
func (dl *downloadTester) sync(id string, td *big.Int, mode SyncMode) error {
88
	dl.lock.RLock()
89
	hash := dl.peers[id].chain.headBlock().Hash()
90 91
	// If no particular TD was requested, load from the peer's blockchain
	if td == nil {
92
		td = dl.peers[id].chain.td(hash)
93
	}
94
	dl.lock.RUnlock()
95 96 97 98 99 100 101 102 103 104 105

	// Synchronise with the chosen peer and ensure proper cleanup afterwards
	err := dl.downloader.synchronise(id, hash, td, mode)
	select {
	case <-dl.downloader.cancelCh:
		// Ok, downloader fully cancelled after sync cycle
	default:
		// Downloader is still accepting packets, can block a peer up
		panic("downloader active post sync cycle") // panic will be caught by tester
	}
	return err
O
obscuren 已提交
106 107
}

108
// HasHeader checks if a header is present in the testers canonical chain.
109
func (dl *downloadTester) HasHeader(hash common.Hash, number uint64) bool {
110
	return dl.GetHeaderByHash(hash) != nil
111 112
}

113 114 115
// HasBlock checks if a block is present in the testers canonical chain.
func (dl *downloadTester) HasBlock(hash common.Hash, number uint64) bool {
	return dl.GetBlockByHash(hash) != nil
116 117
}

118 119
// GetHeader retrieves a header from the testers canonical chain.
func (dl *downloadTester) GetHeaderByHash(hash common.Hash) *types.Header {
120 121 122
	dl.lock.RLock()
	defer dl.lock.RUnlock()

123
	return dl.ownHeaders[hash]
124 125
}

126 127
// GetBlock retrieves a block from the testers canonical chain.
func (dl *downloadTester) GetBlockByHash(hash common.Hash) *types.Block {
128 129 130
	dl.lock.RLock()
	defer dl.lock.RUnlock()

131 132 133
	return dl.ownBlocks[hash]
}

134 135
// CurrentHeader retrieves the current head header from the canonical chain.
func (dl *downloadTester) CurrentHeader() *types.Header {
136 137 138
	dl.lock.RLock()
	defer dl.lock.RUnlock()

139
	for i := len(dl.ownHashes) - 1; i >= 0; i-- {
140
		if header := dl.ownHeaders[dl.ownHashes[i]]; header != nil {
141 142 143
			return header
		}
	}
144
	return dl.genesis.Header()
145 146
}

147 148
// CurrentBlock retrieves the current head block from the canonical chain.
func (dl *downloadTester) CurrentBlock() *types.Block {
149 150 151
	dl.lock.RLock()
	defer dl.lock.RUnlock()

152
	for i := len(dl.ownHashes) - 1; i >= 0; i-- {
153
		if block := dl.ownBlocks[dl.ownHashes[i]]; block != nil {
154 155 156
			if _, err := dl.stateDb.Get(block.Root().Bytes()); err == nil {
				return block
			}
157 158
		}
	}
159
	return dl.genesis
160 161
}

162 163
// CurrentFastBlock retrieves the current head fast-sync block from the canonical chain.
func (dl *downloadTester) CurrentFastBlock() *types.Block {
164 165 166 167
	dl.lock.RLock()
	defer dl.lock.RUnlock()

	for i := len(dl.ownHashes) - 1; i >= 0; i-- {
168
		if block := dl.ownBlocks[dl.ownHashes[i]]; block != nil {
169
			return block
170 171
		}
	}
172
	return dl.genesis
173 174
}

175
// FastSyncCommitHead manually sets the head block to a given hash.
176
func (dl *downloadTester) FastSyncCommitHead(hash common.Hash) error {
177
	// For now only check that the state trie is correct
178
	if block := dl.GetBlockByHash(hash); block != nil {
179
		_, err := trie.NewSecure(block.Root(), trie.NewDatabase(dl.stateDb), 0)
180 181 182
		return err
	}
	return fmt.Errorf("non existent block: %x", hash[:4])
183 184
}

185 186
// GetTd retrieves the block's total difficulty from the canonical chain.
func (dl *downloadTester) GetTd(hash common.Hash, number uint64) *big.Int {
187 188 189
	dl.lock.RLock()
	defer dl.lock.RUnlock()

190 191 192
	return dl.ownChainTd[hash]
}

193
// InsertHeaderChain injects a new batch of headers into the simulated chain.
194
func (dl *downloadTester) InsertHeaderChain(headers []*types.Header, checkFreq int) (i int, err error) {
195 196 197
	dl.lock.Lock()
	defer dl.lock.Unlock()

L
Leif Jurvetson 已提交
198
	// Do a quick check, as the blockchain.InsertHeaderChain doesn't insert anything in case of errors
199 200 201 202 203 204 205 206 207
	if _, ok := dl.ownHeaders[headers[0].ParentHash]; !ok {
		return 0, errors.New("unknown parent")
	}
	for i := 1; i < len(headers); i++ {
		if headers[i].ParentHash != headers[i-1].Hash() {
			return i, errors.New("unknown parent")
		}
	}
	// Do a full insert if pre-checks passed
208
	for i, header := range headers {
209 210 211
		if _, ok := dl.ownHeaders[header.Hash()]; ok {
			continue
		}
212 213 214 215 216
		if _, ok := dl.ownHeaders[header.ParentHash]; !ok {
			return i, errors.New("unknown parent")
		}
		dl.ownHashes = append(dl.ownHashes, header.Hash())
		dl.ownHeaders[header.Hash()] = header
217
		dl.ownChainTd[header.Hash()] = new(big.Int).Add(dl.ownChainTd[header.ParentHash], header.Difficulty)
218 219 220 221
	}
	return len(headers), nil
}

222
// InsertChain injects a new batch of blocks into the simulated chain.
223
func (dl *downloadTester) InsertChain(blocks types.Blocks) (i int, err error) {
224 225 226
	dl.lock.Lock()
	defer dl.lock.Unlock()

227
	for i, block := range blocks {
228
		if parent, ok := dl.ownBlocks[block.ParentHash()]; !ok {
229
			return i, errors.New("unknown parent")
230 231
		} else if _, err := dl.stateDb.Get(parent.Root().Bytes()); err != nil {
			return i, fmt.Errorf("unknown parent state %x: %v", parent.Root(), err)
232
		}
233 234 235 236
		if _, ok := dl.ownHeaders[block.Hash()]; !ok {
			dl.ownHashes = append(dl.ownHashes, block.Hash())
			dl.ownHeaders[block.Hash()] = block.Header()
		}
237
		dl.ownBlocks[block.Hash()] = block
238 239
		dl.stateDb.Put(block.Root().Bytes(), []byte{0x00})
		dl.ownChainTd[block.Hash()] = new(big.Int).Add(dl.ownChainTd[block.ParentHash()], block.Difficulty())
240 241 242 243
	}
	return len(blocks), nil
}

244
// InsertReceiptChain injects a new batch of receipts into the simulated chain.
245
func (dl *downloadTester) InsertReceiptChain(blocks types.Blocks, receipts []types.Receipts) (i int, err error) {
246 247 248 249
	dl.lock.Lock()
	defer dl.lock.Unlock()

	for i := 0; i < len(blocks) && i < len(receipts); i++ {
250 251 252
		if _, ok := dl.ownHeaders[blocks[i].Hash()]; !ok {
			return i, errors.New("unknown owner")
		}
253 254 255 256
		if _, ok := dl.ownBlocks[blocks[i].ParentHash()]; !ok {
			return i, errors.New("unknown parent")
		}
		dl.ownBlocks[blocks[i].Hash()] = blocks[i]
257
		dl.ownReceipts[blocks[i].Hash()] = receipts[i]
258 259 260 261
	}
	return len(blocks), nil
}

262 263
// Rollback removes some recently added elements from the chain.
func (dl *downloadTester) Rollback(hashes []common.Hash) {
264 265 266 267 268 269 270 271 272 273 274 275 276 277
	dl.lock.Lock()
	defer dl.lock.Unlock()

	for i := len(hashes) - 1; i >= 0; i-- {
		if dl.ownHashes[len(dl.ownHashes)-1] == hashes[i] {
			dl.ownHashes = dl.ownHashes[:len(dl.ownHashes)-1]
		}
		delete(dl.ownChainTd, hashes[i])
		delete(dl.ownHeaders, hashes[i])
		delete(dl.ownReceipts, hashes[i])
		delete(dl.ownBlocks, hashes[i])
	}
}

278
// newPeer registers a new block download source into the downloader.
279
func (dl *downloadTester) newPeer(id string, version int, chain *testChain) error {
280 281 282
	dl.lock.Lock()
	defer dl.lock.Unlock()

283 284 285
	peer := &downloadTesterPeer{dl: dl, id: id, chain: chain}
	dl.peers[id] = peer
	return dl.downloader.RegisterPeer(id, version, peer)
286 287
}

288 289
// dropPeer simulates a hard peer removal from the connection pool.
func (dl *downloadTester) dropPeer(id string) {
290 291 292
	dl.lock.Lock()
	defer dl.lock.Unlock()

293
	delete(dl.peers, id)
294 295 296
	dl.downloader.UnregisterPeer(id)
}

297
type downloadTesterPeer struct {
298 299 300 301 302
	dl            *downloadTester
	id            string
	lock          sync.RWMutex
	chain         *testChain
	missingStates map[common.Hash]bool // State entries that fast sync should not return
303 304 305
}

// Head constructs a function to retrieve a peer's current head hash
306
// and total difficulty.
307
func (dlp *downloadTesterPeer) Head() (common.Hash, *big.Int) {
308 309
	b := dlp.chain.headBlock()
	return b.Hash(), dlp.chain.td(b.Hash())
310 311
}

312
// RequestHeadersByHash constructs a GetBlockHeaders function based on a hashed
313 314
// origin; associated with a particular peer in the download tester. The returned
// function can be used to retrieve batches of headers from the particular peer.
315
func (dlp *downloadTesterPeer) RequestHeadersByHash(origin common.Hash, amount int, skip int, reverse bool) error {
316 317
	if reverse {
		panic("reverse header requests not supported")
318
	}
319

320 321 322
	result := dlp.chain.headersByHash(origin, amount, skip)
	go dlp.dl.downloader.DeliverHeaders(dlp.id, result)
	return nil
323 324
}

325
// RequestHeadersByNumber constructs a GetBlockHeaders function based on a numbered
326 327
// origin; associated with a particular peer in the download tester. The returned
// function can be used to retrieve batches of headers from the particular peer.
328
func (dlp *downloadTesterPeer) RequestHeadersByNumber(origin uint64, amount int, skip int, reverse bool) error {
329 330
	if reverse {
		panic("reverse header requests not supported")
331
	}
332 333 334

	result := dlp.chain.headersByNumber(origin, amount, skip)
	go dlp.dl.downloader.DeliverHeaders(dlp.id, result)
335
	return nil
336 337
}

338
// RequestBodies constructs a getBlockBodies method associated with a particular
339 340
// peer in the download tester. The returned function can be used to retrieve
// batches of block bodies from the particularly requested peer.
341
func (dlp *downloadTesterPeer) RequestBodies(hashes []common.Hash) error {
342 343
	txs, uncles := dlp.chain.bodies(hashes)
	go dlp.dl.downloader.DeliverBodies(dlp.id, txs, uncles)
344
	return nil
345 346
}

347
// RequestReceipts constructs a getReceipts method associated with a particular
348 349
// peer in the download tester. The returned function can be used to retrieve
// batches of block receipts from the particularly requested peer.
350
func (dlp *downloadTesterPeer) RequestReceipts(hashes []common.Hash) error {
351 352
	receipts := dlp.chain.receipts(hashes)
	go dlp.dl.downloader.DeliverReceipts(dlp.id, receipts)
353
	return nil
354 355
}

356
// RequestNodeData constructs a getNodeData method associated with a particular
357 358
// peer in the download tester. The returned function can be used to retrieve
// batches of node state data from the particularly requested peer.
359 360 361 362 363 364 365
func (dlp *downloadTesterPeer) RequestNodeData(hashes []common.Hash) error {
	dlp.dl.lock.RLock()
	defer dlp.dl.lock.RUnlock()

	results := make([][]byte, 0, len(hashes))
	for _, hash := range hashes {
		if data, err := dlp.dl.peerDb.Get(hash.Bytes()); err == nil {
366
			if !dlp.missingStates[hash] {
367
				results = append(results, data)
368 369 370
			}
		}
	}
371 372
	go dlp.dl.downloader.DeliverNodeData(dlp.id, results)
	return nil
373 374
}

375 376 377
// assertOwnChain checks if the local chain contains the correct number of items
// of the various chain components.
func assertOwnChain(t *testing.T, tester *downloadTester, length int) {
378 379 380 381 382 383 384
	assertOwnForkedChain(t, tester, 1, []int{length})
}

// assertOwnForkedChain checks if the local forked chain contains the correct
// number of items of the various chain components.
func assertOwnForkedChain(t *testing.T, tester *downloadTester, common int, lengths []int) {
	// Initialize the counters for the first fork
385
	headers, blocks, receipts := lengths[0], lengths[0], lengths[0]-fsMinFullBlocks
386

387 388
	if receipts < 0 {
		receipts = 1
389 390 391 392 393
	}
	// Update the counters for each subsequent fork
	for _, length := range lengths[1:] {
		headers += length - common
		blocks += length - common
394
		receipts += length - common - fsMinFullBlocks
395
	}
396 397
	switch tester.downloader.mode {
	case FullSync:
398
		receipts = 1
399
	case LightSync:
400
		blocks, receipts = 1, 1
401 402 403 404 405 406 407
	}
	if hs := len(tester.ownHeaders); hs != headers {
		t.Fatalf("synchronised headers mismatch: have %v, want %v", hs, headers)
	}
	if bs := len(tester.ownBlocks); bs != blocks {
		t.Fatalf("synchronised blocks mismatch: have %v, want %v", bs, blocks)
	}
408 409
	if rs := len(tester.ownReceipts); rs != receipts {
		t.Fatalf("synchronised receipts mismatch: have %v, want %v", rs, receipts)
410 411 412
	}
}

413 414 415
// Tests that simple synchronization against a canonical chain works correctly.
// In this test common ancestor lookup should be short circuited and not require
// binary searching.
416 417 418 419 420 421 422 423
func TestCanonicalSynchronisation62(t *testing.T)      { testCanonicalSynchronisation(t, 62, FullSync) }
func TestCanonicalSynchronisation63Full(t *testing.T)  { testCanonicalSynchronisation(t, 63, FullSync) }
func TestCanonicalSynchronisation63Fast(t *testing.T)  { testCanonicalSynchronisation(t, 63, FastSync) }
func TestCanonicalSynchronisation64Full(t *testing.T)  { testCanonicalSynchronisation(t, 64, FullSync) }
func TestCanonicalSynchronisation64Fast(t *testing.T)  { testCanonicalSynchronisation(t, 64, FastSync) }
func TestCanonicalSynchronisation64Light(t *testing.T) { testCanonicalSynchronisation(t, 64, LightSync) }

func testCanonicalSynchronisation(t *testing.T, protocol int, mode SyncMode) {
424 425
	t.Parallel()

426
	tester := newTester()
427 428
	defer tester.terminate()

429
	// Create a small enough block chain to download
430 431
	chain := testChainBase.shorten(blockCacheItems - 15)
	tester.newPeer("peer", protocol, chain)
432

433
	// Synchronise with the peer and make sure all relevant data was retrieved
434
	if err := tester.sync("peer", nil, mode); err != nil {
435
		t.Fatalf("failed to synchronise blocks: %v", err)
436
	}
437
	assertOwnChain(t, tester, chain.len())
438 439
}

440 441
// Tests that if a large batch of blocks are being downloaded, it is throttled
// until the cached blocks are retrieved.
442 443 444 445 446 447 448
func TestThrottling62(t *testing.T)     { testThrottling(t, 62, FullSync) }
func TestThrottling63Full(t *testing.T) { testThrottling(t, 63, FullSync) }
func TestThrottling63Fast(t *testing.T) { testThrottling(t, 63, FastSync) }
func TestThrottling64Full(t *testing.T) { testThrottling(t, 64, FullSync) }
func TestThrottling64Fast(t *testing.T) { testThrottling(t, 64, FastSync) }

func testThrottling(t *testing.T, protocol int, mode SyncMode) {
449
	t.Parallel()
450
	tester := newTester()
451 452
	defer tester.terminate()

453
	// Create a long block chain to download and the tester
454 455
	targetBlocks := testChainBase.len() - 1
	tester.newPeer("peer", protocol, testChainBase)
456

457
	// Wrap the importer to allow stepping
458
	blocked, proceed := uint32(0), make(chan struct{})
459 460
	tester.downloader.chainInsertHook = func(results []*fetchResult) {
		atomic.StoreUint32(&blocked, uint32(len(results)))
461
		<-proceed
462
	}
463 464 465
	// Start a synchronisation concurrently
	errc := make(chan error)
	go func() {
466
		errc <- tester.sync("peer", nil, mode)
467 468
	}()
	// Iteratively take some blocks, always checking the retrieval count
469 470 471 472 473 474 475 476
	for {
		// Check the retrieval count synchronously (! reason for this ugly block)
		tester.lock.RLock()
		retrieved := len(tester.ownBlocks)
		tester.lock.RUnlock()
		if retrieved >= targetBlocks+1 {
			break
		}
477
		// Wait a bit for sync to throttle itself
478
		var cached, frozen int
479
		for start := time.Now(); time.Since(start) < 3*time.Second; {
480
			time.Sleep(25 * time.Millisecond)
481

482 483
			tester.lock.Lock()
			tester.downloader.queue.lock.Lock()
484 485 486
			cached = len(tester.downloader.queue.blockDonePool)
			if mode == FastSync {
				if receipts := len(tester.downloader.queue.receiptDonePool); receipts < cached {
487
					cached = receipts
488 489
				}
			}
490 491
			frozen = int(atomic.LoadUint32(&blocked))
			retrieved = len(tester.ownBlocks)
492 493
			tester.downloader.queue.lock.Unlock()
			tester.lock.Unlock()
494

495
			if cached == blockCacheItems || cached == blockCacheItems-reorgProtHeaderDelay || retrieved+cached+frozen == targetBlocks+1 || retrieved+cached+frozen == targetBlocks+1-reorgProtHeaderDelay {
496 497 498
				break
			}
		}
499 500
		// Make sure we filled up the cache, then exhaust it
		time.Sleep(25 * time.Millisecond) // give it a chance to screw up
501 502 503 504

		tester.lock.RLock()
		retrieved = len(tester.ownBlocks)
		tester.lock.RUnlock()
505
		if cached != blockCacheItems && cached != blockCacheItems-reorgProtHeaderDelay && retrieved+cached+frozen != targetBlocks+1 && retrieved+cached+frozen != targetBlocks+1-reorgProtHeaderDelay {
506
			t.Fatalf("block count mismatch: have %v, want %v (owned %v, blocked %v, target %v)", cached, blockCacheItems, retrieved, frozen, targetBlocks+1)
507
		}
508 509 510 511
		// Permit the blocked blocks to import
		if atomic.LoadUint32(&blocked) > 0 {
			atomic.StoreUint32(&blocked, uint32(0))
			proceed <- struct{}{}
512
		}
513 514
	}
	// Check that we haven't pulled more blocks than available
515
	assertOwnChain(t, tester, targetBlocks+1)
516 517
	if err := <-errc; err != nil {
		t.Fatalf("block synchronization failed: %v", err)
518 519
	}
}
520

521 522 523
// Tests that simple synchronization against a forked chain works correctly. In
// this test common ancestor lookup should *not* be short circuited, and a full
// binary search should be executed.
524 525 526 527 528 529 530 531
func TestForkedSync62(t *testing.T)      { testForkedSync(t, 62, FullSync) }
func TestForkedSync63Full(t *testing.T)  { testForkedSync(t, 63, FullSync) }
func TestForkedSync63Fast(t *testing.T)  { testForkedSync(t, 63, FastSync) }
func TestForkedSync64Full(t *testing.T)  { testForkedSync(t, 64, FullSync) }
func TestForkedSync64Fast(t *testing.T)  { testForkedSync(t, 64, FastSync) }
func TestForkedSync64Light(t *testing.T) { testForkedSync(t, 64, LightSync) }

func testForkedSync(t *testing.T, protocol int, mode SyncMode) {
532 533
	t.Parallel()

534
	tester := newTester()
535 536
	defer tester.terminate()

537 538 539 540
	chainA := testChainForkLightA.shorten(testChainBase.len() + 80)
	chainB := testChainForkLightB.shorten(testChainBase.len() + 80)
	tester.newPeer("fork A", protocol, chainA)
	tester.newPeer("fork B", protocol, chainB)
541 542

	// Synchronise with the peer and make sure all blocks were retrieved
543
	if err := tester.sync("fork A", nil, mode); err != nil {
544 545
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
546
	assertOwnChain(t, tester, chainA.len())
547

548
	// Synchronise with the second peer and make sure that fork is pulled too
549
	if err := tester.sync("fork B", nil, mode); err != nil {
550 551
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
552
	assertOwnForkedChain(t, tester, testChainBase.len(), []int{chainA.len(), chainB.len()})
553 554
}

555 556 557 558 559 560 561 562 563 564 565 566 567
// Tests that synchronising against a much shorter but much heavyer fork works
// corrently and is not dropped.
func TestHeavyForkedSync62(t *testing.T)      { testHeavyForkedSync(t, 62, FullSync) }
func TestHeavyForkedSync63Full(t *testing.T)  { testHeavyForkedSync(t, 63, FullSync) }
func TestHeavyForkedSync63Fast(t *testing.T)  { testHeavyForkedSync(t, 63, FastSync) }
func TestHeavyForkedSync64Full(t *testing.T)  { testHeavyForkedSync(t, 64, FullSync) }
func TestHeavyForkedSync64Fast(t *testing.T)  { testHeavyForkedSync(t, 64, FastSync) }
func TestHeavyForkedSync64Light(t *testing.T) { testHeavyForkedSync(t, 64, LightSync) }

func testHeavyForkedSync(t *testing.T, protocol int, mode SyncMode) {
	t.Parallel()

	tester := newTester()
568 569
	defer tester.terminate()

570 571 572 573
	chainA := testChainForkLightA.shorten(testChainBase.len() + 80)
	chainB := testChainForkHeavy.shorten(testChainBase.len() + 80)
	tester.newPeer("light", protocol, chainA)
	tester.newPeer("heavy", protocol, chainB)
574 575 576 577 578

	// Synchronise with the peer and make sure all blocks were retrieved
	if err := tester.sync("light", nil, mode); err != nil {
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
579
	assertOwnChain(t, tester, chainA.len())
580 581 582 583 584

	// Synchronise with the second peer and make sure that fork is pulled too
	if err := tester.sync("heavy", nil, mode); err != nil {
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
585
	assertOwnForkedChain(t, tester, testChainBase.len(), []int{chainA.len(), chainB.len()})
586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601
}

// Tests that chain forks are contained within a certain interval of the current
// chain head, ensuring that malicious peers cannot waste resources by feeding
// long dead chains.
func TestBoundedForkedSync62(t *testing.T)      { testBoundedForkedSync(t, 62, FullSync) }
func TestBoundedForkedSync63Full(t *testing.T)  { testBoundedForkedSync(t, 63, FullSync) }
func TestBoundedForkedSync63Fast(t *testing.T)  { testBoundedForkedSync(t, 63, FastSync) }
func TestBoundedForkedSync64Full(t *testing.T)  { testBoundedForkedSync(t, 64, FullSync) }
func TestBoundedForkedSync64Fast(t *testing.T)  { testBoundedForkedSync(t, 64, FastSync) }
func TestBoundedForkedSync64Light(t *testing.T) { testBoundedForkedSync(t, 64, LightSync) }

func testBoundedForkedSync(t *testing.T, protocol int, mode SyncMode) {
	t.Parallel()

	tester := newTester()
602 603
	defer tester.terminate()

604 605 606 607
	chainA := testChainForkLightA
	chainB := testChainForkLightB
	tester.newPeer("original", protocol, chainA)
	tester.newPeer("rewriter", protocol, chainB)
608 609 610 611 612

	// Synchronise with the peer and make sure all blocks were retrieved
	if err := tester.sync("original", nil, mode); err != nil {
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
613
	assertOwnChain(t, tester, chainA.len())
614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634

	// Synchronise with the second peer and ensure that the fork is rejected to being too old
	if err := tester.sync("rewriter", nil, mode); err != errInvalidAncestor {
		t.Fatalf("sync failure mismatch: have %v, want %v", err, errInvalidAncestor)
	}
}

// Tests that chain forks are contained within a certain interval of the current
// chain head for short but heavy forks too. These are a bit special because they
// take different ancestor lookup paths.
func TestBoundedHeavyForkedSync62(t *testing.T)      { testBoundedHeavyForkedSync(t, 62, FullSync) }
func TestBoundedHeavyForkedSync63Full(t *testing.T)  { testBoundedHeavyForkedSync(t, 63, FullSync) }
func TestBoundedHeavyForkedSync63Fast(t *testing.T)  { testBoundedHeavyForkedSync(t, 63, FastSync) }
func TestBoundedHeavyForkedSync64Full(t *testing.T)  { testBoundedHeavyForkedSync(t, 64, FullSync) }
func TestBoundedHeavyForkedSync64Fast(t *testing.T)  { testBoundedHeavyForkedSync(t, 64, FastSync) }
func TestBoundedHeavyForkedSync64Light(t *testing.T) { testBoundedHeavyForkedSync(t, 64, LightSync) }

func testBoundedHeavyForkedSync(t *testing.T, protocol int, mode SyncMode) {
	t.Parallel()

	tester := newTester()
635 636
	defer tester.terminate()

637
	// Create a long enough forked chain
638 639 640 641
	chainA := testChainForkLightA
	chainB := testChainForkHeavy
	tester.newPeer("original", protocol, chainA)
	tester.newPeer("heavy-rewriter", protocol, chainB)
642 643 644 645 646

	// Synchronise with the peer and make sure all blocks were retrieved
	if err := tester.sync("original", nil, mode); err != nil {
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
647
	assertOwnChain(t, tester, chainA.len())
648 649 650 651 652 653 654

	// Synchronise with the second peer and ensure that the fork is rejected to being too old
	if err := tester.sync("heavy-rewriter", nil, mode); err != errInvalidAncestor {
		t.Fatalf("sync failure mismatch: have %v, want %v", err, errInvalidAncestor)
	}
}

655 656
// Tests that an inactive downloader will not accept incoming block headers and
// bodies.
657
func TestInactiveDownloader62(t *testing.T) {
658
	t.Parallel()
659

660
	tester := newTester()
661
	defer tester.terminate()
662 663 664

	// Check that neither block headers nor bodies are accepted
	if err := tester.downloader.DeliverHeaders("bad peer", []*types.Header{}); err != errNoSyncActive {
665 666
		t.Errorf("error mismatch: have %v, want %v", err, errNoSyncActive)
	}
667
	if err := tester.downloader.DeliverBodies("bad peer", [][]*types.Transaction{}, [][]*types.Header{}); err != errNoSyncActive {
668
		t.Errorf("error mismatch: have %v, want  %v", err, errNoSyncActive)
669 670 671
	}
}

672 673 674
// Tests that an inactive downloader will not accept incoming block headers,
// bodies and receipts.
func TestInactiveDownloader63(t *testing.T) {
675
	t.Parallel()
676

677
	tester := newTester()
678
	defer tester.terminate()
679 680 681 682 683 684 685 686 687 688 689 690

	// Check that neither block headers nor bodies are accepted
	if err := tester.downloader.DeliverHeaders("bad peer", []*types.Header{}); err != errNoSyncActive {
		t.Errorf("error mismatch: have %v, want %v", err, errNoSyncActive)
	}
	if err := tester.downloader.DeliverBodies("bad peer", [][]*types.Transaction{}, [][]*types.Header{}); err != errNoSyncActive {
		t.Errorf("error mismatch: have %v, want %v", err, errNoSyncActive)
	}
	if err := tester.downloader.DeliverReceipts("bad peer", [][]*types.Receipt{}); err != errNoSyncActive {
		t.Errorf("error mismatch: have %v, want %v", err, errNoSyncActive)
	}
}
691

692 693 694 695 696 697 698 699 700
// Tests that a canceled download wipes all previously accumulated state.
func TestCancel62(t *testing.T)      { testCancel(t, 62, FullSync) }
func TestCancel63Full(t *testing.T)  { testCancel(t, 63, FullSync) }
func TestCancel63Fast(t *testing.T)  { testCancel(t, 63, FastSync) }
func TestCancel64Full(t *testing.T)  { testCancel(t, 64, FullSync) }
func TestCancel64Fast(t *testing.T)  { testCancel(t, 64, FastSync) }
func TestCancel64Light(t *testing.T) { testCancel(t, 64, LightSync) }

func testCancel(t *testing.T, protocol int, mode SyncMode) {
701 702
	t.Parallel()

703 704 705
	tester := newTester()
	defer tester.terminate()

706 707
	chain := testChainBase.shorten(MaxHeaderFetch)
	tester.newPeer("peer", protocol, chain)
708 709

	// Make sure canceling works with a pristine downloader
710
	tester.downloader.Cancel()
711 712
	if !tester.downloader.queue.Idle() {
		t.Errorf("download queue not idle")
713 714
	}
	// Synchronise with the peer, but cancel afterwards
715
	if err := tester.sync("peer", nil, mode); err != nil {
716 717
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
718
	tester.downloader.Cancel()
719 720
	if !tester.downloader.queue.Idle() {
		t.Errorf("download queue not idle")
721 722 723
	}
}

724
// Tests that synchronisation from multiple peers works as intended (multi thread sanity test).
725 726 727 728 729 730 731 732
func TestMultiSynchronisation62(t *testing.T)      { testMultiSynchronisation(t, 62, FullSync) }
func TestMultiSynchronisation63Full(t *testing.T)  { testMultiSynchronisation(t, 63, FullSync) }
func TestMultiSynchronisation63Fast(t *testing.T)  { testMultiSynchronisation(t, 63, FastSync) }
func TestMultiSynchronisation64Full(t *testing.T)  { testMultiSynchronisation(t, 64, FullSync) }
func TestMultiSynchronisation64Fast(t *testing.T)  { testMultiSynchronisation(t, 64, FastSync) }
func TestMultiSynchronisation64Light(t *testing.T) { testMultiSynchronisation(t, 64, LightSync) }

func testMultiSynchronisation(t *testing.T, protocol int, mode SyncMode) {
733 734
	t.Parallel()

735 736 737
	tester := newTester()
	defer tester.terminate()

738
	// Create various peers with various parts of the chain
739
	targetPeers := 8
740
	chain := testChainBase.shorten(targetPeers * 100)
741

742 743
	for i := 0; i < targetPeers; i++ {
		id := fmt.Sprintf("peer #%d", i)
744
		tester.newPeer(id, protocol, chain.shorten(chain.len()/(i+1)))
745
	}
746
	if err := tester.sync("peer #0", nil, mode); err != nil {
747 748
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
749
	assertOwnChain(t, tester, chain.len())
750 751
}

752
// Tests that synchronisations behave well in multi-version protocol environments
L
Leif Jurvetson 已提交
753
// and not wreak havoc on other nodes in the network.
754 755 756 757 758 759 760 761
func TestMultiProtoSynchronisation62(t *testing.T)      { testMultiProtoSync(t, 62, FullSync) }
func TestMultiProtoSynchronisation63Full(t *testing.T)  { testMultiProtoSync(t, 63, FullSync) }
func TestMultiProtoSynchronisation63Fast(t *testing.T)  { testMultiProtoSync(t, 63, FastSync) }
func TestMultiProtoSynchronisation64Full(t *testing.T)  { testMultiProtoSync(t, 64, FullSync) }
func TestMultiProtoSynchronisation64Fast(t *testing.T)  { testMultiProtoSync(t, 64, FastSync) }
func TestMultiProtoSynchronisation64Light(t *testing.T) { testMultiProtoSync(t, 64, LightSync) }

func testMultiProtoSync(t *testing.T, protocol int, mode SyncMode) {
762 763
	t.Parallel()

764 765 766
	tester := newTester()
	defer tester.terminate()

767
	// Create a small enough block chain to download
768
	chain := testChainBase.shorten(blockCacheItems - 15)
769 770

	// Create peers of every type
771 772 773
	tester.newPeer("peer 62", 62, chain)
	tester.newPeer("peer 63", 63, chain)
	tester.newPeer("peer 64", 64, chain)
774

775 776
	// Synchronise with the requested peer and make sure all blocks were retrieved
	if err := tester.sync(fmt.Sprintf("peer %d", protocol), nil, mode); err != nil {
777 778
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
779
	assertOwnChain(t, tester, chain.len())
780

781
	// Check that no peers have been dropped off
782
	for _, version := range []int{62, 63, 64} {
783
		peer := fmt.Sprintf("peer %d", version)
784
		if _, ok := tester.peers[peer]; !ok {
785 786 787 788 789
			t.Errorf("%s dropped", peer)
		}
	}
}

790
// Tests that if a block is empty (e.g. header only), no body request should be
791
// made, and instead the header should be assembled into a whole block in itself.
792 793 794 795 796 797 798 799
func TestEmptyShortCircuit62(t *testing.T)      { testEmptyShortCircuit(t, 62, FullSync) }
func TestEmptyShortCircuit63Full(t *testing.T)  { testEmptyShortCircuit(t, 63, FullSync) }
func TestEmptyShortCircuit63Fast(t *testing.T)  { testEmptyShortCircuit(t, 63, FastSync) }
func TestEmptyShortCircuit64Full(t *testing.T)  { testEmptyShortCircuit(t, 64, FullSync) }
func TestEmptyShortCircuit64Fast(t *testing.T)  { testEmptyShortCircuit(t, 64, FastSync) }
func TestEmptyShortCircuit64Light(t *testing.T) { testEmptyShortCircuit(t, 64, LightSync) }

func testEmptyShortCircuit(t *testing.T, protocol int, mode SyncMode) {
800 801
	t.Parallel()

802
	tester := newTester()
803 804
	defer tester.terminate()

805
	// Create a block chain to download
806 807
	chain := testChainBase
	tester.newPeer("peer", protocol, chain)
808 809

	// Instrument the downloader to signal body requests
810
	bodiesHave, receiptsHave := int32(0), int32(0)
811
	tester.downloader.bodyFetchHook = func(headers []*types.Header) {
812
		atomic.AddInt32(&bodiesHave, int32(len(headers)))
813 814
	}
	tester.downloader.receiptFetchHook = func(headers []*types.Header) {
815
		atomic.AddInt32(&receiptsHave, int32(len(headers)))
816 817
	}
	// Synchronise with the peer and make sure all blocks were retrieved
818
	if err := tester.sync("peer", nil, mode); err != nil {
819 820
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
821
	assertOwnChain(t, tester, chain.len())
822

823
	// Validate the number of block bodies that should have been requested
824
	bodiesNeeded, receiptsNeeded := 0, 0
825
	for _, block := range chain.blockm {
826
		if mode != LightSync && block != tester.genesis && (len(block.Transactions()) > 0 || len(block.Uncles()) > 0) {
827
			bodiesNeeded++
828
		}
829
	}
830
	for _, receipt := range chain.receiptm {
831
		if mode == FastSync && len(receipt) > 0 {
832 833 834
			receiptsNeeded++
		}
	}
835 836
	if int(bodiesHave) != bodiesNeeded {
		t.Errorf("body retrieval count mismatch: have %v, want %v", bodiesHave, bodiesNeeded)
837
	}
838 839
	if int(receiptsHave) != receiptsNeeded {
		t.Errorf("receipt retrieval count mismatch: have %v, want %v", receiptsHave, receiptsNeeded)
840 841 842
	}
}

843 844
// Tests that headers are enqueued continuously, preventing malicious nodes from
// stalling the downloader by feeding gapped header chains.
845 846 847 848 849 850 851 852
func TestMissingHeaderAttack62(t *testing.T)      { testMissingHeaderAttack(t, 62, FullSync) }
func TestMissingHeaderAttack63Full(t *testing.T)  { testMissingHeaderAttack(t, 63, FullSync) }
func TestMissingHeaderAttack63Fast(t *testing.T)  { testMissingHeaderAttack(t, 63, FastSync) }
func TestMissingHeaderAttack64Full(t *testing.T)  { testMissingHeaderAttack(t, 64, FullSync) }
func TestMissingHeaderAttack64Fast(t *testing.T)  { testMissingHeaderAttack(t, 64, FastSync) }
func TestMissingHeaderAttack64Light(t *testing.T) { testMissingHeaderAttack(t, 64, LightSync) }

func testMissingHeaderAttack(t *testing.T, protocol int, mode SyncMode) {
853 854
	t.Parallel()

855
	tester := newTester()
856
	defer tester.terminate()
857

858 859 860 861
	chain := testChainBase.shorten(blockCacheItems - 15)
	brokenChain := chain.shorten(chain.len())
	delete(brokenChain.headerm, brokenChain.chain[brokenChain.len()/2])
	tester.newPeer("attack", protocol, brokenChain)
862

863
	if err := tester.sync("attack", nil, mode); err == nil {
864 865 866
		t.Fatalf("succeeded attacker synchronisation")
	}
	// Synchronise with the valid peer and make sure sync succeeds
867
	tester.newPeer("valid", protocol, chain)
868
	if err := tester.sync("valid", nil, mode); err != nil {
869 870
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
871
	assertOwnChain(t, tester, chain.len())
872 873 874 875
}

// Tests that if requested headers are shifted (i.e. first is missing), the queue
// detects the invalid numbering.
876 877 878 879 880 881 882 883
func TestShiftedHeaderAttack62(t *testing.T)      { testShiftedHeaderAttack(t, 62, FullSync) }
func TestShiftedHeaderAttack63Full(t *testing.T)  { testShiftedHeaderAttack(t, 63, FullSync) }
func TestShiftedHeaderAttack63Fast(t *testing.T)  { testShiftedHeaderAttack(t, 63, FastSync) }
func TestShiftedHeaderAttack64Full(t *testing.T)  { testShiftedHeaderAttack(t, 64, FullSync) }
func TestShiftedHeaderAttack64Fast(t *testing.T)  { testShiftedHeaderAttack(t, 64, FastSync) }
func TestShiftedHeaderAttack64Light(t *testing.T) { testShiftedHeaderAttack(t, 64, LightSync) }

func testShiftedHeaderAttack(t *testing.T, protocol int, mode SyncMode) {
884 885
	t.Parallel()

886
	tester := newTester()
887
	defer tester.terminate()
888

889
	chain := testChainBase.shorten(blockCacheItems - 15)
890

891
	// Attempt a full sync with an attacker feeding shifted headers
892 893 894 895 896
	brokenChain := chain.shorten(chain.len())
	delete(brokenChain.headerm, brokenChain.chain[1])
	delete(brokenChain.blockm, brokenChain.chain[1])
	delete(brokenChain.receiptm, brokenChain.chain[1])
	tester.newPeer("attack", protocol, brokenChain)
897
	if err := tester.sync("attack", nil, mode); err == nil {
898 899
		t.Fatalf("succeeded attacker synchronisation")
	}
900

901
	// Synchronise with the valid peer and make sure sync succeeds
902
	tester.newPeer("valid", protocol, chain)
903
	if err := tester.sync("valid", nil, mode); err != nil {
904 905
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
906
	assertOwnChain(t, tester, chain.len())
907 908 909
}

// Tests that upon detecting an invalid header, the recent ones are rolled back
910 911
// for various failure scenarios. Afterwards a full sync is attempted to make
// sure no state was corrupted.
912 913 914 915 916
func TestInvalidHeaderRollback63Fast(t *testing.T)  { testInvalidHeaderRollback(t, 63, FastSync) }
func TestInvalidHeaderRollback64Fast(t *testing.T)  { testInvalidHeaderRollback(t, 64, FastSync) }
func TestInvalidHeaderRollback64Light(t *testing.T) { testInvalidHeaderRollback(t, 64, LightSync) }

func testInvalidHeaderRollback(t *testing.T, protocol int, mode SyncMode) {
917 918
	t.Parallel()

919
	tester := newTester()
920
	defer tester.terminate()
921

922
	// Create a small enough block chain to download
923
	targetBlocks := 3*fsHeaderSafetyNet + 256 + fsMinFullBlocks
924
	chain := testChainBase.shorten(targetBlocks)
925

926 927 928
	// Attempt to sync with an attacker that feeds junk during the fast sync phase.
	// This should result in the last fsHeaderSafetyNet headers being rolled back.
	missing := fsHeaderSafetyNet + MaxHeaderFetch + 1
929 930 931
	fastAttackChain := chain.shorten(chain.len())
	delete(fastAttackChain.headerm, fastAttackChain.chain[missing])
	tester.newPeer("fast-attack", protocol, fastAttackChain)
932

933
	if err := tester.sync("fast-attack", nil, mode); err == nil {
934 935
		t.Fatalf("succeeded fast attacker synchronisation")
	}
936
	if head := tester.CurrentHeader().Number.Int64(); int(head) > MaxHeaderFetch {
937
		t.Errorf("rollback head mismatch: have %v, want at most %v", head, MaxHeaderFetch)
938
	}
939

940 941 942 943
	// Attempt to sync with an attacker that feeds junk during the block import phase.
	// This should result in both the last fsHeaderSafetyNet number of headers being
	// rolled back, and also the pivot point being reverted to a non-block status.
	missing = 3*fsHeaderSafetyNet + MaxHeaderFetch + 1
944 945 946 947
	blockAttackChain := chain.shorten(chain.len())
	delete(fastAttackChain.headerm, fastAttackChain.chain[missing]) // Make sure the fast-attacker doesn't fill in
	delete(blockAttackChain.headerm, blockAttackChain.chain[missing])
	tester.newPeer("block-attack", protocol, blockAttackChain)
948

949
	if err := tester.sync("block-attack", nil, mode); err == nil {
950 951
		t.Fatalf("succeeded block attacker synchronisation")
	}
952
	if head := tester.CurrentHeader().Number.Int64(); int(head) > 2*fsHeaderSafetyNet+MaxHeaderFetch {
953 954
		t.Errorf("rollback head mismatch: have %v, want at most %v", head, 2*fsHeaderSafetyNet+MaxHeaderFetch)
	}
955
	if mode == FastSync {
956
		if head := tester.CurrentBlock().NumberU64(); head != 0 {
957
			t.Errorf("fast sync pivot block #%d not rolled back", head)
958
		}
959
	}
960

961 962 963
	// Attempt to sync with an attacker that withholds promised blocks after the
	// fast sync pivot point. This could be a trial to leave the node with a bad
	// but already imported pivot block.
964 965
	withholdAttackChain := chain.shorten(chain.len())
	tester.newPeer("withhold-attack", protocol, withholdAttackChain)
966
	tester.downloader.syncInitHook = func(uint64, uint64) {
967 968
		for i := missing; i < withholdAttackChain.len(); i++ {
			delete(withholdAttackChain.headerm, withholdAttackChain.chain[i])
969 970
		}
		tester.downloader.syncInitHook = nil
971
	}
972 973 974
	if err := tester.sync("withhold-attack", nil, mode); err == nil {
		t.Fatalf("succeeded withholding attacker synchronisation")
	}
975
	if head := tester.CurrentHeader().Number.Int64(); int(head) > 2*fsHeaderSafetyNet+MaxHeaderFetch {
976
		t.Errorf("rollback head mismatch: have %v, want at most %v", head, 2*fsHeaderSafetyNet+MaxHeaderFetch)
977 978
	}
	if mode == FastSync {
979
		if head := tester.CurrentBlock().NumberU64(); head != 0 {
980 981
			t.Errorf("fast sync pivot block #%d not rolled back", head)
		}
982
	}
983 984 985 986 987 988

	// synchronise with the valid peer and make sure sync succeeds. Since the last rollback
	// should also disable fast syncing for this process, verify that we did a fresh full
	// sync. Note, we can't assert anything about the receipts since we won't purge the
	// database of them, hence we can't use assertOwnChain.
	tester.newPeer("valid", protocol, chain)
989
	if err := tester.sync("valid", nil, mode); err != nil {
990 991
		t.Fatalf("failed to synchronise blocks: %v", err)
	}
992 993
	if hs := len(tester.ownHeaders); hs != chain.len() {
		t.Fatalf("synchronised headers mismatch: have %v, want %v", hs, chain.len())
994
	}
995
	if mode != LightSync {
996 997
		if bs := len(tester.ownBlocks); bs != chain.len() {
			t.Fatalf("synchronised blocks mismatch: have %v, want %v", bs, chain.len())
998
		}
999
	}
1000 1001
}

1002 1003
// Tests that a peer advertising an high TD doesn't get to stall the downloader
// afterwards by not sending any useful hashes.
1004 1005 1006 1007 1008 1009 1010 1011
func TestHighTDStarvationAttack62(t *testing.T)      { testHighTDStarvationAttack(t, 62, FullSync) }
func TestHighTDStarvationAttack63Full(t *testing.T)  { testHighTDStarvationAttack(t, 63, FullSync) }
func TestHighTDStarvationAttack63Fast(t *testing.T)  { testHighTDStarvationAttack(t, 63, FastSync) }
func TestHighTDStarvationAttack64Full(t *testing.T)  { testHighTDStarvationAttack(t, 64, FullSync) }
func TestHighTDStarvationAttack64Fast(t *testing.T)  { testHighTDStarvationAttack(t, 64, FastSync) }
func TestHighTDStarvationAttack64Light(t *testing.T) { testHighTDStarvationAttack(t, 64, LightSync) }

func testHighTDStarvationAttack(t *testing.T, protocol int, mode SyncMode) {
1012 1013
	t.Parallel()

1014
	tester := newTester()
1015
	defer tester.terminate()
1016

1017 1018
	chain := testChainBase.shorten(1)
	tester.newPeer("attack", protocol, chain)
1019
	if err := tester.sync("attack", big.NewInt(1000000), mode); err != errStallingPeer {
1020 1021 1022 1023
		t.Fatalf("synchronisation error mismatch: have %v, want %v", err, errStallingPeer)
	}
}

1024
// Tests that misbehaving peers are disconnected, whilst behaving ones are not.
1025 1026 1027 1028 1029
func TestBlockHeaderAttackerDropping62(t *testing.T) { testBlockHeaderAttackerDropping(t, 62) }
func TestBlockHeaderAttackerDropping63(t *testing.T) { testBlockHeaderAttackerDropping(t, 63) }
func TestBlockHeaderAttackerDropping64(t *testing.T) { testBlockHeaderAttackerDropping(t, 64) }

func testBlockHeaderAttackerDropping(t *testing.T, protocol int) {
1030 1031
	t.Parallel()

1032
	// Define the disconnection requirement for individual hash fetch errors
1033 1034 1035 1036
	tests := []struct {
		result error
		drop   bool
	}{
1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056
		{nil, false},                        // Sync succeeded, all is well
		{errBusy, false},                    // Sync is already in progress, no problem
		{errUnknownPeer, false},             // Peer is unknown, was already dropped, don't double drop
		{errBadPeer, true},                  // Peer was deemed bad for some reason, drop it
		{errStallingPeer, true},             // Peer was detected to be stalling, drop it
		{errNoPeers, false},                 // No peers to download from, soft race, no issue
		{errTimeout, true},                  // No hashes received in due time, drop the peer
		{errEmptyHeaderSet, true},           // No headers were returned as a response, drop as it's a dead end
		{errPeersUnavailable, true},         // Nobody had the advertised blocks, drop the advertiser
		{errInvalidAncestor, true},          // Agreed upon ancestor is not acceptable, drop the chain rewriter
		{errInvalidChain, true},             // Hash chain was detected as invalid, definitely drop
		{errInvalidBlock, false},            // A bad peer was detected, but not the sync origin
		{errInvalidBody, false},             // A bad peer was detected, but not the sync origin
		{errInvalidReceipt, false},          // A bad peer was detected, but not the sync origin
		{errCancelBlockFetch, false},        // Synchronisation was canceled, origin may be innocent, don't drop
		{errCancelHeaderFetch, false},       // Synchronisation was canceled, origin may be innocent, don't drop
		{errCancelBodyFetch, false},         // Synchronisation was canceled, origin may be innocent, don't drop
		{errCancelReceiptFetch, false},      // Synchronisation was canceled, origin may be innocent, don't drop
		{errCancelHeaderProcessing, false},  // Synchronisation was canceled, origin may be innocent, don't drop
		{errCancelContentProcessing, false}, // Synchronisation was canceled, origin may be innocent, don't drop
1057 1058
	}
	// Run the tests and check disconnection status
1059
	tester := newTester()
1060
	defer tester.terminate()
1061
	chain := testChainBase.shorten(1)
1062

1063 1064 1065
	for i, tt := range tests {
		// Register a new peer and ensure it's presence
		id := fmt.Sprintf("test %d", i)
1066
		if err := tester.newPeer(id, protocol, chain); err != nil {
1067 1068
			t.Fatalf("test %d: failed to register new peer: %v", i, err)
		}
1069
		if _, ok := tester.peers[id]; !ok {
1070 1071 1072 1073 1074
			t.Fatalf("test %d: registered peer not found", i)
		}
		// Simulate a synchronisation and check the required result
		tester.downloader.synchroniseMock = func(string, common.Hash) error { return tt.result }

1075
		tester.downloader.Synchronise(id, tester.genesis.Hash(), big.NewInt(1000), FullSync)
1076
		if _, ok := tester.peers[id]; !ok != tt.drop {
1077 1078 1079 1080
			t.Errorf("test %d: peer drop mismatch for %v: have %v, want %v", i, tt.result, !ok, tt.drop)
		}
	}
}
1081

1082 1083 1084 1085 1086 1087 1088 1089 1090 1091
// Tests that synchronisation progress (origin block number, current block number
// and highest block number) is tracked and updated correctly.
func TestSyncProgress62(t *testing.T)      { testSyncProgress(t, 62, FullSync) }
func TestSyncProgress63Full(t *testing.T)  { testSyncProgress(t, 63, FullSync) }
func TestSyncProgress63Fast(t *testing.T)  { testSyncProgress(t, 63, FastSync) }
func TestSyncProgress64Full(t *testing.T)  { testSyncProgress(t, 64, FullSync) }
func TestSyncProgress64Fast(t *testing.T)  { testSyncProgress(t, 64, FastSync) }
func TestSyncProgress64Light(t *testing.T) { testSyncProgress(t, 64, LightSync) }

func testSyncProgress(t *testing.T, protocol int, mode SyncMode) {
1092 1093
	t.Parallel()

1094 1095
	tester := newTester()
	defer tester.terminate()
1096
	chain := testChainBase.shorten(blockCacheItems - 15)
1097

1098
	// Set a sync init hook to catch progress changes
1099 1100 1101 1102 1103 1104 1105
	starting := make(chan struct{})
	progress := make(chan struct{})

	tester.downloader.syncInitHook = func(origin, latest uint64) {
		starting <- struct{}{}
		<-progress
	}
1106 1107
	checkProgress(t, tester.downloader, "pristine", ethereum.SyncProgress{})

1108
	// Synchronise half the blocks and check initial progress
1109
	tester.newPeer("peer-half", protocol, chain.shorten(chain.len()/2))
1110 1111 1112 1113 1114
	pending := new(sync.WaitGroup)
	pending.Add(1)

	go func() {
		defer pending.Done()
1115
		if err := tester.sync("peer-half", nil, mode); err != nil {
E
Egon Elbre 已提交
1116
			panic(fmt.Sprintf("failed to synchronise blocks: %v", err))
1117 1118 1119
		}
	}()
	<-starting
1120 1121 1122
	checkProgress(t, tester.downloader, "initial", ethereum.SyncProgress{
		HighestBlock: uint64(chain.len()/2 - 1),
	})
1123 1124 1125
	progress <- struct{}{}
	pending.Wait()

1126
	// Synchronise all the blocks and check continuation progress
1127
	tester.newPeer("peer-full", protocol, chain)
1128 1129 1130
	pending.Add(1)
	go func() {
		defer pending.Done()
1131
		if err := tester.sync("peer-full", nil, mode); err != nil {
E
Egon Elbre 已提交
1132
			panic(fmt.Sprintf("failed to synchronise blocks: %v", err))
1133 1134 1135
		}
	}()
	<-starting
1136 1137 1138 1139 1140 1141 1142
	checkProgress(t, tester.downloader, "completing", ethereum.SyncProgress{
		StartingBlock: uint64(chain.len()/2 - 1),
		CurrentBlock:  uint64(chain.len()/2 - 1),
		HighestBlock:  uint64(chain.len() - 1),
	})

	// Check final progress after successful sync
1143 1144
	progress <- struct{}{}
	pending.Wait()
1145 1146 1147 1148 1149 1150
	checkProgress(t, tester.downloader, "final", ethereum.SyncProgress{
		StartingBlock: uint64(chain.len()/2 - 1),
		CurrentBlock:  uint64(chain.len() - 1),
		HighestBlock:  uint64(chain.len() - 1),
	})
}
1151

1152 1153 1154 1155 1156 1157 1158
func checkProgress(t *testing.T, d *Downloader, stage string, want ethereum.SyncProgress) {
	t.Helper()
	p := d.Progress()
	p.KnownStates, p.PulledStates = 0, 0
	want.KnownStates, want.PulledStates = 0, 0
	if p != want {
		t.Fatalf("%s progress mismatch:\nhave %+v\nwant %+v", stage, p, want)
1159
	}
1160 1161
}

1162
// Tests that synchronisation progress (origin block number and highest block
1163 1164
// number) is tracked and updated correctly in case of a fork (or manual head
// revertal).
1165 1166 1167 1168 1169 1170 1171 1172
func TestForkedSyncProgress62(t *testing.T)      { testForkedSyncProgress(t, 62, FullSync) }
func TestForkedSyncProgress63Full(t *testing.T)  { testForkedSyncProgress(t, 63, FullSync) }
func TestForkedSyncProgress63Fast(t *testing.T)  { testForkedSyncProgress(t, 63, FastSync) }
func TestForkedSyncProgress64Full(t *testing.T)  { testForkedSyncProgress(t, 64, FullSync) }
func TestForkedSyncProgress64Fast(t *testing.T)  { testForkedSyncProgress(t, 64, FastSync) }
func TestForkedSyncProgress64Light(t *testing.T) { testForkedSyncProgress(t, 64, LightSync) }

func testForkedSyncProgress(t *testing.T, protocol int, mode SyncMode) {
1173 1174
	t.Parallel()

1175 1176
	tester := newTester()
	defer tester.terminate()
1177 1178
	chainA := testChainForkLightA.shorten(testChainBase.len() + MaxHashFetch)
	chainB := testChainForkLightB.shorten(testChainBase.len() + MaxHashFetch)
1179

1180
	// Set a sync init hook to catch progress changes
1181 1182 1183 1184 1185 1186 1187
	starting := make(chan struct{})
	progress := make(chan struct{})

	tester.downloader.syncInitHook = func(origin, latest uint64) {
		starting <- struct{}{}
		<-progress
	}
1188 1189
	checkProgress(t, tester.downloader, "pristine", ethereum.SyncProgress{})

1190
	// Synchronise with one of the forks and check progress
1191
	tester.newPeer("fork A", protocol, chainA)
1192 1193 1194 1195
	pending := new(sync.WaitGroup)
	pending.Add(1)
	go func() {
		defer pending.Done()
1196
		if err := tester.sync("fork A", nil, mode); err != nil {
E
Egon Elbre 已提交
1197
			panic(fmt.Sprintf("failed to synchronise blocks: %v", err))
1198 1199 1200
		}
	}()
	<-starting
1201 1202 1203 1204

	checkProgress(t, tester.downloader, "initial", ethereum.SyncProgress{
		HighestBlock: uint64(chainA.len() - 1),
	})
1205 1206 1207 1208
	progress <- struct{}{}
	pending.Wait()

	// Simulate a successful sync above the fork
1209
	tester.downloader.syncStatsChainOrigin = tester.downloader.syncStatsChainHeight
1210

1211
	// Synchronise with the second fork and check progress resets
1212
	tester.newPeer("fork B", protocol, chainB)
1213 1214 1215
	pending.Add(1)
	go func() {
		defer pending.Done()
1216
		if err := tester.sync("fork B", nil, mode); err != nil {
E
Egon Elbre 已提交
1217
			panic(fmt.Sprintf("failed to synchronise blocks: %v", err))
1218 1219 1220
		}
	}()
	<-starting
1221 1222 1223 1224 1225
	checkProgress(t, tester.downloader, "forking", ethereum.SyncProgress{
		StartingBlock: uint64(testChainBase.len()) - 1,
		CurrentBlock:  uint64(chainA.len() - 1),
		HighestBlock:  uint64(chainB.len() - 1),
	})
1226 1227

	// Check final progress after successful sync
1228 1229 1230 1231 1232 1233 1234
	progress <- struct{}{}
	pending.Wait()
	checkProgress(t, tester.downloader, "final", ethereum.SyncProgress{
		StartingBlock: uint64(testChainBase.len()) - 1,
		CurrentBlock:  uint64(chainB.len() - 1),
		HighestBlock:  uint64(chainB.len() - 1),
	})
1235 1236
}

1237
// Tests that if synchronisation is aborted due to some failure, then the progress
1238 1239
// origin is not updated in the next sync cycle, as it should be considered the
// continuation of the previous sync and not a new instance.
1240 1241 1242 1243 1244 1245 1246 1247
func TestFailedSyncProgress62(t *testing.T)      { testFailedSyncProgress(t, 62, FullSync) }
func TestFailedSyncProgress63Full(t *testing.T)  { testFailedSyncProgress(t, 63, FullSync) }
func TestFailedSyncProgress63Fast(t *testing.T)  { testFailedSyncProgress(t, 63, FastSync) }
func TestFailedSyncProgress64Full(t *testing.T)  { testFailedSyncProgress(t, 64, FullSync) }
func TestFailedSyncProgress64Fast(t *testing.T)  { testFailedSyncProgress(t, 64, FastSync) }
func TestFailedSyncProgress64Light(t *testing.T) { testFailedSyncProgress(t, 64, LightSync) }

func testFailedSyncProgress(t *testing.T, protocol int, mode SyncMode) {
1248 1249
	t.Parallel()

1250 1251
	tester := newTester()
	defer tester.terminate()
1252
	chain := testChainBase.shorten(blockCacheItems - 15)
1253

1254
	// Set a sync init hook to catch progress changes
1255 1256 1257 1258 1259 1260 1261
	starting := make(chan struct{})
	progress := make(chan struct{})

	tester.downloader.syncInitHook = func(origin, latest uint64) {
		starting <- struct{}{}
		<-progress
	}
1262 1263
	checkProgress(t, tester.downloader, "pristine", ethereum.SyncProgress{})

1264
	// Attempt a full sync with a faulty peer
1265 1266 1267 1268 1269 1270
	brokenChain := chain.shorten(chain.len())
	missing := brokenChain.len() / 2
	delete(brokenChain.headerm, brokenChain.chain[missing])
	delete(brokenChain.blockm, brokenChain.chain[missing])
	delete(brokenChain.receiptm, brokenChain.chain[missing])
	tester.newPeer("faulty", protocol, brokenChain)
1271 1272 1273 1274 1275

	pending := new(sync.WaitGroup)
	pending.Add(1)
	go func() {
		defer pending.Done()
1276
		if err := tester.sync("faulty", nil, mode); err == nil {
E
Egon Elbre 已提交
1277
			panic("succeeded faulty synchronisation")
1278 1279 1280
		}
	}()
	<-starting
1281 1282 1283
	checkProgress(t, tester.downloader, "initial", ethereum.SyncProgress{
		HighestBlock: uint64(brokenChain.len() - 1),
	})
1284 1285
	progress <- struct{}{}
	pending.Wait()
1286
	afterFailedSync := tester.downloader.Progress()
1287

1288 1289 1290
	// Synchronise with a good peer and check that the progress origin remind the same
	// after a failure
	tester.newPeer("valid", protocol, chain)
1291 1292 1293
	pending.Add(1)
	go func() {
		defer pending.Done()
1294
		if err := tester.sync("valid", nil, mode); err != nil {
E
Egon Elbre 已提交
1295
			panic(fmt.Sprintf("failed to synchronise blocks: %v", err))
1296 1297 1298
		}
	}()
	<-starting
1299
	checkProgress(t, tester.downloader, "completing", afterFailedSync)
1300 1301

	// Check final progress after successful sync
1302 1303 1304 1305 1306 1307
	progress <- struct{}{}
	pending.Wait()
	checkProgress(t, tester.downloader, "final", ethereum.SyncProgress{
		CurrentBlock: uint64(chain.len() - 1),
		HighestBlock: uint64(chain.len() - 1),
	})
1308 1309 1310
}

// Tests that if an attacker fakes a chain height, after the attack is detected,
1311 1312 1313 1314 1315 1316 1317 1318 1319
// the progress height is successfully reduced at the next sync invocation.
func TestFakedSyncProgress62(t *testing.T)      { testFakedSyncProgress(t, 62, FullSync) }
func TestFakedSyncProgress63Full(t *testing.T)  { testFakedSyncProgress(t, 63, FullSync) }
func TestFakedSyncProgress63Fast(t *testing.T)  { testFakedSyncProgress(t, 63, FastSync) }
func TestFakedSyncProgress64Full(t *testing.T)  { testFakedSyncProgress(t, 64, FullSync) }
func TestFakedSyncProgress64Fast(t *testing.T)  { testFakedSyncProgress(t, 64, FastSync) }
func TestFakedSyncProgress64Light(t *testing.T) { testFakedSyncProgress(t, 64, LightSync) }

func testFakedSyncProgress(t *testing.T, protocol int, mode SyncMode) {
1320 1321
	t.Parallel()

1322 1323
	tester := newTester()
	defer tester.terminate()
1324
	chain := testChainBase.shorten(blockCacheItems - 15)
1325

1326
	// Set a sync init hook to catch progress changes
1327 1328 1329 1330 1331 1332
	starting := make(chan struct{})
	progress := make(chan struct{})
	tester.downloader.syncInitHook = func(origin, latest uint64) {
		starting <- struct{}{}
		<-progress
	}
1333 1334 1335 1336 1337 1338 1339
	checkProgress(t, tester.downloader, "pristine", ethereum.SyncProgress{})

	// Create and sync with an attacker that promises a higher chain than available.
	brokenChain := chain.shorten(chain.len())
	numMissing := 5
	for i := brokenChain.len() - 2; i > brokenChain.len()-numMissing; i-- {
		delete(brokenChain.headerm, brokenChain.chain[i])
1340
	}
1341
	tester.newPeer("attack", protocol, brokenChain)
1342 1343 1344 1345 1346

	pending := new(sync.WaitGroup)
	pending.Add(1)
	go func() {
		defer pending.Done()
1347
		if err := tester.sync("attack", nil, mode); err == nil {
E
Egon Elbre 已提交
1348
			panic("succeeded attacker synchronisation")
1349 1350 1351
		}
	}()
	<-starting
1352 1353 1354
	checkProgress(t, tester.downloader, "initial", ethereum.SyncProgress{
		HighestBlock: uint64(brokenChain.len() - 1),
	})
1355 1356
	progress <- struct{}{}
	pending.Wait()
1357
	afterFailedSync := tester.downloader.Progress()
1358

1359 1360 1361 1362
	// Synchronise with a good peer and check that the progress height has been reduced to
	// the true value.
	validChain := chain.shorten(chain.len() - numMissing)
	tester.newPeer("valid", protocol, validChain)
1363 1364 1365 1366
	pending.Add(1)

	go func() {
		defer pending.Done()
1367
		if err := tester.sync("valid", nil, mode); err != nil {
E
Egon Elbre 已提交
1368
			panic(fmt.Sprintf("failed to synchronise blocks: %v", err))
1369 1370 1371
		}
	}()
	<-starting
1372 1373 1374 1375 1376 1377
	checkProgress(t, tester.downloader, "completing", ethereum.SyncProgress{
		CurrentBlock: afterFailedSync.CurrentBlock,
		HighestBlock: uint64(validChain.len() - 1),
	})

	// Check final progress after successful sync.
1378 1379
	progress <- struct{}{}
	pending.Wait()
1380 1381 1382 1383
	checkProgress(t, tester.downloader, "final", ethereum.SyncProgress{
		CurrentBlock: uint64(validChain.len() - 1),
		HighestBlock: uint64(validChain.len() - 1),
	})
1384
}
1385 1386 1387

// This test reproduces an issue where unexpected deliveries would
// block indefinitely if they arrived at the right time.
1388
func TestDeliverHeadersHang(t *testing.T) {
1389 1390
	t.Parallel()

1391 1392 1393 1394 1395 1396 1397 1398 1399 1400 1401 1402 1403
	testCases := []struct {
		protocol int
		syncMode SyncMode
	}{
		{62, FullSync},
		{63, FullSync},
		{63, FastSync},
		{64, FullSync},
		{64, FastSync},
		{64, LightSync},
	}
	for _, tc := range testCases {
		t.Run(fmt.Sprintf("protocol %d mode %v", tc.protocol, tc.syncMode), func(t *testing.T) {
1404
			t.Parallel()
1405 1406 1407 1408
			testDeliverHeadersHang(t, tc.protocol, tc.syncMode)
		})
	}
}
1409

1410 1411 1412 1413 1414 1415 1416 1417 1418 1419 1420 1421 1422 1423 1424 1425 1426 1427 1428 1429 1430 1431 1432
func testDeliverHeadersHang(t *testing.T, protocol int, mode SyncMode) {
	master := newTester()
	defer master.terminate()
	chain := testChainBase.shorten(15)

	for i := 0; i < 200; i++ {
		tester := newTester()
		tester.peerDb = master.peerDb
		tester.newPeer("peer", protocol, chain)

		// Whenever the downloader requests headers, flood it with
		// a lot of unrequested header deliveries.
		tester.downloader.peers.peers["peer"].peer = &floodingTestPeer{
			peer:   tester.downloader.peers.peers["peer"].peer,
			tester: tester,
		}
		if err := tester.sync("peer", nil, mode); err != nil {
			t.Errorf("test %d: sync failed: %v", i, err)
		}
		tester.terminate()
	}
}

1433 1434 1435 1436 1437 1438 1439 1440 1441 1442 1443 1444 1445 1446 1447 1448 1449 1450 1451 1452 1453
type floodingTestPeer struct {
	peer   Peer
	tester *downloadTester
}

func (ftp *floodingTestPeer) Head() (common.Hash, *big.Int) { return ftp.peer.Head() }
func (ftp *floodingTestPeer) RequestHeadersByHash(hash common.Hash, count int, skip int, reverse bool) error {
	return ftp.peer.RequestHeadersByHash(hash, count, skip, reverse)
}
func (ftp *floodingTestPeer) RequestBodies(hashes []common.Hash) error {
	return ftp.peer.RequestBodies(hashes)
}
func (ftp *floodingTestPeer) RequestReceipts(hashes []common.Hash) error {
	return ftp.peer.RequestReceipts(hashes)
}
func (ftp *floodingTestPeer) RequestNodeData(hashes []common.Hash) error {
	return ftp.peer.RequestNodeData(hashes)
}

func (ftp *floodingTestPeer) RequestHeadersByNumber(from uint64, count, skip int, reverse bool) error {
	deliveriesDone := make(chan struct{}, 500)
1454
	for i := 0; i < cap(deliveriesDone)-1; i++ {
1455 1456 1457 1458 1459 1460
		peer := fmt.Sprintf("fake-peer%d", i)
		go func() {
			ftp.tester.downloader.DeliverHeaders(peer, []*types.Header{{}, {}, {}, {}})
			deliveriesDone <- struct{}{}
		}()
	}
1461

1462
	// None of the extra deliveries should block.
1463
	timeout := time.After(60 * time.Second)
1464
	launched := false
1465 1466 1467
	for i := 0; i < cap(deliveriesDone); i++ {
		select {
		case <-deliveriesDone:
1468 1469 1470 1471 1472 1473 1474 1475 1476
			if !launched {
				// Start delivering the requested headers
				// after one of the flooding responses has arrived.
				go func() {
					ftp.peer.RequestHeadersByNumber(from, count, skip, reverse)
					deliveriesDone <- struct{}{}
				}()
				launched = true
			}
1477 1478 1479 1480 1481 1482
		case <-timeout:
			panic("blocked")
		}
	}
	return nil
}
1483 1484 1485 1486 1487 1488 1489 1490 1491 1492 1493 1494 1495 1496 1497 1498 1499 1500 1501 1502 1503 1504 1505 1506 1507 1508 1509 1510 1511 1512 1513 1514 1515 1516 1517 1518 1519 1520 1521 1522 1523 1524 1525 1526 1527 1528 1529 1530 1531 1532 1533 1534 1535 1536 1537 1538 1539 1540 1541 1542 1543 1544 1545 1546 1547 1548 1549 1550 1551 1552 1553 1554 1555 1556 1557

func TestRemoteHeaderRequestSpan(t *testing.T) {
	testCases := []struct {
		remoteHeight uint64
		localHeight  uint64
		expected     []int
	}{
		// Remote is way higher. We should ask for the remote head and go backwards
		{1500, 1000,
			[]int{1323, 1339, 1355, 1371, 1387, 1403, 1419, 1435, 1451, 1467, 1483, 1499},
		},
		{15000, 13006,
			[]int{14823, 14839, 14855, 14871, 14887, 14903, 14919, 14935, 14951, 14967, 14983, 14999},
		},
		//Remote is pretty close to us. We don't have to fetch as many
		{1200, 1150,
			[]int{1149, 1154, 1159, 1164, 1169, 1174, 1179, 1184, 1189, 1194, 1199},
		},
		// Remote is equal to us (so on a fork with higher td)
		// We should get the closest couple of ancestors
		{1500, 1500,
			[]int{1497, 1499},
		},
		// We're higher than the remote! Odd
		{1000, 1500,
			[]int{997, 999},
		},
		// Check some weird edgecases that it behaves somewhat rationally
		{0, 1500,
			[]int{0, 2},
		},
		{6000000, 0,
			[]int{5999823, 5999839, 5999855, 5999871, 5999887, 5999903, 5999919, 5999935, 5999951, 5999967, 5999983, 5999999},
		},
		{0, 0,
			[]int{0, 2},
		},
	}
	reqs := func(from, count, span int) []int {
		var r []int
		num := from
		for len(r) < count {
			r = append(r, num)
			num += span + 1
		}
		return r
	}
	for i, tt := range testCases {
		from, count, span, max := calculateRequestSpan(tt.remoteHeight, tt.localHeight)
		data := reqs(int(from), count, span)

		if max != uint64(data[len(data)-1]) {
			t.Errorf("test %d: wrong last value %d != %d", i, data[len(data)-1], max)
		}
		failed := false
		if len(data) != len(tt.expected) {
			failed = true
			t.Errorf("test %d: length wrong, expected %d got %d", i, len(tt.expected), len(data))
		} else {
			for j, n := range data {
				if n != tt.expected[j] {
					failed = true
					break
				}
			}
		}
		if failed {
			res := strings.Replace(fmt.Sprint(data), " ", ",", -1)
			exp := strings.Replace(fmt.Sprint(tt.expected), " ", ",", -1)
			fmt.Printf("got: %v\n", res)
			fmt.Printf("exp: %v\n", exp)
			t.Errorf("test %d: wrong values", i)
		}
	}
}