- 12 6月, 2015 1 次提交
-
-
由 Hixie 提交于
This moves input.dart to editing2/, since that way we can define the layering as strictly unidirectional. It also reorders a bunch of imports to fit the style guide. I removed the old remnants of the widgets example, and put the fn2 examples into the examples/widgets/ directory, to parallel the framework directory names. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177243002.
-
- 11 6月, 2015 4 次提交
-
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth, hansmuller Review URL: https://codereview.chromium.org/1181533003
-
由 Adam Barth 提交于
These are now called Block, Stack, and Flex, respectively. Less verbose. R=jackson@google.com, ianh@google.com Review URL: https://codereview.chromium.org/1181533002.
-
由 Hans Muller 提交于
Tweaked the layout in Scaffold a little: the Scaffold accounts for the (Android) notification bar's height, instead of the ToolBar. I think it would be best if moving the app below the notification area were handled at a lower level. Doing it in Scaffold seemed OK for the moment, since one could put a ToolBar component anywhere in an app. Closes #208 R=ianh@google.com Review URL: https://codereview.chromium.org/1171173003.
-
由 Hixie 提交于
This also removes one bit of magic to make it more obvious what on is going on during a sync, which should hopefully help. Components have to decide if they support being stateful or not. If they do, then they must implement syncFields() and have mutable fields; if they don't, then they must have final fields. This isn't particularly enforced, though. This also renames _willSync() to _retainStatefulNodeIfPossible(), for clarity, and fixes some minor style issues and one typo that was breaking the drawer. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174023003
-
- 10 6月, 2015 2 次提交
-
-
由 Hixie 提交于
- constructors first - have either a blank line at the top and bottom of each class, or no blank line in either place (it's still inconsistent about which we should do) - hide clamp() R=abarth@chromium.org Review URL: https://codereview.chromium.org/1172173002
-
由 Adam Barth 提交于
Also, I've fixed the mask color on the drawer. R=ianh@google.com Review URL: https://codereview.chromium.org/1168203004.
-
- 09 6月, 2015 1 次提交
-
-
由 Hixie 提交于
Also change SizedBox. This makes the code that uses Container() and SizedBox() much more readable. The underlying RenderSizedBox is not affected by this change. R=abarth@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/1166203002
-
- 06 6月, 2015 1 次提交
-
-
由 Hixie 提交于
Export Point, Size, Rect, Color, Paint, Path, BoxDecoration, Border, BorderSide, EdgeDims, and FlexDirection from fn2.dart That way most of our libraries don't have to use sky.Foo all over the place, and we can reduce the number of imports in most Dart components. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1161323004
-
- 05 6月, 2015 2 次提交
-
-
由 Hixie 提交于
https://www.dartlang.org/articles/style-guide/#names R=jackson@google.com Review URL: https://codereview.chromium.org/1158813004
-
由 Collin Jackson 提交于
R=abarth@chromium.org, ianh@google.com, abarth, hixie Review URL: https://codereview.chromium.org/1165983002
-
- 04 6月, 2015 2 次提交
-
-
由 Hixie 提交于
Also, make the scaffold code more generic (with slots in a map, instead of dedicated members for each slot). This may eventually benefit from being split into a general "multislot" superclass and a scaffold-specific subclass, but for now it'll do. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1152163007
-
由 Matt Perry 提交于
Also add operator==, hashCode, toString, and some basic Color constants to Color. R=abarth@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1162023004
-
- 03 6月, 2015 1 次提交
-
-
由 Eric Seidel 提交于
Looks horrible. But it's a start. R=abarth@chromium.org, ianh@google.com BUG= Review URL: https://codereview.chromium.org/1146913005
-
- 29 5月, 2015 2 次提交
-
-
由 Adam Barth 提交于
Previously layout2.dart was a thousand lines long. R=ianh@google.com Review URL: https://codereview.chromium.org/1161003002
-
由 Hixie 提交于
R=abarth@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/1165463002
-
- 28 5月, 2015 1 次提交
-
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1153223003
-
- 27 5月, 2015 1 次提交
-
-
由 Hixie 提交于
Eventually this'll be merged back into components/, but we want to keep both running for now. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1158713007
-
- 20 5月, 2015 3 次提交
-
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1133353008
-
由 John McCutchan 提交于
Revert "Add library names to many sky libraries" This reverts commit 1337e0a803a54ee92d6dce7f8c4a6335f7cbb9fa. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1142893007
-
由 John McCutchan 提交于
- Analyzer complains about libraries not having names. This adds names to many libraries. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1150433002
-
- 19 5月, 2015 1 次提交
-
-
由 John McCutchan 提交于
NOTE: This CL appears far larger than it actually is for two reasons: 1) Many files were moved around to use the Dart package directory structure. 2) Many .dart files had to have import paths updated. - Organize mojo/public/dart so that it uses standard Dart package layout - Organize mojo/dart/apptest so that it uses a standard Dart package layout - Organize sky/sdk so that it uses a standard Dart package layout - Create a mojo/testing package (used by unittests) - Introduce the 'dart_pkg' gn rule which populates gen/Config/dart-pkg - All internally vended Dart packages must have a corresponding dart_pkg rule - It is now possible to use dependency_overrides: in pubspec.yaml to mix internal and external package dependencies (enables analyzer, editor, webstorm usage for internal developers). - Package root for dart content handler ends with "packages/" - Imports of mojo package uris no longer need the "public/dart" - mojo/public/tools/dart_package.py is a clone of mojo/public/tools/gn/zip.py - Sky tests no longer run 'deploy_sdk' script. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1132063007
-
- 13 5月, 2015 1 次提交
-
-
由 Hixie 提交于
This introduces a new kind of ContentNode similar to Style but which instead of changing the styles that apply to the node, provides new settings to apply to the "parentData" structure. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1122413006
-
- 12 5月, 2015 3 次提交
-
-
由 Benjamin Lerman 提交于
This reverts commit 1a4db2e964de8a2eba7c76c0904027150cc0c387. This broke the bots. TBR=github.com@spam.hixie.ch Review URL: https://codereview.chromium.org/1137153002
-
由 Hixie 提交于
This introduces a new kind of ContentNode similar to Style but which instead of changing the styles that apply to the node, provides new settings to apply to the "parentData" structure. If you have better ideas for the class names here let me know. Note that the layout.dart backend of this is hacky (more so than before, even); once we have something other than the DOM and CSS to back it, it'll get rewritten. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1129893006
-
由 Hixie 提交于
FlexContainer is a (pretend) new layout primitive that implements Flex layout. It's only pretend because right now it's still just backed by CSS. This is a step along the way to removing all the CSS from fn. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1128743003
-
- 05 5月, 2015 1 次提交
-
-
由 Eric Seidel 提交于
Analyzer was complaining about '-' not being an allowed character in dart file names. R=jamesr@chromium.org
-
- 07 4月, 2015 1 次提交
-
-
由 Ojan Vafai 提交于
-Make display:flex, flex-direction: column, flex-shrink: 1 the default. -Simplify StyleAdjuster::adjustStyleForAlignment to remove special cases we won't need as we make flex the default and remove absolute positioning. -Fix a bug this exposed in column flexboxes where we'd apply the wrong edge of border/padding/margin. -For now leave the default of align-items:stretch. The main change here is that iframe/img will do width:auto the same as blocks (i.e. the width of the parent). I think this is a good change, but we'll have to see how it feels in practice. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1061163002
-
- 02 4月, 2015 1 次提交
-
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1043283003
-
- 26 3月, 2015 2 次提交
-
-
由 Adam Barth 提交于
Most of the elements that want to be Material (i.e., have a level and cast a shadow) don't want to be InkWells (i.e., have an ink splash effect). This CL disentangles these two components, fixing bugs in the Drawer and in the PopupMenu. Separating these concepts also lets us use Material for the ActionBar and the FloatingActionButton. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1037673002
-
由 Adam Barth 提交于
This CL uses CSS transition to add an implicit animation between purple ActionBar and the light grey "search" action bar. It's unclear to me how best to create implicit animations in this system, but using a CSS transition works surprisingly well. Also, fix the typography style for the placeholder in the search box. Previously it was white on Grey[50], which was extremely hard to see. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1036783002
-
- 25 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
This CL cleans up stock_app.dart to better separate concerns now that we have StyleNode. Also, this CL introduces IconButton, which will grow to include an ink effect in the future, and makes the background of the search bar white. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1007893005
-
- 17 3月, 2015 5 次提交
-
-
由 Adam Barth 提交于
This CL adds typography information to the Sky theme. The values are from the Material Design spec. I've also applied these values to the stocks app and the various components. We're not geting precisely the right typography in some cases because of https://github.com/domokit/mojo/issues/65. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1006363004
-
由 Adam Barth 提交于
The left edge of the title should be on the 72px vertical keyline according to the Material Design spec. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1010443005
-
由 Adam Barth 提交于
This naming matches the naming in Material Design. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1010913002
-
由 Adam Barth 提交于
This CL lets Sky apps draw behind the Android status bar, better matching the material design spec. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1010493007
-
由 Adam Barth 提交于
This CL makes the drawer the correct size and use the correct animation curve. Also, remove the hard-coded z-index values now that hit testing works again. This CL adjusts the mask's opacity to match the drawer in Gmail. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1012463003
-
- 14 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1006053002
-
- 12 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
To accomplish this, I made the following changes: 1) Material is now in charge of drawing the material shadows. 2) In order to mix in the style for the shadow, Element now takes a list of Styles instead of a single style. 3) Update all clients of Element#style to understand that we now have a list. 4) Update components that drawer shadows to have Material do that work instead. a) One exception: FloatingActionButton draws its own shadow because of its crazy clip requirements. We'll probably want to find a better way for FloatingActionButton to clip in the future. I've also added a widgets-fn example to demo the fn material widgets. This CL introduces a bug into Drawer whereby you can get ink splashes everywhere in the drawer. In the future, we'll need to separate out the different material aspects to get non-splashable materials. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1003553002
-
- 11 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
Moving these files into sky/framework will make them easier to use from the SDK. Also, this CL also splits up the giant "widgets" library into smaller libraries, one per component. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/993033003
-