- 12 6月, 2015 5 次提交
-
-
由 Hixie 提交于
This moves input.dart to editing2/, since that way we can define the layering as strictly unidirectional. It also reorders a bunch of imports to fit the style guide. I removed the old remnants of the widgets example, and put the fn2 examples into the examples/widgets/ directory, to parallel the framework directory names. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177243002.
-
由 Matt Perry 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1179913002.
-
由 Matt Perry 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1180873003.
-
由 Adam Barth 提交于
This CL wires up the opacity of the popup menu items and teaches the popup menu how to draw its background at the right size. R=ianh@google.com Review URL: https://codereview.chromium.org/1175353002.
-
由 Adam Barth 提交于
This factoring will more code use BoxPainter in the future (in particular, PopupMenu). R=ianh@google.com Review URL: https://codereview.chromium.org/1180633004.
-
- 11 6月, 2015 25 次提交
-
-
由 Adam Barth 提交于
The final animation is more involved, but this CL starts implementing the menu animation by making it fade in. R=ianh@google.com Review URL: https://codereview.chromium.org/1174253003.
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1178783002.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth, hansmuller Review URL: https://codereview.chromium.org/1181533003
-
由 Collin Jackson 提交于
R=abarth@chromium.org, ianh@google.com, abarth Review URL: https://codereview.chromium.org/1174203002
-
由 Hixie 提交于
This lays the groundwork for using fn widgets in static environments. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1178703002
-
由 Hixie 提交于
Dispatch events to fn nodes for each RenderObject that the event goes through, instead of starting at the innermost target and just propagating through our tree. This starts laying the groundwork for fn disconnected subtrees that are linked together into one RenderObject tree. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1181503002
-
由 Collin Jackson 提交于
R=abarth@chromium.org, hixie Review URL: https://codereview.chromium.org/1181523002
-
由 Adam Barth 提交于
These are now called Block, Stack, and Flex, respectively. Less verbose. R=jackson@google.com, ianh@google.com Review URL: https://codereview.chromium.org/1181533002.
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1181453003
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174143002
-
由 Adam Barth 提交于
Previously it was propagating for a constant duration. R=ianh@google.com Review URL: https://codereview.chromium.org/1173173002.
-
由 Hixie 提交于
Turns out that reintroducing the field in each subclass is probably allocating more storage per node. So let's not do that. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177483004
-
由 Adam Barth 提交于
Previously, they always started at the center of the RenderInkWell. Now we remember the local coordinates we computed during the hit test and provide that information when handling the event. R=ianh@google.com Review URL: https://codereview.chromium.org/1180553002.
-
由 Hixie 提交于
I'd do it now, but these files are still being used by fn.dart/stocks1, and it's not worth forking the whole animation directory just for this. TBR=abarth Review URL: https://codereview.chromium.org/1170033005
-
由 Hixie 提交于
In general, we are hugely inconsistent in what onFoo/onFoo() means. I'm cleaning out all the cases where onFoo() is a method. Also, this fixes EditableText, which got missed in the recent syncFields() pass. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1175753003
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1176053002
-
由 Adam Barth 提交于
We can use const [] instead and we'll be sure we don't mutate this constant. R=ianh@google.com Review URL: https://codereview.chromium.org/1178623002.
-
由 Eric Seidel 提交于
Our current static view_configuration design cannot work. https://github.com/domokit/mojo/issues/231 R=ianh@google.com Review URL: https://codereview.chromium.org/1169813009.
-
由 Eric Seidel 提交于
The app looks so much better with this on. R=jackson@google.com, abarth@chromium.org Review URL: https://codereview.chromium.org/1172413002.
-
由 Hans Muller 提交于
Tweaked the layout in Scaffold a little: the Scaffold accounts for the (Android) notification bar's height, instead of the ToolBar. I think it would be best if moving the app below the notification area were handled at a lower level. Doing it in Scaffold seemed OK for the moment, since one could put a ToolBar component anywhere in an app. Closes #208 R=ianh@google.com Review URL: https://codereview.chromium.org/1171173003.
-
由 Hixie 提交于
This also removes one bit of magic to make it more obvious what on is going on during a sync, which should hopefully help. Components have to decide if they support being stateful or not. If they do, then they must implement syncFields() and have mutable fields; if they don't, then they must have final fields. This isn't particularly enforced, though. This also renames _willSync() to _retainStatefulNodeIfPossible(), for clarity, and fixes some minor style issues and one typo that was breaking the drawer. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174023003
-
由 Collin Jackson 提交于
Renders interactive_flex and stocks demos fine. Could use more testing, so I'm going to work on that after I land this. R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1173493003
-
由 Matt Perry 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1175763002.
-
由 Adam Barth 提交于
Previously, the ink splashes would disappear immediately because the button highlight would change the structure of the component hierarchy and we weren't smart enough to retain the underlying RenderInkSplash. This CL is a point fix for that issue by avoiding changing the structure of the component hierarchy. A more complete fix would be to make Container smarter about how it syncs its subcomponents. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1168323003.
-
由 Adam Barth 提交于
This CL replaces the (non-working) components2 InkWell with some code based on the ink_well example. There are at least two issues with the implementation: 1) The ink splash always starts at the center of the well because we don't have a facility for converting from global to local coordinates, which means we can't tell where the tap occurred in the local coordinates we need to use for painting. 2) When used inside a MenuItem, the in splash disappears shortly after starting, presumably because the button starts highlighting, which causes a component rebuild and somehow we lose the RenderInkWell instance. I plan to address these issues in subsequent CLs. R=ianh@google.com Review URL: https://codereview.chromium.org/1172033003.
-
- 10 6月, 2015 10 次提交
-
-
由 Eric Seidel 提交于
I also fixed image_cache to not even bother to call ImageDecoder in the 404 case, but I also fixed CanvasImageDecoder not to blow up if the buffer is empty and its not able to allocate an ImageDecoder. Closes https://github.com/domokit/mojo/issues/229 R=abarth@chromium.org, jackson@google.com Review URL: https://codereview.chromium.org/1170413002.
-
由 Hixie 提交于
I accidentally removed two lines of code in https://codereview.chromium.org/1172173002 when merging upsteam before landing. TBR=abarth Review URL: https://codereview.chromium.org/1171163005
-
由 Hixie 提交于
- constructors first - have either a blank line at the top and bottom of each class, or no blank line in either place (it's still inconsistent about which we should do) - hide clamp() R=abarth@chromium.org Review URL: https://codereview.chromium.org/1172173002
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1171273002
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174683005
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1173783002
-
由 Adam Barth 提交于
Instead of triggering layout synchronously during AppView construction, we now schedule the initial layout using a magic bootstrapping function. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1172123003.
-
由 Adam Barth 提交于
This CL implements a basic version of screen rotation where we just relayout at the new size. In the future, we'll want a fancy version where we transition between the two layouts. R=ianh@google.com BUG= Review URL: https://codereview.chromium.org/1177563002.
-
由 Hixie 提交于
Add asserts to prevent people from setting box.parentData.position or box.size except during layout. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1176623002
-
由 Matt Perry 提交于
Also added a helper class to Sky framework for building shadow DrawLoopers. R=abarth@chromium.org, eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1175683002.
-