- 12 6月, 2015 1 次提交
-
-
由 Hixie 提交于
This moves input.dart to editing2/, since that way we can define the layering as strictly unidirectional. It also reorders a bunch of imports to fit the style guide. I removed the old remnants of the widgets example, and put the fn2 examples into the examples/widgets/ directory, to parallel the framework directory names. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177243002.
-
- 11 6月, 2015 7 次提交
-
-
由 Adam Barth 提交于
These are now called Block, Stack, and Flex, respectively. Less verbose. R=jackson@google.com, ianh@google.com Review URL: https://codereview.chromium.org/1181533002.
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1181453003
-
由 Adam Barth 提交于
Previously it was propagating for a constant duration. R=ianh@google.com Review URL: https://codereview.chromium.org/1173173002.
-
由 Hixie 提交于
Turns out that reintroducing the field in each subclass is probably allocating more storage per node. So let's not do that. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177483004
-
由 Adam Barth 提交于
Previously, they always started at the center of the RenderInkWell. Now we remember the local coordinates we computed during the hit test and provide that information when handling the event. R=ianh@google.com Review URL: https://codereview.chromium.org/1180553002.
-
由 Hixie 提交于
This also removes one bit of magic to make it more obvious what on is going on during a sync, which should hopefully help. Components have to decide if they support being stateful or not. If they do, then they must implement syncFields() and have mutable fields; if they don't, then they must have final fields. This isn't particularly enforced, though. This also renames _willSync() to _retainStatefulNodeIfPossible(), for clarity, and fixes some minor style issues and one typo that was breaking the drawer. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174023003
-
由 Adam Barth 提交于
This CL replaces the (non-working) components2 InkWell with some code based on the ink_well example. There are at least two issues with the implementation: 1) The ink splash always starts at the center of the well because we don't have a facility for converting from global to local coordinates, which means we can't tell where the tap occurred in the local coordinates we need to use for painting. 2) When used inside a MenuItem, the in splash disappears shortly after starting, presumably because the button starts highlighting, which causes a component rebuild and somehow we lose the RenderInkWell instance. I plan to address these issues in subsequent CLs. R=ianh@google.com Review URL: https://codereview.chromium.org/1172033003.
-
- 10 6月, 2015 1 次提交
-
-
由 Hixie 提交于
- constructors first - have either a blank line at the top and bottom of each class, or no blank line in either place (it's still inconsistent about which we should do) - hide clamp() R=abarth@chromium.org Review URL: https://codereview.chromium.org/1172173002
-
- 09 6月, 2015 1 次提交
-
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1164363002
-
- 05 6月, 2015 3 次提交
-
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1162623011
-
由 Hixie 提交于
https://www.dartlang.org/articles/style-guide/#names R=jackson@google.com Review URL: https://codereview.chromium.org/1158813004
-
由 Collin Jackson 提交于
R=abarth@chromium.org, ianh@google.com, abarth, hixie Review URL: https://codereview.chromium.org/1165983002
-
- 29 5月, 2015 1 次提交
-
-
由 Adam Barth 提交于
Previously layout2.dart was a thousand lines long. R=ianh@google.com Review URL: https://codereview.chromium.org/1161003002
-
- 28 5月, 2015 1 次提交
-
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1153223003
-
- 27 5月, 2015 1 次提交
-
-
由 Hixie 提交于
Eventually this'll be merged back into components/, but we want to keep both running for now. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1158713007
-
- 20 5月, 2015 2 次提交
-
-
由 John McCutchan 提交于
Revert "Add library names to many sky libraries" This reverts commit 1337e0a803a54ee92d6dce7f8c4a6335f7cbb9fa. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1142893007
-
由 John McCutchan 提交于
- Analyzer complains about libraries not having names. This adds names to many libraries. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1150433002
-
- 19 5月, 2015 1 次提交
-
-
由 John McCutchan 提交于
NOTE: This CL appears far larger than it actually is for two reasons: 1) Many files were moved around to use the Dart package directory structure. 2) Many .dart files had to have import paths updated. - Organize mojo/public/dart so that it uses standard Dart package layout - Organize mojo/dart/apptest so that it uses a standard Dart package layout - Organize sky/sdk so that it uses a standard Dart package layout - Create a mojo/testing package (used by unittests) - Introduce the 'dart_pkg' gn rule which populates gen/Config/dart-pkg - All internally vended Dart packages must have a corresponding dart_pkg rule - It is now possible to use dependency_overrides: in pubspec.yaml to mix internal and external package dependencies (enables analyzer, editor, webstorm usage for internal developers). - Package root for dart content handler ends with "packages/" - Imports of mojo package uris no longer need the "public/dart" - mojo/public/tools/dart_package.py is a clone of mojo/public/tools/gn/zip.py - Sky tests no longer run 'deploy_sdk' script. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1132063007
-
- 13 5月, 2015 1 次提交
-
-
由 Hixie 提交于
- add a checkbox to the stock app, so that we're testing the checkbox widget (it's not currently wired up to anything, that can come later) - make InkSplash use FlexContainer so that we can use flex in the popup menu items - make effen's Text be more similar to Image and Container, so that it can be styled - make layout.dart's RenderCSSText correctly support being styled - also fixes a bug with the stock list where we were rendering one too few a row when scrolling - check in the code to dump the DOM so I don't have to keep remembering how to do this R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1134163003
-
- 09 5月, 2015 1 次提交
-
-
由 Hixie 提交于
[Effen] Port fn.dart from the legacy sky.Node backend to the RenderNode backend, which is currently just a sky.Node-backed shim, but will eventually be the core Sky interface for layout and painting. - the custom layout class in fn is removed by this patch; a new class will be added in a later CL - the version of layout.dart in this CL is a subset of what we're targetting on the long run with https://codereview.chromium.org/1093633002 - a couple of lines of dead code are removed in this CL also R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1117143003
-
- 21 4月, 2015 1 次提交
-
-
由 Hixie 提交于
Pipe the remaining time for an animation all the way out to the AnimatedValue. Make splashes abortable, which causes them to continue to fade but no longer grow, by having them fade in 100ms or however long the animation was still going to go for, whichever is quickest. Make Scrollables support objects registering with them to be told when scrolling happens. Make UINode support subclasses being informed when _remove() was called. Hook all that together to make splashes go away when scrolling by having them register with any ancestor Scrollables such that when those scroll, all the splashes get aborted. Unregister when removed. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1092423003
-
- 02 4月, 2015 1 次提交
-
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1043283003
-
- 26 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
There's no reason for InkWell to take a |style| parameter anymore. Clients can simply use StyleNode instead. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1019443003
-
- 16 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
This patch adds a base AnimatedComponent from which most components that animated should derive. It takes care of listening & unlistening from the animations during did(Un)mount as well as binding the animated value to a private field and scheduling the component for build. Note that this patch removes the did(Un)mount overridable methods from Component and replaces them with a callback mechanism which is less brittle. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1027633003
-
- 20 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
1) Factors InkWell out of Material so that components can use an ink well without needing the shadow/level machinery. 2) Makes the ink effect move at a different velocity once the tap has actually occurred, converging with the spec. We don't have the right speeds yet, but at least we're approaching the right shape. 3) To support (2), added a primaryPointer attribute to GestureEvents to let authors coorelate gesturetapdown events with later gesturetap events. 4) To support (2), modernized SplashAnimation to used AnimatedValue and friends. 5) Added more constants to view-configuration.dart that match Android. I've also removed the cancelling of the ink effect on scroll. The proper way to do that is to notice that someone in the event chain is listening for scrollstart and delay the beginning of the ink effect for some period of time. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1019023003
-
- 16 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
This patch removes the mutable API to event handling (Nodes no longer have a events object with which to add listeners). Instead, a new (non-Render) Node is introduced: EventTarget. This node represents a location in the Effen tree which can handle events as they bubble. Note that this also changes the implementation to use event delegation (one set of listeners at the sky.document level) rather than direct listeners on leaf nodes. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1019633004
-
- 17 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
This CL is a warmup for using a more sophisticated gesture disambiguation. 1) Use gesturetap instead of click. We should probably remove click events because folks should use gesturetap to integrate with the gesture system. 2) Handle the case where you swipe the drawer during an animation. Previously we had an assert which triggered in some multitouch scenarios. We'll eventually move this over to gestureswipe. 3) Remove an extra container for ink splashes. There's no need to group all the ink splashes in a container. They can all just be children of the Material component itself. This structure is left over from when Material was a base class. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1013713005
-
- 14 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1006053002
-
- 12 3月, 2015 3 次提交
-
-
由 Adam Barth 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1000863002
-
由 Adam Barth 提交于
To accomplish this, I made the following changes: 1) Material is now in charge of drawing the material shadows. 2) In order to mix in the style for the shadow, Element now takes a list of Styles instead of a single style. 3) Update all clients of Element#style to understand that we now have a list. 4) Update components that drawer shadows to have Material do that work instead. a) One exception: FloatingActionButton draws its own shadow because of its crazy clip requirements. We'll probably want to find a better way for FloatingActionButton to clip in the future. I've also added a widgets-fn example to demo the fn material widgets. This CL introduces a bug into Drawer whereby you can get ink splashes everywhere in the drawer. In the future, we'll need to separate out the different material aspects to get non-splashable materials. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1003553002
-
由 Adam Barth 提交于
Instead of MaterialComponent being a base class, components that want material behavior simply create a MaterialComponent during their render function. This approach gives the component more flexibility as to its structure and gives MaterialComponent more flexibility has to how the components it generates are related to the existing children. Also, I've improved some of the event delegation code. There's no reason to attach event handlers to the root component you emit during |render| because the framework already delegates events from your root component to you. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/983903003
-
- 11 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
Moving these files into sky/framework will make them easier to use from the SDK. Also, this CL also splits up the giant "widgets" library into smaller libraries, one per component. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/993033003
-
- 10 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
"Render" is misleading. "Build" may not be the best word either, it's closer to what's actually happening. R=ojan@chromium.org TBR=abarth BUG= Review URL: https://codereview.chromium.org/992033002
-
- 07 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
This patch changes the timing of the unmount call until after the component is removed (and marked as such) and allows setState to be called after this point. If this happens, setState will still invoke the closer to do any neccesary cleanup, but doesn't schedule the component for render R=eseidel@chromium.org, eseidel BUG= Review URL: https://codereview.chromium.org/985853002
-
- 06 3月, 2015 2 次提交
-
-
由 Eric Seidel 提交于
To test: sky/tools/shelldb analyze sky/examples/stocks-fn/stocksapp.dart It prints 600+ warnings about the "native" keyword, and after this change only a couple warnings about missing library names which I don't fully understand. R=abarth@chromium.org Review URL: https://codereview.chromium.org/987613002
-
由 Adam Barth 提交于
This CL changes how events work in fn. Previously, event listeners were passed in as constructor arguments. Now Nodes hold an |events| object, which contains all the event registrations. When a Component renders, all its |events| are copied onto the Node it produces. When an Element syncs, it walks its |events| and adds them as event listeners on the underlying sky.Element. The net result of this change is increased flexibility in how events are registered. Now components don't need to enumerate all the possible events that they support. Instead, the parent component can listen for whatever events it likes. Also, I've cleaned up the association between DrawerAnimation and Drawer. Now the constructor for Drawer accepts an |animation| object and wires up its internal event handlers itself instead of requiring the constructor to do all the wiring. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/975863003
-
- 04 3月, 2015 1 次提交
-
-
由 Hixie 提交于
TBR=raf Review URL: https://codereview.chromium.org/974903005
-