- 12 6月, 2015 1 次提交
-
-
由 Hixie 提交于
This moves input.dart to editing2/, since that way we can define the layering as strictly unidirectional. It also reorders a bunch of imports to fit the style guide. I removed the old remnants of the widgets example, and put the fn2 examples into the examples/widgets/ directory, to parallel the framework directory names. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177243002.
-
- 11 6月, 2015 1 次提交
-
-
由 Hixie 提交于
This also removes one bit of magic to make it more obvious what on is going on during a sync, which should hopefully help. Components have to decide if they support being stateful or not. If they do, then they must implement syncFields() and have mutable fields; if they don't, then they must have final fields. This isn't particularly enforced, though. This also renames _willSync() to _retainStatefulNodeIfPossible(), for clarity, and fixes some minor style issues and one typo that was breaking the drawer. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174023003
-
- 10 6月, 2015 1 次提交
-
-
由 Hixie 提交于
- constructors first - have either a blank line at the top and bottom of each class, or no blank line in either place (it's still inconsistent about which we should do) - hide clamp() R=abarth@chromium.org Review URL: https://codereview.chromium.org/1172173002
-
- 06 6月, 2015 1 次提交
-
-
由 Hixie 提交于
Export Point, Size, Rect, Color, Paint, Path, BoxDecoration, Border, BorderSide, EdgeDims, and FlexDirection from fn2.dart That way most of our libraries don't have to use sky.Foo all over the place, and we can reduce the number of imports in most Dart components. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1161323004
-
- 04 6月, 2015 3 次提交
-
-
由 Eric Seidel 提交于
I also moved Icon back to using int, since double doesn't actually make sense for an icon pixel size. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1164023005
-
由 Eric Seidel 提交于
Even though Image doesn't yet know how to handle relative urls. TBR=jackson@google.com Review URL: https://codereview.chromium.org/1157163009
-
由 Matt Perry 提交于
Also add operator==, hashCode, toString, and some basic Color constants to Color. R=abarth@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1162023004
-
- 03 6月, 2015 1 次提交
-
-
由 Eric Seidel 提交于
Looks horrible. But it's a start. R=abarth@chromium.org, ianh@google.com BUG= Review URL: https://codereview.chromium.org/1146913005
-
- 28 5月, 2015 1 次提交
-
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1153223003
-
- 27 5月, 2015 1 次提交
-
-
由 Hixie 提交于
Eventually this'll be merged back into components/, but we want to keep both running for now. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1158713007
-
- 20 5月, 2015 2 次提交
-
-
由 John McCutchan 提交于
Revert "Add library names to many sky libraries" This reverts commit 1337e0a803a54ee92d6dce7f8c4a6335f7cbb9fa. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1142893007
-
由 John McCutchan 提交于
- Analyzer complains about libraries not having names. This adds names to many libraries. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1150433002
-
- 19 5月, 2015 1 次提交
-
-
由 John McCutchan 提交于
NOTE: This CL appears far larger than it actually is for two reasons: 1) Many files were moved around to use the Dart package directory structure. 2) Many .dart files had to have import paths updated. - Organize mojo/public/dart so that it uses standard Dart package layout - Organize mojo/dart/apptest so that it uses a standard Dart package layout - Organize sky/sdk so that it uses a standard Dart package layout - Create a mojo/testing package (used by unittests) - Introduce the 'dart_pkg' gn rule which populates gen/Config/dart-pkg - All internally vended Dart packages must have a corresponding dart_pkg rule - It is now possible to use dependency_overrides: in pubspec.yaml to mix internal and external package dependencies (enables analyzer, editor, webstorm usage for internal developers). - Package root for dart content handler ends with "packages/" - Imports of mojo package uris no longer need the "public/dart" - mojo/public/tools/dart_package.py is a clone of mojo/public/tools/gn/zip.py - Sky tests no longer run 'deploy_sdk' script. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1132063007
-
- 02 4月, 2015 1 次提交
-
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1043283003
-
- 25 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
This CL cleans up stock_app.dart to better separate concerns now that we have StyleNode. Also, this CL introduces IconButton, which will grow to include an ink effect in the future, and makes the background of the search bar white. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1007893005
-
- 14 3月, 2015 2 次提交
-
-
由 Eric Seidel 提交于
Dart actually expects package: to work. This CL makes package:foo map to /packages/foo, similar to how Dartium or bin/dart would expect. This also means overlaying the /gen directory over the actual package outputs (as consumers of an SDK would expect) as well as adding an additional /lib indirection for the actual package source as the Dart pub tool will expect. This is far from perfect, but it unlocks us actually producing a sky SDK. I expect there may be some fallout from this change as I'm sure I missed some package: uses. We also don't have a general solution for all /foo/bar/baz includes which randomly included parts of mojo's source directory. Those will need to be updated to use a package: and deploy_sdk.py taught how to build a package for them. R=abarth@chromium.org Review URL: https://codereview.chromium.org/990493002
-
由 Rafael Weinstein 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1006053002
-
- 12 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
To accomplish this, I made the following changes: 1) Material is now in charge of drawing the material shadows. 2) In order to mix in the style for the shadow, Element now takes a list of Styles instead of a single style. 3) Update all clients of Element#style to understand that we now have a list. 4) Update components that drawer shadows to have Material do that work instead. a) One exception: FloatingActionButton draws its own shadow because of its crazy clip requirements. We'll probably want to find a better way for FloatingActionButton to clip in the future. I've also added a widgets-fn example to demo the fn material widgets. This CL introduces a bug into Drawer whereby you can get ink splashes everywhere in the drawer. In the future, we'll need to separate out the different material aspects to get non-splashable materials. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1003553002
-
- 11 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
Moving these files into sky/framework will make them easier to use from the SDK. Also, this CL also splits up the giant "widgets" library into smaller libraries, one per component. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/993033003
-
- 10 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
"Render" is misleading. "Build" may not be the best word either, it's closer to what's actually happening. R=ojan@chromium.org TBR=abarth BUG= Review URL: https://codereview.chromium.org/992033002
-
- 06 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
This CL changes how events work in fn. Previously, event listeners were passed in as constructor arguments. Now Nodes hold an |events| object, which contains all the event registrations. When a Component renders, all its |events| are copied onto the Node it produces. When an Element syncs, it walks its |events| and adds them as event listeners on the underlying sky.Element. The net result of this change is increased flexibility in how events are registered. Now components don't need to enumerate all the possible events that they support. Instead, the parent component can listen for whatever events it likes. Also, I've cleaned up the association between DrawerAnimation and Drawer. Now the constructor for Drawer accepts an |animation| object and wires up its internal event handlers itself instead of requiring the constructor to do all the wiring. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/975863003
-
- 03 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
This is just a proof of concept. If we like this direction, it will move out of the examples directory (likely re-written) and be committed in smaller pieces with unit tests and formal reviews. TBR=abarth BUG= Review URL: https://codereview.chromium.org/971183002
-