- 12 6月, 2015 1 次提交
-
-
由 Hixie 提交于
This moves input.dart to editing2/, since that way we can define the layering as strictly unidirectional. It also reorders a bunch of imports to fit the style guide. I removed the old remnants of the widgets example, and put the fn2 examples into the examples/widgets/ directory, to parallel the framework directory names. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177243002.
-
- 11 6月, 2015 3 次提交
-
-
由 Collin Jackson 提交于
R=abarth@chromium.org, ianh@google.com, abarth Review URL: https://codereview.chromium.org/1174203002
-
由 Adam Barth 提交于
These are now called Block, Stack, and Flex, respectively. Less verbose. R=jackson@google.com, ianh@google.com Review URL: https://codereview.chromium.org/1181533002.
-
由 Hixie 提交于
This also removes one bit of magic to make it more obvious what on is going on during a sync, which should hopefully help. Components have to decide if they support being stateful or not. If they do, then they must implement syncFields() and have mutable fields; if they don't, then they must have final fields. This isn't particularly enforced, though. This also renames _willSync() to _retainStatefulNodeIfPossible(), for clarity, and fixes some minor style issues and one typo that was breaking the drawer. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174023003
-
- 10 6月, 2015 1 次提交
-
-
由 Adam Barth 提交于
Also, I've fixed the mask color on the drawer. R=ianh@google.com Review URL: https://codereview.chromium.org/1168203004.
-
- 06 6月, 2015 1 次提交
-
-
由 Hixie 提交于
Export Point, Size, Rect, Color, Paint, Path, BoxDecoration, Border, BorderSide, EdgeDims, and FlexDirection from fn2.dart That way most of our libraries don't have to use sky.Foo all over the place, and we can reduce the number of imports in most Dart components. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1161323004
-
- 05 6月, 2015 3 次提交
-
-
由 Adam Barth 提交于
This CL makes FixedHeightScrollable able to measure heights. In the DOM-based version, FixedHeightScrollable forced a synchronous layout in a microtask in order to measure the size of itself and its children. In the DOM-less version, we now require the subclass to tell us the item height and we measure our own height using a layout callback. R=ianh@google.com Review URL: https://codereview.chromium.org/1161063005
-
由 Adam Barth 提交于
In the future, we might want to extend this class to clip to a configurable rect in addition to clipping to its bounds. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1145263006
-
由 Adam Barth 提交于
We still need to add a clip and a way to integrate with layout, but those changes are more invasive and I'll do them in separate CLs. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1166983003
-
- 28 5月, 2015 1 次提交
-
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1153223003
-
- 27 5月, 2015 1 次提交
-
-
由 Hixie 提交于
Eventually this'll be merged back into components/, but we want to keep both running for now. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1158713007
-
- 20 5月, 2015 2 次提交
-
-
由 John McCutchan 提交于
Revert "Add library names to many sky libraries" This reverts commit 1337e0a803a54ee92d6dce7f8c4a6335f7cbb9fa. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1142893007
-
由 John McCutchan 提交于
- Analyzer complains about libraries not having names. This adds names to many libraries. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1150433002
-
- 19 5月, 2015 1 次提交
-
-
由 John McCutchan 提交于
NOTE: This CL appears far larger than it actually is for two reasons: 1) Many files were moved around to use the Dart package directory structure. 2) Many .dart files had to have import paths updated. - Organize mojo/public/dart so that it uses standard Dart package layout - Organize mojo/dart/apptest so that it uses a standard Dart package layout - Organize sky/sdk so that it uses a standard Dart package layout - Create a mojo/testing package (used by unittests) - Introduce the 'dart_pkg' gn rule which populates gen/Config/dart-pkg - All internally vended Dart packages must have a corresponding dart_pkg rule - It is now possible to use dependency_overrides: in pubspec.yaml to mix internal and external package dependencies (enables analyzer, editor, webstorm usage for internal developers). - Package root for dart content handler ends with "packages/" - Imports of mojo package uris no longer need the "public/dart" - mojo/public/tools/dart_package.py is a clone of mojo/public/tools/gn/zip.py - Sky tests no longer run 'deploy_sdk' script. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1132063007
-
- 13 5月, 2015 1 次提交
-
-
由 Hixie 提交于
- add a checkbox to the stock app, so that we're testing the checkbox widget (it's not currently wired up to anything, that can come later) - make InkSplash use FlexContainer so that we can use flex in the popup menu items - make effen's Text be more similar to Image and Container, so that it can be styled - make layout.dart's RenderCSSText correctly support being styled - also fixes a bug with the stock list where we were rendering one too few a row when scrolling - check in the code to dump the DOM so I don't have to keep remembering how to do this R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1134163003
-
- 09 5月, 2015 1 次提交
-
-
由 Hixie 提交于
[Effen] Port fn.dart from the legacy sky.Node backend to the RenderNode backend, which is currently just a sky.Node-backed shim, but will eventually be the core Sky interface for layout and painting. - the custom layout class in fn is removed by this patch; a new class will be added in a later CL - the version of layout.dart in this CL is a subset of what we're targetting on the long run with https://codereview.chromium.org/1093633002 - a couple of lines of dead code are removed in this CL also R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1117143003
-
- 28 4月, 2015 2 次提交
-
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1104233003
-
由 Hixie 提交于
TBR=hansmuller Review URL: https://codereview.chromium.org/1102393002
-
- 22 4月, 2015 1 次提交
-
-
由 Hixie 提交于
- make the ScrollBehavior instance long-lived, rather than recreating it each time we update the list contents. - have OverscrollBehavior track the total height of the contents and the height of the scrollable region, so that it can determine when to stop scrolling down. - teach OverscrollBehavior about how to determine when to stop scrolling down, and how to bounce when it's too far down. - replace the 'energy' concept in Particles with a method that sets the energy and direction at the same time, instead of assuming that the direction is always positive when setting energy. - make FixedHeightScrollable lists track the number of items in the list and have them update their ScrollBehavior regarding this information as it changes. - track how many items are currently showing in the list stock list. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1097373002
-
- 15 4月, 2015 1 次提交
-
-
由 Hixie 提交于
[Effen] Custom layout. For now, FixedHeightScrollable uses a custom BlockLayout algorithm, mostly as a proof of concept. R=ojan@chromium.org Review URL: https://codereview.chromium.org/1064983002
-
- 02 4月, 2015 1 次提交
-
-
由 Hixie 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1043283003
-
- 24 3月, 2015 2 次提交
-
-
由 Adam Barth 提交于
This will let us form a wholistic picture of work done in the framework and in the engine. R=ojan@chromium.org, rafaelw@chromium.org Review URL: https://codereview.chromium.org/1028243003
-
由 Adam Barth 提交于
Instead of hard-coding the stock data in the Dart file, this CL moves the data to a JSON file and loads that file over the network. This change improves load time for the Stocks app from 3 seconds to 2 seconds. Also, this CL removes shake-to-reload from the Stocks app because that also slows down load time (due to the two module systems fighting each other). R=rafaelw@chromium.org, ojan@chromium.org Review URL: https://codereview.chromium.org/1021723005
-
- 17 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
This patch adds a new (non-Render) StyleNode which takes two arguments: A (content) node, which it wraps and a Style object. This allows for styles to be applied to Nodes which are constructed elsewhere (e.g. passed in as arguments). R=abarth@chromium.org Review URL: https://codereview.chromium.org/1027653002
-
- 16 3月, 2015 2 次提交
-
-
由 Rafael Weinstein 提交于
This patch adds a base AnimatedComponent from which most components that animated should derive. It takes care of listening & unlistening from the animations during did(Un)mount as well as binding the animated value to a private field and scheduling the component for build. Note that this patch removes the did(Un)mount overridable methods from Component and replaces them with a callback mechanism which is less brittle. BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1027633003
-
由 Rafael Weinstein 提交于
This patch removes the mutable API to event handling (Nodes no longer have a events object with which to add listeners). Instead, a new (non-Render) Node is introduced: EventTarget. This node represents a location in the Effen tree which can handle events as they bubble. Note that this also changes the implementation to use event delegation (one set of listeners at the sky.document level) rather than direct listeners on leaf nodes. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1019633004
-
- 14 3月, 2015 3 次提交
-
-
由 Adam Barth 提交于
We now use a physics simulationt to drive the scroll fling. We're also closer to integrating fling into overscroll. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1004363002
-
由 Rafael Weinstein 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1006053002
-
由 Adam Barth 提交于
This CL cleans up the sky/framework/animation as follows: 1) I've moved code that's used only by the custom elements framework into sky/framework/elements/animation. This code is based on AnimationDelegates rather than Streams. 2) Rename ScrollCurve to ScrollBehavior because it encapsulates more behavior than just a curve. 3) Make the Generator interface explicit and mark subclasses as actual subclasses. 4) Move Simulation into generators.dart because it implements the Generator interface. 5) Move Animation out of generators.dart because it does not implement the Generator interface. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1001373002
-
- 13 3月, 2015 4 次提交
-
-
由 Adam Barth 提交于
When using OverscrollCurve, we continue to scroll beyond the top of the scrollable area but the scroll delta is reduced by 2x. A future CL will add an animation at gesturescrollend to relax back to scroll position 0.0. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1002953003
-
由 Adam Barth 提交于
Intead of hard-coding the notion of bounded scrolling into Scrollable, this CL factors out a ScrollCurve class that applies the bounds. In the future, we'll refine this mechanism to implement overflow scrolling. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1005633002
-
由 Adam Barth 提交于
This class encapsulates the scrolling behavior but not the mechanism for building the visual components. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1006533002
-
由 Adam Barth 提交于
We're using underscores as word separators per Dart style. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/998373002
-
- 12 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
To accomplish this, I made the following changes: 1) Material is now in charge of drawing the material shadows. 2) In order to mix in the style for the shadow, Element now takes a list of Styles instead of a single style. 3) Update all clients of Element#style to understand that we now have a list. 4) Update components that drawer shadows to have Material do that work instead. a) One exception: FloatingActionButton draws its own shadow because of its crazy clip requirements. We'll probably want to find a better way for FloatingActionButton to clip in the future. I've also added a widgets-fn example to demo the fn material widgets. This CL introduces a bug into Drawer whereby you can get ink splashes everywhere in the drawer. In the future, we'll need to separate out the different material aspects to get non-splashable materials. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/1003553002
-
- 11 3月, 2015 1 次提交
-
-
由 Adam Barth 提交于
Moving these files into sky/framework will make them easier to use from the SDK. Also, this CL also splits up the giant "widgets" library into smaller libraries, one per component. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/993033003
-
- 10 3月, 2015 2 次提交
-
-
由 Rafael Weinstein 提交于
"Render" is misleading. "Build" may not be the best word either, it's closer to what's actually happening. R=ojan@chromium.org TBR=abarth BUG= Review URL: https://codereview.chromium.org/992033002
-
由 Rafael Weinstein 提交于
Ensure that sky Nodes are in the document when didMount() is fired. Refactor FixedHeightScrollable to inspect heights rather than having the passed in BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/994553003
-
- 07 3月, 2015 1 次提交
-
-
由 Rafael Weinstein 提交于
This patch changes the timing of the unmount call until after the component is removed (and marked as such) and allows setState to be called after this point. If this happens, setState will still invoke the closer to do any neccesary cleanup, but doesn't schedule the component for render R=eseidel@chromium.org, eseidel BUG= Review URL: https://codereview.chromium.org/985853002
-
- 06 3月, 2015 2 次提交
-
-
由 Eric Seidel 提交于
To test: sky/tools/shelldb analyze sky/examples/stocks-fn/stocksapp.dart It prints 600+ warnings about the "native" keyword, and after this change only a couple warnings about missing library names which I don't fully understand. R=abarth@chromium.org Review URL: https://codereview.chromium.org/987613002
-
由 Adam Barth 提交于
This CL changes how events work in fn. Previously, event listeners were passed in as constructor arguments. Now Nodes hold an |events| object, which contains all the event registrations. When a Component renders, all its |events| are copied onto the Node it produces. When an Element syncs, it walks its |events| and adds them as event listeners on the underlying sky.Element. The net result of this change is increased flexibility in how events are registered. Now components don't need to enumerate all the possible events that they support. Instead, the parent component can listen for whatever events it likes. Also, I've cleaned up the association between DrawerAnimation and Drawer. Now the constructor for Drawer accepts an |animation| object and wires up its internal event handlers itself instead of requiring the constructor to do all the wiring. R=rafaelw@chromium.org Review URL: https://codereview.chromium.org/975863003
-