- 27 2月, 2015 7 次提交
-
-
由 Zachary Anderson 提交于
This change causes the generated abstract class having the same name as the interface to contain only the interface's method declarations. The generated Proxy class then implements the base class. In addition to implementing the interface methods, the generated Proxy class has one private field _proxyImpl, which is a MojoEventStreamListener and manages sending messages and receiving responses. Operations on the ProxyImpl (close, bind, etc.) are exposed through generated utility functions. The generated Stub is largely as before with the difference that a class providing a service will implement the mojo interface and *have* a Stub rather than be a Stub. Where appropriate, this change also calls listen() immediately where a Stub is constructed. BUG= R=hansmuller@google.com, sky@chromium.org Review URL: https://codereview.chromium.org/959993002
-
由 Eric Seidel 提交于
This makes debugging that case much easier. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/958203002
-
由 Ojan Vafai 提交于
-Move perspectiveOrigin to RenderBox. It's only used in one place and called on a RenderBox. -Inline some methods that were just calling out to the renderer. -Inline updateStackingNode() into the constructor and remove the branch since requiresStackingNode is always true. -Delete a bunch of dead code. R=abarth@chromium.org Review URL: https://codereview.chromium.org/961053002
-
由 Eric Seidel 提交于
Before this patch it crashed. Also updated the touch-demo to support multi-touch. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/961483004
-
由 Adam Barth 提交于
This CL renames SkyShell.apk to SkyDemo.apk and adds a Stocks.apk which defaults to the stocks demo app. Sky Shell is now a library that can be packaged by different APKs. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/965493002
-
由 Ojan Vafai 提交于
Inline a couple methods that are only called from one place and remove a bunch of dead code. R=abarth@chromium.org Review URL: https://codereview.chromium.org/961553003
-
由 Adam Barth 提交于
This code is unused. It's not even built. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/963513004
-
- 26 2月, 2015 6 次提交
-
-
由 Benjamin Lerman 提交于
This add the missing RequestNavigateHistory method on sky::Engine. It is currently not implemented. TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/957973003
-
由 Ojan Vafai 提交于
-m_hasSelfPaintingLayerDescendant is never read. -remove showLayerTree. The layer tree is going away. We won't need this. R=abarth@chromium.org Review URL: https://codereview.chromium.org/952343003
-
由 Adam Barth 提交于
TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/952213005
-
由 Eric Seidel 提交于
However WebView::close() no longer crashes. close() is never called in MojoShell since mojo can't shutdown yet. I tried closing the existing WebView and replacing it but somehow that caused it to only draw red. After a while of looking at this with abarth we decided to just load into the same WebView for now. Eventually we should do something smarter where we start the provisional load and only replace the webview once the new one is ready, but that's a later CL. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/952273003
-
由 Zachary Anderson 提交于
This improves consistency with the convention that the dart: scheme is only for things from the Dart standard library. BUG= R=erg@chromium.org Review URL: https://codereview.chromium.org/951783004
-
由 Adam Barth 提交于
This should let SkyShell load images. R=eseidel@chromium.org BUG=https://github.com/domokit/mojo/issues/52 Review URL: https://codereview.chromium.org/959773005
-
- 25 2月, 2015 20 次提交
-
-
由 Ojan Vafai 提交于
This is the only remaining caller. R=abarth@chromium.org Review URL: https://codereview.chromium.org/954913002
-
由 Ojan Vafai 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/943333005
-
由 Ojan Vafai 提交于
https://codereview.chromium.org/899753003 incorrectly passed down the RenderView's clipping rect all the down through transforms instead of using the one from the LayerPaintingInfo, which is adjusted for transforms as you recurse down the tree. TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/957643002
-
由 Eric Seidel 提交于
Originally reviewed for the branch on: https://codereview.chromium.org/945083002 TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/953933004
-
由 Eric Seidel 提交于
This was landed on the skyshell branch and I forgot to pull it over: https://codereview.chromium.org/946583003 TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/954893002
-
由 Ojan Vafai 提交于
-Consolidate the beginTransparencyLayers calls. The call on layer()->parent() was just not needed as best I can tell and the filter one could just be shared with the non-filter codepath. FWIW, blink has already made a similar set of changes. -Don't walk up the tree calling beginTransparencyLayer. We're doing this in a recursive call down, so we've already created the transparency layer for any transparent ancestors. -Remove unused TransparencyClipBoxMode argument. -Inline the paintingExtent method. -Removed unused REVEAL_TRANSPARENCY_LAYERS #define. R=abarth@chromium.org Review URL: https://codereview.chromium.org/959543002
-
由 Eric Seidel 提交于
I also fixed the transform hack in material-element to clean up after itself. I also discovered that our namedSetter implementation did not handle null (it crashed) while doing this. I fixed that and tested my fix. This runs great on a Nexus 5, but poorly on an Nexus 10. R=abarth@chromium.org BUG= Review URL: https://codereview.chromium.org/956753002
-
由 Adam Barth 提交于
These aren't 100% correct, but they look somewhat reasonable. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/954023002
-
由 Adam Barth 提交于
This CL makes the list view in the stocks app more consistent with the material spec by using a colored circle instead of color-coding the percentage change. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/932103004
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/957563002
-
由 Ojan Vafai 提交于
-Get rid of paintsWithTransform. -Remove currentTransform. It was only ever called with IncludeTransformOrigin and on non-null transforms. -Remove renderableTransform. It was only called on non-null transforms. -Remove a layer()->parent() branch. The ASSERT had been added in a previous patch, but the branch wasn't removed. -Inline makeMatrixRenderable. It was only called in one place. -Add a test to make sure that transform origin is corrrectly excluded from the transform computedStyle. R=abarth@chromium.org Review URL: https://codereview.chromium.org/958463002
-
由 Eric Seidel 提交于
Turns out scrollbars are very inconsistent throughout Android apps. R=abarth@chromium.org Review URL: https://codereview.chromium.org/955653005
-
由 Hixie 提交于
Review URL: https://codereview.chromium.org/959473002
-
由 Rafael Weinstein 提交于
R=abarth@chromium.org, abarth BUG= Review URL: https://codereview.chromium.org/949313002
-
由 Rafael Weinstein 提交于
This patch adds utility functions which provide a single choke point for calling into sky application code. For now this is only serving the purpose of having a common trace event for calls into app code. R=abarth@chromium.org, abarth BUG= Review URL: https://codereview.chromium.org/941153003
-
由 Adam Barth 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/950353003
-
由 Adam Barth 提交于
The menu items don't quite make sense for this app, but they're closer in visual styling. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/951413002
-
由 Adam Barth 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/953903004
-
由 Przemyslaw Pietrzkiewicz 提交于
This patch makes skydb http server available only for local connections. BUG=460908 R=abarth@chromium.org Review URL: https://codereview.chromium.org/945663003
-
由 Przemyslaw Pietrzkiewicz 提交于
This patch allows to specify a full NetAddress on which the server is to be set up. This is needed to decide between running the server on externally visible address (like http_handler would like) and localhost (like skydb would like). No change in behavior of existing clients in the Mojo repo should occur. A follow-up patch will switch some of the clients from 0.0.0.0 to localhost. BUG=460908 R=qsr@chromium.org Review URL: https://codereview.chromium.org/953513002
-
- 24 2月, 2015 7 次提交
-
-
https://crrev.com/317530由 Benjamin Lerman 提交于
TBR=qsr@chromium.org BUG=461092 Review URL: https://codereview.chromium.org/952893003
-
由 Hans Muller 提交于
Also: gratuitous simplication of ApplicationConnection.requestService(). R=abarth@chromium.org Review URL: https://codereview.chromium.org/954653002
-
由 Colin Blundell 提交于
This CL adds ApplicationDelegate::Quit(), which ApplicationImpl calls before shutting down the main run loop. In this function, an ApplicationDelegate should shut down anything that relies on the main run loop being active. R=eseidel@chromium.org, jamesr@chromium.org Review URL: https://codereview.chromium.org/947253003
-
由 Adam Barth 提交于
This CL updates the Sky widgets to be closer to the material design spec. There's still a long way to go, but this CL is a start. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/951823002
-
由 Adam Barth 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/956463002
-
由 Adam Barth 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/947383002
-
由 Adam Barth 提交于
We're going to use these assets to make pretty demos of Sky but not every developer needs them in their working copy. R=eseidel@chromium.org, jamesr@chromium.org Review URL: https://codereview.chromium.org/951063006
-