Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
大炮V587
oceanbase
提交
e7671e92
O
oceanbase
项目概览
大炮V587
/
oceanbase
与 Fork 源项目一致
Fork自
oceanbase / oceanbase
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
O
oceanbase
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
e7671e92
编写于
12月 05, 2022
作者:
S
simonjoylet
提交者:
ob-robot
1月 12, 2023
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
fix deadlock
上级
ddec7a83
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
30 addition
and
21 deletion
+30
-21
src/storage/ddl/ob_tablet_ddl_kv_mgr.cpp
src/storage/ddl/ob_tablet_ddl_kv_mgr.cpp
+30
-21
未找到文件。
src/storage/ddl/ob_tablet_ddl_kv_mgr.cpp
浏览文件 @
e7671e92
...
...
@@ -96,7 +96,8 @@ int ObTabletDDLKvMgr::ddl_start(const ObITable::TableKey &table_key,
{
int
ret
=
OB_SUCCESS
;
bool
is_brand_new
=
false
;
TCWLockGuard
guard
(
lock_
);
SCN
saved_start_scn
;
int64_t
saved_snapshot_version
=
0
;
if
(
OB_UNLIKELY
(
!
is_inited_
))
{
ret
=
OB_NOT_INIT
;
LOG_WARN
(
"not init"
,
K
(
ret
),
K
(
is_inited_
));
...
...
@@ -107,31 +108,39 @@ int ObTabletDDLKvMgr::ddl_start(const ObITable::TableKey &table_key,
}
else
if
(
table_key
.
get_tablet_id
()
!=
tablet_id_
)
{
ret
=
OB_ERR_SYS
;
LOG_WARN
(
"tablet id not same"
,
K
(
ret
),
K
(
table_key
),
K
(
tablet_id_
));
}
else
if
(
start_scn_
.
is_valid_and_not_min
())
{
if
(
execution_id
>=
execution_id_
&&
start_scn
>=
start_scn_
)
{
LOG_INFO
(
"execution id changed, need cleanup"
,
K
(
ls_id_
),
K
(
tablet_id_
),
K
(
execution_id_
),
K
(
execution_id
),
K
(
start_scn_
),
K
(
start_scn
));
cleanup_unlock
();
is_brand_new
=
true
;
}
else
{
if
(
!
checkpoint_scn
.
is_valid_and_not_min
())
{
// only return error code when not start from checkpoint.
ret
=
OB_TASK_EXPIRED
;
}
else
{
TCWLockGuard
guard
(
lock_
);
if
(
start_scn_
.
is_valid_and_not_min
())
{
if
(
execution_id
>=
execution_id_
&&
start_scn
>=
start_scn_
)
{
LOG_INFO
(
"execution id changed, need cleanup"
,
K
(
ls_id_
),
K
(
tablet_id_
),
K
(
execution_id_
),
K
(
execution_id
),
K
(
start_scn_
),
K
(
start_scn
));
cleanup_unlock
();
is_brand_new
=
true
;
}
else
{
if
(
!
checkpoint_scn
.
is_valid_and_not_min
())
{
// only return error code when not start from checkpoint.
ret
=
OB_TASK_EXPIRED
;
}
LOG_INFO
(
"ddl start ignored"
,
K
(
ls_id_
),
K
(
tablet_id_
),
K
(
execution_id_
),
K
(
execution_id
),
K
(
start_scn_
),
K
(
start_scn
));
}
LOG_INFO
(
"ddl start ignored"
,
K
(
ls_id_
),
K
(
tablet_id_
),
K
(
execution_id_
),
K
(
execution_id
),
K
(
start_scn_
),
K
(
start_scn
));
}
else
{
is_brand_new
=
true
;
}
if
(
OB_SUCC
(
ret
)
&&
is_brand_new
)
{
table_key_
=
table_key
;
cluster_version_
=
cluster_version
;
execution_id_
=
execution_id
;
start_scn_
=
start_scn
;
max_freeze_scn_
=
SCN
::
max
(
start_scn
,
checkpoint_scn
);
}
if
(
OB_SUCC
(
ret
))
{
// save variables under lock
saved_start_scn
=
start_scn_
;
saved_snapshot_version
=
table_key_
.
get_snapshot_version
();
}
}
else
{
is_brand_new
=
true
;
}
if
(
OB_SUCC
(
ret
)
&&
is_brand_new
)
{
table_key_
=
table_key
;
cluster_version_
=
cluster_version
;
execution_id_
=
execution_id
;
start_scn_
=
start_scn
;
max_freeze_scn_
=
SCN
::
max
(
start_scn
,
checkpoint_scn
);
}
if
(
OB_SUCC
(
ret
)
&&
!
checkpoint_scn
.
is_valid_and_not_min
())
{
// remove ddl sstable if exists and flush ddl start log ts and snapshot version into tablet meta
if
(
OB_FAIL
(
update_tablet
(
s
tart_scn_
,
table_key_
.
get_snapshot_version
(),
start_scn_
)))
{
if
(
OB_FAIL
(
update_tablet
(
s
aved_start_scn
,
saved_snapshot_version
,
saved_start_scn
)))
{
LOG_WARN
(
"clean up ddl sstable failed"
,
K
(
ret
),
K
(
ls_id_
),
K
(
tablet_id_
));
}
}
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录