提交 91d94ce2 编写于 作者: O obdev 提交者: ob-robot

remove links.

上级 b89fe9aa
......@@ -3494,7 +3494,7 @@ OB_INLINE bool ObNumber::try_fast_add(ObNumber &l_num, ObNumber &r_num,
}
}
res_desc.sign_ = POSITIVE;
res_desc.reserved_ = 0; // must assign 0 explicitly here, due to optimization in sql, https://work.aone.alibaba-inc.com/issue/40852179.
res_desc.reserved_ = 0; // must assign 0 explicitly here, due to optimization in sql.
}
return is_fast_panel;
......
......@@ -882,7 +882,6 @@ int ObExprAdd::add_number_number_batch(BATCH_EVAL_FUNC_ARG_DECL)
ObNumber::Desc &desc_buf = const_cast<ObNumber::Desc &> (results.at(i)->get_number_desc());
// Notice that, space of tmp is allocated in frame but without memset operation, which causes random memory content.
// And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc.
// Reference: https://work.aone.alibaba-inc.com/issue/40852179
ObNumber::Desc *res_desc = new (&desc_buf) ObNumber::Desc();
// speedup detection
if (ObNumber::try_fast_add(l_num, r_num, res_digits, *res_desc)) {
......
......@@ -995,7 +995,6 @@ int ObExprMinus::minus_number_number_batch(BATCH_EVAL_FUNC_ARG_DECL)
ObNumber::Desc &desc_buf = const_cast<ObNumber::Desc &> (results.at(i)->get_number_desc());
// Notice that, space of desc_buf is allocated in frame but without memset operation, which causes random memory content.
// And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc.
// Reference: https://work.aone.alibaba-inc.com/issue/40852179
ObNumber::Desc *res_desc = new (&desc_buf) ObNumberDesc();
// speedup detection
if (ObNumber::try_fast_minus(l_num, r_num, res_digits, *res_desc)) {
......
......@@ -762,7 +762,6 @@ int ObExprMul::mul_number_batch(BATCH_EVAL_FUNC_ARG_DECL)
ObNumber::Desc &desc_buf = const_cast<ObNumber::Desc &> (results.at(i)->get_number_desc());
// Notice that, space of desc_buf is allocated in frame but without memset operation, which causes random memory content.
// And the reserved in storage layer should be 0, thus you must replacement new here to avoid checksum error, etc.
// Reference: https://work.aone.alibaba-inc.com/issue/40852179
ObNumber::Desc *res_desc = new (&desc_buf) ObNumber::Desc();
// speedup detection
if (ObNumber::try_fast_mul(l_num, r_num, res_digits, *res_desc)) {
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册