提交 af056cd1 编写于 作者: D Daniel Imms

Remove resolved TODOs

上级 7ad78e65
......@@ -78,10 +78,6 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess
const results = await Promise.all([this._validateCwd(), this._validateExecutable()]);
const firstError = results.find(r => r !== undefined);
if (firstError) {
// TODO: Anything else we need to do here to tear down the terminal instance?
// this._processStartupComplete = Promise.resolve(undefined);
// this._onProcessExit.fire(0);
return firstError;
}
......@@ -89,8 +85,6 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess
this.setupPtyProcess(this._shellLaunchConfig, this._ptyOptions);
return undefined;
} catch (err) {
// TODO: Anything else we need to do here to tear down the terminal instance?
// A native exception occurred
this._logService.trace('IPty#spawn native exception', err);
return { message: `A native exception occurred during launch (${err.message})` };
}
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册