From af056cd159a0427e682815ca48971b9fa26d8d02 Mon Sep 17 00:00:00 2001 From: Daniel Imms Date: Fri, 12 Jun 2020 11:33:32 -0700 Subject: [PATCH] Remove resolved TODOs --- src/vs/workbench/contrib/terminal/node/terminalProcess.ts | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/vs/workbench/contrib/terminal/node/terminalProcess.ts b/src/vs/workbench/contrib/terminal/node/terminalProcess.ts index 502cbfacf58..a66322eb69a 100644 --- a/src/vs/workbench/contrib/terminal/node/terminalProcess.ts +++ b/src/vs/workbench/contrib/terminal/node/terminalProcess.ts @@ -78,10 +78,6 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess const results = await Promise.all([this._validateCwd(), this._validateExecutable()]); const firstError = results.find(r => r !== undefined); if (firstError) { - // TODO: Anything else we need to do here to tear down the terminal instance? - // this._processStartupComplete = Promise.resolve(undefined); - // this._onProcessExit.fire(0); - return firstError; } @@ -89,8 +85,6 @@ export class TerminalProcess extends Disposable implements ITerminalChildProcess this.setupPtyProcess(this._shellLaunchConfig, this._ptyOptions); return undefined; } catch (err) { - // TODO: Anything else we need to do here to tear down the terminal instance? - // A native exception occurred this._logService.trace('IPty#spawn native exception', err); return { message: `A native exception occurred during launch (${err.message})` }; } -- GitLab