Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
Metz
oceanbase
提交
f5e39109
O
oceanbase
项目概览
Metz
/
oceanbase
与 Fork 源项目一致
Fork自
oceanbase / oceanbase
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
O
oceanbase
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
f5e39109
编写于
8月 18, 2021
作者:
B
br0
提交者:
wangzelin.wzl
8月 18, 2021
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Fix some checked returns found by white scan
上级
fb1c1fd7
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
20 addition
and
16 deletion
+20
-16
deps/oblib/src/lib/number/ob_number_v2.cpp
deps/oblib/src/lib/number/ob_number_v2.cpp
+20
-16
未找到文件。
deps/oblib/src/lib/number/ob_number_v2.cpp
浏览文件 @
f5e39109
...
...
@@ -1387,50 +1387,52 @@ int ObNumber::width_bucket(
ObDataBuffer
allocator2
(
buf_alloc2
,
ObNumber
::
MAX_BYTE_LEN
);
ObDataBuffer
allocator3
(
buf_alloc3
,
ObNumber
::
MAX_BYTE_LEN
);
if
(
OB_FAIL
(
bucket_num
.
from
(
bucket
,
allocator_bucket
)))
{
LOG_WARN
(
"copy bucket number failed"
,
K
(
*
this
),
K
(
bucket_num
),
K
(
ret
));
LOG_WARN
(
"copy bucket number failed"
,
K
(
bucket_num
),
K
(
ret
));
}
else
if
(
OB_FAIL
(
bucket_num
.
floor
(
0
)))
{
LOG_WARN
(
"bucket floor failed"
,
K
(
*
this
),
K
(
bucket_num
),
K
(
ret
));
LOG_WARN
(
"bucket floor failed"
,
K
(
bucket_num
),
K
(
ret
));
}
else
if
(
OB_UNLIKELY
(
bucket_num
.
is_zero
()
||
bucket_num
.
is_negative
()))
{
ret
=
OB_INVALID_ARGUMENT
;
LOG_WARN
(
"bucket < 1"
,
K
(
*
this
),
K
(
bucket_num
),
K
(
ret
));
LOG_WARN
(
"bucket < 1"
,
K
(
bucket_num
),
K
(
ret
));
}
else
{
ObNumber
range
,
offset
;
if
(
start
==
end
)
{
if
(
*
this
<
start
)
{
res
.
from
(
static_cast
<
int64_t
>
(
0
),
allocator_res
);
if
(
OB_FAIL
(
res
.
from
(
static_cast
<
int64_t
>
(
0
),
allocator_res
)))
{
LOG_WARN
(
"create number 0 failed"
,
K
(
res
),
K
(
ret
));
}
}
else
{
ObNumber
temp
;
if
(
OB_FAIL
(
temp
.
from
(
static_cast
<
int64_t
>
(
1
),
allocator1
)))
{
LOG_WARN
(
"create number 1 failed"
,
K
(
*
this
),
K
(
bucket_num
),
K
(
res
),
K
(
temp
),
K
(
ret
));
LOG_WARN
(
"create number 1 failed"
,
K
(
res
),
K
(
temp
),
K
(
ret
));
}
else
if
(
OB_FAIL
(
bucket_num
.
add
(
temp
,
res
,
allocator_res
)))
{
LOG_WARN
(
"bucket add 1 failed"
,
K
(
*
this
),
K
(
bucket_num
),
K
(
res
),
K
(
ret
));
LOG_WARN
(
"bucket add 1 failed"
,
K
(
bucket_num
),
K
(
res
),
K
(
ret
));
}
}
}
else
{
if
(
start
>
end
)
{
if
(
OB_FAIL
(
start
.
sub
(
end
,
range
,
allocator1
)))
{
LOG_WARN
(
"start sub end failed"
,
K
(
*
this
),
K
(
start
),
K
(
end
),
K
(
range
),
K
(
ret
));
LOG_WARN
(
"start sub end failed"
,
K
(
start
),
K
(
end
),
K
(
range
),
K
(
ret
));
}
else
if
(
OB_FAIL
(
start
.
sub
(
*
this
,
offset
,
allocator2
)))
{
LOG_WARN
(
"start sub target failed"
,
K
(
*
this
),
K
(
start
),
K
(
offset
),
K
(
ret
));
LOG_WARN
(
"start sub target failed"
,
K
(
start
),
K
(
offset
),
K
(
ret
));
}
}
else
{
if
(
OB_FAIL
(
end
.
sub
(
start
,
range
,
allocator1
)))
{
LOG_WARN
(
"end sub start failed"
,
K
(
*
this
),
K
(
start
),
K
(
end
),
K
(
range
),
K
(
ret
));
LOG_WARN
(
"end sub start failed"
,
K
(
start
),
K
(
end
),
K
(
range
),
K
(
ret
));
}
else
if
(
OB_FAIL
(
sub
(
start
,
offset
,
allocator2
)))
{
LOG_WARN
(
"end sub target failed"
,
K
(
*
this
),
K
(
start
),
K
(
offset
),
K
(
ret
));
LOG_WARN
(
"end sub target failed"
,
K
(
start
),
K
(
offset
),
K
(
ret
));
}
}
if
(
OB_SUCC
(
ret
))
{
if
(
offset
.
is_negative
())
{
if
(
OB_FAIL
(
res
.
from
(
static_cast
<
int64_t
>
(
0
),
allocator_res
)))
{
LOG_WARN
(
"assign 0 to res failed"
,
K
(
*
this
),
K
(
res
),
K
(
ret
));
LOG_WARN
(
"assign 0 to res failed"
,
K
(
res
),
K
(
ret
));
}
}
else
if
(
offset
>=
range
)
{
ObNumber
temp
;
if
(
OB_FAIL
(
temp
.
from
(
static_cast
<
int64_t
>
(
1
),
allocator3
)))
{
LOG_WARN
(
"create number 1 failed"
,
K
(
*
this
),
K
(
temp
),
K
(
ret
));
LOG_WARN
(
"create number 1 failed"
,
K
(
temp
),
K
(
ret
));
}
else
if
(
OB_FAIL
(
bucket_num
.
add
(
temp
,
res
,
allocator_res
)))
{
LOG_WARN
(
"bucket add 1 failed"
,
K
(
*
this
),
K
(
bucket_num
),
K
(
temp
),
K
(
res
),
K
(
ret
));
LOG_WARN
(
"bucket add 1 failed"
,
K
(
bucket_num
),
K
(
temp
),
K
(
res
),
K
(
ret
));
}
}
else
{
ObNumber
q
;
...
...
@@ -1446,16 +1448,18 @@ int ObNumber::width_bucket(
allocator2
.
free
();
std
::
swap
(
allocator2
,
allocator_res
);
if
(
OB_FAIL
(
temp
.
from
(
static_cast
<
int64_t
>
(
1
),
allocator1
)))
{
LOG_WARN
(
"create number 1 failed"
,
K
(
*
this
),
K
(
temp
),
K
(
ret
));
LOG_WARN
(
"create number 1 failed"
,
K
(
temp
),
K
(
ret
));
}
else
if
(
OB_FAIL
(
res
.
add
(
temp
,
res
,
allocator_res
)))
{
LOG_WARN
(
"value add 1 failed"
,
K
(
*
this
),
K
(
res
),
K
(
temp
),
K
(
ret
));
LOG_WARN
(
"value add 1 failed"
,
K
(
res
),
K
(
temp
),
K
(
ret
));
}
}
}
}
}
if
(
OB_SUCC
(
ret
))
{
value
.
from
(
res
,
allocator
);
if
(
OB_FAIL
(
value
.
from
(
res
,
allocator
)))
{
LOG_WARN
(
"copy res failed"
,
K
(
value
),
K
(
res
),
K
(
ret
));
}
}
}
return
ret
;
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录