- 07 7月, 2015 12 次提交
-
-
由 Adam Barth 提交于
This CL makes home.dart less of a special snowflake and instead makes it a peer to the other Sky examples. As a result, we can add a sky.yaml file and embed the thumbnail assets it needs into demo_launcher.skyx. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1215703010.
-
由 Hixie 提交于
This: - Adds asserts all over the place to make sure things are working right with respect to the parent pointer. - Fixes the bugs those asserts uncovered. It turns out we were failing to update the parent pointer in a couple of cases: when the child hadn't changed (but the parent had), and when the node was replaced. - Remove the operator[] nonsense in scaffold. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1218183009.
-
由 Hans Muller 提交于
As far as I can tell, Material TabBars are not supposed to overscroll/bounce. The new TabBarScrollBehavior class supports fling, but it doesn't overscroll/bounce. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1215713009.
-
由 Matt Perry 提交于
- The drawer mask was too dark. - The drawer didn't track the user's finger when dragging. R=ianh@google.com Review URL: https://codereview.chromium.org/1220973005.
-
由 John McCutchan 提交于
BUG= R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1224623007.
-
https://codereview.chromium.org/1218183009/由 Hixie 提交于
Trivial parts of https://codereview.chromium.org/1218183009/ so that that patch isn't confused by variable renames. TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/1222393002.
-
由 Hixie 提交于
This is done by the following steps: - Make Inherited classes notify their descendants when their state changes. - Make Components track which Inherited classes they looked at. - Make Components handle being notified of state changes by rebuilding if the changed ancestor is of a type we've looked at. - Refactor setState() and scheduleBuild(). - Make the "buildDirtyComponents" phase support incrementally building more components as each one finds it needs to update itself. The way this works is that when the menu item updates its color, it does so by changing a DefaultTextStyle (Inherited) node in its tree. That node then notifies its ancestors, which include in particular the Text component, which uses DefaultTextStyle. The notification is received, and, even though we're already in the rebuild phase, the Text queues itself up to be rebuilt as well. Since we now support adding people to the rebuild phase while it's active, it gets rebuilt as well, and all is well. This CL depends on the fix in https://codereview.chromium.org/1218183009 R=abarth@chromium.org Review URL: https://codereview.chromium.org/1222823004.
-
由 Adam Barth 提交于
We no longer have view padding during testing so these values change a bit. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1225703003.
-
由 Adam Barth 提交于
Rather than hardcoding the size and presence of the notification area in Dart, we now expose padding values on the view. These values are set to non-zero values when there are UI elements that overlap the view. We currently respect only the top padding, but this CL paves the way to respect padding in other directions. We still hardcode the size of the notification area in Java. A future CL will retrieve this value from the Android framework. Fixes #257 R=ianh@google.com Review URL: https://codereview.chromium.org/1220353002.
-
由 Adam Barth 提交于
We should remove the state from our map only if the last button is going up. Fixes #260 R=chinmaygarde@google.com Review URL: https://codereview.chromium.org/1215743003.
-
由 Hans Muller 提交于
TODO: - Make fling-scrolling work - Tune scrolling performance - When a tab is selected, snap it to the center if possible R=abarth@chromium.org Review URL: https://codereview.chromium.org/1221673006.
-
由 Adam Barth 提交于
These are now scheduleFrame/setFrameCallback. Also, update schduler.dart to not poke at sky.window, which is now always null. Fixes #178 R=ianh@google.com Review URL: https://codereview.chromium.org/1214943005.
-
- 06 7月, 2015 10 次提交
-
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth@google.com Review URL: https://codereview.chromium.org/1216613004.
-
由 Collin Jackson 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1218153005.
-
由 Benjamin Lerman 提交于
R=abarth@chromium.org, eseidel@chromium.org Review URL: https://codereview.chromium.org/1217573005.
-
由 Adam Barth 提交于
No one references this code anymore. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1219833007.
-
由 Adam Barth 提交于
No one references this code anymore. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1223793006.
-
由 Adam Barth 提交于
This CL removes all references to sky/engine/core/fetch from outside that directory. All these references appear to be dead code. Also, remove a few "loader" classes that were also dead code. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1214513003.
-
由 Adam Barth 提交于
This CL removes the ability to load remote font faces using CSS. This CL is part of a series to remove the network dependency from Sky engine. We'll likely add the ability to load custom fonts in the future, but we'll base the API on mojo::DataPipe, similar to how we load images over mojo::DataPipes today. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1223843003.
-
由 Adam Barth 提交于
This CL removes RenderImage and all the other remaining uses of ImageResource from sky/engine/core/rendering. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1228463002.
-
由 Adam Barth 提交于
This CL is part of a series to remove the network dependency from Sky Engine. This CL removes the clients of ImageResource in sky/engine/core/css. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1214633005.
-
由 Adam Barth 提交于
This code is unused. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1223783002.
-
- 05 7月, 2015 1 次提交
-
-
由 Tony Gentilcore 提交于
BUG= R=abarth@chromium.org Review URL: https://codereview.chromium.org/1210923003.
-
- 04 7月, 2015 1 次提交
-
-
由 Adam Barth 提交于
There were two problems: 1) We didn't update the demo's use of RenderImage when we switched RenderImage to take a sky.Image rather than a URL. 2) Scheduling a layout no longer ensured a visual update, which meant we'd never actually flushLayout unless something else ensured a visual update. TBR=jackson@google.com Review URL: https://codereview.chromium.org/1221273002.
-
- 03 7月, 2015 10 次提交
-
-
由 Adam Barth 提交于
This CL factors the skyx build logic out of sky/apk/rules.gni so that we can build skyx bundles without building entire APKs. This change makes it possible to build skyx bundles for all the examples (except game). TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1222673003.
-
由 Adam Barth 提交于
This CL teaches SkyDemo how to load Sky applications from local bundles. It also teaches home.dart how to request a load from a bundle. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1213203008.
-
由 Adam Barth 提交于
This CL adds a build-time flag for building skyx packages, which make our example Sky applications work offline. We can't enable this flag by default yet because our build bots lack a few Dart packages, but landing this flag will let folks experiment with this feature locally. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1221203002.
-
由 Adam Barth 提交于
This CL switches SkyDemo over to using explicit intents for deciding which Sky apps to run. This change lets us get rid of the hacky "sky" URI scheme. Instead, we use normal URLs but we require the sender of the intent to be explicit in directing the VIEW intent to us. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1221123003.
-
由 Adam Barth 提交于
This CL adds the concept of a root asset bundle to Sky. If the Sky app was launched from a bundle, the root bundle is that bundle. This CL teaches icon.dart to default to loading icons out of the root bundle, if a root bundle exists. The next result is that Stocks has icons when run offline because the icons are present in stock's skyx bundle. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1208273003.
-
由 Adam Barth 提交于
This CL teaches Stocks.apk how to start from a skyx bundle name |app.skyx| in the APK's asset collection. Stocks.apk still actually starts from |snapshot_blob.bin| because we can't yet produce skyx files as part of the build process. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1221033006.
-
由 Adam Barth 提交于
These functions used to support testing, but they're no longer used by any tests now that we've deleted the DOM-based world. Really we should merge dart:sky.internals into dart:sky, but that's a CL for another day. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1221163002.
-
由 Adam Barth 提交于
This CL prepares us to have more interesting resources than base's ResourceExtractor understands. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1221153002.
-
由 Adam Barth 提交于
The term ViewportObserver doesn't mean anything. This interface has evolved to control the engine. This new name reflects that. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1222663003.
-
由 Adam Barth 提交于
Rather than require Sky developers to have a Python environment, we should write our tooling for Sky in Dart. This CL converts skyx.py into skyx.dart and makes skyx.py into a wrapper for skyx.dart. We still need the Python wrapper because gn requires that build actions are written in Python. This code isn't wired into the main build yet. We'll need to add some more pub packages to our buildbot environment first. TBR=eseidel@google.com Review URL: https://codereview.chromium.org/1213213003.
-
- 02 7月, 2015 6 次提交
-
-
由 Adam Barth 提交于
TBR=ianh@google.com,mpcomplete@google.com Review URL: https://codereview.chromium.org/1213573006.
-
由 Adam Barth 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1212013004.
-
由 Adam Barth 提交于
TBR=ianh@google.com Review URL: https://codereview.chromium.org/1221023002.
-
由 Matt Perry 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1216923008.
-
由 Viktor Lidholt 提交于
Refactors clamp function R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1215413002.
-
由 Adam Barth 提交于
Currently this asset bundle is based on the network, but soon we'll be able to use a local asset bundle. R=jackson@google.com Review URL: https://codereview.chromium.org/1217593004.
-