未验证 提交 b00bc2e0 编写于 作者: G Gary Qian 提交者: GitHub

Disable flaky/hanging split AOT test (#23070)

上级 687e767f
...@@ -487,7 +487,9 @@ TEST_F(DartIsolateTest, InvalidLoadingUnitFails) { ...@@ -487,7 +487,9 @@ TEST_F(DartIsolateTest, InvalidLoadingUnitFails) {
ASSERT_TRUE(root_isolate->Shutdown()); ASSERT_TRUE(root_isolate->Shutdown());
} }
TEST_F(DartIsolateTest, ValidLoadingUnitSucceeds) { // TODO(garyq): Re-enable this test, and resolve dart-side hanging future and
// threading. See https://github.com/flutter/flutter/issues/72312
TEST_F(DartIsolateTest, DISABLED_ValidLoadingUnitSucceeds) {
if (!DartVM::IsRunningPrecompiledCode()) { if (!DartVM::IsRunningPrecompiledCode()) {
FML_LOG(INFO) << "Split AOT does not work in JIT mode"; FML_LOG(INFO) << "Split AOT does not work in JIT mode";
return; return;
...@@ -529,6 +531,7 @@ TEST_F(DartIsolateTest, ValidLoadingUnitSucceeds) { ...@@ -529,6 +531,7 @@ TEST_F(DartIsolateTest, ValidLoadingUnitSucceeds) {
ASSERT_TRUE(isolate->get()->LoadLoadingUnit(2, std::move(isolate_data), ASSERT_TRUE(isolate->get()->LoadLoadingUnit(2, std::move(isolate_data),
std::move(isolate_instructions))); std::move(isolate_instructions)));
Wait();
} }
} // namespace testing } // namespace testing
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册