From b00bc2e098106af1648637540876a4dd43a048a7 Mon Sep 17 00:00:00 2001
From: Gary Qian <garyq@google.com>
Date: Tue, 15 Dec 2020 22:18:07 -0700
Subject: [PATCH] Disable flaky/hanging split AOT test (#23070)

---
 runtime/dart_isolate_unittests.cc | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/runtime/dart_isolate_unittests.cc b/runtime/dart_isolate_unittests.cc
index cb97e2b74..1b59e70c8 100644
--- a/runtime/dart_isolate_unittests.cc
+++ b/runtime/dart_isolate_unittests.cc
@@ -487,7 +487,9 @@ TEST_F(DartIsolateTest, InvalidLoadingUnitFails) {
   ASSERT_TRUE(root_isolate->Shutdown());
 }
 
-TEST_F(DartIsolateTest, ValidLoadingUnitSucceeds) {
+// TODO(garyq): Re-enable this test, and resolve dart-side hanging future and
+// threading. See https://github.com/flutter/flutter/issues/72312
+TEST_F(DartIsolateTest, DISABLED_ValidLoadingUnitSucceeds) {
   if (!DartVM::IsRunningPrecompiledCode()) {
     FML_LOG(INFO) << "Split AOT does not work in JIT mode";
     return;
@@ -529,6 +531,7 @@ TEST_F(DartIsolateTest, ValidLoadingUnitSucceeds) {
 
   ASSERT_TRUE(isolate->get()->LoadLoadingUnit(2, std::move(isolate_data),
                                               std::move(isolate_instructions)));
+  Wait();
 }
 
 }  // namespace testing
-- 
GitLab