Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
不争之德
oceanbase
提交
ff8b7236
O
oceanbase
项目概览
不争之德
/
oceanbase
与 Fork 源项目一致
Fork自
oceanbase / oceanbase
通知
1
Star
1
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
1
列表
看板
标记
里程碑
合并请求
0
DevOps
流水线
流水线任务
计划
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
O
oceanbase
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
1
Issue
1
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
DevOps
DevOps
流水线
流水线任务
计划
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
流水线任务
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
ff8b7236
编写于
9月 09, 2022
作者:
T
tuhahaha
提交者:
GitHub
9月 09, 2022
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
fix typos arugment (#615)
上级
eb459dc1
变更
11
隐藏空白更改
内联
并排
Showing
11 changed file
with
16 addition
and
16 deletion
+16
-16
deps/oblib/src/lib/json/ob_json_print_utils.cpp
deps/oblib/src/lib/json/ob_json_print_utils.cpp
+1
-1
deps/oblib/src/rpc/obmysql/ob_mysql_compress_protocol_processor.cpp
.../src/rpc/obmysql/ob_mysql_compress_protocol_processor.cpp
+1
-1
deps/oblib/src/rpc/obrpc/ob_virtual_rpc_protocol_processor.cpp
...oblib/src/rpc/obrpc/ob_virtual_rpc_protocol_processor.cpp
+1
-1
src/observer/virtual_table/ob_virtual_sql_monitor.cpp
src/observer/virtual_table/ob_virtual_sql_monitor.cpp
+1
-1
src/rootserver/backup/ob_backup_backupset.cpp
src/rootserver/backup/ob_backup_backupset.cpp
+1
-1
src/rootserver/ob_ddl_service.cpp
src/rootserver/ob_ddl_service.cpp
+2
-2
src/share/scheduler/ob_dag_scheduler.cpp
src/share/scheduler/ob_dag_scheduler.cpp
+3
-3
src/sql/optimizer/ob_skyline_prunning.cpp
src/sql/optimizer/ob_skyline_prunning.cpp
+1
-1
src/storage/ob_partition_range_spliter.cpp
src/storage/ob_partition_range_spliter.cpp
+3
-3
src/storage/ob_partition_service_rpc.cpp
src/storage/ob_partition_service_rpc.cpp
+1
-1
src/storage/transaction/ob_trans_version_mgr.cpp
src/storage/transaction/ob_trans_version_mgr.cpp
+1
-1
未找到文件。
deps/oblib/src/lib/json/ob_json_print_utils.cpp
浏览文件 @
ff8b7236
...
...
@@ -26,7 +26,7 @@ int ObStdJsonConvertor::init(const char* json, char* buf, const int64_t buf_size
int
ret
=
OB_SUCCESS
;
if
(
OB_ISNULL
(
json
)
||
OB_ISNULL
(
buf
)
||
OB_UNLIKELY
(
0
==
buf_size
))
{
ret
=
OB_INVALID_ARGUMENT
;
LOG_WARN
(
"invalid ar
ug
ment"
,
K
(
json
),
K
(
buf
),
K
(
buf_size
));
LOG_WARN
(
"invalid ar
gu
ment"
,
K
(
json
),
K
(
buf
),
K
(
buf_size
));
}
else
{
json_
=
json
;
buf_
=
buf
;
...
...
deps/oblib/src/rpc/obmysql/ob_mysql_compress_protocol_processor.cpp
浏览文件 @
ff8b7236
...
...
@@ -53,7 +53,7 @@ int ObMysqlCompressProtocolProcessor::decode(easy_message_t* m, rpc::ObPacket*&
if
(
0
==
pktlen
)
{
ret
=
OB_INVALID_ARGUMENT
;
LOG_ERROR
(
"invalid ar
ug
ment"
,
K
(
sessid
),
K
(
pktlen
),
K
(
pktlen_before_compress
),
K
(
ret
));
LOG_ERROR
(
"invalid ar
gu
ment"
,
K
(
sessid
),
K
(
pktlen
),
K
(
pktlen_before_compress
),
K
(
ret
));
}
else
if
(
pktlen
>
rpktlen
)
{
// one packet was not received complete
int64_t
delta_len
=
pktlen
-
rpktlen
;
// valid packet, but not sufficient data received by easy, tell easy read more.
...
...
deps/oblib/src/rpc/obrpc/ob_virtual_rpc_protocol_processor.cpp
浏览文件 @
ff8b7236
...
...
@@ -646,7 +646,7 @@ int ObVirtualRpcProtocolProcessor::decode_raw_net_rpc_packet(
ObRpcProxy
::
PCodeGuard
pcode_guard
(
OB_RPC_STREAM_TEST_DECODE_RAW_PCODE
);
if
(
OB_ISNULL
(
ms
)
||
OB_UNLIKELY
(
preceding_data_len
<
0
))
{
ret
=
OB_INVALID_ARGUMENT
;
LOG_ERROR
(
"invalid ar
ug
ment"
,
KP
(
ms
),
K
(
preceding_data_len
),
K
(
ret
));
LOG_ERROR
(
"invalid ar
gu
ment"
,
KP
(
ms
),
K
(
preceding_data_len
),
K
(
ret
));
}
else
if
(
OB_ISNULL
(
ms
->
input
)
||
OB_ISNULL
(
ms
->
pool
))
{
ret
=
OB_INVALID_ARGUMENT
;
LOG_ERROR
(
"invalid argument"
,
"input"
,
ms
->
input
,
"pool"
,
ms
->
pool
,
K
(
ret
));
...
...
src/observer/virtual_table/ob_virtual_sql_monitor.cpp
浏览文件 @
ff8b7236
...
...
@@ -166,7 +166,7 @@ int ObVirtualSqlMonitor::inner_get_next_row(common::ObNewRow*& row)
ret
=
OB_ITER_END
;
}
else
if
(
OB_ISNULL
(
cells
)
||
OB_ISNULL
(
allocator_
))
{
ret
=
OB_NOT_INIT
;
SERVER_LOG
(
WARN
,
"invalid ar
ug
ment"
,
K
(
ret
),
K
(
cells
),
K
(
allocator_
),
K
(
monitor_manager_
));
SERVER_LOG
(
WARN
,
"invalid ar
gu
ment"
,
K
(
ret
),
K
(
cells
),
K
(
allocator_
),
K
(
monitor_manager_
));
}
else
{
while
(
OB_SUCC
(
get_next_monitor_info
()))
{
// take care of the possible "holes"
if
(
NULL
!=
plan_info_
)
{
...
...
src/rootserver/backup/ob_backup_backupset.cpp
浏览文件 @
ff8b7236
...
...
@@ -2141,7 +2141,7 @@ int ObBackupBackupset::calc_backup_set_copy_id(
LOG_WARN
(
"backup backupset do not init"
,
KR
(
ret
));
}
else
if
(
backup_set_id
<
1
)
{
ret
=
OB_INVALID_ARGUMENT
;
LOG_WARN
(
"get tenant backup backup task copy id get invalid ar
ug
ment"
,
KR
(
ret
),
K
(
job_info
),
K
(
backup_set_id
));
LOG_WARN
(
"get tenant backup backup task copy id get invalid ar
gu
ment"
,
KR
(
ret
),
K
(
job_info
),
K
(
backup_set_id
));
}
else
if
(
OB_FAIL
(
get_job_copy_id_level
(
job_info
,
copy_id_level
)))
{
LOG_WARN
(
"failed to get job copy id level"
,
KR
(
ret
),
K
(
job_info
));
}
else
if
(
OB_FAIL
(
ObBackupSetFilesOperator
::
get_backup_set_file_info_copy_list
(
...
...
src/rootserver/ob_ddl_service.cpp
浏览文件 @
ff8b7236
...
...
@@ -9850,7 +9850,7 @@ int ObDDLService::force_drop_schema(const obrpc::ObForceDropSchemaArg &arg)
LOG_WARN("variable is not init");
} else if (OB_INVALID_ID == schema_id) {
ret = OB_INVALID_ARGUMENT;
LOG_WARN("invalid ar
ug
ment", K(schema_id));
LOG_WARN("invalid ar
gu
ment", K(schema_id));
} else if (OB_FAIL(get_tenant_schema_guard_with_version_in_inner_table(tenant_id, schema_guard))) {
LOG_WARN("fail to get schema guard with version in inner table", K(ret), K(tenant_id));
} else if (OB_FAIL(trans.start(sql_proxy_))) {
...
...
@@ -10263,7 +10263,7 @@ int ObDDLService::update_index_status(const obrpc::ObUpdateIndexStatusArg &arg,
} else if (OB_INVALID_ID == table_id || create_mem_version <= 0 || new_status <= INDEX_STATUS_NOT_FOUND ||
new_status >= INDEX_STATUS_MAX) {
ret = OB_INVALID_ARGUMENT;
LOG_WARN("invalid ar
ug
ment", KT(table_id), K(new_status), K(create_mem_version));
LOG_WARN("invalid ar
gu
ment", KT(table_id), K(new_status), K(create_mem_version));
} else if (OB_FAIL(get_tenant_schema_guard_with_version_in_inner_table(tenant_id, schema_guard))) {
LOG_WARN("fail to get schema guard with version in inner table", KR(ret), K(tenant_id));
} else if (OB_FAIL(schema_guard.get_table_schema(table_id, table))) {
src/share/scheduler/ob_dag_scheduler.cpp
浏览文件 @
ff8b7236
...
...
@@ -1109,7 +1109,7 @@ int ObDagScheduler::add_dag(ObIDag* dag, const bool emergency)
COMMON_LOG
(
WARN
,
"ObDagScheduler is not inited"
,
K
(
ret
));
}
else
if
(
OB_ISNULL
(
dag
))
{
ret
=
OB_INVALID_ARGUMENT
;
COMMON_LOG
(
WARN
,
"invalid ar
ug
ment"
,
KP
(
dag
));
COMMON_LOG
(
WARN
,
"invalid ar
gu
ment"
,
KP
(
dag
));
}
else
if
(
OB_UNLIKELY
(
!
dag
->
is_valid
()))
{
ret
=
OB_INVALID_ARGUMENT
;
COMMON_LOG
(
WARN
,
"invalid argument"
,
K
(
ret
),
K
(
*
dag
));
...
...
@@ -1914,7 +1914,7 @@ int ObDagScheduler::check_dag_exist(const ObIDag* dag, bool& exist)
COMMON_LOG
(
WARN
,
"ObDagScheduler is not inited"
,
K
(
ret
));
}
else
if
(
OB_ISNULL
(
dag
))
{
ret
=
OB_INVALID_ARGUMENT
;
COMMON_LOG
(
WARN
,
"invalid ar
ug
ment"
,
KP
(
dag
));
COMMON_LOG
(
WARN
,
"invalid ar
gu
ment"
,
KP
(
dag
));
}
else
{
ObThreadCondGuard
guard
(
scheduler_sync_
);
ObIDag
*
stored_dag
=
nullptr
;
...
...
@@ -1944,7 +1944,7 @@ int ObDagScheduler::cancel_dag(const ObIDag* dag)
COMMON_LOG
(
WARN
,
"ObDagScheduler is not inited"
,
K
(
ret
));
}
else
if
(
OB_ISNULL
(
dag
))
{
ret
=
OB_INVALID_ARGUMENT
;
COMMON_LOG
(
WARN
,
"invalid ar
ug
ment"
,
KP
(
dag
));
COMMON_LOG
(
WARN
,
"invalid ar
gu
ment"
,
KP
(
dag
));
}
else
{
{
ObThreadCondGuard
guard
(
scheduler_sync_
);
...
...
src/sql/optimizer/ob_skyline_prunning.cpp
浏览文件 @
ff8b7236
...
...
@@ -184,7 +184,7 @@ int KeyPrefixComp::operator()(const uint64_t* left, const bool* left_const, cons
int
ret
=
OB_SUCCESS
;
if
(
left_cnt
<
0
||
right_cnt
<
0
)
{
ret
=
OB_INVALID_ARGUMENT
;
LOG_WARN
(
"invalid ar
ug
ment"
,
K
(
ret
),
K
(
left_cnt
),
K
(
right_cnt
),
K
(
ret
));
LOG_WARN
(
"invalid ar
gu
ment"
,
K
(
ret
),
K
(
left_cnt
),
K
(
right_cnt
),
K
(
ret
));
}
else
if
(
0
==
left_cnt
&&
0
==
right_cnt
)
{
status_
=
ObSkylineDim
::
EQUAL
;
}
else
if
(
left_cnt
==
0
||
right_cnt
==
0
)
{
...
...
src/storage/ob_partition_range_spliter.cpp
浏览文件 @
ff8b7236
...
...
@@ -152,7 +152,7 @@ int ObPartitionParallelRanger::init(
}
else
if
(
OB_UNLIKELY
(
!
range
.
is_valid
()
||
range_paras
.
empty
()
||
parallel_target_count
<=
0
))
{
ret
=
OB_INVALID_ARGUMENT
;
STORAGE_LOG
(
WARN
,
"Invalid ar
ug
ment to init ObPartitionParallelRanger"
,
"Invalid ar
gu
ment to init ObPartitionParallelRanger"
,
K
(
ret
),
K
(
range
),
K
(
range_paras
),
...
...
@@ -946,7 +946,7 @@ int ObPartitionMultiRangeSpliter::merge_and_push_range_array(const RangeSplitArr
if
(
OB_UNLIKELY
(
src_range_split_array
.
empty
()))
{
ret
=
OB_INVALID_ARGUMENT
;
STORAGE_LOG
(
WARN
,
"Invalid ar
ug
ment to merge range array"
,
K
(
ret
),
K
(
src_range_split_array
));
STORAGE_LOG
(
WARN
,
"Invalid ar
gu
ment to merge range array"
,
K
(
ret
),
K
(
src_range_split_array
));
}
else
{
const
ObStoreRange
*
last_range
=
nullptr
;
RangeSplitArray
dst_range_array
;
...
...
@@ -1032,7 +1032,7 @@ int ObPartitionMultiRangeSpliter::build_single_range_array(const ObIArray<ObStor
if
(
OB_UNLIKELY
(
range_array
.
empty
()))
{
ret
=
OB_INVALID_ARGUMENT
;
STORAGE_LOG
(
WARN
,
"Invalid ar
ug
ment to build single range array"
,
K
(
ret
),
K
(
range_array
));
STORAGE_LOG
(
WARN
,
"Invalid ar
gu
ment to build single range array"
,
K
(
ret
),
K
(
range_array
));
}
else
{
RangeSplitArray
range_split_array
;
ObStoreRange
store_range
;
...
...
src/storage/ob_partition_service_rpc.cpp
浏览文件 @
ff8b7236
...
...
@@ -1084,7 +1084,7 @@ int ObLogicPartitionServiceRpcP<RPC_CODE>::update_header(const int64_t data_size
int
ret
=
OB_SUCCESS
;
if
(
data_size
<=
0
)
{
ret
=
OB_INVALID_ARGUMENT
;
LOG_WARN
(
"update header get invalid ar
ug
ment"
,
K
(
ret
),
K
(
data_size
));
LOG_WARN
(
"update header get invalid ar
gu
ment"
,
K
(
ret
),
K
(
data_size
));
}
else
{
rpc_header_
.
data_size_
+=
static_cast
<
int32_t
>
(
data_size
);
++
rpc_header_
.
object_count_
;
...
...
src/storage/transaction/ob_trans_version_mgr.cpp
浏览文件 @
ff8b7236
...
...
@@ -85,7 +85,7 @@ int ObTransVersionMgr::update_publish_version(const int64_t publish_version)
int
ret
=
OB_SUCCESS
;
if
(
!
ObTransVersion
::
is_valid
(
publish_version
))
{
TRANS_LOG
(
WARN
,
"invalid ar
ug
ment"
,
K
(
publish_version
));
TRANS_LOG
(
WARN
,
"invalid ar
gu
ment"
,
K
(
publish_version
));
ret
=
OB_INVALID_ARGUMENT
;
}
else
if
(
OB_FAIL
(
update_local_trans_version_
(
publish_version
)))
{
TRANS_LOG
(
WARN
,
"update local transaction version error"
,
KR
(
ret
),
K
(
publish_version
));
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录