Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
qq_34031325
engine
提交
09320084
E
engine
项目概览
qq_34031325
/
engine
与 Fork 源项目一致
从无法访问的项目Fork
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
E
engine
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
09320084
编写于
5月 28, 2019
作者:
G
Gary Qian
提交者:
GitHub
5月 28, 2019
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove outdated TODOs (#9114)
上级
c880ca21
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
0 addition
and
22 deletion
+0
-22
third_party/txt/src/txt/paragraph.h
third_party/txt/src/txt/paragraph.h
+0
-2
third_party/txt/tests/paragraph_unittests.cc
third_party/txt/tests/paragraph_unittests.cc
+0
-20
未找到文件。
third_party/txt/src/txt/paragraph.h
浏览文件 @
09320084
...
...
@@ -56,8 +56,6 @@ class Paragraph {
enum
Affinity
{
UPSTREAM
,
DOWNSTREAM
};
// TODO(garyq): Implement kIncludeLineSpacing and kExtendEndOfLine
// Options for various types of bounding boxes provided by
// GetRectsForRange(...).
enum
class
RectHeightStyle
{
...
...
third_party/txt/tests/paragraph_unittests.cc
浏览文件 @
09320084
...
...
@@ -3138,11 +3138,6 @@ TEST_F(ParagraphTest, FontFallbackParagraph) {
0
);
}
// Disabled due to Skia depending on platform to get metrics, which
// results in presubmit runs to have different values.
//
// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
// consolidate skia font metric behavior.
TEST_F
(
ParagraphTest
,
DISABLE_ON_WINDOWS
(
StrutParagraph1
))
{
// The chinese extra height should be absorbed by the strut.
const
char
*
text
=
"01234満毎冠p来É本可
\n
abcd
\n
満毎É行p昼本可"
;
...
...
@@ -3271,11 +3266,6 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph1)) {
ASSERT_TRUE
(
Snapshot
());
}
// Disabled due to Skia depending on platform to get metrics, which
// results in presubmit runs to have different values.
//
// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
// consolidate skia font metric behavior.
TEST_F
(
ParagraphTest
,
DISABLE_ON_WINDOWS
(
StrutParagraph2
))
{
// This string is all one size and smaller than the strut metrics.
const
char
*
text
=
"01234ABCDEFGH
\n
abcd
\n
ABCDEFGH"
;
...
...
@@ -3400,11 +3390,6 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph2)) {
ASSERT_TRUE
(
Snapshot
());
}
// Disabled due to Skia depending on platform to get metrics, which
// results in presubmit runs to have different values.
//
// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
// consolidate skia font metric behavior.
TEST_F
(
ParagraphTest
,
DISABLE_ON_WINDOWS
(
StrutParagraph3
))
{
// The strut is too small to absorb the extra chinese height, but the english
// second line height is increased due to strut.
...
...
@@ -3530,11 +3515,6 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph3)) {
ASSERT_TRUE
(
Snapshot
());
}
// Disabled due to Skia depending on platform to get metrics, which
// results in presubmit runs to have different values.
//
// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
// consolidate skia font metric behavior.
TEST_F
(
ParagraphTest
,
DISABLE_ON_WINDOWS
(
StrutForceParagraph
))
{
// The strut is too small to absorb the extra chinese height, but the english
// second line height is increased due to strut.
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录