未验证 提交 09320084 编写于 作者: G Gary Qian 提交者: GitHub

Remove outdated TODOs (#9114)

上级 c880ca21
......@@ -56,8 +56,6 @@ class Paragraph {
enum Affinity { UPSTREAM, DOWNSTREAM };
// TODO(garyq): Implement kIncludeLineSpacing and kExtendEndOfLine
// Options for various types of bounding boxes provided by
// GetRectsForRange(...).
enum class RectHeightStyle {
......
......@@ -3138,11 +3138,6 @@ TEST_F(ParagraphTest, FontFallbackParagraph) {
0);
}
// Disabled due to Skia depending on platform to get metrics, which
// results in presubmit runs to have different values.
//
// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
// consolidate skia font metric behavior.
TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph1)) {
// The chinese extra height should be absorbed by the strut.
const char* text = "01234満毎冠p来É本可\nabcd\n満毎É行p昼本可";
......@@ -3271,11 +3266,6 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph1)) {
ASSERT_TRUE(Snapshot());
}
// Disabled due to Skia depending on platform to get metrics, which
// results in presubmit runs to have different values.
//
// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
// consolidate skia font metric behavior.
TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph2)) {
// This string is all one size and smaller than the strut metrics.
const char* text = "01234ABCDEFGH\nabcd\nABCDEFGH";
......@@ -3400,11 +3390,6 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph2)) {
ASSERT_TRUE(Snapshot());
}
// Disabled due to Skia depending on platform to get metrics, which
// results in presubmit runs to have different values.
//
// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
// consolidate skia font metric behavior.
TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph3)) {
// The strut is too small to absorb the extra chinese height, but the english
// second line height is increased due to strut.
......@@ -3530,11 +3515,6 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph3)) {
ASSERT_TRUE(Snapshot());
}
// Disabled due to Skia depending on platform to get metrics, which
// results in presubmit runs to have different values.
//
// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
// consolidate skia font metric behavior.
TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutForceParagraph)) {
// The strut is too small to absorb the extra chinese height, but the english
// second line height is increased due to strut.
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册