From 0932008480d4364e0438bc428217efbb1b923024 Mon Sep 17 00:00:00 2001
From: Gary Qian <garyq@google.com>
Date: Tue, 28 May 2019 17:06:57 -0700
Subject: [PATCH] Remove outdated TODOs (#9114)

---
 third_party/txt/src/txt/paragraph.h          |  2 --
 third_party/txt/tests/paragraph_unittests.cc | 20 --------------------
 2 files changed, 22 deletions(-)

diff --git a/third_party/txt/src/txt/paragraph.h b/third_party/txt/src/txt/paragraph.h
index 1c3567659..2328ba8c9 100644
--- a/third_party/txt/src/txt/paragraph.h
+++ b/third_party/txt/src/txt/paragraph.h
@@ -56,8 +56,6 @@ class Paragraph {
 
   enum Affinity { UPSTREAM, DOWNSTREAM };
 
-  // TODO(garyq): Implement kIncludeLineSpacing and kExtendEndOfLine
-
   // Options for various types of bounding boxes provided by
   // GetRectsForRange(...).
   enum class RectHeightStyle {
diff --git a/third_party/txt/tests/paragraph_unittests.cc b/third_party/txt/tests/paragraph_unittests.cc
index 448cfdf47..c7c9086f5 100644
--- a/third_party/txt/tests/paragraph_unittests.cc
+++ b/third_party/txt/tests/paragraph_unittests.cc
@@ -3138,11 +3138,6 @@ TEST_F(ParagraphTest, FontFallbackParagraph) {
               0);
 }
 
-// Disabled due to Skia depending on platform to get metrics, which
-// results in presubmit runs to have different values.
-//
-// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
-// consolidate skia font metric behavior.
 TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph1)) {
   // The chinese extra height should be absorbed by the strut.
   const char* text = "01234満毎冠p来É本可\nabcd\n満毎É行p昼本可";
@@ -3271,11 +3266,6 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph1)) {
   ASSERT_TRUE(Snapshot());
 }
 
-// Disabled due to Skia depending on platform to get metrics, which
-// results in presubmit runs to have different values.
-//
-// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
-// consolidate skia font metric behavior.
 TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph2)) {
   // This string is all one size and smaller than the strut metrics.
   const char* text = "01234ABCDEFGH\nabcd\nABCDEFGH";
@@ -3400,11 +3390,6 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph2)) {
   ASSERT_TRUE(Snapshot());
 }
 
-// Disabled due to Skia depending on platform to get metrics, which
-// results in presubmit runs to have different values.
-//
-// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
-// consolidate skia font metric behavior.
 TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph3)) {
   // The strut is too small to absorb the extra chinese height, but the english
   // second line height is increased due to strut.
@@ -3530,11 +3515,6 @@ TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutParagraph3)) {
   ASSERT_TRUE(Snapshot());
 }
 
-// Disabled due to Skia depending on platform to get metrics, which
-// results in presubmit runs to have different values.
-//
-// TODO(garyq): Re-enable strut tests, allow font metric fakery, or
-// consolidate skia font metric behavior.
 TEST_F(ParagraphTest, DISABLE_ON_WINDOWS(StrutForceParagraph)) {
   // The strut is too small to absorb the extra chinese height, but the english
   // second line height is increased due to strut.
-- 
GitLab