- 30 11月, 2016 1 次提交
-
-
由 Daniel Carral 提交于
[ci skip]
-
- 28 11月, 2016 2 次提交
-
-
由 Kasper Timm Hansen 提交于
Mention the Accept header and how that figures into the request format.
-
由 Kasper Timm Hansen 提交于
Wrongly added when fixing the request path wrangling.
-
- 24 11月, 2016 2 次提交
-
-
由 Kasper Timm Hansen 提交于
Don't want to add defensive programming to this fairly simple thing. Fixes #27060.
-
由 Kasper Timm Hansen 提交于
Instead of appending a format to the request, it's much better to just pass a more appropriate accept header. Rails will figure out the format from that instead. This allows devs to use `:as` on routes that don't have a format. Introduce an `IdentityEncoder` to avoid `if request_encoder`, essentially a better version of the purpose of the `WWWFormEncoder`. One that makes conceptual sense on GET requests too. Fixes #27144.
-
- 22 11月, 2016 1 次提交
-
-
由 Taishi Kasuga 提交于
-
- 20 11月, 2016 2 次提交
-
-
由 Jon Moss 提交于
-
由 yuuji.yaginuma 提交于
s/Constrains/Constraints
-
- 19 11月, 2016 2 次提交
-
-
由 Erick Reyna 提交于
Rails routes (even rake routes in previous versions) output showed incorrect routes when an application use resource :controller, implying that edit_controller_path match with controller#show. The order of the output has changed to correct this. View #26606 for more information. Added a test case, change unit test in rake to expect the new output. Since the output of resource :controller is changing, the string spected of the railties/test/application/rake_test.rb test_rails_routes_with_controller_environment had to be modified.
-
由 Tawan Sierek 提交于
Reset a new session directly after its creation in `ActionDispatch::IntegrationTest#open_session`. Reset the session to a clean state before making it available to the client's test code. Issue #22742 reports unexpected behavior of integration tests that run multiple sessions. For example an `ActionDispatch::Flash` instance is shared across multiple sessions, though a client code will rightfully assume that each new session has its own flash hash. The following test failed due to this behavior: class Issue22742Test < ActionDispatch::IntegrationTest test 'issue #22742' do integration_session # initialize first session a = open_session b = open_session refute_same(a.integration_session, b.integration_session) end end Instead of creating a new `ActionDispatch::Integration::Session` instance, the same instance is shared across all newly opened test sessions. This is due to the way how new test sessions are created in `ActionDispatch::IntegrationTest#open_session`. The already existing `ActionDispatch::IntegrationTest` instance is duplicated with `Object#dup`, This approach was introduced in commit 15c31c76. `Object#dup` copies the instance variables, but not the objects they reference. Therefore this issue only occurred when the current test instance had been tapped in such a way that the instance variable `@integration_session` was initialized before creating the new test session. Close #22742 [Tawan Sierek + Sina Sadeghian]
-
- 15 11月, 2016 2 次提交
-
-
由 Artem Rashev 提交于
CONENT_LENGTH setted by string length, which is equal to number of characters in string but StringIO.length is byte sequence and when payload contains non-ASCII characters, stream's length will be different. That's why real byte length should be used for CONTENT_LENGTH header. Add unit test for CONTENT_LENGTH header fix It just passes non-ascii symbols as parameters and verifies that "CONTENT_LENGTH" header has content bytes count as value.
-
由 Akira Matsuda 提交于
-
- 13 11月, 2016 3 次提交
-
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
This alternative case expressions read better for my taste, and look more uniform in a file where other similar case expressions are used (without dynamic clauses).
-
由 Vipul A M 提交于
Format and send logs to logger.fatal from DebugExceptions instead of calling fatal multiple times. Expose tags_text from TaggedLogging to be used for log formatting Fixes #26134
-
- 12 11月, 2016 3 次提交
-
-
由 Xavier Noria 提交于
The current implementation of AC::Parameters#permit builds permitted hashes and then calls permit! on them. This filtering is recursive, so we call permit! on terminal branches, but then ascendants call permit! on themselves when the recursion goes up the stack, which recurses all the way down again because permit! is recursive itself. Repeat this for every parent node and you get some scary O-something going on that I don't even want to compute. Instead, since the whole point of the permit recursion is to build permitted hashes along the way and at that point you know you've just come up with a valid filtered version, you can already switch the toggle on the spot. I have seen 2x speedups in casual benchmarks with small structures. As the previous description shows, the difference in performance is going to be a function of the nesting. Note that that the involved methods are private and used only by permit.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
-
- 11 11月, 2016 1 次提交
-
-
由 Jon Moss 提交于
This commit prevents a possible issue wherein an empty CONTENT_TYPE header is sent in a request to a Rails application, and then `request.content_mime_type` would return `nil`. This is because the `has_content_type?` guard method was not properly checking the validity of a request's content type; it was only checking to see whether or not the header existed, not whether it had a value stored inside. Relatedly, after an internal discussion, it was determined that the `has_content_type?` method is not meant to be part of the public API, and is therefore changed to a `:nodoc:` method in this commit. The test for this behavior is a little bit ugly, for two reasons. One is that it was difficult to determine where to place the test... I figured the best place would be with the rest of the ParamsWrapper stuff, since that's where the original issue was. Also, we have to do some fancy footwork in calling `dispatch` on the test's controller manually... this is because `ActionController::TestCase` will throw an error if you try and pass in a nil content type, which is exactly what we are trying to test here... Because of that, we have to manually call in to the controller, and bypass the `post` request helper. Fixes #26912. This is a regression in behavior between Rails versions 4.2.x and 5.0.x, which was introduced via [this commit](https://github.com/rails/rails/commit/a9f28600e901b11a9222e34bfae8642bfb753186).
-
- 29 10月, 2016 2 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 Genadi Samokovarov 提交于
I have been seeing people setting `Logger` instances for `config.logger` and it blowing up on `rails/web-console` usage. Now, I doubt many folks are manually setting `ActionView::Base.logger`, but given that `DebugExceptions` is running in a pretty fragile environment already, having it crash (and being silent) in those cases can be pretty tricky to trace down. I'm proposing we verify whether the `ActionView::Base.logger` supports silencing before we try to do it, to save us the headache of tracing it down.
-
- 28 10月, 2016 1 次提交
-
-
由 Ryuta Kamizono 提交于
-
- 27 10月, 2016 5 次提交
-
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
Regexp#match? should be considered to be part of the Ruby core library. We are emulating it for < 2.4, but not having to require the extension is part of the illusion of the emulation.
-
由 yuuji.yaginuma 提交于
Follow up to 333bfd89
-
由 bogdanvlviv 提交于
Mainly around `nil` [ci skip]
-
由 Rafael Mendonça França 提交于
There were never public API only there by mistake. [ci skip]
-
- 23 10月, 2016 1 次提交
-
-
由 प्रथमेश Sonpatki 提交于
- Followup of fda5afeb
-
- 22 10月, 2016 1 次提交
-
-
由 Rafael Mendonça França 提交于
This reverts commit 5dde413e. Reason: The gem defines it so we don't need to remove
-
- 18 10月, 2016 1 次提交
-
-
由 yuuji.yaginuma 提交于
This method has the same behavior as `Hash#merge!`, returns current `ActionController::Parameters`.
-
- 17 10月, 2016 1 次提交
-
-
由 प्रथमेश Sonpatki 提交于
-
- 15 10月, 2016 3 次提交
-
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Zach Aysan 提交于
-
由 Sammy Larbi 提交于
When rendering arbitrary templates, it is helpful to not overwrite `env` keys with nil if they don't match any found in the `RACK_KEY_TRANSLATION` This allows the developer to set the environment to exactly what is needed for rendering.
-
- 11 10月, 2016 1 次提交
-
-
由 Pavel Evstigneev 提交于
* ActionController::Parameters#deep_dup * Tests for ActionController::Parameters#deep_dup * Fix test for ActionController::Parameters#deep_dup * More tests for ActionController::Parameters#deep_dup [Rafael Mendonça França + Pavel Evstigneev]
-
- 10 10月, 2016 5 次提交
-
-
由 bogdanvlviv 提交于
-
由 Rafael Mendonça França 提交于
`#process`, `#get`, `#post`, `#patch`, `#put`, `#delete`, and `#head`.
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
-
由 Rafael Mendonça França 提交于
Remove deprecated support for passing `:path` and route path as stings in `ActionDispatch::Routing::Mapper#match`
-