- 06 8月, 2013 11 次提交
-
-
由 Alex Tambellini 提交于
MRI reimplemented Date in C so it doesn't hit this division anymore while JRuby still uses the old stdlib implementation of Date so it will always hit this. With this change the actionview date_helper_test.rb tests should pass on JRuby.
-
由 Guillermo Iguaran 提交于
[Jruby] Make all tests in ActionView::TemplateDigestorTest green
-
由 Rafael Mendonça França 提交于
This change was breaking the Railties tests. See https://travis-ci.org/rails/rails/jobs/9865969
-
由 Rafael Mendonça França 提交于
The deprecation message was removed on 50cbc03d but the code was not.
-
由 Rafael Mendonça França 提交于
The pattern is event.component Closes #11769 Conflicts: railties/CHANGELOG.md
-
由 Rafael Mendonça França 提交于
Load fixtures from linked folders[master]
-
由 Kassio Borges 提交于
-
由 Xavier Noria 提交于
Removed confusing statement about adding route for show action in getting started guide [ci skip]
-
由 Carlos Antonio da Silva 提交于
Free result_metadata directly instead of freeing 2nd, redundant call.
-
由 José Valim 提交于
Create sqlite3 directory if not present
-
由 schneems 提交于
If the `db/` directory is not present on a remote machine it will blow up in unexpected ways with error messages that do not indicate there is a missing directory: ``` SQLite3::CantOpenException: unable to open database file ``` This PR checks to see if a directory exists for the sqlite3 file and if not creates it for you. This PR is an alternative to #11692 as suggested by @josevalim
-
- 05 8月, 2013 9 次提交
-
-
由 Prathamesh Sonpatki 提交于
- routes for CRUD already exists as `resources :posts` is in `config/routes.rb` - So we don't have to add any new route in the `config/routes.rb` - As per #11644, the adding of routes which are already there confuses user, so here its changed to referring output of `rake routes`
-
由 Peter Kovacs 提交于
`result_metadata` returns a new object each time it is called, so calling `result_metadata.free` is essentially a noop. Instead call `free` directly on the metadata when we're done with it.
-
由 Xavier Noria 提交于
-
由 Xavier Noria 提交于
Passing the actual ID is not idiomatic.
-
由 Rafael Mendonça França 提交于
Added data for permit array into scalar value [ci skip]
-
由 Rahul P. Chaudhari 提交于
-
由 Rafael Mendonça França 提交于
Fix: documentation for ActiveModel::Errors [ci skip]
-
由 Ryoji Yoshioka 提交于
-
由 Gaurish Sharma 提交于
Missing tmp directory will cause the test to fail on JRuby. will commit adds tmp directory & 22 TemplateDigestorTests which were failing before are now green. Further Discussion on this can be seen at #11743
-
- 04 8月, 2013 20 次提交
-
-
由 Rafael Mendonça França 提交于
Pass assert_dom_equal message arg to underlying assertion
-
由 Ryan McGeary 提交于
#assert_dom_equal and #assert_dom_not_equal both take a "failure" message argument, but this argument was not utilized.
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
Rails.logger should have level specified by config.log_level.
-
由 Rafael Mendonça França 提交于
update guide to reflect default HMAC SHA1 in MessageVerifier used in SignedCookieStore
-
由 Rafael Mendonça França 提交于
Minor optimization and code cleanup in query_methods.rb
-
由 Rafael Mendonça França 提交于
Added to 'Security' section in 'Getting Started with Rails' guide, including reference to 'Ruby on Rails Security Guide'.
-
由 Rafael Mendonça França 提交于
Fix active_record_validations.md document, `:save` for `on:` validation helper was never available
-
由 Takehiro Adachi 提交于
According to the guide, ":save" value for the "on:" validation helper was available like below validates :name, presence: true, on: :save but this was never available according to the implementation of the valid? method, which is below # Runs all the validations within the specified context. Returns +true+ if # no errors are found, +false+ otherwise. # # If the argument is +false+ (default is +nil+), the context is set to <tt>:create</tt> if # <tt>new_record?</tt> is +true+, and to <tt>:update</tt> if it is not. # # Validations with no <tt>:on</tt> option will run no matter the context. Validations with # some <tt>:on</tt> option will only run in the specified context. def valid?(context = nil) context ||= (new_record? ? :create : :update) output = super(context) errors.empty? && output end So the documentation was always wrong since the PR proposed by @neerajdotname ( #10287 ) was rejected.
-
由 Adrien Lamothe 提交于
-
由 Andrew White 提交于
-
由 Andrew White 提交于
We need to call `in_time_zone` to test that it isn't modifying the receiver but since the variable isn't used it raises a warning so add an assertion to make Ruby think it's being used.
-
由 Guillermo Iguaran 提交于
The section was clearly wrong and was just an example about how to use ActiveSupport helpers in Rack/Sinatra
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
[ci skip]
-
由 Rafael Mendonça França 提交于
Add note that you must be in the rails app when starting the server
-
由 Rafael Mendonça França 提交于
i18n guide update: corrected reference to activerecord to instead reference activemodel
-
由 Bradly Feeley 提交于
This is a response to issue #11731 and is a common mistake for people newer to rails that try forget to cd into the new rails app after running rails new.
-
由 Rafael Mendonça França 提交于
Removed an unnecessary loop - it kills performance on large texts.
-
由 Rafael Mendonça França 提交于
[Fixes #11734]Correct Association Basics Guide on has_and_belongs_to_many
-