Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
50cbc03d
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
50cbc03d
编写于
7月 03, 2013
作者:
A
Arun Agrawal
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Remove deprecated `scope` use without passing a callable object.
Removed tests from deprecated code.
上级
9105c59a
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
4 addition
and
23 deletion
+4
-23
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+4
-0
activerecord/lib/active_record/scoping/named.rb
activerecord/lib/active_record/scoping/named.rb
+0
-13
activerecord/test/cases/scoping/named_scoping_test.rb
activerecord/test/cases/scoping/named_scoping_test.rb
+0
-10
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
50cbc03d
*
Remove deprecated
`scope`
use without passing a callable object.
*Arun Agrawal*
*
Remove deprecated
`transaction_joinable=`
in favor of
`begin_transaction`
with
`:joinable`
option.
...
...
activerecord/lib/active_record/scoping/named.rb
浏览文件 @
50cbc03d
...
...
@@ -141,19 +141,6 @@ def scope_attributes? # :nodoc:
def
scope
(
name
,
body
,
&
block
)
extension
=
Module
.
new
(
&
block
)
if
block
# Check body.is_a?(Relation) to prevent the relation actually being
# loaded by respond_to?
if
body
.
is_a?
(
Relation
)
||
!
body
.
respond_to?
(
:call
)
ActiveSupport
::
Deprecation
.
warn
(
"Using #scope without passing a callable object is deprecated. For "
\
"example `scope :red, where(color: 'red')` should be changed to "
\
"`scope :red, -> { where(color: 'red') }`. There are numerous gotchas "
\
"in the former usage and it makes the implementation more complicated "
\
"and buggy. (If you prefer, you can just define a class method named "
\
"`self.red`.)"
)
end
singleton_class
.
send
(
:define_method
,
name
)
do
|*
args
|
if
body
.
respond_to?
(
:call
)
scope
=
all
.
scoping
{
body
.
call
(
*
args
)
}
...
...
activerecord/test/cases/scoping/named_scoping_test.rb
浏览文件 @
50cbc03d
...
...
@@ -435,16 +435,6 @@ def test_scoped_are_lazy_loaded_if_table_still_does_not_exist
end
end
def
test_eager_scopes_are_deprecated
klass
=
Class
.
new
(
ActiveRecord
::
Base
)
klass
.
table_name
=
'posts'
assert_deprecated
do
klass
.
scope
:welcome_2
,
klass
.
where
(
:id
=>
posts
(
:welcome
).
id
)
end
assert_equal
[
posts
(
:welcome
).
title
],
klass
.
welcome_2
.
map
(
&
:title
)
end
def
test_eager_default_scope_relations_are_remove
klass
=
Class
.
new
(
ActiveRecord
::
Base
)
klass
.
table_name
=
'posts'
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录