- 29 5月, 2020 7 次提交
-
-
由 Ryuta Kamizono 提交于
Related to 7d4cc56e.
-
由 Eugene Kenny 提交于
Freeze many read only ModelSchema properties
-
由 Ryuta Kamizono 提交于
It is very confusing.
-
由 Ryuta Kamizono 提交于
-
由 Andrew White 提交于
Make signed_id_verifier_secret lazily evaluated
-
由 Andrew White 提交于
The signed id feature introduced in #39313 can cause loading issues since it may try to generate a key before the secret key base has been set. To prevent this wrap the secret initialization in a lambda.
-
由 Jean Boussier 提交于
-
- 28 5月, 2020 15 次提交
-
-
由 George Claghorn 提交于
Fixes that calling e.g. `url_for @user.avatar` would return an incorrect URL resulting in a 404. The Active Storage URL helper ends up calling ActiveStorage::Attachment#signed_id, which previously delegated to ActiveStorage::Blob#signed_id but changed to return a signed *attachment* ID in 1a3dc42c. The Active Storage controllers pass signed IDs to ActiveStorage::Blob.find_signed, so we need signed blob IDs.
-
由 Eileen M. Uchitelle 提交于
activerecord: No warning for return out of transaction block without writes
-
由 Eugene Kenny 提交于
Fix nil encrypted/signed cookie value when value is stored as `false`
-
由 Rolandas Barysas 提交于
-
由 Jonathan Hefner 提交于
Prefer form builder methods in Form Helpers guide [ci skip]
-
由 Jonathan Hefner 提交于
Update assert_redirected_to docs [ci skip]
-
由 Jonathan Hefner 提交于
`assert_redirected_to` does not partially match `options` anymore. That feature was removed in 3900f400. Closes #39446.
-
由 Ryuta Kamizono 提交于
This makes `merge rewhere: true` follow the original `merge`'s behavior.
-
由 Ryuta Kamizono 提交于
-
由 Ryuta Kamizono 提交于
-
由 Eugene Kenny 提交于
Set retry_jitter to 0.0 for upgraded applications
-
由 Eugene Kenny 提交于
The point of new framework defaults is that they're opt-in for upgraded applications, but the default for this option applied the new behaviour.
-
由 Dylan Thacker-Smith 提交于
It doesn't matter if the transaction is rolled back or committed if it wasn't written to, so we can avoid warning about a breaking change.
-
由 Dylan Thacker-Smith 提交于
If the transaction block is exited due to a timeout, we don't want to change what exception is raised. Also, not raising will allow the transaction to be conveniently aborted by an `return` or `break` statement.
-
由 Eugene Kenny 提交于
https://buildkite.com/rails/rails/builds/69620#ffaa78f1-aba4-42b9-91c8-0fe5d333263a Since 096d143c, when the tests run in parallel it's possible for `ActionView::LookupContext::DetailsKey.clear` to be called while this test is running, which wouldn't work correctly.
-
- 27 5月, 2020 12 次提交
-
-
由 John Hawthorn 提交于
Introduce Resolver::PathParser
-
由 John Hawthorn 提交于
-
由 Ryuta Kamizono 提交于
Follow up to #39415.
-
由 Ryuta Kamizono 提交于
`assert_no_queries` sometimes fails due to counting implict schema info load queries, most case that is enough to just ignore it. https://buildkite.com/rails/rails/builds/69598#321bb1bc-ec67-40cd-813f-68dc7809ddde/1444-1452
-
由 Aaron Patterson 提交于
Ensure cache fragment keys (i.e. dependency tree digests) include all relevant templates
-
由 Aaron Lipman 提交于
Following the introduction of the @current_template variable in 1581cab9, the @virtual_path variable is now redundant, as the value of the virtual path may be accessed via @current_template.virtual_path. This commit removes @virtual_path and replaces any references to @virtual_path with @current_template.virtual_path.
-
由 Aaron Lipman 提交于
A Rails view may rely on several templates (e.g. layouts and partials) in addition to the template for the action being rendered (e.g. "show.html.erb"). To track which view file is currently being rendered for the purpose of generating template tree digests used in cache fragment keys, Action View uses a stack, the top item of which is accessed via the @current_template variable (introduced in 1581cab9). Consider the following template: <!-- home.html.erb --> <%= render layout: "wrapper" do %> <%= cache "foo" %> HOME <%= end %> <%= end %> Inside the block passed to the render helper, @current_template corresponds to the wrapper.html.erb template instead of home.html.erb. As wrapper.html.erb is then used as the root node for generating the template tree digest used in the cache fragment key, the cache fragment fails to expire upon changes to home.html.erb. Additionally, should a second template use the wrapper.html.erb layout and contain a cache fragment with the same key, the cache fragment keys for both templates will be identical - causing cached content to "leak" from one view to another (as described in #38984). This commit skips adding templates to the stack when rendered as a layout with a block via the render helper, ensuring correct and unique cache fragment digests. Additionally, the virtual_path keyword arguments found in CacheHelper and all references to the are removed as they no longer possess any function. (Following the introduction of @current_template, virtual_path is accessed via @current_template.virtual_path rather than as a standalone variable.)
-
由 Ryuta Kamizono 提交于
No need to extend ActionController::Caching by ActiveSupport::Autoload
-
由 Vipul A M 提交于
A few action_controller docs corrections [skip ci]
-
由 fatkodima 提交于
-
由 fatkodima 提交于
-
由 Ryuta Kamizono 提交于
It is safer than direct mutation.
-
- 26 5月, 2020 6 次提交
-
-
由 Ryuta Kamizono 提交于
Follow up to #39404.
-
由 Vinicius Stock 提交于
* Remove dup from post body for forcing encoding * Properly assign raw_post variable to encoded version Co-authored-by: NRyuta Kamizono <kamipo@gmail.com>
-
由 Ryuta Kamizono 提交于
Remove dup from Request#set_cotent_type
-
由 Ryuta Kamizono 提交于
-
由 Vinicius Stock 提交于
-
由 Eugene Kenny 提交于
Add status the 103 Early Hints as Not content for action_dispatch
-