Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
787b991c
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
787b991c
编写于
5月 27, 2020
作者:
R
Ryuta Kamizono
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
`rewhere` allow to overwrite non-attribute nodes
Follow up to #39415.
上级
95e13052
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
13 addition
and
11 deletion
+13
-11
activerecord/lib/active_record/relation/query_methods.rb
activerecord/lib/active_record/relation/query_methods.rb
+1
-1
activerecord/lib/active_record/relation/where_clause.rb
activerecord/lib/active_record/relation/where_clause.rb
+6
-10
activerecord/test/cases/relation/merging_test.rb
activerecord/test/cases/relation/merging_test.rb
+6
-0
未找到文件。
activerecord/lib/active_record/relation/query_methods.rb
浏览文件 @
787b991c
...
...
@@ -1399,7 +1399,7 @@ def order_column(field)
def
resolve_arel_attributes
(
attrs
)
attrs
.
flat_map
do
|
attr
|
case
attr
when
Arel
::
Attributes
::
Attribute
when
Arel
::
Predications
attr
when
Hash
attr
.
flat_map
do
|
table
,
columns
|
...
...
activerecord/lib/active_record/relation/where_clause.rb
浏览文件 @
787b991c
...
...
@@ -104,7 +104,7 @@ def extract_attributes
attrs
=
[]
predicates
.
each
do
|
node
|
Arel
.
fetch_attribute
(
node
)
{
|
attr
|
attrs
<<
attr
}
||
begin
attrs
<<
node
.
left
if
node
.
equality?
&&
node
.
left
.
is_a?
(
Arel
::
Nodes
::
Node
)
attrs
<<
node
.
left
if
node
.
equality?
&&
node
.
left
.
is_a?
(
Arel
::
Predications
)
end
end
attrs
...
...
@@ -157,18 +157,14 @@ def invert_predicate(node)
end
def
except_predicates
(
columns
)
non_attrs
=
columns
.
extract!
{
|
node
|
node
.
is_a?
(
Arel
::
Nodes
::
Node
)
}
attrs
=
columns
.
extract!
{
|
node
|
node
.
is_a?
(
Arel
::
Attribute
)
}
non_attrs
=
columns
.
extract!
{
|
node
|
node
.
is_a?
(
Arel
::
Predications
)
}
predicates
.
reject
do
|
node
|
if
!
non_attrs
.
empty?
&&
node
.
equality?
&&
node
.
left
.
is_a?
(
Arel
::
Nodes
::
Node
)
if
!
non_attrs
.
empty?
&&
node
.
equality?
&&
node
.
left
.
is_a?
(
Arel
::
Predications
)
non_attrs
.
include?
(
node
.
left
)
end
||
Arel
.
fetch_attribute
(
node
)
do
|
attr
|
columns
.
any?
do
|
column
|
if
column
.
is_a?
(
Arel
::
Attributes
::
Attribute
)
attr
==
column
else
attr
.
name
.
to_s
==
column
.
to_s
end
end
attrs
.
include?
(
attr
)
||
columns
.
include?
(
attr
.
name
.
to_s
)
end
end
end
...
...
activerecord/test/cases/relation/merging_test.rb
浏览文件 @
787b991c
...
...
@@ -137,6 +137,9 @@ def test_relation_merging_with_arel_equalities_keeps_last_equality
devs
=
Developer
.
where
(
salary_attr
.
eq
(
80000
)).
merge
(
Developer
.
where
(
salary_attr
.
eq
(
9000
)),
rewhere:
true
)
assert_equal
[
developers
(
:poor_jamis
)],
devs
.
to_a
devs
=
Developer
.
where
(
salary_attr
.
eq
(
80000
)).
rewhere
(
salary_attr
.
eq
(
9000
))
assert_equal
[
developers
(
:poor_jamis
)],
devs
.
to_a
end
def
test_relation_merging_with_arel_equalities_keeps_last_equality_with_non_attribute_left_hand
...
...
@@ -148,6 +151,9 @@ def test_relation_merging_with_arel_equalities_keeps_last_equality_with_non_attr
devs
=
Developer
.
where
(
abs_salary
.
eq
(
80000
)).
merge
(
Developer
.
where
(
abs_salary
.
eq
(
9000
)),
rewhere:
true
)
assert_equal
[
developers
(
:poor_jamis
)],
devs
.
to_a
devs
=
Developer
.
where
(
abs_salary
.
eq
(
80000
)).
rewhere
(
abs_salary
.
eq
(
9000
))
assert_equal
[
developers
(
:poor_jamis
)],
devs
.
to_a
end
def
test_relation_merging_with_eager_load
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录