Reference #17453

This reverts commit f93df528, reversing
changes made to a455e3f4.

Conflicts:
	actionpack/lib/action_controller/test_case.rb
	actionview/lib/action_view/test_case.rb

Follow up to 212057b9. Since that commit, we need to pass the `route_name`
explicitly. This is one of the left-over cases that was not handled in that
commit, which was causing `use_route` to be ignored in functional tests.

This is to match the changes in Rails Dom Testing rails/rails-dom-testing#20.

The test was not failing for `assert_template file: nil` when a file
has been rendered.

The latest modification to the code was done in https://github.com/rails/rails/commit/5e3517ea. In Rails 3.2,
`ActionController#rescue_action` was deprecated and `rescue_action_without_handler` is no longer being used.

we know that this call only wants the path returned, so lets call a
method that returns the path.

See https://github.com/rails/rails/pull/16234#commitcomment-7115670.

Fixes https://github.com/rails/rails/issues/16119.

We can just use nokogiri

This pull request is a continuation of https://github.com/rails/rails/commit/925bd975 and https://github.com/rails/rails/commit/8d8ebe3d.

Moved html_document to ActionDispatch::Assertions. Included the Rails::Dom::Testing::Assertions there as well.

`to_session_value` returns nil when empty.

[ci skip]

This reverts commit 2aef9fdd.

Reason: The added change isn't clear in terms of explaining the
arguments. Will ask the author to provide a PR and take it forward.

[ci skip]

Revert Festival!

I reverted a reverted commit, undo.

This reverts commit 07ea3776.

Reason: docrails policy is very strict about code. No matter how
innocent the change, if it is not documentation it needs to go
through a PR to rails/rails.

Plase see the warning box at the bottom of

    http://edgeguides.rubyonrails.org/contributing_to_ruby_on_rails.html#contributing-to-the-rails-documentation

This reverts commit e1c5d243.

This reverts commit 9b1c077c.

my bad.
`assert_template` only accepts a String, Symbol, Hash, Regexp or nil.

`false`(layout: false) is provided as a Hash.

[ci skip]

[ci skip]

avoid freezing the headers until the web server has actually read data
from the body proxy.  Once the webserver has read data, then we should
throw an error if someone tries to set a header

when streaming responses, we need to make sure the cookie jar is written
to the headers before returning up the stack. This commit introduces a
new method on the response object that writes the cookie jar to the
headers as the response is committed.  The middleware and test framework
will not write the cookie headers if the response has already been
committed.

fixes #14352

detect the type of controller we're testing and return the right type of
response based on that controller.  This allows us to stop doing the
weird sleep thing.

Commit 4f2cd3e9 introduced a bug by reordering the call to
`@controller.recycle!` above the call to `build_request_uri`. The
impact of this was that the `@_url_options` cache ends up not being
reset between building a request URI (occurring within the test
controller) and the firing of the actual request.

We encountered this bug because we had the following setup:

  class MinimumReproducibleController < ActionController::Base
    before_filter { @param = 'param' }

    def index
      render text: url_for(params)
    end

    def default_url_options
      { custom_opt: @param }
    end
  end

  def test_index
    get :index # builds url, then fires actual request
  end

The first step in  `get :index` in the test suite would populate the
@_url_options cache. The subsequent call to `url_for` inside of the
controller action would then utilize the uncleared cache, thus never
calling the now-updated default_url_options.

This commit fixes this bug calling recycle! twice, and removes a call
to set response_body, which should no longer be needed since we're
recycling the request object explicitly.

The request attributes filtered_parameters, filtered_env and filtered_path
are memoized for performance reasons. However this can cause unusual
behavior in tests where there are multiple calls to get, post, etc.

Fixes #13803.