Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
8e73abbd
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
8e73abbd
编写于
11月 23, 2014
作者:
G
Godfrey Chan
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Deprecate `use_route` in controller tests
Reference #17453
上级
c23bb156
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
24 addition
and
3 deletion
+24
-3
actionpack/lib/action_controller/test_case.rb
actionpack/lib/action_controller/test_case.rb
+22
-1
actionpack/test/controller/test_case_test.rb
actionpack/test/controller/test_case_test.rb
+2
-2
未找到文件。
actionpack/lib/action_controller/test_case.rb
浏览文件 @
8e73abbd
...
...
@@ -2,6 +2,7 @@
require
'active_support/core_ext/object/to_query'
require
'active_support/core_ext/module/anonymous'
require
'active_support/core_ext/hash/keys'
require
'active_support/deprecation'
require
'rails-dom-testing'
...
...
@@ -710,7 +711,27 @@ def build_request_uri(action, parameters)
:relative_url_root
=>
nil
,
:_recall
=>
@request
.
path_parameters
)
route_name
=
options
.
delete
:use_route
if
route_name
=
options
.
delete
(
:use_route
)
ActiveSupport
::
Deprecation
.
warn
<<-
MSG
.
squish
Passing the `use_route` option in functional tests are deprecated.
Support for this option in the `process` method (and the related
`get`, `head`, `post`, `patch`, `put` and `delete` helpers) will
be removed in the next version without replacement.
Functional tests are essentially unit tests for controllers and
they should not require knowledge to how the application's routes
are configured. Instead, you should explicitly pass the appropiate
params to the `process` method.
Previously the engines guide also contained an incorrect example
that recommended using this option to test an engine's controllers
within the dummy application. That recommendation was incorrect
and has since been corrected. Instead, you should override the
`@routes` variable in the test case with `Foo::Engine.routes`. See
the updated engines guide for details.
MSG
end
url
,
query_string
=
@routes
.
path_for
(
options
,
route_name
).
split
(
"?"
,
2
)
@request
.
env
[
"SCRIPT_NAME"
]
=
@controller
.
config
.
relative_url_root
...
...
actionpack/test/controller/test_case_test.rb
浏览文件 @
8e73abbd
...
...
@@ -528,7 +528,7 @@ def test_use_route
get
'via_named_route'
,
as: :a_named_route
,
to:
'test_case_test/test#test_uri'
end
get
:test_uri
,
use_route: :a_named_route
assert_deprecated
{
get
:test_uri
,
use_route: :a_named_route
}
assert_equal
'/via_named_route'
,
@response
.
body
end
end
...
...
@@ -798,7 +798,7 @@ def test_use_route
with_routing
do
|
set
|
set
.
draw
{
mount
Engine
=>
'/foo'
}
get
:index
,
use_route: :foo
assert_deprecated
{
get
:index
,
use_route: :foo
}
assert_equal
@response
.
body
,
'bar'
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录