- 14 8月, 2015 3 次提交
-
-
由 Aaron Patterson 提交于
the same value that is extracted from the options hash earlier is returned, so we don't need to pass it in in the first place. The caller already has the data, so stop passing it around.
-
由 Aaron Patterson 提交于
this way we don't have to mutate the options hash so far away from where the user passed it in
-
由 Aaron Patterson 提交于
The `anchor` parameter [is overridden](https://github.com/rails/rails/blob/b4b4a611d0eb9aa1c640c5f521c6a43bf2a65bab/actionpack/lib/action_dispatch/routing/mapper.rb#L1528) unless it is directly passed to `match`, so setting it in a scope must be a mistake.
-
- 13 8月, 2015 7 次提交
-
-
由 Aaron Patterson 提交于
this reduces the number of times we have to mutate the options hash.
-
由 Aaron Patterson 提交于
This just ensures that `format` is applied to things inside the scope
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
Eventually we don't want to expose the "options" hash from scope, only read values from it. Lets start by adding a reader method.
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
We're going to try pulling this up further, and check `via` validity sooner. This way we don't have to do a bunch of processing on `options` hashes only to find out that the route is incorrect
-
- 12 8月, 2015 3 次提交
-
-
由 Aaron Patterson 提交于
this way we don't have to insert / delete it from the options hash so many times.
-
由 Aaron Patterson 提交于
I think we can find the original place where `action` is added to the options hash now.
-
由 Aaron Patterson 提交于
we want to try to pull this logic up to where the user actually passed in "controller" so that it's close to the related call. That way when we're down the stack, we don't need to wonder "why are we doing this?"
-
- 08 8月, 2015 1 次提交
-
-
由 Xavier Shay 提交于
-
- 14 8月, 2014 1 次提交
-
-
由 Aaron Patterson 提交于
since we pass `as` down, then we won't have to do an insert / delete dance with the options hash
-
- 16 7月, 2014 1 次提交
-
-
由 Aaron Patterson 提交于
Now we can override how requests are dispatched in the routeset object
-
- 04 6月, 2014 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 30 5月, 2014 2 次提交
-
-
由 Aaron Patterson 提交于
-
由 Aaron Patterson 提交于
-
- 11 7月, 2012 1 次提交
-
-
由 Carl Lerche 提交于
-
- 30 6月, 2012 1 次提交
-
-
由 Rafael Mendonça França 提交于
Related with 5e7d6bba
-
- 26 4月, 2012 1 次提交
-
-
由 Yehuda Katz 提交于
-
- 25 4月, 2012 1 次提交
-
-
由 Jose and Yehuda 提交于
In the current router DSL, using the +match+ DSL method will match all verbs for the path to the specified endpoint. In the vast majority of cases, people are currently using +match+ when they actually mean +get+. This introduces security implications. This commit disallows calling +match+ without an HTTP verb constraint by default. To explicitly match all verbs, this commit also adds a :via => :all option to +match+. Closes #5964
-
- 13 9月, 2011 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 14 8月, 2011 2 次提交
-
-
由 Aaron Patterson 提交于
-
由 Erik Michaels-Ober 提交于
When format is true, it is mandatory (as opposed to :format => false). This is currently not possible with resource routes, which automatically make format optional by default.
-
- 27 7月, 2011 1 次提交
-
-
由 Aaron Patterson 提交于
-
- 26 7月, 2011 1 次提交
-
-
由 Erik Michaels-Ober 提交于
When format is true, it is mandatory (as opposed to :format => false). This is currently not possible with resource routes, which automatically make format optional by default.
-
- 29 3月, 2011 3 次提交
-
-
由 Sebastian Martinez 提交于
Signed-off-by: NSantiago Pastorino <santiago@wyeworks.com>
-
由 Prem Sichanugrist 提交于
It seems like in 89c5b9ae Aaron actually put the test in action_dispatch folder. However, there's already a `test/dispatch` directory which I think it's more appropriate. Signed-off-by: NAndrew White <andyw@pixeltrix.co.uk>
-
由 Prem Sichanugrist 提交于
Update the wildcard route to be non-greedy by default, therefore be able to match the (.:format) segment [#6605 state:resolved] After some discussion with Andrew White, it seems like this is a better approach for handling a wildcard route. However, user can still bring back the old behavior by supplying `:format => false` to the route. Signed-off-by: NAndrew White <andyw@pixeltrix.co.uk>
-
- 23 3月, 2011 1 次提交
-
-
由 Prem Sichanugrist 提交于
This will make the output of `rake routes` to be correctly match to the behavior of the application, as the regular expression used to match the path is greedy and won't capture the format part by default
-
- 12 3月, 2011 1 次提交
-
-
由 Aaron Patterson 提交于
-