1. 22 6月, 2013 2 次提交
    • N
      flatten merged join_values before building the joins · 32420bd4
      Neeraj Singh 提交于
      fixes #10669
      
      While joining_values special treatment is given to string values.
      By flattening the array it ensures that string values are detected
      as strings and not arrays.
      32420bd4
    • N
      do not load all child records for inverse case · 82882d41
      Neeraj Singh 提交于
      currently `post.comments.find(Comment.first.id)` would load all
      comments for the given post to set the inverse association.
      
      This has a huge performance penalty. Because if post has 100k
      records and all these 100k records would be loaded in memory
      even though the comment id was supplied.
      
      Fix is to use in-memory records only if loaded? is true. Otherwise
      load the records using full sql.
      
      Fixes #10509
      82882d41
  2. 21 6月, 2013 1 次提交
  3. 20 6月, 2013 2 次提交
  4. 19 6月, 2013 3 次提交
    • J
      Revert "Merge pull request #10566 from neerajdotname/10509d" · e47b6dee
      Jon Leighton 提交于
      This reverts commit 2b817a5e, reversing
      changes made to 353a398b.
      
      Conflicts:
      	activerecord/CHANGELOG.md
      
      Reason: the build broke
      e47b6dee
    • N
      log the sql that is actually sent to the database · 6fb5f6f3
      Neeraj Singh 提交于
      If I have a query that produces sql
      `WHERE "users"."name" = 'a         b'` then in the log all the
      whitespace is being squeezed. So the sql that is printed in the
      log is `WHERE "users"."name" = 'a b'`.
      
      This can be confusing. This commit fixes it by ensuring that
      whitespace is not squeezed.
      
      fixes #10982
      6fb5f6f3
    • N
      do not load all child records for inverse case · 2b73f780
      Neeraj Singh 提交于
      currently `post.comments.find(Comment.first.id)` would load all
      comments for the given post to set the inverse association.
      
      This has a huge performance penalty. Because if post has 100k
      records and all these 100k records would be loaded in memory
      even though the comment id was supplied.
      
      Fix is to use in-memory records only if loaded? is true. Otherwise
      load the records using full sql.
      
      Fixes #10509
      2b73f780
  5. 18 6月, 2013 1 次提交
  6. 15 6月, 2013 4 次提交
  7. 14 6月, 2013 16 次提交
  8. 13 6月, 2013 6 次提交
  9. 12 6月, 2013 5 次提交