Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
2b817a5e
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
2b817a5e
编写于
6月 18, 2013
作者:
J
Jon Leighton
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #10566 from neerajdotname/10509d
do not load all child records for inverse case
上级
353a398b
2b73f780
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
25 addition
and
1 deletion
+25
-1
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+16
-0
activerecord/lib/active_record/associations/collection_association.rb
.../lib/active_record/associations/collection_association.rb
+1
-1
activerecord/test/cases/associations/inverse_associations_test.rb
...cord/test/cases/associations/inverse_associations_test.rb
+8
-0
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
2b817a5e
*
Do not load all child records for inverse case.
currently `post.comments.find(Comment.first.id)` would load all
comments for the given post to set the inverse association.
This has a huge performance penalty. Because if post has 100k
records and all these 100k records would be loaded in memory
even though the comment id was supplied.
Fix is to use in-memory records only if loaded? is true. Otherwise
load the records using full sql.
Fixes #10509.
*Neeraj Singh*
*
Fixture setup does no longer depend on
`ActiveRecord::Base.configurations`
.
This is relevant when
`ENV["DATABASE_URL"]`
is used in place of a
`database.yml`
.
...
...
activerecord/lib/active_record/associations/collection_association.rb
浏览文件 @
2b817a5e
...
...
@@ -81,7 +81,7 @@ def find(*args)
else
if
options
[
:finder_sql
]
find_by_scan
(
*
args
)
elsif
options
[
:inverse_of
]
elsif
options
[
:inverse_of
]
&&
loaded?
args
=
args
.
flatten
raise
RecordNotFound
,
"Couldn't find
#{
scope
.
klass
.
name
}
without an ID"
if
args
.
blank?
...
...
activerecord/test/cases/associations/inverse_associations_test.rb
浏览文件 @
2b817a5e
...
...
@@ -401,6 +401,14 @@ def test_parent_instance_should_find_child_instance_using_child_instance_id_when
assert_equal
man
.
name
,
man
.
interests
.
find
(
interest
.
id
).
man
.
name
,
"The name of the man should match after the child name is changed"
end
def
test_find_on_child_instance_with_id_should_not_load_all_child_records
man
=
Man
.
create!
interest
=
Interest
.
create!
(
man:
man
)
man
.
interests
.
find
(
interest
.
id
)
refute
man
.
interests
.
loaded?
end
def
test_raise_record_not_found_error_when_invalid_ids_are_passed
man
=
Man
.
create!
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录