1. 12 3月, 2017 2 次提交
  2. 11 3月, 2017 1 次提交
  3. 10 3月, 2017 1 次提交
  4. 08 3月, 2017 2 次提交
  5. 06 3月, 2017 1 次提交
  6. 05 3月, 2017 2 次提交
    • R
      Fix CI failure due to contain <U+2028> · 660e189c
      Ryuta Kamizono 提交于
      ```diff
      diff --git a/actionpack/lib/action_controller/metal/redirecting.rb b/actionpack/lib/action_controller/metal/redirecting.rb
      index a3159c29dd..1836a07d4e 100644
      --- a/actionpack/lib/action_controller/metal/redirecting.rb
      +++ b/actionpack/lib/action_controller/metal/redirecting.rb
      @@ -50,8 +50,8 @@ module Redirecting
           #   redirect_to post_url(@post), status: 301, flash: { updated_post_id: @post.id }
           #   redirect_to({ action: 'atom' }, alert: "Something serious happened")
           #
      -    # Statements after redirect_to in our controller get executed, so redirect_to doesn't stop the execution of the function.
      -    <U+2028># To terminate the execution of the function immediately after the redirect_to, use return.
      +    # Statements after +redirect_to+ in our controller get executed, so +redirect_to+ doesn't stop the execution of the function.
      +    # To terminate the execution of the function immediately after the +redirect_to+, use return.
           #   redirect_to post_url(@post) and return
           def redirect_to(options = {}, response_status = {})
             raise ActionControllerError.new("Cannot redirect to nil!") unless options
      ```
      
      https://travis-ci.org/rails/rails/jobs/207908041#L549
      660e189c
    • T
      [ci skip] Fix ParameterMissing exception name in docs · 609bf1ac
      Tejas Bubane 提交于
      Should be `ActionController::ParameterMissing` and not
      `ActionController::MissingParameter`.
      
      Corresponding change was done in guides in
      https://github.com/rails/rails/pull/9816.
      609bf1ac
  7. 04 3月, 2017 1 次提交
  8. 21 2月, 2017 1 次提交
  9. 13 2月, 2017 1 次提交
  10. 07 2月, 2017 1 次提交
  11. 24 1月, 2017 1 次提交
    • D
      Delete PATH_INFO after each controller test request · 13c7f2b5
      Dominic Cleal 提交于
      Prevents PATH_INFO from being used to infer the request format in later
      test requests when no explicit format is given.
      
      As the request PATH_INFO may be set before a request, it can't be
      deleted during pre-request scrubbing.
      
      Fixes #27774
      13c7f2b5
  12. 16 1月, 2017 1 次提交
  13. 13 1月, 2017 2 次提交
  14. 12 1月, 2017 2 次提交
  15. 06 1月, 2017 1 次提交
    • J
      Update `cookies` helper on all HTTP requests · c5da6414
      Jon Moss 提交于
      Regression introduced by ae291421 / 8363b879.
      
      Previously, cookies were only updated on `GET` requests. Now we will
      update the helper for all requests, as part of `process`. Added
      regression tests for all available HTTP method helpers in
      `ActionController::TestCase`.
      c5da6414
  16. 05 1月, 2017 2 次提交
  17. 04 1月, 2017 2 次提交
  18. 03 1月, 2017 1 次提交
    • J
      Extract variant setter to process method · feacb990
      Jon Moss 提交于
      Provide an API interface similar to how format is handled in
      Controllers. In situations where variants are not needed (ex: in
      Action Mailer) the method will simply trigger a no-op, and will not
      affect end users.
      feacb990
  19. 27 12月, 2016 1 次提交
  20. 24 12月, 2016 2 次提交
  21. 22 12月, 2016 2 次提交
    • A
      updating docs · 87105622
      Aaron Patterson 提交于
      87105622
    • A
      Document and update API for `skip_parameter_encoding` · 2eb0a663
      Aaron Patterson 提交于
      This commit changes `parameter_encoding` to `skip_parameter_encoding`.
      `skip_parameter_encoding` will set encoding on all parameters to
      ASCII-8BIT for a given action on a particular controller.  This allows
      the controller to handle data when the encoding of that data is unknown,
      for example file systems or truly binary parameters.
      2eb0a663
  22. 20 12月, 2016 1 次提交
  23. 14 12月, 2016 1 次提交
  24. 12 12月, 2016 1 次提交
  25. 06 12月, 2016 1 次提交
  26. 30 11月, 2016 1 次提交
  27. 22 11月, 2016 1 次提交
  28. 15 11月, 2016 1 次提交
    • A
      Fixed CONTENT_LENGTH header in ActionController::TestRequest · b388ca41
      Artem Rashev 提交于
      CONENT_LENGTH setted by string length, which is equal to number of
      characters in string but StringIO.length is byte sequence and
      when payload contains non-ASCII characters, stream's length will be
      different. That's why real byte length should be used for CONTENT_LENGTH
      header.
      
      Add unit test for CONTENT_LENGTH header fix
      
      It just passes non-ascii symbols as parameters and verifies that
      "CONTENT_LENGTH" header has content bytes count as value.
      b388ca41
  29. 13 11月, 2016 2 次提交
  30. 12 11月, 2016 1 次提交
    • X
      significant speedup of AC::Parameters#permit · 26dd9b26
      Xavier Noria 提交于
      The current implementation of AC::Parameters#permit builds permitted hashes and
      then calls permit! on them.
      
      This filtering is recursive, so we call permit! on terminal branches, but then
      ascendants call permit! on themselves when the recursion goes up the stack,
      which recurses all the way down again because permit! is recursive itself.
      Repeat this for every parent node and you get some scary O-something going on
      that I don't even want to compute.
      
      Instead, since the whole point of the permit recursion is to build permitted
      hashes along the way and at that point you know you've just come up with a
      valid filtered version, you can already switch the toggle on the spot.
      
      I have seen 2x speedups in casual benchmarks with small structures. As the
      previous description shows, the difference in performance is going to be a
      function of the nesting.
      
      Note that that the involved methods are private and used only by permit.
      26dd9b26