- 12 3月, 2017 3 次提交
-
-
由 Hrvoje Šimić 提交于
[ci skip]
-
由 alpaca-tc 提交于
`env` is undefined.
-
由 Renaud Chaput 提交于
3 output types are supported: - simple: only display the screenshot path - artifact: display the screenshot in the terminal, using the artifact protocol (supported by some CI) - inline (default): display the screenshot in the terminal, inline (supported by some terminals) You can force the output type by setting the `RAILS_SYSTEM_TESTING_SCREENSHOT` environment variable
-
- 11 3月, 2017 4 次提交
-
-
由 Hrvoje Šimić 提交于
[ci skip]
-
由 Ryuta Kamizono 提交于
-
由 yuuji.yaginuma 提交于
-
由 Rafael Mendonça França 提交于
-
- 10 3月, 2017 1 次提交
-
-
由 Edouard CHIN 提交于
- This PR adds the `reverse_merge` and `reverse_merge!` method to `ActionController::Parameters` - Fixes #28353
-
- 09 3月, 2017 2 次提交
-
-
由 eileencodes 提交于
Previously the system test subclasses would call `driven_by` when the app booted and not again when the test was initialized which resulted in the driver from whichever class was called last to be used in tests. In rails/rails#28144 the `driven_by` method was changed to run `use` on setup and `reset` on teardown. While this was a viable fix this really pointed to the problem that system test `driven_by` was a global setting, rather than a per-class setting. To alieviate this problem calling the driver should be done on an instance level, rather than on the global level. I added an `initialize` method to `SystemTestCase` which will call `use` on the superclass driver. Running the server has been moved to `start_application` so that it only needs to be called once on boot and no options from `driven_by` were being passed to it. This required a largish rewrite of the tests. Each test needs to utilize the subclass so that it can properly test the drivers. `ActionDispatch::SystemTestCase` shouldn't be called directly anymore.
-
由 eileencodes 提交于
Since using a browser is only for selenium it doesn't really make sense to have a separate class for handling it there. This brings a lot of the if/else out of the main SystemTestCase class and into the Driver class so we can abstract away all that extra work.
-
- 08 3月, 2017 3 次提交
-
-
由 T.J. Schuck 提交于
-
由 Jon Moss 提交于
[ci skip]
-
由 T.J. Schuck 提交于
[ci skip]
-
- 06 3月, 2017 3 次提交
-
-
由 Andrew White 提交于
-
由 Giorgos Vrettos 提交于
-
由 yuuji.yaginuma 提交于
Since `ActionController:Parameters` does not inherit `Hash`, need to explicitly convert it to `Hash`. Also, `Parameters#to_h` returns `Hash` whose key is `String`. Therefore, if merge as it is, the value will not be overwritten as expected.
-
- 05 3月, 2017 4 次提交
-
-
由 Ryuta Kamizono 提交于
```diff diff --git a/actionpack/lib/action_controller/metal/redirecting.rb b/actionpack/lib/action_controller/metal/redirecting.rb index a3159c29dd..1836a07d4e 100644 --- a/actionpack/lib/action_controller/metal/redirecting.rb +++ b/actionpack/lib/action_controller/metal/redirecting.rb @@ -50,8 +50,8 @@ module Redirecting # redirect_to post_url(@post), status: 301, flash: { updated_post_id: @post.id } # redirect_to({ action: 'atom' }, alert: "Something serious happened") # - # Statements after redirect_to in our controller get executed, so redirect_to doesn't stop the execution of the function. - <U+2028># To terminate the execution of the function immediately after the redirect_to, use return. + # Statements after +redirect_to+ in our controller get executed, so +redirect_to+ doesn't stop the execution of the function. + # To terminate the execution of the function immediately after the +redirect_to+, use return. # redirect_to post_url(@post) and return def redirect_to(options = {}, response_status = {}) raise ActionControllerError.new("Cannot redirect to nil!") unless options ``` https://travis-ci.org/rails/rails/jobs/207908041#L549
-
由 eileencodes 提交于
This reverts commit 84c1b107. Reverted #28283 so reverted it's changelog update as well.
-
由 eileencodes 提交于
This reverts commit 0d73f911, reversing changes made to 21ff8a49. We don't want to silence Puma because it's start up messages can be useful (to see threads, port etc). #28109 was instead fixed by not running system tests by defaul with `bin/rails test` in #28286.
-
由 Tejas Bubane 提交于
Should be `ActionController::ParameterMissing` and not `ActionController::MissingParameter`. Corresponding change was done in guides in https://github.com/rails/rails/pull/9816.
-
- 04 3月, 2017 5 次提交
-
-
由 Robin Dupret 提交于
-
由 Robin Dupret 提交于
-
由 yuuji.yaginuma 提交于
Fixes #28109
-
由 yuuji.yaginuma 提交于
`Capybara::RackTest::Driver` does not support taking screenshots. If call `#save_screenshot` on `Capybara::RackTest::Driver` will raise the error. ```ruby Error: UsersTest#test_visiting_the_index: Capybara::NotSupportedByDriverError: Capybara::Driver::Base#save_screenshot ``` To prevent errors, if driver does not support screenshot, do not call it.
-
由 ChakreshwarSharma 提交于
-
- 03 3月, 2017 1 次提交
-
-
由 Fumiaki MATSUSHIMA 提交于
If application has ajax, browser may begin request after rollback. `teardown_fixtures` will be called after `super` on `after_teardown` so we must call `Capybara.reset_sessions!` before `super` https://github.com/rails/rails/blob/b61a56541aecd7ac685d4f19d943177a3f1b465a/activerecord/lib/active_record/fixtures.rb#L857
-
- 28 2月, 2017 1 次提交
-
-
由 yuuji.yaginuma 提交于
Now reset the driver before take failed screenshot since #28144. However, I think that failed screenshot should be take with the driver actually used in the test. So, fixed to take screenshot before reset driver.
-
- 26 2月, 2017 2 次提交
-
-
由 Jerry Tao 提交于
-
由 Andrew White 提交于
In ca324a0d the flash middleware was effectively removed by its constructor returning the app it was passed and the `commit_flash` call was moved to the `ActionController::Metal#dispatch` method. This broke any redirect routes that modified the flash because the redirect happens before `dispatch` gets called. To fix it, this commit adds a `commit_flash` call in the `serve` method of `ActionDispatch::Routing::Redirect`. Fixes #27992.
-
- 25 2月, 2017 3 次提交
-
-
由 Andrew White 提交于
-
由 Dylan Thacker-Smith 提交于
A gzip file has a checksum and length for the decompressed data in its footer which isn't checked by just calling Zlib::GzipReader#read. Calling Zlib::GzipReader#close must be called after reading to the end of the file causes this check to be done, which is done by Zlib::GzipReader.wrap after its block is called.
-
由 Lucas Mazza 提交于
Previously, `driven_by` would change the Capybara configuration when the test case is loaded, and having multiple test classes with different `driven_by` configs would fail as the last loaded would be effective.
-
- 24 2月, 2017 2 次提交
-
-
由 Rafael Mendonça França 提交于
-
由 eileencodes 提交于
The documentation needs to be above the method to correctly document the method.
-
- 23 2月, 2017 3 次提交
-
-
由 yuuji.yaginuma 提交于
-
由 Andrew White 提交于
Also correct use of `direct class:` to `resolve` in example.
-
由 Andrew White 提交于
Since a `direct` url helper block is evaluated using `instance_exec` then methods that are available in the instance context can be accessed, e.g. the params object in a controller action or view. This wasn't clear from the example so expand on that point and add a test case for this situation.
-
- 22 2月, 2017 3 次提交
-
-
由 Andrew White 提交于
Further missing requires for Timeout exposed due to Bundler 1.14.5
-
由 Andrew White 提交于
-
由 Kasper Timm Hansen 提交于
Use double quoted strings, come down hard on some typos.
-