1. 21 7月, 2017 1 次提交
  2. 20 7月, 2017 3 次提交
  3. 18 7月, 2017 6 次提交
  4. 17 7月, 2017 2 次提交
    • S
      Post.joins(:users) should not be affected by `User.current_scope` · 3630d635
      Sean Griffin 提交于
      This change was introduced by #18109. The intent of that change was to
      specifically apply `unscoped`, not to allow all changes to
      `current_scope` to affect the join. The idea of allowing `current_scope`
      to affect joins is interesting and potentially more consistent, but has
      sever problems associated with it. The fact that we're specifically
      stripping out joins indicates one such problem (and potentially leads to
      invalid queries).
      
      Ultimately it's difficult to reason about what `Posts.joins(:users)`
      actually means if it's affected by `User.current_scope`, and it's
      difficult to specifically control what does or doesn't get added. If we
      were starting from scratch, I don't think I'd have `joins` be affected
      by `default_scope` either, but that's too big of a breaking change to
      make at this point.
      
      With this change, we no longer apply `current_scope` when bringing in
      joins, with the singular exception of the motivating use case which
      introduced this bug, which is providing a way to *opt-out* of having the
      default scope apply to joins.
      
      Fixes #29338.
      3630d635
    • R
      Merge pull request #29817 from koic/replace_erubis_with_erubi_in_guide · 1dc2344e
      Ryuta Kamizono 提交于
      Replace Erubis with Erubi in a part of guide [ci skip]
      1dc2344e
  5. 13 7月, 2017 1 次提交
    • K
      Merge pull request #29772 from... · c3c35c9d
      Kasper Timm Hansen 提交于
      Merge pull request #29772 from y-yagi/allow_to_edit_secrets_in_mutiple_applications_at_the_same_time
      
      Allow to edit secrets in mutiple apps at the same time
      c3c35c9d
  6. 11 7月, 2017 4 次提交
  7. 09 7月, 2017 3 次提交
  8. 08 7月, 2017 1 次提交
    • E
      Don't call register on custom drivers · 6a28aa5b
      eileencodes 提交于
      It's possible for developers toadd a custom driver and then call it
      using `driven_by`. Because we were only skipping `register` for
      `:rack_test` that meant any custom driver would attempt to be registered
      as well.
      
      The three listed here are special because Rails registers them with
      special options. If you're registering your own custom driver then you
      don't want to separately register that driver.
      
      Fixes #29688
      6a28aa5b
  9. 06 7月, 2017 2 次提交
  10. 05 7月, 2017 5 次提交
  11. 01 7月, 2017 4 次提交
  12. 29 6月, 2017 3 次提交
  13. 28 6月, 2017 5 次提交